Adding validity dates to ProductPromoCode

[Jacopo Cappellato]

Is it ok if I add a new field to the ProductPromoCode entity: expiryDate

I'd like to use it to set a validity date for the promo code.
Or would it be better to use the standard fromDate/thruDate pattern?

Jacopo

[Jacopo Cappellato]

The solution with fromDate/thruDate  is now implemented in rev. 581961

Jacopo


Jacopo Cappellato wrote:
> Is it ok if I add a new field to the ProductPromoCode entity: expiryDate
>
> I'd like to use it to set a validity date for the promo code.
> Or would it be better to use the standard fromDate/thruDate pattern?
>
> Jacopo

[David E Jones]

Yeah, I think that looks fine Jacopo. We recently discussed doing  
something just like this with a client but it was never green lit. So  
yes, looks good and the option of doing from/thru is better than just  
a thru, so that's cool too.

-David


On Oct 4, 2007, at 10:46 AM, Jacopo Cappellato wrote:

> The solution with fromDate/thruDate  is now implemented in rev. 581961
>
> Jacopo
>
>
> Jacopo Cappellato wrote:
>> Is it ok if I add a new field to the ProductPromoCode entity:  
>> expiryDate
>> I'd like to use it to set a validity date for the promo code.
>> Or would it be better to use the standard fromDate/thruDate pattern?
>> Jacopo
>
>