All JUnit tests now pass! Next steps...

[Adrian Crum-2]

I didn't notice that. Thanks for pointing it out.

-Adrian

--- On Mon, 11/23/09, Scott Gray <[hidden email]> wrote:

> From: Scott Gray <[hidden email]>
> Subject: Re: All JUnit tests now pass! Next steps...
> To: [hidden email]
> Date: Monday, November 23, 2009, 9:09 PM
> Hi Adrian,
>
> Yeah that issue has been there for a while but you'll
> notice that the 
> exception is just a logged exception and isn't actually
> thrown, hence 
> no error and the test passes.
>
> Regards
> Scott
>
> On 24/11/2009, at 6:01 PM, Adrian Crum wrote:
>
> > Scott,
> >
> > Are you sure all tests pass? I'm seeing errors in the
> entity engine 
> > test - testBlobCreate. I thought it might be caused by
> my recent 
> > Blob converter commit, so I reverted it locally. I
> still get the 
> > same error. Looking at the code causing the
> error 
> > (GenericEntity.java line 420) it appears to me this
> test never 
> > should have succeeded.
> >
> > -Adrian
> >
> > --- On Mon, 11/23/09, Scott Gray <[hidden email]>
> wrote:
> >
> >> From: Scott Gray <[hidden email]>
> >> Subject: Re: All JUnit tests now pass! Next
> steps...
> >> To: [hidden email]
> >> Date: Monday, November 23, 2009, 7:53 PM
> >> Quick update, I've since learnt that
> >> we've already had the trunk and 9.04 branch
> running on
> >> buildbot at the ASF for a few months now. 
> I've created
> >> an infra ticket (https://issues.apache.org/jira/browse/INFRA-2345)
> >> requesting that build notifications be sent to the
> dev list
> >> and also that the run-install and run-tests
> targets be added
> >> to the buildbot configuration (for the trunk
> only).
> >>
> >> Regards
> >> Scott
> >>
> >> On 20/11/2009, at 9:06 AM, Scott Gray wrote:
> >>
> >>> Thanks for the pointer Christian, I figured
> the ASF
> >> would have something for us and they haven't
> disappointed
> >> :-)
> >>>
> >>> I'll keep playing around the different CI
> services
> >> locally for a little bit so I can learn how they
> work a bit
> >> better and also find the one that will be the most
> useful to
> >> us.
> >>>
> >>> Thanks
> >>> Scott
> >>>
> >>> On 20/11/2009, at 1:08 AM, Christian Geisert
> wrote:
> >>>
> >>>> Scott Gray schrieb:
> >>>>> It took a while but all our JUnit
> tests now
> >> pass, next I'd like to get a continuous
> integration server
> >> set up.  Can anybody recommend some tools
> >>>>
> >>>> Why not just use what is available at the
> ASF ;-)
> >>>>
> >>>> http://ci.apache.org/
> >>>>
> >>>> I use Hudson and like it, but I haven't
> tried the
> >> others...
> >>>>
> >>>>> Once that is done I'd like to have it
> run the
> >> tests after every commit and report any failures
> to the dev
> >> list.  It would then be the offending
> committer's
> >> responsibility (well primarily at least) to fix
> the problem
> >> as soon as possible, much like a build
> failure.  If we
> >> can't get everyone to agree to take on that
> responsibility
> >> then I might as well stop now because I'll be
> damned if I'm
> >> going to spend any more time fixing tests that I
> didn't
> >> break :-)
> >>>>
> >>>> +1
> >>>>
> >>>>> All of this should help us increase
> the
> >> stability of the trunk and our confidence when
> taking a
> >> checkout that we won't half to spend our
> development time
> >> fixing things that used to work.  It'll
> hopefully also
> >> encourage the community to contribute more tests
> with the
> >> knowledge that doing so will increase the
> stability of the
> >> functionality they depend on.  Fix a bug and
> you're
> >> good for a day, write a test and you're good a
> lifetime :-)
> >>>>
> >>>> Absolutly agreed, big thanks for your (and
> all the
> >> others) work in this area!
> >>>>
> >>>> --Christian
> >>>>
> >>>
> >>
> >>
> >
> >
> >
>
>

[Jacopo Cappellato-4]

Hey Scott,

I think I am responsible for this (I have changed some of the demo data yesterday).
I am going to fix them right away, so don't waste your time on this.

Thank you for the notice,

Jacopo

On Nov 24, 2009, at 6:13 AM, Scott Gray wrote:

> BTW, the accounting tests are failing at the moment but I'll have them fixed again shortly.
>
> Regards
> Scott
>
> On 24/11/2009, at 6:09 PM, Scott Gray wrote:
>
>> Hi Adrian,
>>
>> Yeah that issue has been there for a while but you'll notice that the exception is just a logged exception and isn't actually thrown, hence no error and the test passes.
>>
>> Regards
>> Scott
>>
>> On 24/11/2009, at 6:01 PM, Adrian Crum wrote:
>>
>>> Scott,
>>>
>>> Are you sure all tests pass? I'm seeing errors in the entity engine test - testBlobCreate. I thought it might be caused by my recent Blob converter commit, so I reverted it locally. I still get the same error. Looking at the code causing the error (GenericEntity.java line 420) it appears to me this test never should have succeeded.
>>>
>>> -Adrian
>>>
>>> --- On Mon, 11/23/09, Scott Gray <[hidden email]> wrote:
>>>
>>>> From: Scott Gray <[hidden email]>
>>>> Subject: Re: All JUnit tests now pass! Next steps...
>>>> To: [hidden email]
>>>> Date: Monday, November 23, 2009, 7:53 PM
>>>> Quick update, I've since learnt that
>>>> we've already had the trunk and 9.04 branch running on
>>>> buildbot at the ASF for a few months now.  I've created
>>>> an infra ticket (https://issues.apache.org/jira/browse/INFRA-2345)
>>>> requesting that build notifications be sent to the dev list
>>>> and also that the run-install and run-tests targets be added
>>>> to the buildbot configuration (for the trunk only).
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> On 20/11/2009, at 9:06 AM, Scott Gray wrote:
>>>>
>>>>> Thanks for the pointer Christian, I figured the ASF
>>>> would have something for us and they haven't disappointed
>>>> :-)
>>>>>
>>>>> I'll keep playing around the different CI services
>>>> locally for a little bit so I can learn how they work a bit
>>>> better and also find the one that will be the most useful to
>>>> us.
>>>>>
>>>>> Thanks
>>>>> Scott
>>>>>
>>>>> On 20/11/2009, at 1:08 AM, Christian Geisert wrote:
>>>>>
>>>>>> Scott Gray schrieb:
>>>>>>> It took a while but all our JUnit tests now
>>>> pass, next I'd like to get a continuous integration server
>>>> set up.  Can anybody recommend some tools
>>>>>>
>>>>>> Why not just use what is available at the ASF ;-)
>>>>>>
>>>>>> http://ci.apache.org/
>>>>>>
>>>>>> I use Hudson and like it, but I haven't tried the
>>>> others...
>>>>>>
>>>>>>> Once that is done I'd like to have it run the
>>>> tests after every commit and report any failures to the dev
>>>> list.  It would then be the offending committer's
>>>> responsibility (well primarily at least) to fix the problem
>>>> as soon as possible, much like a build failure.  If we
>>>> can't get everyone to agree to take on that responsibility
>>>> then I might as well stop now because I'll be damned if I'm
>>>> going to spend any more time fixing tests that I didn't
>>>> break :-)
>>>>>>
>>>>>> +1
>>>>>>
>>>>>>> All of this should help us increase the
>>>> stability of the trunk and our confidence when taking a
>>>> checkout that we won't half to spend our development time
>>>> fixing things that used to work.  It'll hopefully also
>>>> encourage the community to contribute more tests with the
>>>> knowledge that doing so will increase the stability of the
>>>> functionality they depend on.  Fix a bug and you're
>>>> good for a day, write a test and you're good a lifetime :-)
>>>>>>
>>>>>> Absolutly agreed, big thanks for your (and all the
>>>> others) work in this area!
>>>>>>
>>>>>> --Christian
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>

[Adrian Crum-2]

I have a run-tests target set up in the base component. I'm having one small problem that I hope a junit guru can help me with...

The tests that require properties files are failing with a MissingResourceException. I know what the problem is - the classloader can't find the properties files, but I can't figure out how to fix it.

Here is the classpath I set up for the junit tests:

    <path id="junit.class.path">
        <fileset dir="${build.dir}/lib" includes="*.jar"/>
        <fileset dir="config" includes="*.properties"/>
        <fileset dir="${lib.dir}" includes="*.jar"/>
        <fileset dir="${lib.dir}/commons" includes="*.jar"/>
        <fileset dir="${lib.dir}/j2eespecs" includes="*.jar"/>
        <fileset dir="${lib.dir}/scripting" includes="*.jar"/>
        <fileset dir="../start/build/lib" includes="*.jar"/>
    </path>

And here is the target:

    <target name="run-tests" depends="jar">
        <junit fork="yes" haltonfailure="yes">
            <test name="org.ofbiz.base.test.BaseUnitTests" />
            <formatter type="plain" usefile="false" />
            <classpath refid="junit.class.path" />
        </junit>
    </target>

Any help would be greatly appreciated!

-Adrian

--- On Thu, 11/19/09, Adrian Crum <[hidden email]> wrote:

> From: Adrian Crum <[hidden email]>
> Subject: Re: All JUnit tests now pass! Next steps...
> To: [hidden email]
> Date: Thursday, November 19, 2009, 1:59 PM
> Thanks for the links! I'll look into
> it further this weekend.
>
> -Adrian
>
> Scott Gray wrote:
> > Just because our test tools require container loading
> there is no reason why we couldn't run tests that don't
> require containers and use the junit ant task to run them
> during the test build:
> > http://junit.sourceforge.net/doc/faq/faq.htm#running_5
> > http://ant.apache.org/manual/OptionalTasks/junit.html
> >
> > That reminds me, we need to upgrade to the latest
> version of JUnit, I'll take care of it this weekend.
> >
> > Regards
> > Scott
> >
> > On 20/11/2009, at 10:00 AM, Adrian Crum wrote:
> >
> >> I guess I was being myopic. Adam mentioned having
> to load the containers, and he's right - most
> component-level tests would require loading OFBiz in order
> for them to work. I was thinking only of the framework/base
> component - where you could run unit tests on the various
> classes found there. That wouldn't require container loading
> (I think).
> >>
> >> Maybe it's too much of a bother. *shrug*
> >>
> >> -Adrian
> >>
> >>
> >> Scott Gray wrote:
> >>> You can run a single test suite using the main
> build file:
> >>> ant run-single-test-suite
> -Dtest.component=accounting
> -Dtest.suiteName=accountingtests
> >>> it doesn't depend on the build target for some
> reason though but that could easily be changed.
> >>> Is this what you meant or something
> different?
> >>> Regards
> >>> Scott
> >>> On 20/11/2009, at 9:20 AM, Adrian Crum wrote:
> >>>> What I had in mind was something like a
> run-tests ant target in the component's build.xml file. The
> run-tests target would depend on the build target.
> >>>>
> >>>> That would make code testing really easy
> and convenient: modify code, run-tests, modify code some
> more, run-tests...
> >>>>
> >>>> -Adrian
> >>>>
> >>>> Scott Gray wrote:
> >>>>> On 20/11/2009, at 4:43 AM, Adrian Crum
> wrote:
> >>>>>> I would like to build out the unit
> tests in the framework/base component, but I still need help
> getting that component's build.xml file to run tests.
> >>>>> Sorry I meant to look into it when you
> first raised that thread, I'll dig it up and see if I can
> help.
> >>>>> Regards
> >>>>> Scott
> >
>

     

[Adam Heath-2]

Adrian Crum wrote:
> I have a run-tests target set up in the base component. I'm having one small problem that I hope a junit guru can help me with...
>
> The tests that require properties files are failing with a MissingResourceException. I know what the problem is - the classloader can't find the properties files, but I can't figure out how to fix it.
>
> Here is the classpath I set up for the junit tests:
>
>     <path id="junit.class.path">
>         <fileset dir="${build.dir}/lib" includes="*.jar"/>
>         <fileset dir="config" includes="*.properties"/>

Remove the includes attribute, and all will be well.