Are git patches acceptable?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Are git patches acceptable?

Christian Carlow-OFBizzer
Are git patches acceptable?

Reply | Threaded
Open this post in threaded view
|

Re: Are git patches acceptable?

Christian Carlow-OFBizzer
Bump.  Committers?

On Fri, 2015-03-27 at 19:33 -0500, Christian Carlow wrote:
> Are git patches acceptable?
>


Reply | Threaded
Open this post in threaded view
|

Re: Are git patches acceptable?

Deepak Dixit-3
Hi Christian,

You can create git patch using "git diff —no-prefix", It will create patch similar to svn diff.
I think it should be accepted. We can apply patch using patch -p0 < file path>

Others opinion ?


Thanks & Regards

Deepak Dixit

> On Mar 28, 2015, at 7:07 PM, Christian Carlow <[hidden email]> wrote:
>
> Bump.  Committers?
>
> On Fri, 2015-03-27 at 19:33 -0500, Christian Carlow wrote:
>> Are git patches acceptable?
>>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Are git patches acceptable?

Gil Portenseigne
Hi Christian,

If this kind of patch is easily
applyable, it will be accepted. No problem if the patch is generated from git, svn or other system (addonmanager for example).

Best Regards

Gil

On 28/03/2015 14:47, Deepak Dixit wrote:
Hi Christian, 

You can create git patch using "git diff —no-prefix", It will create patch similar to svn diff.
I think it should be accepted. We can apply patch using patch -p0 < file path>

Others opinion ?


Thanks & Regards
—
Deepak Dixit

On Mar 28, 2015, at 7:07 PM, Christian Carlow [hidden email] wrote:

Bump.  Committers?

On Fri, 2015-03-27 at 19:33 -0500, Christian Carlow wrote:
Are git patches acceptable?



    

Reply | Threaded
Open this post in threaded view
|

Re: Are git patches acceptable?

Christian Carlow-OFBizzer
The git patches are just as easily applied as svn and created similarly
in eclipse.  Git allows anyone to create local branches without needing
committer privilege.  I just wanted to make sure that the switch
wouldn't prevent patches from being rejected.

On Sat, 2015-03-28 at 15:03 +0100, gil portenseigne wrote:

> Hi Christian,
>
> If this kind of patch is easily applyable, it will be accepted. No
> problem if the patch is generated from git, svn or other system
> (addonmanager for example).
>
> Best Regards
>
> Gil
>
> On 28/03/2015 14:47, Deepak Dixit wrote:
>
> > Hi Christian,
> >
> > You can create git patch using "git diff —no-prefix", It will create patch similar to svn diff.
> > I think it should be accepted. We can apply patch using patch -p0 < file path>
> >
> > Others opinion ?
> >
> >
> > Thanks & Regards
> > —
> > Deepak Dixit
> >
> > > On Mar 28, 2015, at 7:07 PM, Christian Carlow <[hidden email]> wrote:
> > >
> > > Bump.  Committers?
> > >
> > > On Fri, 2015-03-27 at 19:33 -0500, Christian Carlow wrote:
> > > > Are git patches acceptable?
> > > >
> > >
>