OFBiz › OFBiz - Dev

Are html renderers really deprecated ?

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 3 messages Options
Blas Rodriguez Somoza
Reply | Threaded
Open this post in threaded view
♦
♦
|

Are html renderers really deprecated ?

Blas Rodriguez Somoza
Hello

    When working on the xhtml validation, I've patched some of the macro
renderers, in the assumption that the html ones could be forgeted.

    Unfortunately I've found that the HtmlFormRenderer is still used in
several pages of the Demo.

    Perhaps due to my lack of Ofbiz expertise, I supposed that the
default renderers are the macro ones and the html are no longer used.

    Trying to understand the code dependencies, I've done a simple
search for "import org.ofbiz.widget.html." in the java sources,  and
this is what I've found:

Outside of widget directories

(3) org\ofbiz\birt\email\BirtEmailServices.java  --> import
org.ofbiz.widget.html.HtmlScreenRenderer;
(3) org\ofbiz\common\email\EmailServices.java -->:import
org.ofbiz.widget.html.HtmlScreenRenderer;
(3) org\ofbiz\example\ExamplePrintServices.java --> import
org.ofbiz.widget.html.HtmlScreenRenderer;
(3) org\ofbiz\webtools\print\FoPrintServerEvents.java --> import
org.ofbiz.widget.html.HtmlScreenRenderer;
(3) org\ofbiz\oagis\OagisServices.java --> import
org.ofbiz.widget.html.HtmlScreenRenderer;
(3) org\ofbiz\oagis\OagisShipmentServices.java --> import
org.ofbiz.widget.html.HtmlScreenRenderer;

Inside widget directories (html directory excluded)

(1) org\ofbiz\widget\fo\FoFormRenderer.java --> import
org.ofbiz.widget.html.HtmlWidgetRenderer;
(1) org\ofbiz\widget\fo\FoScreenRenderer.java --> import
org.ofbiz.widget.html.HtmlWidgetRenderer;
(1) org\ofbiz\widget\screen\HtmlWidget.java -->:import
org.ofbiz.widget.html.HtmlWidgetRenderer;

(2) org\ofbiz\widget\menu\MenuWrapTransform.java --> import
org.ofbiz.widget.html.HtmlMenuWrapper;
(2) org\ofbiz\widget\screen\MacroScreenRenderer.java -->:import
org.ofbiz.widget.html.HtmlScreenRenderer.ScreenletMenuRenderer;
(2) org\ofbiz\widget\screen\ModelScreenWidget.java -->:import
org.ofbiz.widget.html.HtmlMenuRenderer;

(3) org\ofbiz\widget\screen\MacroScreenRenderer.java  -->:import
org.ofbiz.widget.html.HtmlFormRenderer;
(3) org\ofbiz\widget\screen\ModelScreenWidget.java -->:import
org.ofbiz.widget.html.HtmlFormRenderer;
(3) org\ofbiz\widget\screen\ScreenFopViewHandler.java -->:import
org.ofbiz.widget.html.HtmlScreenRenderer;
(3) org\ofbiz\widget\screen\ScreenWidgetViewHandler.java -->:import
org.ofbiz.widget.html.HtmlFormRenderer;
(3) org\ofbiz\widget\screen\ScreenWidgetViewHandler.java -->:import
org.ofbiz.widget.html.HtmlScreenRenderer;
(3) org\ofbiz\widget\screen\ScreenWidgetViewHandler.java -->:import
org.ofbiz.widget.html.HtmlTreeRenderer;

The dependencies can be classified in three categories:

(1) HtmlWidgetRenderer is not really an html dependency since it can be
moved to other directory, f.i. org.ofbiz.widget, because it don't
depends on other org.ofbiz.widget.html sources.
(2) AFAIK there are no macro equivalents for menus
(HtmlMenuRenderer/HtmlMenuWrapper/ScreenletMenuRenderer) so the
dependencies can't be replaced.
(3) AFAIK there are macro equivalents for
HtmlFormRenderer,HtmlScreenRenderer,HtmlTreeRenderer (MacroFormRenderer,
MacroScreenRenderer, MacroTreeRenderer).
 
    Are the dependencies in category (3) really needed or can be
replaced with macro equivalents ?

Regards
Blas Rodrigez Somoza


Scott Gray-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Are html renderers really deprecated ?

Scott Gray-2
Well I guess you could say that we're working towards deprecation :-)

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 7/05/2010, at 7:34 AM, Blas Rodriguez Somoza wrote:

> Hello
>
>   When working on the xhtml validation, I've patched some of the macro renderers, in the assumption that the html ones could be forgeted.
>
>   Unfortunately I've found that the HtmlFormRenderer is still used in several pages of the Demo.
>
>   Perhaps due to my lack of Ofbiz expertise, I supposed that the default renderers are the macro ones and the html are no longer used.
>
>   Trying to understand the code dependencies, I've done a simple search for "import org.ofbiz.widget.html." in the java sources,  and this is what I've found:
>
> Outside of widget directories
>
> (3) org\ofbiz\birt\email\BirtEmailServices.java  --> import org.ofbiz.widget.html.HtmlScreenRenderer;
> (3) org\ofbiz\common\email\EmailServices.java -->:import org.ofbiz.widget.html.HtmlScreenRenderer;
> (3) org\ofbiz\example\ExamplePrintServices.java --> import org.ofbiz.widget.html.HtmlScreenRenderer;
> (3) org\ofbiz\webtools\print\FoPrintServerEvents.java --> import org.ofbiz.widget.html.HtmlScreenRenderer;
> (3) org\ofbiz\oagis\OagisServices.java --> import org.ofbiz.widget.html.HtmlScreenRenderer;
> (3) org\ofbiz\oagis\OagisShipmentServices.java --> import org.ofbiz.widget.html.HtmlScreenRenderer;
>
> Inside widget directories (html directory excluded)
>
> (1) org\ofbiz\widget\fo\FoFormRenderer.java --> import org.ofbiz.widget.html.HtmlWidgetRenderer;
> (1) org\ofbiz\widget\fo\FoScreenRenderer.java --> import org.ofbiz.widget.html.HtmlWidgetRenderer;
> (1) org\ofbiz\widget\screen\HtmlWidget.java -->:import org.ofbiz.widget.html.HtmlWidgetRenderer;
>
> (2) org\ofbiz\widget\menu\MenuWrapTransform.java --> import org.ofbiz.widget.html.HtmlMenuWrapper;
> (2) org\ofbiz\widget\screen\MacroScreenRenderer.java -->:import org.ofbiz.widget.html.HtmlScreenRenderer.ScreenletMenuRenderer;
> (2) org\ofbiz\widget\screen\ModelScreenWidget.java -->:import org.ofbiz.widget.html.HtmlMenuRenderer;
>
> (3) org\ofbiz\widget\screen\MacroScreenRenderer.java  -->:import org.ofbiz.widget.html.HtmlFormRenderer;
> (3) org\ofbiz\widget\screen\ModelScreenWidget.java -->:import org.ofbiz.widget.html.HtmlFormRenderer;
> (3) org\ofbiz\widget\screen\ScreenFopViewHandler.java -->:import org.ofbiz.widget.html.HtmlScreenRenderer;
> (3) org\ofbiz\widget\screen\ScreenWidgetViewHandler.java -->:import org.ofbiz.widget.html.HtmlFormRenderer;
> (3) org\ofbiz\widget\screen\ScreenWidgetViewHandler.java -->:import org.ofbiz.widget.html.HtmlScreenRenderer;
> (3) org\ofbiz\widget\screen\ScreenWidgetViewHandler.java -->:import org.ofbiz.widget.html.HtmlTreeRenderer;
>
> The dependencies can be classified in three categories:
>
> (1) HtmlWidgetRenderer is not really an html dependency since it can be moved to other directory, f.i. org.ofbiz.widget, because it don't depends on other org.ofbiz.widget.html sources.
> (2) AFAIK there are no macro equivalents for menus (HtmlMenuRenderer/HtmlMenuWrapper/ScreenletMenuRenderer) so the dependencies can't be replaced.
> (3) AFAIK there are macro equivalents for HtmlFormRenderer,HtmlScreenRenderer,HtmlTreeRenderer (MacroFormRenderer, MacroScreenRenderer, MacroTreeRenderer).
>   Are the dependencies in category (3) really needed or can be replaced with macro equivalents ?
>
> Regards
> Blas Rodrigez Somoza
>
>


smime.p7s (3K) Download Attachment
Blas Rodriguez Somoza
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: Are html renderers really deprecated ?

Blas Rodriguez Somoza
I've found the reason why HtmlFormRenderer is still used in the demo and
is only a bug.in MacroScreenRenderer.

Excluding this bug, the only real html dependency of the macro renderers
against html is the HtmlMenuRenderer, as expected.

I'll will create a JIRA entry with the explanation and a patch, hoping
someone commit it. ;-)

Scott Gray escribió:

> Well I guess you could say that we're working towards deprecation :-)
>
> Regards
> Scott
>
> HotWax Media
> http://www.hotwaxmedia.com
>
> On 7/05/2010, at 7:34 AM, Blas Rodriguez Somoza wrote:
>
>  
>> Hello
>>
>>   When working on the xhtml validation, I've patched some of the macro renderers, in the assumption that the html ones could be forgeted.
>>
>>   Unfortunately I've found that the HtmlFormRenderer is still used in several pages of the Demo.
>>
>>   Perhaps due to my lack of Ofbiz expertise, I supposed that the default renderers are the macro ones and the html are no longer used.
>>
>>   Trying to understand the code dependencies, I've done a simple search for "import org.ofbiz.widget.html." in the java sources,  and this is what I've found:
>>
>> Outside of widget directories
>>
>> (3) org\ofbiz\birt\email\BirtEmailServices.java  --> import org.ofbiz.widget.html.HtmlScreenRenderer;
>> (3) org\ofbiz\common\email\EmailServices.java -->:import org.ofbiz.widget.html.HtmlScreenRenderer;
>> (3) org\ofbiz\example\ExamplePrintServices.java --> import org.ofbiz.widget.html.HtmlScreenRenderer;
>> (3) org\ofbiz\webtools\print\FoPrintServerEvents.java --> import org.ofbiz.widget.html.HtmlScreenRenderer;
>> (3) org\ofbiz\oagis\OagisServices.java --> import org.ofbiz.widget.html.HtmlScreenRenderer;
>> (3) org\ofbiz\oagis\OagisShipmentServices.java --> import org.ofbiz.widget.html.HtmlScreenRenderer;
>>
>> Inside widget directories (html directory excluded)
>>
>> (1) org\ofbiz\widget\fo\FoFormRenderer.java --> import org.ofbiz.widget.html.HtmlWidgetRenderer;
>> (1) org\ofbiz\widget\fo\FoScreenRenderer.java --> import org.ofbiz.widget.html.HtmlWidgetRenderer;
>> (1) org\ofbiz\widget\screen\HtmlWidget.java -->:import org.ofbiz.widget.html.HtmlWidgetRenderer;
>>
>> (2) org\ofbiz\widget\menu\MenuWrapTransform.java --> import org.ofbiz.widget.html.HtmlMenuWrapper;
>> (2) org\ofbiz\widget\screen\MacroScreenRenderer.java -->:import org.ofbiz.widget.html.HtmlScreenRenderer.ScreenletMenuRenderer;
>> (2) org\ofbiz\widget\screen\ModelScreenWidget.java -->:import org.ofbiz.widget.html.HtmlMenuRenderer;
>>
>> (3) org\ofbiz\widget\screen\MacroScreenRenderer.java  -->:import org.ofbiz.widget.html.HtmlFormRenderer;
>> (3) org\ofbiz\widget\screen\ModelScreenWidget.java -->:import org.ofbiz.widget.html.HtmlFormRenderer;
>> (3) org\ofbiz\widget\screen\ScreenFopViewHandler.java -->:import org.ofbiz.widget.html.HtmlScreenRenderer;
>> (3) org\ofbiz\widget\screen\ScreenWidgetViewHandler.java -->:import org.ofbiz.widget.html.HtmlFormRenderer;
>> (3) org\ofbiz\widget\screen\ScreenWidgetViewHandler.java -->:import org.ofbiz.widget.html.HtmlScreenRenderer;
>> (3) org\ofbiz\widget\screen\ScreenWidgetViewHandler.java -->:import org.ofbiz.widget.html.HtmlTreeRenderer;
>>
>> The dependencies can be classified in three categories:
>>
>> (1) HtmlWidgetRenderer is not really an html dependency since it can be moved to other directory, f.i. org.ofbiz.widget, because it don't depends on other org.ofbiz.widget.html sources.
>> (2) AFAIK there are no macro equivalents for menus (HtmlMenuRenderer/HtmlMenuWrapper/ScreenletMenuRenderer) so the dependencies can't be replaced.
>> (3) AFAIK there are macro equivalents for HtmlFormRenderer,HtmlScreenRenderer,HtmlTreeRenderer (MacroFormRenderer, MacroScreenRenderer, MacroTreeRenderer).
>>   Are the dependencies in category (3) really needed or can be replaced with macro equivalents ?
>>
>> Regards
>> Blas Rodrigez Somoza
>>
>>
>>    
>
>  

Free forum by Nabble Edit this page