BROKEN! Re: svn commit: r692448 - in /ofbiz/trunk/applications: ecommerce/data/ ecommerce/script/org/ofbiz/ecommerce/customer/ ecommerce/webapp/ecommerce/images/ ecommerce/webapp/ecommerce/order/ order/script/org/ofbiz/order/order/ order/servicedef/ party/script/o...

[Adam Heath-2]

[hidden email] wrote:

> Modified: ofbiz/trunk/applications/order/servicedef/services.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/services.xml?rev=692448&r1=692447&r2=692448&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/servicedef/services.xml (original)
> +++ ofbiz/trunk/applications/order/servicedef/services.xml Fri Sep  5 07:08:18 2008
> @@ -843,4 +843,66 @@
>          <description>A service designed to be automatically run by job scheduler to create orders from subscriptions which need to be extended.
>              This is done by looking for all subscriptions which are active and where the automaticExtend flag is set to "Y"</description>
>      </service>
> -</services>
> +    
> +    <service name="createUpdateShippingAddress" engine="simple"
> +            location="org/ofbiz/order/order/OrderServices.xml" invoke="createUpdateShippingAddress" auth="true">
> +        <description>Creates new shipping address and update existing address</description>
> +        <attribute name="productStoreId" mode="IN" type="String" optional="true"/>
> +        <attribute name="setDefaultShipping" mode="IN" type="String" optional="true"/>
> +        <attribute name="keepAddressBook" mode="IN" type="String" optional="true"/>
> +        <attribute name="partyId" mode="IN" type="String" optional="true"/>
> +        <attribute name="userLogin" mode="IN" type="GenericValue" optional="true"/>
> +        <attribute name="shipToAttnName" mode="IN" type="String" optional="true"/>
> +        <attribute name="shipToToName" mode="IN" type="String" optional="true"/>
> +        <attribute name="shipToAddress1" mode="IN" type="String" optional="false"/>
> +        <attribute name="shipToAddress2" mode="IN" type="String" optional="true"/>
> +        <attribute name="shipToCity" mode="IN" type="String" optional="false"/>
> +        <attribute name="shipToStateProvinceGeoId" mode="IN" type="String" optional="false"/>
> +        <attribute name="shipToPostalCode" mode="IN" type="String" optional="false"/>
> +        <attribute name="shipToCountryGeoId" mode="IN" type="String" optional="false"/>
> +        <attribute name="shipToContactMechId" mode="IN" type="String" optional="true"/>
> +        <attribute name="contactMechId" mode="OUT" type="String" optional="false"/>
> +        <attribute name="billToContactMechId" mode="IN" type="String" optional="true"/>
> +    </service>
> +
> +    <service name="createUpdateBillingAddress" engine="simple"
> +            location="org/ofbiz/order/order/OrderServices.xml" invoke="createUpdateBillingAddress" auth="true">
> +        <description>Creates new billing address and update existing address</description>
> +        <attribute name="productStoreId" mode="IN" type="String" optional="true"/>
> +        <attribute name="setDefaultBilling" mode="IN" type="String" optional="true"/>
> +        <attribute name="keepAddressBook" mode="IN" type="String" optional="true"/>
> +        <attribute name="useShippingAddressForBilling" mode="IN" type="String" optional="true"/>
> +        <attribute name="partyId" mode="IN" type="String" optional="true"/>
> +        <attribute name="userLogin" mode="IN" type="GenericValue" optional="true"/>
> +        <attribute name="billToAttnName" mode="IN" type="String" optional="true"/>
> +        <attribute name="billToName" mode="IN" type="String" optional="true"/>
> +        <attribute name="billToAddress1" mode="IN" type="String" optional="false"/>
> +        <attribute name="billToAddress2" mode="IN" type="String" optional="true"/>
> +        <attribute name="billToCity" mode="IN" type="String" optional="false"/>
> +        <attribute name="billToStateProvinceGeoId" mode="IN" type="String" optional="false"/>
> +        <attribute name="billToPostalCode" mode="IN" type="String" optional="false"/>
> +        <attribute name="billToCountryGeoId" mode="IN" type="String" optional="false"/>
> +        <attribute name="shipToContactMechId" mode="IN" type="String" optional="true"/>
> +        <attribute name="billToContactMechId" mode="IN" type="String" optional="true"/>
> +        <attribute name="contactMechId" mode="OUT" type="String" optional="false"/>
> +    </service>
> +
> +    <service name="createUpdateCreditCard" engine="simple" auth="true" default-entity-name="CreditCard"
> +            location="org/ofbiz/order/order/OrderServices.xml" invoke="createUpdateCreditCard">
> +        <description>Create/Update credit card</description>
> +        <attribute name="expMonth" type="String" mode="IN" optional="false"/>
> +        <attribute name="expYear" type="String" mode="IN" optional="false"/>
> +        <attribute name="cardType" type="String" mode="IN" optional="false"/>
> +        <attribute name="cardNumber" type="String" mode="IN" optional="false"/>
> +        <attribute name="partyId" type="String" mode="IN" optional="true"/>
> +        <attribute name="companyNameOnCard" type="String" mode="IN" optional="true"/>
> +        <attribute name="titleOnCard" type="String" mode="IN" optional="true"/>
> +        <attribute name="firstNameOnCard" type="String" mode="IN" optional="false"/>
> +        <attribute name="middleNameOnCard" type="String" mode="IN" optional="true"/>
> +        <attribute name="lastNameOnCard" type="String" mode="IN" optional="false"/>
> +        <attribute name="suffixOnCard" type="String" mode="IN" optional="true"/>
> +        <attribute name="contactMechId" type="String" mode="IN" optional="true"/>
> +        <attribute name="paymentMethodId" type="String" mode="IN" optional="true"/>
> +        <attribute name="paymentMethodId" type="String" mode="OUT" optional="false"/>
> +    </service>
> +
>

Please fix this broken commit; there is no trailing </services> tag!

[Adrian Crum]

Done, rev 692569.

-Adrian

Adam Heath wrote:

> [hidden email] wrote:
>> Modified: ofbiz/trunk/applications/order/servicedef/services.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/services.xml?rev=692448&r1=692447&r2=692448&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/order/servicedef/services.xml (original)
>> +++ ofbiz/trunk/applications/order/servicedef/services.xml Fri Sep  5 07:08:18 2008
>> @@ -843,4 +843,66 @@
>>          <description>A service designed to be automatically run by job scheduler to create orders from subscriptions which need to be extended.
>>              This is done by looking for all subscriptions which are active and where the automaticExtend flag is set to "Y"</description>
>>      </service>
>> -</services>
>> +    
>> +    <service name="createUpdateShippingAddress" engine="simple"
>> +            location="org/ofbiz/order/order/OrderServices.xml" invoke="createUpdateShippingAddress" auth="true">
>> +        <description>Creates new shipping address and update existing address</description>
>> +        <attribute name="productStoreId" mode="IN" type="String" optional="true"/>
>> +        <attribute name="setDefaultShipping" mode="IN" type="String" optional="true"/>
>> +        <attribute name="keepAddressBook" mode="IN" type="String" optional="true"/>
>> +        <attribute name="partyId" mode="IN" type="String" optional="true"/>
>> +        <attribute name="userLogin" mode="IN" type="GenericValue" optional="true"/>
>> +        <attribute name="shipToAttnName" mode="IN" type="String" optional="true"/>
>> +        <attribute name="shipToToName" mode="IN" type="String" optional="true"/>
>> +        <attribute name="shipToAddress1" mode="IN" type="String" optional="false"/>
>> +        <attribute name="shipToAddress2" mode="IN" type="String" optional="true"/>
>> +        <attribute name="shipToCity" mode="IN" type="String" optional="false"/>
>> +        <attribute name="shipToStateProvinceGeoId" mode="IN" type="String" optional="false"/>
>> +        <attribute name="shipToPostalCode" mode="IN" type="String" optional="false"/>
>> +        <attribute name="shipToCountryGeoId" mode="IN" type="String" optional="false"/>
>> +        <attribute name="shipToContactMechId" mode="IN" type="String" optional="true"/>
>> +        <attribute name="contactMechId" mode="OUT" type="String" optional="false"/>
>> +        <attribute name="billToContactMechId" mode="IN" type="String" optional="true"/>
>> +    </service>
>> +
>> +    <service name="createUpdateBillingAddress" engine="simple"
>> +            location="org/ofbiz/order/order/OrderServices.xml" invoke="createUpdateBillingAddress" auth="true">
>> +        <description>Creates new billing address and update existing address</description>
>> +        <attribute name="productStoreId" mode="IN" type="String" optional="true"/>
>> +        <attribute name="setDefaultBilling" mode="IN" type="String" optional="true"/>
>> +        <attribute name="keepAddressBook" mode="IN" type="String" optional="true"/>
>> +        <attribute name="useShippingAddressForBilling" mode="IN" type="String" optional="true"/>
>> +        <attribute name="partyId" mode="IN" type="String" optional="true"/>
>> +        <attribute name="userLogin" mode="IN" type="GenericValue" optional="true"/>
>> +        <attribute name="billToAttnName" mode="IN" type="String" optional="true"/>
>> +        <attribute name="billToName" mode="IN" type="String" optional="true"/>
>> +        <attribute name="billToAddress1" mode="IN" type="String" optional="false"/>
>> +        <attribute name="billToAddress2" mode="IN" type="String" optional="true"/>
>> +        <attribute name="billToCity" mode="IN" type="String" optional="false"/>
>> +        <attribute name="billToStateProvinceGeoId" mode="IN" type="String" optional="false"/>
>> +        <attribute name="billToPostalCode" mode="IN" type="String" optional="false"/>
>> +        <attribute name="billToCountryGeoId" mode="IN" type="String" optional="false"/>
>> +        <attribute name="shipToContactMechId" mode="IN" type="String" optional="true"/>
>> +        <attribute name="billToContactMechId" mode="IN" type="String" optional="true"/>
>> +        <attribute name="contactMechId" mode="OUT" type="String" optional="false"/>
>> +    </service>
>> +
>> +    <service name="createUpdateCreditCard" engine="simple" auth="true" default-entity-name="CreditCard"
>> +            location="org/ofbiz/order/order/OrderServices.xml" invoke="createUpdateCreditCard">
>> +        <description>Create/Update credit card</description>
>> +        <attribute name="expMonth" type="String" mode="IN" optional="false"/>
>> +        <attribute name="expYear" type="String" mode="IN" optional="false"/>
>> +        <attribute name="cardType" type="String" mode="IN" optional="false"/>
>> +        <attribute name="cardNumber" type="String" mode="IN" optional="false"/>
>> +        <attribute name="partyId" type="String" mode="IN" optional="true"/>
>> +        <attribute name="companyNameOnCard" type="String" mode="IN" optional="true"/>
>> +        <attribute name="titleOnCard" type="String" mode="IN" optional="true"/>
>> +        <attribute name="firstNameOnCard" type="String" mode="IN" optional="false"/>
>> +        <attribute name="middleNameOnCard" type="String" mode="IN" optional="true"/>
>> +        <attribute name="lastNameOnCard" type="String" mode="IN" optional="false"/>
>> +        <attribute name="suffixOnCard" type="String" mode="IN" optional="true"/>
>> +        <attribute name="contactMechId" type="String" mode="IN" optional="true"/>
>> +        <attribute name="paymentMethodId" type="String" mode="IN" optional="true"/>
>> +        <attribute name="paymentMethodId" type="String" mode="OUT" optional="false"/>
>> +    </service>
>> +
>>
>
>
> Please fix this broken commit; there is no trailing </services> tag!
>

[Adam Heath-2]

Adrian Crum wrote:
> Done, rev 692569.

I could have done that myself; that wasn't the reason I sent it.

I'm surprised no one else noticed this particular problem; the entire
ordermgr was broken all day because of it.

[Adrian Crum]

How long would you have waited to fix it?

I've been in WebTools all day.

-Adrian

Adam Heath wrote:
> Adrian Crum wrote:
>> Done, rev 692569.
>
> I could have done that myself; that wasn't the reason I sent it.
>
> I'm surprised no one else noticed this particular problem; the entire
> ordermgr was broken all day because of it.
>

[Adam Heath-2]

Adrian Crum wrote:
> How long would you have waited to fix it?

Probably an hour; almost end of day here.

And I have something big planned for GroovyUtil.

[Tim Ruppert]

Thanks for fixing it Adrian.  Vikas, please be more careful on this  
next time.

Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

On Sep 5, 2008, at 5:00 PM, Adrian Crum wrote:

> How long would you have waited to fix it?
>
> I've been in WebTools all day.
>
> -Adrian
>
> Adam Heath wrote:
>> Adrian Crum wrote:
>>> Done, rev 692569.
>> I could have done that myself; that wasn't the reason I sent it.
>> I'm surprised no one else noticed this particular problem; the entire
>> ordermgr was broken all day because of it.

[Adam Heath-2]

Tim Ruppert wrote:
> Thanks for fixing it Adrian.  Vikas, please be more careful on this next
> time.

Yeah, just did another seed data fix.  Revision 692448 didn't even pass
an ant clean-data/run-install run.  Which is extremely simple to do.

[Tim Ruppert]

Thanks Adam.

Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

On Sep 5, 2008, at 5:12 PM, Adam Heath wrote:

> Tim Ruppert wrote:
>> Thanks for fixing it Adrian.  Vikas, please be more careful on this  
>> next
>> time.
>
> Yeah, just did another seed data fix.  Revision 692448 didn't even  
> pass
> an ant clean-data/run-install run.  Which is extremely simple to do.

[Jacopo Cappellato-3]

Thanks for the bug report Adam, and thanks for the quick fix Adrian.
By the way, I don't see the need of doing all this noise around an  
error... it happens to all of us, me and you included Adam.

Jacopo


On Sep 6, 2008, at 5:05 AM, Tim Ruppert wrote:

> Thanks Adam.
>
> Cheers,
> Tim
> --
> Tim Ruppert
> HotWax Media
> http://www.hotwaxmedia.com
>
> o:801.649.6594
> f:801.649.6595
>
> On Sep 5, 2008, at 5:12 PM, Adam Heath wrote:
>
>> Tim Ruppert wrote:
>>> Thanks for fixing it Adrian.  Vikas, please be more careful on  
>>> this next
>>> time.
>>
>> Yeah, just did another seed data fix.  Revision 692448 didn't even  
>> pass
>> an ant clean-data/run-install run.  Which is extremely simple to do.
>

[Jacques Le Roux]

From: "Jacopo Cappellato" <[hidden email]>
> Thanks for the bug report Adam, and thanks for the quick fix Adrian.
> By the way, I don't see the need of doing all this noise around an  
> error... it happens to all of us, me and you included Adam.
>
> Jacopo

So true !

Jacques
 

>
> On Sep 6, 2008, at 5:05 AM, Tim Ruppert wrote:
>
>> Thanks Adam.
>>
>> Cheers,
>> Tim
>> --
>> Tim Ruppert
>> HotWax Media
>> http://www.hotwaxmedia.com
>>
>> o:801.649.6594
>> f:801.649.6595
>>
>> On Sep 5, 2008, at 5:12 PM, Adam Heath wrote:
>>
>>> Tim Ruppert wrote:
>>>> Thanks for fixing it Adrian.  Vikas, please be more careful on  
>>>> this next
>>>> time.
>>>
>>> Yeah, just did another seed data fix.  Revision 692448 didn't even  
>>> pass
>>> an ant clean-data/run-install run.  Which is extremely simple to do.
>>
>
>

[Adam Heath-2]

Jacques Le Roux wrote:
> From: "Jacopo Cappellato" <[hidden email]>
>> Thanks for the bug report Adam, and thanks for the quick fix Adrian.
>> By the way, I don't see the need of doing all this noise around an
>> error... it happens to all of us, me and you included Adam.
>>
>> Jacopo
>
> So true !

Of course we all make mistakes.  But if you just fix the mistake,
without understand *why* it occurred, or without providing a way to help
stop them from occurring, then they will keep happening.

Don't we all want to become better at what we do?