Yes, no changes required.
Thanks !!
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Wed, Jul 22, 2020 at 8:14 PM Jacques Le Roux <
[hidden email]> wrote:
> It works as expected in 4.2 when using our formatter in Eclipse.
> Since the checkstyle was based on the formatter, that should not be changed
>
> Jacques
>
> Le 22/07/2020 à 14:16, Jacques Le Roux a écrit :
> > I had a doubt too, this is always confusing.
> >
> > I'll test formatting in Eclipse...
> >
> > Jacques
> >
> > Le 22/07/2020 à 12:56, Suraj Khurana a écrit :
> >> Hello team,
> >>
> >> I further checked oracle docs [1] and maybe this is the reason for this.
> >> See 4.2 in this pdf.
> >>
> >> [1]:
https://www.oracle.com/technetwork/java/codeconventions-150003.pdf> >>
> >> --
> >> Best Regards,
> >> Suraj Khurana
> >> Senior Technical Consultant
> >>
> >>
> >> On Tue, Jul 21, 2020 at 10:52 PM Jacques Le Roux <
> >>
[hidden email]> wrote:
> >>
> >>> +1 reading the link
> >>>
> >>> Thanks Suraj!
> >>>
> >>> Le 21/07/2020 à 14:21, Pritam Kute a écrit :
> >>>> Good catch Suraj. +1 for having it as 4 instead of 8.
> >>>>
> >>>> Kind Regards,
> >>>> --
> >>>> Pritam Kute
> >>>>
> >>>>
> >>>> On Tue, Jul 21, 2020 at 5:26 PM Suraj Khurana <
>
[hidden email]>
> >>>> wrote:
> >>>>
> >>>>> Hello folks,
> >>>>>
> >>>>> In checkstyle.xml, we have set lineWrappingIndentation value to 8. I
> >>>>> Propose we should make it 4 instead which is default. [1]
> >>>>>
> >>>>> Is there any specific reason for setting it to 8? Please advise.
> >>>>>
> >>>>> [1]:
> >>>>>
> >>>>>
> >>>
>
https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheck.html> >>>>> --
> >>>>> Best Regards,
> >>>>> Suraj Khurana
> >>>>> Senior Technical Consultant
> >>>>>
>
Locked
