Confusing implementation of the quickAdd feature of e-commerce

[Pawan Verma]

Hello Devs,

While looking into OFBIZ-10978, I found the implementation of the quickAdd
feature of e-commerce confusing.

What I found under the quickadd screen of ecommerce/CatalogScreens.xml is
that the UI and data preparation layers are in no sync to each other.
The QuickAdd.groovy file has the correct implementation of the QuickAdd
feature (as per the ordermgr component) and the FTL has been designed as
per e-commerce.

I think we need to take a decision here about the quickadd screen.

Should we make this feature same as quickadd feature of ordermgr?
OR
Should we write separate data preparation logic for quickadd feature of
e-commerce?

Suggestions are most welcome. Thanks!

--
Kind Regards,
*Pawan Verma* | Technical Consultant
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P. 452010
Linkedin: *Pawan Verma <https://www.linkedin.com/in/pawan--verma>*

[Rishi Solanki]

Dear Pawan,
In general template should be change. So that we can reuse the data
preparation logic. In case quick add is not working due to some
parameters/context missing then we can think of separate groovy for
ecommerce.
But first we try to reuse the base component logics in plugin component.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems <http://www.hotwaxsystems.com/>
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*
<https://www.linkedin.com/in/rishi-solanki-62271b7/>
Direct: [phone]


On Sat, Apr 27, 2019 at 8:44 PM Pawan Verma <[hidden email]>
wrote:

> Hello Devs,
>
> While looking into OFBIZ-10978, I found the implementation of the quickAdd
> feature of e-commerce confusing.
>
> What I found under the quickadd screen of ecommerce/CatalogScreens.xml is
> that the UI and data preparation layers are in no sync to each other.
> The QuickAdd.groovy file has the correct implementation of the QuickAdd
> feature (as per the ordermgr component) and the FTL has been designed as
> per e-commerce.
>
> I think we need to take a decision here about the quickadd screen.
>
> Should we make this feature same as quickadd feature of ordermgr?
> OR
> Should we write separate data preparation logic for quickadd feature of
> e-commerce?
>
> Suggestions are most welcome. Thanks!
>
> --
> Kind Regards,
> *Pawan Verma* | Technical Consultant
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> M.P. 452010
> Linkedin: *Pawan Verma <https://www.linkedin.com/in/pawan--verma>*
>

[Vivek Bisen]

Thanks  @Rishi Solanki <[hidden email]>  for your
recommendation,
As recommended, I have changed the template and added the patch for the
same.

Please have a look and let me know in case of any concerns.
Thanks in advance !!


On Sat, Apr 27, 2019 at 10:37 PM Rishi Solanki <[hidden email]>
wrote:

> Dear Pawan,
> In general template should be change. So that we can reuse the data
> preparation logic. In case quick add is not working due to some
> parameters/context missing then we can think of separate groovy for
> ecommerce.
> But first we try to reuse the base component logics in plugin component.
>
> Best Regards,
> --
> *Rishi Solanki* | Sr Manager, Enterprise Software Development
> HotWax Systems <http://www.hotwaxsystems.com/>
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> M.P 452010
> Linkedin: *Rishi Solanki*
> <https://www.linkedin.com/in/rishi-solanki-62271b7/>
> Direct: [phone]
>
>
> On Sat, Apr 27, 2019 at 8:44 PM Pawan Verma <[hidden email]
> >
> wrote:
>
> > Hello Devs,
> >
> > While looking into OFBIZ-10978, I found the implementation of the
> quickAdd
> > feature of e-commerce confusing.
> >
> > What I found under the quickadd screen of ecommerce/CatalogScreens.xml is
> > that the UI and data preparation layers are in no sync to each other.
> > The QuickAdd.groovy file has the correct implementation of the QuickAdd
> > feature (as per the ordermgr component) and the FTL has been designed as
> > per e-commerce.
> >
> > I think we need to take a decision here about the quickadd screen.
> >
> > Should we make this feature same as quickadd feature of ordermgr?
> > OR
> > Should we write separate data preparation logic for quickadd feature of
> > e-commerce?
> >
> > Suggestions are most welcome. Thanks!
> >
> > --
> > Kind Regards,
> > *Pawan Verma* | Technical Consultant
> > HotWax Systems <http://www.hotwaxsystems.com/>
> > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > Indore,
> > M.P. 452010
> > Linkedin: *Pawan Verma <https://www.linkedin.com/in/pawan--verma>*
> >
>

--
Thanks & Regards
*Vivek Singh Bisen* | Enterprise Software Engineer
Hotwax Systems Pvt. Ltd.
Cell Phone: [phone]