[DISCUSSION] Remove mask feature for date-time fields

[Jacques Le Roux]

Hi,

I was looking at https://issues.apache.org/jira/browse/OFBIZ-6734 and specifically the comment I made there about mask feature for date-time fields.
The masked input for date-time fields does not work as it should (compare behaviour of the 1st field of
https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples and https://igorescobar.github.io/jQuery-Mask-Plugin/)
I think there is a conflict between the calendar which is used by default with date-time fields and the masked input feature. So masked input feature
is ignored and adds nothing to date-time fields which is confusing.

I propose to remove this feature, what do you think?

Also the /<date-time type="time"/>/ is demonstrated there, and only used there, but does nothing.
As it ever working or is /<date-time input-method="time-dropdown" /a replacement/?
/Should we not clear that also (ie remove this demonstrating field and the feature at large)?
//

Thanks

Jacques

[taher]

why not resolve conflicts?

On Sat, Dec 15, 2018 at 3:48 PM Jacques Le Roux
<[hidden email]> wrote:

>
> Hi,
>
> I was looking at https://issues.apache.org/jira/browse/OFBIZ-6734 and specifically the comment I made there about mask feature for date-time fields.
> The masked input for date-time fields does not work as it should (compare behaviour of the 1st field of
> https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples and https://igorescobar.github.io/jQuery-Mask-Plugin/)
> I think there is a conflict between the calendar which is used by default with date-time fields and the masked input feature. So masked input feature
> is ignored and adds nothing to date-time fields which is confusing.
>
> I propose to remove this feature, what do you think?
>
> Also the /<date-time type="time"/>/ is demonstrated there, and only used there, but does nothing.
> As it ever working or is /<date-time input-method="time-dropdown" /a replacement/?
> /Should we not clear that also (ie remove this demonstrating field and the feature at large)?
> //
>
> Thanks
>
> Jacques
>

[Jacques Le Roux]

Yes we could open a Jira for that

Jacques

Le 15/12/2018 à 14:35, Taher Alkhateeb a écrit :

> why not resolve conflicts?
>
> On Sat, Dec 15, 2018 at 3:48 PM Jacques Le Roux
> <[hidden email]> wrote:
>> Hi,
>>
>> I was looking at https://issues.apache.org/jira/browse/OFBIZ-6734 and specifically the comment I made there about mask feature for date-time fields.
>> The masked input for date-time fields does not work as it should (compare behaviour of the 1st field of
>> https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples and https://igorescobar.github.io/jQuery-Mask-Plugin/)
>> I think there is a conflict between the calendar which is used by default with date-time fields and the masked input feature. So masked input feature
>> is ignored and adds nothing to date-time fields which is confusing.
>>
>> I propose to remove this feature, what do you think?
>>
>> Also the /<date-time type="time"/>/ is demonstrated there, and only used there, but does nothing.
>> As it ever working or is /<date-time input-method="time-dropdown" /a replacement/?
>> /Should we not clear that also (ie remove this demonstrating field and the feature at large)?
>> //
>>
>> Thanks
>>
>> Jacques
>>

[Pierre Smits-3]

Hey Jacques,

Is this, in a way, connected (or relevant to)
https://issues.apache.org/jira/browse/OFBIZ-10152 ?

Best regards,

Pierre Smits

*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
*Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
since 2008*
Apache Steve <https://steve.apache.org>, committer


On Sun, Dec 16, 2018 at 11:18 AM Jacques Le Roux <
[hidden email]> wrote:

> Yes we could open a Jira for that
>
> Jacques
>
> Le 15/12/2018 à 14:35, Taher Alkhateeb a écrit :
> > why not resolve conflicts?
> >
> > On Sat, Dec 15, 2018 at 3:48 PM Jacques Le Roux
> > <[hidden email]> wrote:
> >> Hi,
> >>
> >> I was looking at https://issues.apache.org/jira/browse/OFBIZ-6734 and
> specifically the comment I made there about mask feature for date-time
> fields.
> >> The masked input for date-time fields does not work as it should
> (compare behaviour of the 1st field of
> >> https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples
> and https://igorescobar.github.io/jQuery-Mask-Plugin/)
> >> I think there is a conflict between the calendar which is used by
> default with date-time fields and the masked input feature. So masked input
> feature
> >> is ignored and adds nothing to date-time fields which is confusing.
> >>
> >> I propose to remove this feature, what do you think?
> >>
> >> Also the /<date-time type="time"/>/ is demonstrated there, and only
> used there, but does nothing.
> >> As it ever working or is /<date-time input-method="time-dropdown" /a
> replacement/?
> >> /Should we not clear that also (ie remove this demonstrating field and
> the feature at large)?
> >> //
> >>
> >> Thanks
> >>
> >> Jacques
> >>
>

[Jacques Le Roux]

Yes it is somehow related, but not the same.

Jacques

Le 16/12/2018 à 11:25, Pierre Smits a écrit :

> Hey Jacques,
>
> Is this, in a way, connected (or relevant to)
> https://issues.apache.org/jira/browse/OFBIZ-10152 ?
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>
>
> On Sun, Dec 16, 2018 at 11:18 AM Jacques Le Roux <
> [hidden email]> wrote:
>
>> Yes we could open a Jira for that
>>
>> Jacques
>>
>> Le 15/12/2018 à 14:35, Taher Alkhateeb a écrit :
>>> why not resolve conflicts?
>>>
>>> On Sat, Dec 15, 2018 at 3:48 PM Jacques Le Roux
>>> <[hidden email]> wrote:
>>>> Hi,
>>>>
>>>> I was looking at https://issues.apache.org/jira/browse/OFBIZ-6734 and
>> specifically the comment I made there about mask feature for date-time
>> fields.
>>>> The masked input for date-time fields does not work as it should
>> (compare behaviour of the 1st field of
>>>> https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples
>> and https://igorescobar.github.io/jQuery-Mask-Plugin/)
>>>> I think there is a conflict between the calendar which is used by
>> default with date-time fields and the masked input feature. So masked input
>> feature
>>>> is ignored and adds nothing to date-time fields which is confusing.
>>>>
>>>> I propose to remove this feature, what do you think?
>>>>
>>>> Also the /<date-time type="time"/>/ is demonstrated there, and only
>> used there, but does nothing.
>>>> As it ever working or is /<date-time input-method="time-dropdown" /a
>> replacement/?
>>>> /Should we not clear that also (ie remove this demonstrating field and
>> the feature at large)?
>>>> //
>>>>
>>>> Thanks
>>>>
>>>> Jacques
>>>>

This is also related: https://issues.apache.org/jira/browse/OFBIZ-7532

Jacques

Le 16/12/2018 à 12:47, Jacques Le Roux a écrit :

> Yes it is somehow related, but not the same.
>
> Jacques
>
> Le 16/12/2018 à 11:25, Pierre Smits a écrit :
>> Hey Jacques,
>>
>> Is this, in a way, connected (or relevant to)
>> https://issues.apache.org/jira/browse/OFBIZ-10152 ?
>>
>> Best regards,
>>
>> Pierre Smits
>>
>> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
>> *Apache Directory <https://directory.apache.org>, PMC Member*
>> Apache Incubator <https://incubator.apache.org>, committer
>> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
>> since 2008*
>> Apache Steve <https://steve.apache.org>, committer
>>
>>
>> On Sun, Dec 16, 2018 at 11:18 AM Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>> Yes we could open a Jira for that
>>>
>>> Jacques
>>>
>>> Le 15/12/2018 à 14:35, Taher Alkhateeb a écrit :
>>>> why not resolve conflicts?
>>>>
>>>> On Sat, Dec 15, 2018 at 3:48 PM Jacques Le Roux
>>>> <[hidden email]> wrote:
>>>>> Hi,
>>>>>
>>>>> I was looking at https://issues.apache.org/jira/browse/OFBIZ-6734 and
>>> specifically the comment I made there about mask feature for date-time
>>> fields.
>>>>> The masked input for date-time fields does not work as it should
>>> (compare behaviour of the 1st field of
>>>>> https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples
>>> and https://igorescobar.github.io/jQuery-Mask-Plugin/)
>>>>> I think there is a conflict between the calendar which is used by
>>> default with date-time fields and the masked input feature. So masked input
>>> feature
>>>>> is ignored and adds nothing to date-time fields which is confusing.
>>>>>
>>>>> I propose to remove this feature, what do you think?
>>>>>
>>>>> Also the /<date-time type="time"/>/ is demonstrated there, and only
>>> used there, but does nothing.
>>>>> As it ever working or is /<date-time input-method="time-dropdown" /a
>>> replacement/?
>>>>> /Should we not clear that also (ie remove this demonstrating field and
>>> the feature at large)?
>>>>> //
>>>>>
>>>>> Thanks
>>>>>
>>>>> Jacques
>>>>>
>

[Jacques Le Roux]

Done at OFBIZ-10719

Jacques

Le 16/12/2018 à 11:12, Jacques Le Roux a écrit :

> Yes we could open a Jira for that
>
> Jacques
>
> Le 15/12/2018 à 14:35, Taher Alkhateeb a écrit :
>> why not resolve conflicts?
>>
>> On Sat, Dec 15, 2018 at 3:48 PM Jacques Le Roux
>> <[hidden email]> wrote:
>>> Hi,
>>>
>>> I was looking at https://issues.apache.org/jira/browse/OFBIZ-6734 and specifically the comment I made there about mask feature for date-time fields.
>>> The masked input for date-time fields does not work as it should (compare behaviour of the 1st field of
>>> https://demo-trunk.ofbiz.apache.org/example/control/FormWidgetExamples and https://igorescobar.github.io/jQuery-Mask-Plugin/)
>>> I think there is a conflict between the calendar which is used by default with date-time fields and the masked input feature. So masked input feature
>>> is ignored and adds nothing to date-time fields which is confusing.
>>>
>>> I propose to remove this feature, what do you think?
>>>
>>> Also the /<date-time type="time"/>/ is demonstrated there, and only used there, but does nothing.
>>> As it ever working or is /<date-time input-method="time-dropdown" /a replacement/?
>>> /Should we not clear that also (ie remove this demonstrating field and the feature at large)?
>>> //
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>