OFBiz › OFBiz - Dev

[DISCUSSION] where download gradle-wrapper.jar ?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

40 messages Options

Jacques Le Roux

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Administrator

Le 02/07/2019 à 08:46, Jacopo Cappellato a écrit :

> On Tue, Jul 2, 2019 at 7:14 AM Jacques Le Roux <[hidden email]>
> wrote:
>
>> [...]
>
>> It's only a RM issue. It's when packaging that we are tying OFBiz code
>> with a Gradle version.
>>
>> It's only then that we need to modify the gradlew script, to call an
>> init-gradle-wrapper script if the wrapper is missing.
>>
>> What do you think folks? Notably you Jacopo, with your RM hat on?
>
> I think that the direction we are heading is to not include it in the
> releases and add instructions in the release's README file to tell the user
> how to download it.
> So we could keep the wrappers (if we like) in the trunk and/or release
> branches and remove them when we package/publish a new release.
>
> Jacopo

Keeping the wrapper in branches is certainly easier for demos, Buildbot and working copies.

For the releases, my proposition was to alleviate the charge on users and their customers.

I'm not against letting them grab it. Maybe we could deliver an init-gradle-wrapper script version which would do the work for them

But again we would need to maintain it and it's benign to grab the wrapper files and put them in OFBiz-root-dir/gradle/wrapper folder.

Back to basic :)

Jacques

Jacques Le Roux

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Administrator

Le 02/07/2019 à 09:45, Jacques Le Roux a écrit :

> Le 02/07/2019 à 08:46, Jacopo Cappellato a écrit :
>> On Tue, Jul 2, 2019 at 7:14 AM Jacques Le Roux <[hidden email]>
>> wrote:
>>
>>> [...]
>>
>>> It's only a RM issue. It's when packaging that we are tying OFBiz code
>>> with a Gradle version.
>>>
>>> It's only then that we need to modify the gradlew script, to call an
>>> init-gradle-wrapper script if the wrapper is missing.
>>>
>>> What do you think folks? Notably you Jacopo, with your RM hat on?
>>
>> I think that the direction we are heading is to not include it in the
>> releases and add instructions in the release's README file to tell the user
>> how to download it.
>> So we could keep the wrappers (if we like) in the trunk and/or release
>> branches and remove them when we package/publish a new release.
>>
>> Jacopo
>
> Keeping the wrapper in branches is certainly easier for demos, Buildbot and working copies.
>
> For the releases, my proposition was to alleviate the charge on users and their customers.
>
> I'm not against letting them grab it. Maybe we could deliver an init-gradle-wrapper script version which would do the work for them
>
> But again we would need to maintain it and it's benign to grab the wrapper files and put them in OFBiz-root-dir/gradle/wrapper folder.
>
> Back to basic :)
>
> Jacques
>
>

OK, if nobody is against, I'll revert all related changes in trunk (including Nicolas's and Mathieu's) and Buildbot in 3 days, and will close OFBIZ-10145.

No maintenance will be needed, all will be handled during the RM phase as Jacopo initially suggested.

We will need to keep only the "Manual setting" section (w/o its title) in the main README.adoc. And to clearly document the RM phase.

Thank you to all who discussed and provided ideas and code.

Jacques

Nicolas Malin-2

Re: [DISCUSSION] where download gradle-wrapper.jar ?

On 03/07/2019 14:27, Jacques Le Roux wrote:

> Le 02/07/2019 à 09:45, Jacques Le Roux a écrit :
>> Le 02/07/2019 à 08:46, Jacopo Cappellato a écrit :
>>> On Tue, Jul 2, 2019 at 7:14 AM Jacques Le Roux
>>> <[hidden email]>
>>> wrote:
>>>
>>>> [...]
>>>
>>>> It's only a RM issue. It's when packaging that we are tying OFBiz code
>>>> with a Gradle version.
>>>>
>>>> It's only then that we need to modify the gradlew script, to call an
>>>> init-gradle-wrapper script if the wrapper is missing.
>>>>
>>>> What do you think folks? Notably you Jacopo, with your RM hat on?
>>>
>>> I think that the direction we are heading is to not include it in the
>>> releases and add instructions in the release's README file to tell
>>> the user
>>> how to download it.
>>> So we could keep the wrappers (if we like) in the trunk and/or release
>>> branches and remove them when we package/publish a new release.
>>>
>>> Jacopo
>>
>> Keeping the wrapper in branches is certainly easier for demos,
>> Buildbot and working copies.
>>
>> For the releases, my proposition was to alleviate the charge on users
>> and their customers.
>>
>> I'm not against letting them grab it. Maybe we could deliver an
>> init-gradle-wrapper script version which would do the work for them
>>
>> But again we would need to maintain it and it's benign to grab the
>> wrapper files and put them in OFBiz-root-dir/gradle/wrapper folder.
>>
>> Back to basic :)
>>
>> Jacques
>>
>>
> OK, if nobody is against, I'll revert all related changes in trunk
> (including Nicolas's and Mathieu's) and Buildbot in 3 days, and will
> close OFBIZ-10145.
>
> No maintenance will be needed, all will be handled during the RM phase
> as Jacopo initially suggested.
>
> We will need to keep only the "Manual setting" section (w/o its title)
> in the main README.adoc. And to clearly document the RM phase.
>
> Thank you to all who discussed and provided ideas and code.
>
> Jacques
>

No problem to revert on trunk however I'm in favor to keep an
init-gradle-wrapper to help first discovery without complex preparation
and the script maintenance is really easy.

So we can have on documentation advisable part with install gradle from
official source and other part for unfamiliar people with quick start
through init-gradle-wrapper.

After I'm always disturbed to have a different process to initialize
OFBiz between release branch and released package but I can live very
well with it.

Nicolas

Jacques Le Roux

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Administrator

Le 04/07/2019 à 11:07, Nicolas Malin a écrit :

> On 03/07/2019 14:27, Jacques Le Roux wrote:
>> Le 02/07/2019 à 09:45, Jacques Le Roux a écrit :
>>> Le 02/07/2019 à 08:46, Jacopo Cappellato a écrit :
>>>> On Tue, Jul 2, 2019 at 7:14 AM Jacques Le Roux <[hidden email]>
>>>> wrote:
>>>>
>>>>> [...]
>>>>
>>>>> It's only a RM issue. It's when packaging that we are tying OFBiz code
>>>>> with a Gradle version.
>>>>>
>>>>> It's only then that we need to modify the gradlew script, to call an
>>>>> init-gradle-wrapper script if the wrapper is missing.
>>>>>
>>>>> What do you think folks? Notably you Jacopo, with your RM hat on?
>>>>
>>>> I think that the direction we are heading is to not include it in the
>>>> releases and add instructions in the release's README file to tell the user
>>>> how to download it.
>>>> So we could keep the wrappers (if we like) in the trunk and/or release
>>>> branches and remove them when we package/publish a new release.
>>>>
>>>> Jacopo
>>>
>>> Keeping the wrapper in branches is certainly easier for demos, Buildbot and working copies.
>>>
>>> For the releases, my proposition was to alleviate the charge on users and their customers.
>>>
>>> I'm not against letting them grab it. Maybe we could deliver an init-gradle-wrapper script version which would do the work for them
>>>
>>> But again we would need to maintain it and it's benign to grab the wrapper files and put them in OFBiz-root-dir/gradle/wrapper folder.
>>>
>>> Back to basic :)
>>>
>>> Jacques
>>>
>>>
>> OK, if nobody is against, I'll revert all related changes in trunk (including Nicolas's and Mathieu's) and Buildbot in 3 days, and will close
>> OFBIZ-10145.
>>
>> No maintenance will be needed, all will be handled during the RM phase as Jacopo initially suggested.
>>
>> We will need to keep only the "Manual setting" section (w/o its title) in the main README.adoc. And to clearly document the RM phase.
>>
>> Thank you to all who discussed and provided ideas and code.
>>
>> Jacques
>>
> No problem to revert on trunk however I'm in favor to keep an init-gradle-wrapper to help first discovery without complex preparation and the script
> maintenance is really easy.
>
> So we can have on documentation advisable part with install gradle from official source and other part for unfamiliar people with quick start
> through init-gradle-wrapper.
>
> After I'm always disturbed to have a different process to initialize OFBiz between release branch and released package but I can live very well with
> it.
>
> Nicolas
>
>

This can even exist for Windows: +1

Jacques

Jacques Le Roux

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Administrator

Le 04/07/2019 à 12:06, Jacques Le Roux a écrit :

> Le 04/07/2019 à 11:07, Nicolas Malin a écrit :
>> On 03/07/2019 14:27, Jacques Le Roux wrote:
>>> Le 02/07/2019 à 09:45, Jacques Le Roux a écrit :
>>>> Le 02/07/2019 à 08:46, Jacopo Cappellato a écrit :
>>>>> On Tue, Jul 2, 2019 at 7:14 AM Jacques Le Roux <[hidden email]>
>>>>> wrote:
>>>>>
>>>>>> [...]
>>>>>
>>>>>> It's only a RM issue. It's when packaging that we are tying OFBiz code
>>>>>> with a Gradle version.
>>>>>>
>>>>>> It's only then that we need to modify the gradlew script, to call an
>>>>>> init-gradle-wrapper script if the wrapper is missing.
>>>>>>
>>>>>> What do you think folks? Notably you Jacopo, with your RM hat on?
>>>>>
>>>>> I think that the direction we are heading is to not include it in the
>>>>> releases and add instructions in the release's README file to tell the user
>>>>> how to download it.
>>>>> So we could keep the wrappers (if we like) in the trunk and/or release
>>>>> branches and remove them when we package/publish a new release.
>>>>>
>>>>> Jacopo
>>>>
>>>> Keeping the wrapper in branches is certainly easier for demos, Buildbot and working copies.
>>>>
>>>> For the releases, my proposition was to alleviate the charge on users and their customers.
>>>>
>>>> I'm not against letting them grab it. Maybe we could deliver an init-gradle-wrapper script version which would do the work for them
>>>>
>>>> But again we would need to maintain it and it's benign to grab the wrapper files and put them in OFBiz-root-dir/gradle/wrapper folder.
>>>>
>>>> Back to basic :)
>>>>
>>>> Jacques
>>>>
>>>>
>>> OK, if nobody is against, I'll revert all related changes in trunk (including Nicolas's and Mathieu's) and Buildbot in 3 days, and will close
>>> OFBIZ-10145.
>>>
>>> No maintenance will be needed, all will be handled during the RM phase as Jacopo initially suggested.
>>>
>>> We will need to keep only the "Manual setting" section (w/o its title) in the main README.adoc. And to clearly document the RM phase.
>>>
>>> Thank you to all who discussed and provided ideas and code.
>>>
>>> Jacques
>>>
>> No problem to revert on trunk however I'm in favor to keep an init-gradle-wrapper to help first discovery without complex preparation and the
>> script maintenance is really easy.
>>
>> So we can have on documentation advisable part with install gradle from official source and other part for unfamiliar people with quick start
>> through init-gradle-wrapper.
>>
>> After I'm always disturbed to have a different process to initialize OFBiz between release branch and released package but I can live very well
>> with it.
>>
>> Nicolas
>>
>>
> This can even exist for Windows: +1
>
> Jacques
>
>

Hi,

At revision: 1862745 I have removed all changes done for OFBIZ-10145 <https://issues.apache.org/jira/browse/OFBIZ-10145> so far. The wrapper stays in
branches and trunk. Now all should be handled during the Release Management phase.

I'll soon tackle the documentation changes...

Jacques

Swapnil M Mane

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Thanks so much, Jacques and Nicolas for your help in this, highly
appreciated.
Also, thank you, everyone involved in the efforts!

Best Regards,
Swapnil M Mane,
ofbiz.apache.org

On Tue, Jul 9, 2019 at 8:22 PM Jacques Le Roux <[hidden email]>
wrote:

> Le 04/07/2019 à 12:06, Jacques Le Roux a écrit :
> > Le 04/07/2019 à 11:07, Nicolas Malin a écrit :
> >> On 03/07/2019 14:27, Jacques Le Roux wrote:
> >>> Le 02/07/2019 à 09:45, Jacques Le Roux a écrit :
> >>>> Le 02/07/2019 à 08:46, Jacopo Cappellato a écrit :
> >>>>> On Tue, Jul 2, 2019 at 7:14 AM Jacques Le Roux <
> [hidden email]>
> >>>>> wrote:
> >>>>>
> >>>>>> [...]
> >>>>>
> >>>>>> It's only a RM issue. It's when packaging that we are tying OFBiz
> code
> >>>>>> with a Gradle version.
> >>>>>>
> >>>>>> It's only then that we need to modify the gradlew script, to call an
> >>>>>> init-gradle-wrapper script if the wrapper is missing.
> >>>>>>
> >>>>>> What do you think folks? Notably you Jacopo, with your RM hat on?
> >>>>>
> >>>>> I think that the direction we are heading is to not include it in the
> >>>>> releases and add instructions in the release's README file to tell
> the user
> >>>>> how to download it.
> >>>>> So we could keep the wrappers (if we like) in the trunk and/or
> release
> >>>>> branches and remove them when we package/publish a new release.
> >>>>>
> >>>>> Jacopo
> >>>>
> >>>> Keeping the wrapper in branches is certainly easier for demos,
> Buildbot and working copies.
> >>>>
> >>>> For the releases, my proposition was to alleviate the charge on users
> and their customers.
> >>>>
> >>>> I'm not against letting them grab it. Maybe we could deliver an
> init-gradle-wrapper script version which would do the work for them
> >>>>
> >>>> But again we would need to maintain it and it's benign to grab the
> wrapper files and put them in OFBiz-root-dir/gradle/wrapper folder.
> >>>>
> >>>> Back to basic :)
> >>>>
> >>>> Jacques
> >>>>
> >>>>
> >>> OK, if nobody is against, I'll revert all related changes in trunk
> (including Nicolas's and Mathieu's) and Buildbot in 3 days, and will close
> >>> OFBIZ-10145.
> >>>
> >>> No maintenance will be needed, all will be handled during the RM phase
> as Jacopo initially suggested.
> >>>
> >>> We will need to keep only the "Manual setting" section (w/o its title)
> in the main README.adoc. And to clearly document the RM phase.
> >>>
> >>> Thank you to all who discussed and provided ideas and code.
> >>>
> >>> Jacques
> >>>
> >> No problem to revert on trunk however I'm in favor to keep an
> init-gradle-wrapper to help first discovery without complex preparation and
> the
> >> script maintenance is really easy.
> >>
> >> So we can have on documentation advisable part with install gradle from
> official source and other part for unfamiliar people with quick start
> >> through init-gradle-wrapper.
> >>
> >> After I'm always disturbed to have a different process to initialize
> OFBiz between release branch and released package but I can live very well
> >> with it.
> >>
> >> Nicolas
> >>
> >>
> > This can even exist for Windows: +1
> >
> > Jacques
> >
> >
> Hi,
>
> At revision: 1862745 I have removed all changes done for OFBIZ-10145 <
> https://issues.apache.org/jira/browse/OFBIZ-10145> so far. The wrapper
> stays in
> branches and trunk. Now all should be handled during the Release
> Management phase.
>
> I'll soon tackle the documentation changes...
>
> Jacques
>
>

Jacques Le Roux

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Administrator

Thanks Swapnil, @All,

In Builbot config, I have reverted the commits related to grabbing Gradle Wrapper files from tools.
The Gradle Wrapper files will stay in branches and trunk, so not point getting them during builds.
For the same reason, I have also removed the copies in tools\Buildbot\Gradle\Wrapper.

As we know all we be handled during RM. I'll work on documentation soon.
I'll also provide an init-gradle-wrapper.ps1 script in OFBIZ-10145.
To be used as an alternative to Gradle Wrapper manual installation in new R16+ released packages.

Jacques

Le 10/07/2019 à 07:17, Swapnil M Mane a écrit :

> Thanks so much, Jacques and Nicolas for your help in this, highly
> appreciated.
> Also, thank you, everyone involved in the efforts!
>
>
> Best Regards,
> Swapnil M Mane,
> ofbiz.apache.org
>
>
>
> On Tue, Jul 9, 2019 at 8:22 PM Jacques Le Roux <[hidden email]>
> wrote:
>
>> Le 04/07/2019 à 12:06, Jacques Le Roux a écrit :
>>> Le 04/07/2019 à 11:07, Nicolas Malin a écrit :
>>>> On 03/07/2019 14:27, Jacques Le Roux wrote:
>>>>> Le 02/07/2019 à 09:45, Jacques Le Roux a écrit :
>>>>>> Le 02/07/2019 à 08:46, Jacopo Cappellato a écrit :
>>>>>>> On Tue, Jul 2, 2019 at 7:14 AM Jacques Le Roux <
>> [hidden email]>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> [...]
>>>>>>>> It's only a RM issue. It's when packaging that we are tying OFBiz
>> code
>>>>>>>> with a Gradle version.
>>>>>>>>
>>>>>>>> It's only then that we need to modify the gradlew script, to call an
>>>>>>>> init-gradle-wrapper script if the wrapper is missing.
>>>>>>>>
>>>>>>>> What do you think folks? Notably you Jacopo, with your RM hat on?
>>>>>>> I think that the direction we are heading is to not include it in the
>>>>>>> releases and add instructions in the release's README file to tell
>> the user
>>>>>>> how to download it.
>>>>>>> So we could keep the wrappers (if we like) in the trunk and/or
>> release
>>>>>>> branches and remove them when we package/publish a new release.
>>>>>>>
>>>>>>> Jacopo
>>>>>> Keeping the wrapper in branches is certainly easier for demos,
>> Buildbot and working copies.
>>>>>> For the releases, my proposition was to alleviate the charge on users
>> and their customers.
>>>>>> I'm not against letting them grab it. Maybe we could deliver an
>> init-gradle-wrapper script version which would do the work for them
>>>>>> But again we would need to maintain it and it's benign to grab the
>> wrapper files and put them in OFBiz-root-dir/gradle/wrapper folder.
>>>>>> Back to basic :)
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>> OK, if nobody is against, I'll revert all related changes in trunk
>> (including Nicolas's and Mathieu's) and Buildbot in 3 days, and will close
>>>>> OFBIZ-10145.
>>>>>
>>>>> No maintenance will be needed, all will be handled during the RM phase
>> as Jacopo initially suggested.
>>>>> We will need to keep only the "Manual setting" section (w/o its title)
>> in the main README.adoc. And to clearly document the RM phase.
>>>>> Thank you to all who discussed and provided ideas and code.
>>>>>
>>>>> Jacques
>>>>>
>>>> No problem to revert on trunk however I'm in favor to keep an
>> init-gradle-wrapper to help first discovery without complex preparation and
>> the
>>>> script maintenance is really easy.
>>>>
>>>> So we can have on documentation advisable part with install gradle from
>> official source and other part for unfamiliar people with quick start
>>>> through init-gradle-wrapper.
>>>>
>>>> After I'm always disturbed to have a different process to initialize
>> OFBiz between release branch and released package but I can live very well
>>>> with it.
>>>>
>>>> Nicolas
>>>>
>>>>
>>> This can even exist for Windows: +1
>>>
>>> Jacques
>>>
>>>
>> Hi,
>>
>> At revision: 1862745 I have removed all changes done for OFBIZ-10145 <
>> https://issues.apache.org/jira/browse/OFBIZ-10145> so far. The wrapper
>> stays in
>> branches and trunk. Now all should be handled during the Release
>> Management phase.
>>
>> I'll soon tackle the documentation changes...
>>
>> Jacques
>>
>>

Jacopo Cappellato-3

Re: [DISCUSSION] where download gradle-wrapper.jar ?

As regards the preparation for the new release from 16.11 please have a
look at my last comment (and patch) in OFBIZ-10145:

https://issues.apache.org/jira/browse/OFBIZ-10145?focusedCommentId=16895978&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16895978

This approach should be inline with what was suggested by Mathieu Lirzin
and seconded by others.

Regards,

Jacopo

On Wed, Jul 10, 2019 at 11:54 AM Jacques Le Roux <
[hidden email]> wrote:

> Thanks Swapnil, @All,
>
> In Builbot config, I have reverted the commits related to grabbing Gradle
> Wrapper files from tools.
> The Gradle Wrapper files will stay in branches and trunk, so not point
> getting them during builds.
> For the same reason, I have also removed the copies in
> tools\Buildbot\Gradle\Wrapper.
>
> As we know all we be handled during RM. I'll work on documentation soon.
> I'll also provide an init-gradle-wrapper.ps1 script in OFBIZ-10145.
> To be used as an alternative to Gradle Wrapper manual installation in new
> R16+ released packages.
>
> Jacques
>
> Le 10/07/2019 à 07:17, Swapnil M Mane a écrit :
> > Thanks so much, Jacques and Nicolas for your help in this, highly
> > appreciated.
> > Also, thank you, everyone involved in the efforts!
> >
> >
> > Best Regards,
> > Swapnil M Mane,
> > ofbiz.apache.org
> >
> >
> >
> > On Tue, Jul 9, 2019 at 8:22 PM Jacques Le Roux <
> [hidden email]>
> > wrote:
> >
> >> Le 04/07/2019 à 12:06, Jacques Le Roux a écrit :
> >>> Le 04/07/2019 à 11:07, Nicolas Malin a écrit :
> >>>> On 03/07/2019 14:27, Jacques Le Roux wrote:
> >>>>> Le 02/07/2019 à 09:45, Jacques Le Roux a écrit :
> >>>>>> Le 02/07/2019 à 08:46, Jacopo Cappellato a écrit :
> >>>>>>> On Tue, Jul 2, 2019 at 7:14 AM Jacques Le Roux <
> >> [hidden email]>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> [...]
> >>>>>>>> It's only a RM issue. It's when packaging that we are tying OFBiz
> >> code
> >>>>>>>> with a Gradle version.
> >>>>>>>>
> >>>>>>>> It's only then that we need to modify the gradlew script, to call
> an
> >>>>>>>> init-gradle-wrapper script if the wrapper is missing.
> >>>>>>>>
> >>>>>>>> What do you think folks? Notably you Jacopo, with your RM hat on?
> >>>>>>> I think that the direction we are heading is to not include it in
> the
> >>>>>>> releases and add instructions in the release's README file to tell
> >> the user
> >>>>>>> how to download it.
> >>>>>>> So we could keep the wrappers (if we like) in the trunk and/or
> >> release
> >>>>>>> branches and remove them when we package/publish a new release.
> >>>>>>>
> >>>>>>> Jacopo
> >>>>>> Keeping the wrapper in branches is certainly easier for demos,
> >> Buildbot and working copies.
> >>>>>> For the releases, my proposition was to alleviate the charge on
> users
> >> and their customers.
> >>>>>> I'm not against letting them grab it. Maybe we could deliver an
> >> init-gradle-wrapper script version which would do the work for them
> >>>>>> But again we would need to maintain it and it's benign to grab the
> >> wrapper files and put them in OFBiz-root-dir/gradle/wrapper folder.
> >>>>>> Back to basic :)
> >>>>>>
> >>>>>> Jacques
> >>>>>>
> >>>>>>
> >>>>> OK, if nobody is against, I'll revert all related changes in trunk
> >> (including Nicolas's and Mathieu's) and Buildbot in 3 days, and will
> close
> >>>>> OFBIZ-10145.
> >>>>>
> >>>>> No maintenance will be needed, all will be handled during the RM
> phase
> >> as Jacopo initially suggested.
> >>>>> We will need to keep only the "Manual setting" section (w/o its
> title)
> >> in the main README.adoc. And to clearly document the RM phase.
> >>>>> Thank you to all who discussed and provided ideas and code.
> >>>>>
> >>>>> Jacques
> >>>>>
> >>>> No problem to revert on trunk however I'm in favor to keep an
> >> init-gradle-wrapper to help first discovery without complex preparation
> and
> >> the
> >>>> script maintenance is really easy.
> >>>>
> >>>> So we can have on documentation advisable part with install gradle
> from
> >> official source and other part for unfamiliar people with quick start
> >>>> through init-gradle-wrapper.
> >>>>
> >>>> After I'm always disturbed to have a different process to initialize
> >> OFBiz between release branch and released package but I can live very
> well
> >>>> with it.
> >>>>
> >>>> Nicolas
> >>>>
> >>>>
> >>> This can even exist for Windows: +1
> >>>
> >>> Jacques
> >>>
> >>>
> >> Hi,
> >>
> >> At revision: 1862745 I have removed all changes done for OFBIZ-10145 <
> >> https://issues.apache.org/jira/browse/OFBIZ-10145> so far. The wrapper
> >> stays in
> >> branches and trunk. Now all should be handled during the Release
> >> Management phase.
> >>
> >> I'll soon tackle the documentation changes...
> >>
> >> Jacques
> >>
> >>
>

Jacques Le Roux

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Administrator

Hi Jacopo,

I put a suggestion to keep init-gradle-wrapper scripts in Jira.

It would need a simplification of init-gradle-wrapper.sh, to simply load the wrapper from the branch repo.

Jacques

Le 30/07/2019 à 11:59, Jacopo Cappellato a écrit :

> As regards the preparation for the new release from 16.11 please have a
> look at my last comment (and patch) in OFBIZ-10145:
>
> https://issues.apache.org/jira/browse/OFBIZ-10145?focusedCommentId=16895978&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16895978
>
> This approach should be inline with what was suggested by Mathieu Lirzin
> and seconded by others.
>
> Regards,
>
> Jacopo
>
>
>
> On Wed, Jul 10, 2019 at 11:54 AM Jacques Le Roux <
> [hidden email]> wrote:
>
>> Thanks Swapnil, @All,
>>
>> In Builbot config, I have reverted the commits related to grabbing Gradle
>> Wrapper files from tools.
>> The Gradle Wrapper files will stay in branches and trunk, so not point
>> getting them during builds.
>> For the same reason, I have also removed the copies in
>> tools\Buildbot\Gradle\Wrapper.
>>
>> As we know all we be handled during RM. I'll work on documentation soon.
>> I'll also provide an init-gradle-wrapper.ps1 script in OFBIZ-10145.
>> To be used as an alternative to Gradle Wrapper manual installation in new
>> R16+ released packages.
>>
>> Jacques
>>
>> Le 10/07/2019 à 07:17, Swapnil M Mane a écrit :
>>> Thanks so much, Jacques and Nicolas for your help in this, highly
>>> appreciated.
>>> Also, thank you, everyone involved in the efforts!
>>>
>>>
>>> Best Regards,
>>> Swapnil M Mane,
>>> ofbiz.apache.org
>>>
>>>
>>>
>>> On Tue, Jul 9, 2019 at 8:22 PM Jacques Le Roux <
>> [hidden email]>
>>> wrote:
>>>
>>>> Le 04/07/2019 à 12:06, Jacques Le Roux a écrit :
>>>>> Le 04/07/2019 à 11:07, Nicolas Malin a écrit :
>>>>>> On 03/07/2019 14:27, Jacques Le Roux wrote:
>>>>>>> Le 02/07/2019 à 09:45, Jacques Le Roux a écrit :
>>>>>>>> Le 02/07/2019 à 08:46, Jacopo Cappellato a écrit :
>>>>>>>>> On Tue, Jul 2, 2019 at 7:14 AM Jacques Le Roux <
>>>> [hidden email]>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> [...]
>>>>>>>>>> It's only a RM issue. It's when packaging that we are tying OFBiz
>>>> code
>>>>>>>>>> with a Gradle version.
>>>>>>>>>>
>>>>>>>>>> It's only then that we need to modify the gradlew script, to call
>> an
>>>>>>>>>> init-gradle-wrapper script if the wrapper is missing.
>>>>>>>>>>
>>>>>>>>>> What do you think folks? Notably you Jacopo, with your RM hat on?
>>>>>>>>> I think that the direction we are heading is to not include it in
>> the
>>>>>>>>> releases and add instructions in the release's README file to tell
>>>> the user
>>>>>>>>> how to download it.
>>>>>>>>> So we could keep the wrappers (if we like) in the trunk and/or
>>>> release
>>>>>>>>> branches and remove them when we package/publish a new release.
>>>>>>>>>
>>>>>>>>> Jacopo
>>>>>>>> Keeping the wrapper in branches is certainly easier for demos,
>>>> Buildbot and working copies.
>>>>>>>> For the releases, my proposition was to alleviate the charge on
>> users
>>>> and their customers.
>>>>>>>> I'm not against letting them grab it. Maybe we could deliver an
>>>> init-gradle-wrapper script version which would do the work for them
>>>>>>>> But again we would need to maintain it and it's benign to grab the
>>>> wrapper files and put them in OFBiz-root-dir/gradle/wrapper folder.
>>>>>>>> Back to basic :)
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>> OK, if nobody is against, I'll revert all related changes in trunk
>>>> (including Nicolas's and Mathieu's) and Buildbot in 3 days, and will
>> close
>>>>>>> OFBIZ-10145.
>>>>>>>
>>>>>>> No maintenance will be needed, all will be handled during the RM
>> phase
>>>> as Jacopo initially suggested.
>>>>>>> We will need to keep only the "Manual setting" section (w/o its
>> title)
>>>> in the main README.adoc. And to clearly document the RM phase.
>>>>>>> Thank you to all who discussed and provided ideas and code.
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>> No problem to revert on trunk however I'm in favor to keep an
>>>> init-gradle-wrapper to help first discovery without complex preparation
>> and
>>>> the
>>>>>> script maintenance is really easy.
>>>>>>
>>>>>> So we can have on documentation advisable part with install gradle
>> from
>>>> official source and other part for unfamiliar people with quick start
>>>>>> through init-gradle-wrapper.
>>>>>>
>>>>>> After I'm always disturbed to have a different process to initialize
>>>> OFBiz between release branch and released package but I can live very
>> well
>>>>>> with it.
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>>
>>>>> This can even exist for Windows: +1
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>> Hi,
>>>>
>>>> At revision: 1862745 I have removed all changes done for OFBIZ-10145 <
>>>> https://issues.apache.org/jira/browse/OFBIZ-10145> so far. The wrapper
>>>> stays in
>>>> branches and trunk. Now all should be handled during the Release
>>>> Management phase.
>>>>
>>>> I'll soon tackle the documentation changes...
>>>>
>>>> Jacques
>>>>
>>>>

Jacopo Cappellato-3

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Hi Jacques,
I saw your comment, thanks.

However, at least for the upcoming 16.11 release, my preference is to
minimize the changes/additions and stick to one solid workflow: install
JDK + install Gradle + run "gradle wrapper".
In this way we will avoid the concerns of using our branch repo for serving
files and we will buy some time to think and test these alternative
solutions.

Jacopo

On Tue, Jul 30, 2019 at 4:41 PM Jacques Le Roux <
[hidden email]> wrote:

> Hi Jacopo,
>
> I put a suggestion to keep init-gradle-wrapper scripts in Jira.
>
> It would need a simplification of init-gradle-wrapper.sh, to simply load
> the wrapper from the branch repo.
>
> Jacques
>
> Le 30/07/2019 à 11:59, Jacopo Cappellato a écrit :
> > As regards the preparation for the new release from 16.11 please have a
> > look at my last comment (and patch) in OFBIZ-10145:
> >
> >
> https://issues.apache.org/jira/browse/OFBIZ-10145?focusedCommentId=16895978&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16895978
> >
> > This approach should be inline with what was suggested by Mathieu Lirzin
> > and seconded by others.
> >
> > Regards,
> >
> > Jacopo
> >
> >
> >
> > On Wed, Jul 10, 2019 at 11:54 AM Jacques Le Roux <
> > [hidden email]> wrote:
> >
> >> Thanks Swapnil, @All,
> >>
> >> In Builbot config, I have reverted the commits related to grabbing
> Gradle
> >> Wrapper files from tools.
> >> The Gradle Wrapper files will stay in branches and trunk, so not point
> >> getting them during builds.
> >> For the same reason, I have also removed the copies in
> >> tools\Buildbot\Gradle\Wrapper.
> >>
> >> As we know all we be handled during RM. I'll work on documentation soon.
> >> I'll also provide an init-gradle-wrapper.ps1 script in OFBIZ-10145.
> >> To be used as an alternative to Gradle Wrapper manual installation in
> new
> >> R16+ released packages.
> >>
> >> Jacques
> >>
> >> Le 10/07/2019 à 07:17, Swapnil M Mane a écrit :
> >>> Thanks so much, Jacques and Nicolas for your help in this, highly
> >>> appreciated.
> >>> Also, thank you, everyone involved in the efforts!
> >>>
> >>>
> >>> Best Regards,
> >>> Swapnil M Mane,
> >>> ofbiz.apache.org
> >>>
> >>>
> >>>
> >>> On Tue, Jul 9, 2019 at 8:22 PM Jacques Le Roux <
> >> [hidden email]>
> >>> wrote:
> >>>
> >>>> Le 04/07/2019 à 12:06, Jacques Le Roux a écrit :
> >>>>> Le 04/07/2019 à 11:07, Nicolas Malin a écrit :
> >>>>>> On 03/07/2019 14:27, Jacques Le Roux wrote:
> >>>>>>> Le 02/07/2019 à 09:45, Jacques Le Roux a écrit :
> >>>>>>>> Le 02/07/2019 à 08:46, Jacopo Cappellato a écrit :
> >>>>>>>>> On Tue, Jul 2, 2019 at 7:14 AM Jacques Le Roux <
> >>>> [hidden email]>
> >>>>>>>>> wrote:
> >>>>>>>>>
> >>>>>>>>>> [...]
> >>>>>>>>>> It's only a RM issue. It's when packaging that we are tying
> OFBiz
> >>>> code
> >>>>>>>>>> with a Gradle version.
> >>>>>>>>>>
> >>>>>>>>>> It's only then that we need to modify the gradlew script, to
> call
> >> an
> >>>>>>>>>> init-gradle-wrapper script if the wrapper is missing.
> >>>>>>>>>>
> >>>>>>>>>> What do you think folks? Notably you Jacopo, with your RM hat
> on?
> >>>>>>>>> I think that the direction we are heading is to not include it in
> >> the
> >>>>>>>>> releases and add instructions in the release's README file to
> tell
> >>>> the user
> >>>>>>>>> how to download it.
> >>>>>>>>> So we could keep the wrappers (if we like) in the trunk and/or
> >>>> release
> >>>>>>>>> branches and remove them when we package/publish a new release.
> >>>>>>>>>
> >>>>>>>>> Jacopo
> >>>>>>>> Keeping the wrapper in branches is certainly easier for demos,
> >>>> Buildbot and working copies.
> >>>>>>>> For the releases, my proposition was to alleviate the charge on
> >> users
> >>>> and their customers.
> >>>>>>>> I'm not against letting them grab it. Maybe we could deliver an
> >>>> init-gradle-wrapper script version which would do the work for them
> >>>>>>>> But again we would need to maintain it and it's benign to grab the
> >>>> wrapper files and put them in OFBiz-root-dir/gradle/wrapper folder.
> >>>>>>>> Back to basic :)
> >>>>>>>>
> >>>>>>>> Jacques
> >>>>>>>>
> >>>>>>>>
> >>>>>>> OK, if nobody is against, I'll revert all related changes in trunk
> >>>> (including Nicolas's and Mathieu's) and Buildbot in 3 days, and will
> >> close
> >>>>>>> OFBIZ-10145.
> >>>>>>>
> >>>>>>> No maintenance will be needed, all will be handled during the RM
> >> phase
> >>>> as Jacopo initially suggested.
> >>>>>>> We will need to keep only the "Manual setting" section (w/o its
> >> title)
> >>>> in the main README.adoc. And to clearly document the RM phase.
> >>>>>>> Thank you to all who discussed and provided ideas and code.
> >>>>>>>
> >>>>>>> Jacques
> >>>>>>>
> >>>>>> No problem to revert on trunk however I'm in favor to keep an
> >>>> init-gradle-wrapper to help first discovery without complex
> preparation
> >> and
> >>>> the
> >>>>>> script maintenance is really easy.
> >>>>>>
> >>>>>> So we can have on documentation advisable part with install gradle
> >> from
> >>>> official source and other part for unfamiliar people with quick start
> >>>>>> through init-gradle-wrapper.
> >>>>>>
> >>>>>> After I'm always disturbed to have a different process to initialize
> >>>> OFBiz between release branch and released package but I can live very
> >> well
> >>>>>> with it.
> >>>>>>
> >>>>>> Nicolas
> >>>>>>
> >>>>>>
> >>>>> This can even exist for Windows: +1
> >>>>>
> >>>>> Jacques
> >>>>>
> >>>>>
> >>>> Hi,
> >>>>
> >>>> At revision: 1862745 I have removed all changes done for OFBIZ-10145 <
> >>>> https://issues.apache.org/jira/browse/OFBIZ-10145> so far. The
> wrapper
> >>>> stays in
> >>>> branches and trunk. Now all should be handled during the Release
> >>>> Management phase.
> >>>>
> >>>> I'll soon tackle the documentation changes...
> >>>>
> >>>> Jacques
> >>>>
> >>>>
>

Nicolas Malin-2

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Hello,

I think also it's a good compromise. At the beginning I would implement
the alternative from 17.12, so you confirm my feeling.

I see the following step :

  * publish 16.11.06 without gradle-wrapper.jar and the documentation
updated to initialize it
  * prepare the release 17.12, 18.12 and trunk with a script to download
gradle-wrapper.jar related
  * publish 17.12.01 without gradle-wrapper.jar, the documentation
updated to initialize it and the helper script.

I will check your proposition for le 16.11 and if my stepping is ok your
you I can works on release branch to finalise this long task :)

Nicolas

On 7/31/19 12:29 PM, Jacopo Cappellato wrote:

> Hi Jacques,
> I saw your comment, thanks.
>
> However, at least for the upcoming 16.11 release, my preference is to
> minimize the changes/additions and stick to one solid workflow: install
> JDK + install Gradle + run "gradle wrapper".
> In this way we will avoid the concerns of using our branch repo for serving
> files and we will buy some time to think and test these alternative
> solutions.
>
> Jacopo
>
>
> On Tue, Jul 30, 2019 at 4:41 PM Jacques Le Roux <
> [hidden email]> wrote:
>
>> Hi Jacopo,
>>
>> I put a suggestion to keep init-gradle-wrapper scripts in Jira.
>>
>> It would need a simplification of init-gradle-wrapper.sh, to simply load
>> the wrapper from the branch repo.
>>
>> Jacques
>>
>> Le 30/07/2019 à 11:59, Jacopo Cappellato a écrit :
>>> As regards the preparation for the new release from 16.11 please have a
>>> look at my last comment (and patch) in OFBIZ-10145:
>>>
>>>
>> https://issues.apache.org/jira/browse/OFBIZ-10145?focusedCommentId=16895978&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16895978
>>> This approach should be inline with what was suggested by Mathieu Lirzin
>>> and seconded by others.
>>>
>>> Regards,
>>>
>>> Jacopo
>>>
>>>
>>>
>>> On Wed, Jul 10, 2019 at 11:54 AM Jacques Le Roux <
>>> [hidden email]> wrote:
>>>
>>>> Thanks Swapnil, @All,
>>>>
>>>> In Builbot config, I have reverted the commits related to grabbing
>> Gradle
>>>> Wrapper files from tools.
>>>> The Gradle Wrapper files will stay in branches and trunk, so not point
>>>> getting them during builds.
>>>> For the same reason, I have also removed the copies in
>>>> tools\Buildbot\Gradle\Wrapper.
>>>>
>>>> As we know all we be handled during RM. I'll work on documentation soon.
>>>> I'll also provide an init-gradle-wrapper.ps1 script in OFBIZ-10145.
>>>> To be used as an alternative to Gradle Wrapper manual installation in
>> new
>>>> R16+ released packages.
>>>>
>>>> Jacques
>>>>
>>>> Le 10/07/2019 à 07:17, Swapnil M Mane a écrit :
>>>>> Thanks so much, Jacques and Nicolas for your help in this, highly
>>>>> appreciated.
>>>>> Also, thank you, everyone involved in the efforts!
>>>>>
>>>>>
>>>>> Best Regards,
>>>>> Swapnil M Mane,
>>>>> ofbiz.apache.org
>>>>>
>>>>>
>>>>>
>>>>> On Tue, Jul 9, 2019 at 8:22 PM Jacques Le Roux <
>>>> [hidden email]>
>>>>> wrote:
>>>>>
>>>>>> Le 04/07/2019 à 12:06, Jacques Le Roux a écrit :
>>>>>>> Le 04/07/2019 à 11:07, Nicolas Malin a écrit :
>>>>>>>> On 03/07/2019 14:27, Jacques Le Roux wrote:
>>>>>>>>> Le 02/07/2019 à 09:45, Jacques Le Roux a écrit :
>>>>>>>>>> Le 02/07/2019 à 08:46, Jacopo Cappellato a écrit :
>>>>>>>>>>> On Tue, Jul 2, 2019 at 7:14 AM Jacques Le Roux <
>>>>>> [hidden email]>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> [...]
>>>>>>>>>>>> It's only a RM issue. It's when packaging that we are tying
>> OFBiz
>>>>>> code
>>>>>>>>>>>> with a Gradle version.
>>>>>>>>>>>>
>>>>>>>>>>>> It's only then that we need to modify the gradlew script, to
>> call
>>>> an
>>>>>>>>>>>> init-gradle-wrapper script if the wrapper is missing.
>>>>>>>>>>>>
>>>>>>>>>>>> What do you think folks? Notably you Jacopo, with your RM hat
>> on?
>>>>>>>>>>> I think that the direction we are heading is to not include it in
>>>> the
>>>>>>>>>>> releases and add instructions in the release's README file to
>> tell
>>>>>> the user
>>>>>>>>>>> how to download it.
>>>>>>>>>>> So we could keep the wrappers (if we like) in the trunk and/or
>>>>>> release
>>>>>>>>>>> branches and remove them when we package/publish a new release.
>>>>>>>>>>>
>>>>>>>>>>> Jacopo
>>>>>>>>>> Keeping the wrapper in branches is certainly easier for demos,
>>>>>> Buildbot and working copies.
>>>>>>>>>> For the releases, my proposition was to alleviate the charge on
>>>> users
>>>>>> and their customers.
>>>>>>>>>> I'm not against letting them grab it. Maybe we could deliver an
>>>>>> init-gradle-wrapper script version which would do the work for them
>>>>>>>>>> But again we would need to maintain it and it's benign to grab the
>>>>>> wrapper files and put them in OFBiz-root-dir/gradle/wrapper folder.
>>>>>>>>>> Back to basic :)
>>>>>>>>>>
>>>>>>>>>> Jacques
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> OK, if nobody is against, I'll revert all related changes in trunk
>>>>>> (including Nicolas's and Mathieu's) and Buildbot in 3 days, and will
>>>> close
>>>>>>>>> OFBIZ-10145.
>>>>>>>>>
>>>>>>>>> No maintenance will be needed, all will be handled during the RM
>>>> phase
>>>>>> as Jacopo initially suggested.
>>>>>>>>> We will need to keep only the "Manual setting" section (w/o its
>>>> title)
>>>>>> in the main README.adoc. And to clearly document the RM phase.
>>>>>>>>> Thank you to all who discussed and provided ideas and code.
>>>>>>>>>
>>>>>>>>> Jacques
>>>>>>>>>
>>>>>>>> No problem to revert on trunk however I'm in favor to keep an
>>>>>> init-gradle-wrapper to help first discovery without complex
>> preparation
>>>> and
>>>>>> the
>>>>>>>> script maintenance is really easy.
>>>>>>>>
>>>>>>>> So we can have on documentation advisable part with install gradle
>>>> from
>>>>>> official source and other part for unfamiliar people with quick start
>>>>>>>> through init-gradle-wrapper.
>>>>>>>>
>>>>>>>> After I'm always disturbed to have a different process to initialize
>>>>>> OFBiz between release branch and released package but I can live very
>>>> well
>>>>>>>> with it.
>>>>>>>>
>>>>>>>> Nicolas
>>>>>>>>
>>>>>>>>
>>>>>>> This can even exist for Windows: +1
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> At revision: 1862745 I have removed all changes done for OFBIZ-10145 <
>>>>>> https://issues.apache.org/jira/browse/OFBIZ-10145> so far. The
>> wrapper
>>>>>> stays in
>>>>>> branches and trunk. Now all should be handled during the Release
>>>>>> Management phase.
>>>>>>
>>>>>> I'll soon tackle the documentation changes...
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>

Jacques Le Roux

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Administrator

In reply to this post by Jacopo Cappellato-3

Hi Jacopo,

I still don't see what the concerns could be.

From the performance perspective: the (55 Ko!) download would be done only once by instance installed; and when only used instead of the manual procedure.
From the legal perspective, I don't see any issues.

But I'm not much opinionated for R16 either. Let's do it this way then.

Jacques

Le 31/07/2019 à 12:29, Jacopo Cappellato a écrit :

Jacopo Cappellato-3

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Hi Jacques,

please see inline:

On Wed, Jul 31, 2019 at 6:52 PM Jacques Le Roux <
[hidden email]> wrote:

> Hi Jacopo,
>
> I still don't see what the concerns could be.
>
> From the performance perspective: the (55 Ko!) download would be done
> only once by instance installed; and when only used instead of the manual
> procedure.
>

I am quoting from [*]:

"PLEASE NOTE The SVN directories under https://dist.apache.org/repos/dist/
are not to be used to link to releases on download pages or elsewhere.
Download pages must use the ASF mirror system [...]"

[*] http://www.apache.org/dev/release-publishing.html#distribution

> From the legal perspective, I don't see any issues.
>

For the legal perspective, considering that we would distribute from svn
files that are not part of a release, this may be relevant [**]:

"Unreleased materials, in original or derived form... [...]:

- MUST NOT be distributed through channels which encourage use by anyone
outside the project development community.
- MUST NOT be advertised to anyone outside of the project development
community.
- MAY be distributed to consenting members of a development community."

[**] http://www.apache.org/dev/release-distribution#unreleased

Jacopo

> But I'm not much opinionated for R16 either. Let's do it this way then.
>
> Jacques
>

Jacques Le Roux

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Administrator

Hi Jacopo,

Inline too

Le 01/08/2019 à 07:34, Jacopo Cappellato a écrit :

The download would be from OFBiz repo not from https://dist.apache.org/repos/dist/.

This said I get the idea, and it gave me another: as a priority we should download the wrapper from Gradle "repo", and if it's not longer there, use
OFBiz repo. Later would be very rare.

I'll add that in OFBIZ-10145, in order to provide new init-gradle-wrapper scripts for hopefully next releases...

>
>
>> From the legal perspective, I don't see any issues.
>>
> For the legal perspective, considering that we would distribute from svn
> files that are not part of a release, this may be relevant [**]:
>
> "Unreleased materials, in original or derived form... [...]:
>
> - MUST NOT be distributed through channels which encourage use by anyone
> outside the project development community.

I also read there:

<<Release Policy specifies that binary packages provided by third parties which meet certain criteria may be distributed alongside official source
packages. Such packages are sometimes referred to as "convenience binaries" to distinguish them from other binary packages.>>

It gave me another idea. I think we (the OFBiz community) could agree that the Gradle wrapper files are "convenience binaries provided by third
parties which meet certain criteria". Then we can discuss (or ask legal) if "distributed alongside official source packages" includes downloading them
later. That would avoid OFBiz repo in the very rare case where the wrapper would not be available in Gradle "repo". But it a bit more complicated and
not sure it's worth following this way

> - MUST NOT be advertised to anyone outside of the project development
> community.

I don't think we would advertise it

> - MAY be distributed to consenting members of a development community."

Again the idea of putting the Gradle wrapper files surges here. Again seems convoluted. I believe Gradle will not soon remove from their "repo" the
wrapper versions which are used by R17 and R18.

Anyway it's not mine to decide but the community

>
> [**] http://www.apache.org/dev/release-distribution#unreleased
>
> Jacopo
>
>
>> But I'm not much opinionated for R16 either. Let's do it this way then.
>>
>> Jacques
>>

I must add here that I'm not doing that for myself but to ease UX. That's why it's not something I'm much opinionated about, after all it's only sugar
for users...

Nevertheless, we could also have the init scripts in the branches (to be removed when releasing if we don't agree with my proposition) for devs, like
at least Nicolas and I, who want an easiest experience when installing for customers...

I can't think at anything else :)

Jacques

Nicolas Malin-2

Re: [DISCUSSION] where download gradle-wrapper.jar ?

In reply to this post by Jacopo Cappellato-3

Thanks Jacopo for spot these rules.

Currently with the script helper, I used the github location [1] to
download the wrapper and if failed backup used own svn.

If use the svn as sparse is a problem I can have different solution :

  * No use backup, if github gradle wrapper isn't available, they can
use manual process
  * Load gradle wrapper on own dist as backup and before ask the board
for this solution
  * Load the wrapper on bintray [2], because we download after all jar
from here

if you have a felling about this, it will be nice :)

[1] https://github.com/gradle/gradle/tree/v5.0.0/gradle/wrapper
[2]
https://bintray.com/bintray/jcenter/org.gradle%3Agradle-wrapper#files/org/gradle/gradle-wrapper/

Nicolas

On 8/1/19 7:34 AM, Jacopo Cappellato wrote:

> Hi Jacques,
>
> please see inline:
>
> On Wed, Jul 31, 2019 at 6:52 PM Jacques Le Roux <
> [hidden email]> wrote:
>
>> Hi Jacopo,
>>
>> I still don't see what the concerns could be.
>>
>> From the performance perspective: the (55 Ko!) download would be done
>> only once by instance installed; and when only used instead of the manual
>> procedure.
>>
> I am quoting from [*]:
>
> "PLEASE NOTE The SVN directories under https://dist.apache.org/repos/dist/
> are not to be used to link to releases on download pages or elsewhere.
> Download pages must use the ASF mirror system [...]"
>
> [*] http://www.apache.org/dev/release-publishing.html#distribution
>
>
>> From the legal perspective, I don't see any issues.
>>
> For the legal perspective, considering that we would distribute from svn
> files that are not part of a release, this may be relevant [**]:
>
> "Unreleased materials, in original or derived form... [...]:
>
> - MUST NOT be distributed through channels which encourage use by anyone
> outside the project development community.
> - MUST NOT be advertised to anyone outside of the project development
> community.
> - MAY be distributed to consenting members of a development community."
>
> [**] http://www.apache.org/dev/release-distribution#unreleased
>
> Jacopo
>
>
>> But I'm not much opinionated for R16 either. Let's do it this way then.
>>
>> Jacques
>>

Nicolas Malin-2

Re: [DISCUSSION] where download gradle-wrapper.jar ?

In reply to this post by Jacques Le Roux

Jacques, in line

On 8/1/19 1:08 PM, Jacques Le Roux wrote:

> I also read there:
>
> <<Release Policy specifies that binary packages provided by third
> parties which meet certain criteria may be distributed alongside
> official source
> packages. Such packages are sometimes referred to as "convenience
> binaries" to distinguish them from other binary packages.>>
>
> It gave me another idea. I think we (the OFBiz community) could agree
> that the Gradle wrapper files are "convenience binaries provided by
> third parties which meet certain criteria". Then we can discuss (or
> ask legal) if "distributed alongside official source packages"
> includes downloading them later. That would avoid OFBiz repo in the
> very rare case where the wrapper would not be available in Gradle
> "repo". But it a bit more complicated and not sure it's worth
> following this way

I write my previous message before this your proposition :) , I agree !

we (I) can ask the the board :

"[1] All official releases MUST be uploaded to the official distribution
channel, |www.apache.org/dist|.

Content suitable for the official distribution channel includes:
* Official releases
* "Convenience binaries"
* Cryptographic signatures and checksums
* The KEYS file
* README, CHANGES and similar documents describing distributed content

If an Apache PMC wishes to publish additional materials through the
official distribution channel and there is any question about the
suitability of said materials, the PMC MUST consult with the Board.

"

If you are on case "Convenience binaries", we can share through dist, I
ask the board to confirm that with are on the way, woulfd be a confidence

Nicolas

[1] http://www.apache.org/dev/release-distribution

Jacques Le Roux

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Administrator

In reply to this post by Nicolas Malin-2

Hi Nicolas,

I think your idea of using Bintray is the best ! Simple, no question to ask to anybody.-

This also answers to the message you specifically sent to me :)

Jacques

Le 05/08/2019 à 10:03, Nicolas Malin a écrit :

> Thanks Jacopo for spot these rules.
>
> Currently with the script helper, I used the github location [1] to download the wrapper and if failed backup used own svn.
>
> If use the svn as sparse is a problem I can have different solution :
>
> * No use backup, if github gradle wrapper isn't available, they can use manual process
> * Load gradle wrapper on own dist as backup and before ask the board for this solution
> * Load the wrapper on bintray [2], because we download after all jar from here
>
> if you have a felling about this, it will be nice :)
>
> [1] https://github.com/gradle/gradle/tree/v5.0.0/gradle/wrapper
> [2] https://bintray.com/bintray/jcenter/org.gradle%3Agradle-wrapper#files/org/gradle/gradle-wrapper/
>
> Nicolas
>
> On 8/1/19 7:34 AM, Jacopo Cappellato wrote:
>> Hi Jacques,
>>
>> please see inline:
>>
>> On Wed, Jul 31, 2019 at 6:52 PM Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>> Hi Jacopo,
>>>
>>> I still don't see what the concerns could be.
>>>
>>> From the performance perspective: the (55 Ko!) download would be done
>>> only once by instance installed; and when only used instead of the manual
>>> procedure.
>>>
>> I am quoting from [*]:
>>
>> "PLEASE NOTE The SVN directories under https://dist.apache.org/repos/dist/
>> are not to be used to link to releases on download pages or elsewhere.
>> Download pages must use the ASF mirror system [...]"
>>
>> [*] http://www.apache.org/dev/release-publishing.html#distribution
>>
>>
>>> From the legal perspective, I don't see any issues.
>>>
>> For the legal perspective, considering that we would distribute from svn
>> files that are not part of a release, this may be relevant [**]:
>>
>> "Unreleased materials, in original or derived form... [...]:
>>
>>     - MUST NOT be distributed through channels which encourage use by anyone
>>     outside the project development community.
>>     - MUST NOT be advertised to anyone outside of the project development
>>     community.
>>     - MAY be distributed to consenting members of a development community."
>>
>> [**] http://www.apache.org/dev/release-distribution#unreleased
>>
>> Jacopo
>>
>>
>>> But I'm not much opinionated for R16 either. Let's do it this way then.
>>>
>>> Jacques
>>>
>

Jacques Le Roux

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Administrator

And to be clear: we don't need to muck around testing if a version is not on Gradle Github.

We can directly take it from Bintray, et voilà :) Can't be simpler!

Le 05/08/2019 à 12:03, Jacques Le Roux a écrit :

> Hi Nicolas,
>
> I think your idea of using Bintray is the best ! Simple, no question to ask to anybody.-
>
> This also answers to the message you specifically sent to me :)
>
> Jacques
>
> Le 05/08/2019 à 10:03, Nicolas Malin a écrit :
>> Thanks Jacopo for spot these rules.
>>
>> Currently with the script helper, I used the github location [1] to download the wrapper and if failed backup used own svn.
>>
>> If use the svn as sparse is a problem I can have different solution :
>>
>> * No use backup, if github gradle wrapper isn't available, they can use manual process
>> * Load gradle wrapper on own dist as backup and before ask the board for this solution
>> * Load the wrapper on bintray [2], because we download after all jar from here
>>
>> if you have a felling about this, it will be nice :)
>>
>> [1] https://github.com/gradle/gradle/tree/v5.0.0/gradle/wrapper
>> [2] https://bintray.com/bintray/jcenter/org.gradle%3Agradle-wrapper#files/org/gradle/gradle-wrapper/
>>
>> Nicolas
>>
>> On 8/1/19 7:34 AM, Jacopo Cappellato wrote:
>>> Hi Jacques,
>>>
>>> please see inline:
>>>
>>> On Wed, Jul 31, 2019 at 6:52 PM Jacques Le Roux <
>>> [hidden email]> wrote:
>>>
>>>> Hi Jacopo,
>>>>
>>>> I still don't see what the concerns could be.
>>>>
>>>> From the performance perspective: the (55 Ko!) download would be done
>>>> only once by instance installed; and when only used instead of the manual
>>>> procedure.
>>>>
>>> I am quoting from [*]:
>>>
>>> "PLEASE NOTE The SVN directories under https://dist.apache.org/repos/dist/
>>> are not to be used to link to releases on download pages or elsewhere.
>>> Download pages must use the ASF mirror system [...]"
>>>
>>> [*] http://www.apache.org/dev/release-publishing.html#distribution
>>>
>>>
>>>> From the legal perspective, I don't see any issues.
>>>>
>>> For the legal perspective, considering that we would distribute from svn
>>> files that are not part of a release, this may be relevant [**]:
>>>
>>> "Unreleased materials, in original or derived form... [...]:
>>>
>>>     - MUST NOT be distributed through channels which encourage use by anyone
>>>     outside the project development community.
>>>     - MUST NOT be advertised to anyone outside of the project development
>>>     community.
>>>     - MAY be distributed to consenting members of a development community."
>>>
>>> [**] http://www.apache.org/dev/release-distribution#unreleased
>>>
>>> Jacopo
>>>
>>>
>>>> But I'm not much opinionated for R16 either. Let's do it this way then.
>>>>
>>>> Jacques
>>>>
>>
>

Jacopo Cappellato-3

Re: [DISCUSSION] where download gradle-wrapper.jar ?

On Mon, Aug 5, 2019 at 7:08 PM Jacques Le Roux <[hidden email]>
wrote:

> And to be clear: we don't need to muck around testing if a version is not
> on Gradle Github.
>
> We can directly take it from Bintray, et voilà :) Can't be simpler!

I agree that Bintray seems a good idea: my only concern is about the
license of the binary file; are we allowed to create one and license it
with an compatible license?

Jacopo

Jacques Le Roux

Re: [DISCUSSION] where download gradle-wrapper.jar ?

Administrator

Le 06/08/2019 à 11:40, Jacopo Cappellato a écrit :

> On Mon, Aug 5, 2019 at 7:08 PM Jacques Le Roux <[hidden email]>
> wrote:
>
>> And to be clear: we don't need to muck around testing if a version is not
>> on Gradle Github.
>>
>> We can directly take it from Bintray, et voilà :) Can't be simpler!
>
> I agree that Bintray seems a good idea: my only concern is about the
> license of the binary file; are we allowed to create one and license it
> with an compatible license?
>
> Jacopo

I'm not sure about the issue you think about. If I refer at https://github.com/gradle/gradle/issues/2852 there should be no issues. It's plain ASL2
licensed like all the rest of Gradle, isn'it?

The users will possibly download it after they downloaded the package.

Do I miss something?

Jacques