Demo Trunk Break

[Scott Gray-3]

That's the problem though, this domain isn't available for that purpose
either.

You're also using infra volunteer time for feature development rather than
project support.

Regards
Scott

On 16/03/2018 7:29 PM, "Jacques Le Roux" <[hidden email]>
wrote:

> I'm sorry, this is a temporary poor man solution. I have no other domain
> available.
>
> Jacques
>
>
> Le 16/03/2018 à 03:08, Scott Gray a écrit :
>
>> I guess what Michael is getting at, is that the demo server is for demos,
>> it's not intended for use as a development sandbox.
>>
>> As far as I can tell you don't *need* to be using the demo servers for
>> this, it's just convenient for you.  But the problem is, if you're
>> modifying the code on the demos and someone reports a problem, the rest of
>> us will go looking for a problem in the branches that doesn't exist.
>>
>> Long story short, probably not an appropriate use of the demo instances.
>>
>> Regards
>> Scott
>>
>> On 16 March 2018 at 08:34, Jacques Le Roux <[hidden email]>
>> wrote:
>>
>> Before Jacopo asked to revert my work on OFBIZ-9833 I continued to work on
>>> a replacing solution.
>>>
>>> This other solution still uses the same (slightly modified)
>>> externalServerLoginCheck preprocessor.
>>> FYI this solution is still based on AutoUserLogin cookies, and uses now
>>> Ajax and CORS, instead of  ContextFilter.
>>>
>>> So to test that on a server I need a small modification on the current
>>> code:
>>>
>>> Index: framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>> ol/ExternalLoginKeysManager.java
>>> ===================================================================
>>> --- framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>> ol/ExternalLoginKeysManager.java (revision 1826773)
>>> +++ framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>> ol/ExternalLoginKeysManager.java (working copy)
>>> @@ -182,18 +182,15 @@
>>>           Delegator delegator = (Delegator)
>>> request.getAttribute("delegato
>>> r");
>>>           HttpSession session = request.getSession();
>>>
>>> -        // The target server does not allow external login by default
>>> -        boolean useExternalServer = EntityUtilProperties.getProper
>>> tyAsBoolean("security",
>>> "use-external-server", false);
>>> -        String sourceWebappName = request.getParameter(SOURCE_SE
>>> RVER_WEBAPP_NAME);
>>> -        if (!useExternalServer || sourceWebappName == null) return
>>> "success"; // Nothing to do here
>>> -
>>>           try {
>>>               String userLoginId = null;
>>>               String authorizationHeader = request.getHeader("Authorizati
>>> on");
>>>               if (authorizationHeader != null) {
>>>                   Claims claims = returnsClaims(authorizationHeader);
>>>                   userLoginId = getSourceUserLoginId(claims );
>>> -                boolean jwtOK = checkJwt(authorizationHeader,
>>> userLoginId, getTargetServerUrl(request), UtilHttp.getApplicationName(re
>>> quest));
>>> +                boolean jwtOK = checkJwt(authorizationHeader,
>>> userLoginId, "","");
>>>                   if (!jwtOK) {
>>>                       // Something unexpected happened here
>>>                       Debug.logWarning("*** There was a problem with the
>>> JWT token, not signin in the user login " + userLoginId, module);
>>>
>>> I did this modification on the trunk demo. I have no other solution to
>>> test my work.
>>>
>>> Also I had to request the installation of HTTPS headers handling by
>>> infra:
>>> https://issues.apache.org/jira/browse/INFRA-16189
>>>
>>> Jacques
>>>
>>>
>>>
>>> Le 15/03/2018 à 17:37, Michael Brohl a écrit :
>>>
>>> I still do not understand why you had to change the demo instance for
>>>> your developments. What was this change?
>>>>
>>>> Michael
>>>>
>>>>
>>>> Am 15.03.18 um 14:46 schrieb Jacques Le Roux:
>>>>
>>>> Because for testing changes for OFBIZ-9833 I had to make a slight change
>>>>> on the trunk demo instance and needed to restart but
>>>>>
>>>>> ./gradlew --no-daemon "ofbiz --shutdown"
>>>>>
>>>>> Does not always behaves well, at least on demos VM where there is 3
>>>>> instances
>>>>>
>>>>> So you get unstable situation and have to use "kill -9".
>>>>>
>>>>> Anyway some data were not well loaded. A loadAll fixed it.
>>>>>
>>>>> HTH
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 15/03/2018 à 13:56, Michael Brohl a écrit :
>>>>>
>>>>> Of course it should read: "I try to understand why trunk demo was
>>>>>> broken while the trunk codebase seems to have no issues."
>>>>>>
>>>>>> Michael
>>>>>>
>>>>>>
>>>>>> Am 15.03.18 um 13:51 schrieb Michael Brohl:
>>>>>>
>>>>>> To be more clear: I try to understand why trunk demo was broken while
>>>>>>> the trunk demo seems to have no issues.
>>>>>>>
>>>>>>> Michael
>>>>>>>
>>>>>>>
>>>>>>> Am 15.03.18 um 13:36 schrieb Jacques Le Roux:
>>>>>>>
>>>>>>> Ho, it would be convoluted, please wait, WIP...
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 15/03/2018 à 12:37, Michael Brohl a écrit :
>>>>>>>>
>>>>>>>> Jacques did changes he already reverted in the mantime, see his post
>>>>>>>>> this morning.
>>>>>>>>>
>>>>>>>>> Jacques, can you please explain what happened?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Am 15.03.18 um 12:24 schrieb Taher Alkhateeb:
>>>>>>>>>
>>>>>>>>> Hi Rishi, I'm not getting any errors in the demo on my side? Could
>>>>>>>>>> it
>>>>>>>>>> be a web browser cache thing? I always fall in that trap myself.
>>>>>>>>>>
>>>>>>>>>> On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki <
>>>>>>>>>> [hidden email]> wrote:
>>>>>>>>>>
>>>>>>>>>> It seems something specific with deployment/data at demo instance,
>>>>>>>>>>> locally
>>>>>>>>>>> It is working. No issue with latest trunk fresh data.
>>>>>>>>>>>
>>>>>>>>>>> Best,
>>>>>>>>>>>
>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki <
>>>>>>>>>>> [hidden email]>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Devs,
>>>>>>>>>>>
>>>>>>>>>>>> On browsing - https://demo-trunk.ofbiz.apach
>>>>>>>>>>>> e.org/webtools/control/
>>>>>>>>>>>> FindGeneric?entityName=Party
>>>>>>>>>>>>
>>>>>>>>>>>> Received following exception, Any one facing the similar issue
>>>>>>>>>>>> with demo
>>>>>>>>>>>> please share. I'm looking into it and get back if find the root
>>>>>>>>>>>> cause for
>>>>>>>>>>>> the same.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks!
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Here is the error received on UI
>>>>>>>>>>>>
>>>>>>>>>>>> ========================================================
>>>>>>>>>>>> ERROR rendering error page [/error/error.jsp], but here is the
>>>>>>>>>>>> error text:
>>>>>>>>>>>> java.lang.IllegalArgumentException: Error running script at
>>>>>>>>>>>> location
>>>>>>>>>>>> [component://webtools/groovyScripts/entity/FindGeneric.groovy]:
>>>>>>>>>>>> org.codehaus.groovy.control.MultipleCompilationErrorsException:
>>>>>>>>>>>> startup
>>>>>>>>>>>> failed: General error during class generation:
>>>>>>>>>>>> java.lang.NoClassDefFoundError:
>>>>>>>>>>>> Unable to load class org.apache.ofbiz.widget.render
>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>> due to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>> java.lang.RuntimeException: java.lang.NoClassDefFoundError:
>>>>>>>>>>>> Unable to
>>>>>>>>>>>> load class org.apache.ofbiz.widget.render
>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>> due
>>>>>>>>>>>> to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.
>>>>>>>>>>>> convertUncaughtExceptionToCompilationError(CompilationUnit.j
>>>>>>>>>>>> ava:1101)
>>>>>>>>>>>> at
>>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryCl
>>>>>>>>>>>> assNodes(CompilationUnit.java:1079)
>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation
>>>>>>>>>>>> (CompilationUnit.java:603)
>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.processPhaseOper
>>>>>>>>>>>> ations(CompilationUnit.java:581)
>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.compile(Compilat
>>>>>>>>>>>> ionUnit.java:558)
>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader
>>>>>>>>>>>> .java:298)
>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>> ava:268)
>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>> ava:254)
>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>> ava:211)
>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.parseClass(GroovyUtil.
>>>>>>>>>>>> java:195)
>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.getScriptClassFromLoca
>>>>>>>>>>>> tion(GroovyUtil.java:159)
>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(Gr
>>>>>>>>>>>> oovyUtil.java:206)
>>>>>>>>>>>> at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
>>>>>>>>>>>> il.java:342)
>>>>>>>>>>>> at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
>>>>>>>>>>>> il.java:324)
>>>>>>>>>>>> at
>>>>>>>>>>>>
>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>
>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>
>>>>
>

[Jacques Le Roux]

Actually I expect to put this feature on the server to demonstrate it, for people to test it and use it on their side

Still a WIP...

Jacques


Le 16/03/2018 à 09:30, Scott Gray a écrit :

> That's the problem though, this domain isn't available for that purpose
> either.
>
> You're also using infra volunteer time for feature development rather than
> project support.
>
> Regards
> Scott
>
> On 16/03/2018 7:29 PM, "Jacques Le Roux" <[hidden email]>
> wrote:
>
>> I'm sorry, this is a temporary poor man solution. I have no other domain
>> available.
>>
>> Jacques
>>
>>
>> Le 16/03/2018 à 03:08, Scott Gray a écrit :
>>
>>> I guess what Michael is getting at, is that the demo server is for demos,
>>> it's not intended for use as a development sandbox.
>>>
>>> As far as I can tell you don't *need* to be using the demo servers for
>>> this, it's just convenient for you.  But the problem is, if you're
>>> modifying the code on the demos and someone reports a problem, the rest of
>>> us will go looking for a problem in the branches that doesn't exist.
>>>
>>> Long story short, probably not an appropriate use of the demo instances.
>>>
>>> Regards
>>> Scott
>>>
>>> On 16 March 2018 at 08:34, Jacques Le Roux <[hidden email]>
>>> wrote:
>>>
>>> Before Jacopo asked to revert my work on OFBIZ-9833 I continued to work on
>>>> a replacing solution.
>>>>
>>>> This other solution still uses the same (slightly modified)
>>>> externalServerLoginCheck preprocessor.
>>>> FYI this solution is still based on AutoUserLogin cookies, and uses now
>>>> Ajax and CORS, instead of  ContextFilter.
>>>>
>>>> So to test that on a server I need a small modification on the current
>>>> code:
>>>>
>>>> Index: framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>> ol/ExternalLoginKeysManager.java
>>>> ===================================================================
>>>> --- framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>> ol/ExternalLoginKeysManager.java (revision 1826773)
>>>> +++ framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>> ol/ExternalLoginKeysManager.java (working copy)
>>>> @@ -182,18 +182,15 @@
>>>>            Delegator delegator = (Delegator)
>>>> request.getAttribute("delegato
>>>> r");
>>>>            HttpSession session = request.getSession();
>>>>
>>>> -        // The target server does not allow external login by default
>>>> -        boolean useExternalServer = EntityUtilProperties.getProper
>>>> tyAsBoolean("security",
>>>> "use-external-server", false);
>>>> -        String sourceWebappName = request.getParameter(SOURCE_SE
>>>> RVER_WEBAPP_NAME);
>>>> -        if (!useExternalServer || sourceWebappName == null) return
>>>> "success"; // Nothing to do here
>>>> -
>>>>            try {
>>>>                String userLoginId = null;
>>>>                String authorizationHeader = request.getHeader("Authorizati
>>>> on");
>>>>                if (authorizationHeader != null) {
>>>>                    Claims claims = returnsClaims(authorizationHeader);
>>>>                    userLoginId = getSourceUserLoginId(claims );
>>>> -                boolean jwtOK = checkJwt(authorizationHeader,
>>>> userLoginId, getTargetServerUrl(request), UtilHttp.getApplicationName(re
>>>> quest));
>>>> +                boolean jwtOK = checkJwt(authorizationHeader,
>>>> userLoginId, "","");
>>>>                    if (!jwtOK) {
>>>>                        // Something unexpected happened here
>>>>                        Debug.logWarning("*** There was a problem with the
>>>> JWT token, not signin in the user login " + userLoginId, module);
>>>>
>>>> I did this modification on the trunk demo. I have no other solution to
>>>> test my work.
>>>>
>>>> Also I had to request the installation of HTTPS headers handling by
>>>> infra:
>>>> https://issues.apache.org/jira/browse/INFRA-16189
>>>>
>>>> Jacques
>>>>
>>>>
>>>>
>>>> Le 15/03/2018 à 17:37, Michael Brohl a écrit :
>>>>
>>>> I still do not understand why you had to change the demo instance for
>>>>> your developments. What was this change?
>>>>>
>>>>> Michael
>>>>>
>>>>>
>>>>> Am 15.03.18 um 14:46 schrieb Jacques Le Roux:
>>>>>
>>>>> Because for testing changes for OFBIZ-9833 I had to make a slight change
>>>>>> on the trunk demo instance and needed to restart but
>>>>>>
>>>>>> ./gradlew --no-daemon "ofbiz --shutdown"
>>>>>>
>>>>>> Does not always behaves well, at least on demos VM where there is 3
>>>>>> instances
>>>>>>
>>>>>> So you get unstable situation and have to use "kill -9".
>>>>>>
>>>>>> Anyway some data were not well loaded. A loadAll fixed it.
>>>>>>
>>>>>> HTH
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>> Le 15/03/2018 à 13:56, Michael Brohl a écrit :
>>>>>>
>>>>>> Of course it should read: "I try to understand why trunk demo was
>>>>>>> broken while the trunk codebase seems to have no issues."
>>>>>>>
>>>>>>> Michael
>>>>>>>
>>>>>>>
>>>>>>> Am 15.03.18 um 13:51 schrieb Michael Brohl:
>>>>>>>
>>>>>>> To be more clear: I try to understand why trunk demo was broken while
>>>>>>>> the trunk demo seems to have no issues.
>>>>>>>>
>>>>>>>> Michael
>>>>>>>>
>>>>>>>>
>>>>>>>> Am 15.03.18 um 13:36 schrieb Jacques Le Roux:
>>>>>>>>
>>>>>>>> Ho, it would be convoluted, please wait, WIP...
>>>>>>>>> Jacques
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 15/03/2018 à 12:37, Michael Brohl a écrit :
>>>>>>>>>
>>>>>>>>> Jacques did changes he already reverted in the mantime, see his post
>>>>>>>>>> this morning.
>>>>>>>>>>
>>>>>>>>>> Jacques, can you please explain what happened?
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Am 15.03.18 um 12:24 schrieb Taher Alkhateeb:
>>>>>>>>>>
>>>>>>>>>> Hi Rishi, I'm not getting any errors in the demo on my side? Could
>>>>>>>>>>> it
>>>>>>>>>>> be a web browser cache thing? I always fall in that trap myself.
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki <
>>>>>>>>>>> [hidden email]> wrote:
>>>>>>>>>>>
>>>>>>>>>>> It seems something specific with deployment/data at demo instance,
>>>>>>>>>>>> locally
>>>>>>>>>>>> It is working. No issue with latest trunk fresh data.
>>>>>>>>>>>>
>>>>>>>>>>>> Best,
>>>>>>>>>>>>
>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki <
>>>>>>>>>>>> [hidden email]>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> Devs,
>>>>>>>>>>>>
>>>>>>>>>>>>> On browsing - https://demo-trunk.ofbiz.apach
>>>>>>>>>>>>> e.org/webtools/control/
>>>>>>>>>>>>> FindGeneric?entityName=Party
>>>>>>>>>>>>>
>>>>>>>>>>>>> Received following exception, Any one facing the similar issue
>>>>>>>>>>>>> with demo
>>>>>>>>>>>>> please share. I'm looking into it and get back if find the root
>>>>>>>>>>>>> cause for
>>>>>>>>>>>>> the same.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks!
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Here is the error received on UI
>>>>>>>>>>>>>
>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>> ERROR rendering error page [/error/error.jsp], but here is the
>>>>>>>>>>>>> error text:
>>>>>>>>>>>>> java.lang.IllegalArgumentException: Error running script at
>>>>>>>>>>>>> location
>>>>>>>>>>>>> [component://webtools/groovyScripts/entity/FindGeneric.groovy]:
>>>>>>>>>>>>> org.codehaus.groovy.control.MultipleCompilationErrorsException:
>>>>>>>>>>>>> startup
>>>>>>>>>>>>> failed: General error during class generation:
>>>>>>>>>>>>> java.lang.NoClassDefFoundError:
>>>>>>>>>>>>> Unable to load class org.apache.ofbiz.widget.render
>>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>>> due to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>> java.lang.RuntimeException: java.lang.NoClassDefFoundError:
>>>>>>>>>>>>> Unable to
>>>>>>>>>>>>> load class org.apache.ofbiz.widget.render
>>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>>> due
>>>>>>>>>>>>> to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.
>>>>>>>>>>>>> convertUncaughtExceptionToCompilationError(CompilationUnit.j
>>>>>>>>>>>>> ava:1101)
>>>>>>>>>>>>> at
>>>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryCl
>>>>>>>>>>>>> assNodes(CompilationUnit.java:1079)
>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation
>>>>>>>>>>>>> (CompilationUnit.java:603)
>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.processPhaseOper
>>>>>>>>>>>>> ations(CompilationUnit.java:581)
>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.compile(Compilat
>>>>>>>>>>>>> ionUnit.java:558)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader
>>>>>>>>>>>>> .java:298)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>>> ava:268)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>>> ava:254)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>>> ava:211)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.parseClass(GroovyUtil.
>>>>>>>>>>>>> java:195)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.getScriptClassFromLoca
>>>>>>>>>>>>> tion(GroovyUtil.java:159)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(Gr
>>>>>>>>>>>>> oovyUtil.java:206)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
>>>>>>>>>>>>> il.java:342)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
>>>>>>>>>>>>> il.java:324)
>>>>>>>>>>>>> at
>>>>>>>>>>>>>
>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>>
>>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>

[Jacques Le Roux]

Thanks Nicolas,

I'll consider it, I just want to finish something (WIP...) before.

Jacques


Le 16/03/2018 à 09:17, Nicolas Malin a écrit :

> Hello,
>
> Jacques, if you need some testing server for you dev, don't hesitate to ask us. I'm sure we can use some time to deploy different OFBiz instance on
> the nereide farm.
>
> This proposal can be apply to all developer that works on an ofbiz issue who need strong architecture. If we can help to move forward, it's will be
> with great pleasure :)
>
> Nicolas
>
>
> On 16/03/2018 07:28, Jacques Le Roux wrote:
>> I'm sorry, this is a temporary poor man solution. I have no other domain available.
>>
>> Jacques
>>
>>
>> Le 16/03/2018 à 03:08, Scott Gray a écrit :
>>> I guess what Michael is getting at, is that the demo server is for demos,
>>> it's not intended for use as a development sandbox.
>>>
>>> As far as I can tell you don't *need* to be using the demo servers for
>>> this, it's just convenient for you.  But the problem is, if you're
>>> modifying the code on the demos and someone reports a problem, the rest of
>>> us will go looking for a problem in the branches that doesn't exist.
>>>
>>> Long story short, probably not an appropriate use of the demo instances.
>>>
>>> Regards
>>> Scott
>>>
>>> On 16 March 2018 at 08:34, Jacques Le Roux <[hidden email]>
>>> wrote:
>>>
>>>> Before Jacopo asked to revert my work on OFBIZ-9833 I continued to work on
>>>> a replacing solution.
>>>>
>>>> This other solution still uses the same (slightly modified)
>>>> externalServerLoginCheck preprocessor.
>>>> FYI this solution is still based on AutoUserLogin cookies, and uses now
>>>> Ajax and CORS, instead of  ContextFilter.
>>>>
>>>> So to test that on a server I need a small modification on the current
>>>> code:
>>>>
>>>> Index: framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>> ol/ExternalLoginKeysManager.java
>>>> ===================================================================
>>>> --- framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>> ol/ExternalLoginKeysManager.java (revision 1826773)
>>>> +++ framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>> ol/ExternalLoginKeysManager.java (working copy)
>>>> @@ -182,18 +182,15 @@
>>>>           Delegator delegator = (Delegator) request.getAttribute("delegato
>>>> r");
>>>>           HttpSession session = request.getSession();
>>>>
>>>> -        // The target server does not allow external login by default
>>>> -        boolean useExternalServer = EntityUtilProperties.getPropertyAsBoolean("security",
>>>> "use-external-server", false);
>>>> -        String sourceWebappName = request.getParameter(SOURCE_SE
>>>> RVER_WEBAPP_NAME);
>>>> -        if (!useExternalServer || sourceWebappName == null) return
>>>> "success"; // Nothing to do here
>>>> -
>>>>           try {
>>>>               String userLoginId = null;
>>>>               String authorizationHeader = request.getHeader("Authorizati
>>>> on");
>>>>               if (authorizationHeader != null) {
>>>>                   Claims claims = returnsClaims(authorizationHeader);
>>>>                   userLoginId = getSourceUserLoginId(claims );
>>>> -                boolean jwtOK = checkJwt(authorizationHeader,
>>>> userLoginId, getTargetServerUrl(request), UtilHttp.getApplicationName(re
>>>> quest));
>>>> +                boolean jwtOK = checkJwt(authorizationHeader,
>>>> userLoginId, "","");
>>>>                   if (!jwtOK) {
>>>>                       // Something unexpected happened here
>>>>                       Debug.logWarning("*** There was a problem with the
>>>> JWT token, not signin in the user login " + userLoginId, module);
>>>>
>>>> I did this modification on the trunk demo. I have no other solution to
>>>> test my work.
>>>>
>>>> Also I had to request the installation of HTTPS headers handling by infra:
>>>> https://issues.apache.org/jira/browse/INFRA-16189
>>>>
>>>> Jacques
>>>>
>>>>
>>>>
>>>> Le 15/03/2018 à 17:37, Michael Brohl a écrit :
>>>>
>>>>> I still do not understand why you had to change the demo instance for
>>>>> your developments. What was this change?
>>>>>
>>>>> Michael
>>>>>
>>>>>
>>>>> Am 15.03.18 um 14:46 schrieb Jacques Le Roux:
>>>>>
>>>>>> Because for testing changes for OFBIZ-9833 I had to make a slight change
>>>>>> on the trunk demo instance and needed to restart but
>>>>>>
>>>>>> ./gradlew --no-daemon "ofbiz --shutdown"
>>>>>>
>>>>>> Does not always behaves well, at least on demos VM where there is 3
>>>>>> instances
>>>>>>
>>>>>> So you get unstable situation and have to use "kill -9".
>>>>>>
>>>>>> Anyway some data were not well loaded. A loadAll fixed it.
>>>>>>
>>>>>> HTH
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>> Le 15/03/2018 à 13:56, Michael Brohl a écrit :
>>>>>>
>>>>>>> Of course it should read: "I try to understand why trunk demo was
>>>>>>> broken while the trunk codebase seems to have no issues."
>>>>>>>
>>>>>>> Michael
>>>>>>>
>>>>>>>
>>>>>>> Am 15.03.18 um 13:51 schrieb Michael Brohl:
>>>>>>>
>>>>>>>> To be more clear: I try to understand why trunk demo was broken while
>>>>>>>> the trunk demo seems to have no issues.
>>>>>>>>
>>>>>>>> Michael
>>>>>>>>
>>>>>>>>
>>>>>>>> Am 15.03.18 um 13:36 schrieb Jacques Le Roux:
>>>>>>>>
>>>>>>>>> Ho, it would be convoluted, please wait, WIP...
>>>>>>>>>
>>>>>>>>> Jacques
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 15/03/2018 à 12:37, Michael Brohl a écrit :
>>>>>>>>>
>>>>>>>>>> Jacques did changes he already reverted in the mantime, see his post
>>>>>>>>>> this morning.
>>>>>>>>>>
>>>>>>>>>> Jacques, can you please explain what happened?
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Am 15.03.18 um 12:24 schrieb Taher Alkhateeb:
>>>>>>>>>>
>>>>>>>>>>> Hi Rishi, I'm not getting any errors in the demo on my side? Could
>>>>>>>>>>> it
>>>>>>>>>>> be a web browser cache thing? I always fall in that trap myself.
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki <
>>>>>>>>>>> [hidden email]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> It seems something specific with deployment/data at demo instance,
>>>>>>>>>>>> locally
>>>>>>>>>>>> It is working. No issue with latest trunk fresh data.
>>>>>>>>>>>>
>>>>>>>>>>>> Best,
>>>>>>>>>>>>
>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki <
>>>>>>>>>>>> [hidden email]>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> Devs,
>>>>>>>>>>>>> On browsing - https://demo-trunk.ofbiz.apach
>>>>>>>>>>>>> e.org/webtools/control/
>>>>>>>>>>>>> FindGeneric?entityName=Party
>>>>>>>>>>>>>
>>>>>>>>>>>>> Received following exception, Any one facing the similar issue
>>>>>>>>>>>>> with demo
>>>>>>>>>>>>> please share. I'm looking into it and get back if find the root
>>>>>>>>>>>>> cause for
>>>>>>>>>>>>> the same.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks!
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Here is the error received on UI
>>>>>>>>>>>>>
>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>> ERROR rendering error page [/error/error.jsp], but here is the
>>>>>>>>>>>>> error text:
>>>>>>>>>>>>> java.lang.IllegalArgumentException: Error running script at
>>>>>>>>>>>>> location
>>>>>>>>>>>>> [component://webtools/groovyScripts/entity/FindGeneric.groovy]:
>>>>>>>>>>>>> org.codehaus.groovy.control.MultipleCompilationErrorsException:
>>>>>>>>>>>>> startup
>>>>>>>>>>>>> failed: General error during class generation:
>>>>>>>>>>>>> java.lang.NoClassDefFoundError:
>>>>>>>>>>>>> Unable to load class org.apache.ofbiz.widget.render
>>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>>> due to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>> java.lang.RuntimeException: java.lang.NoClassDefFoundError:
>>>>>>>>>>>>> Unable to
>>>>>>>>>>>>> load class org.apache.ofbiz.widget.renderer.macro.MacroFormRenderer
>>>>>>>>>>>>> due
>>>>>>>>>>>>> to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.
>>>>>>>>>>>>> convertUncaughtExceptionToCompilationError(CompilationUnit.java:1101)
>>>>>>>>>>>>> at
>>>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryCl
>>>>>>>>>>>>> assNodes(CompilationUnit.java:1079)
>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation
>>>>>>>>>>>>> (CompilationUnit.java:603)
>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.processPhaseOper
>>>>>>>>>>>>> ations(CompilationUnit.java:581)
>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.compile(Compilat
>>>>>>>>>>>>> ionUnit.java:558)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader
>>>>>>>>>>>>> .java:298)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>>> ava:268)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>>> ava:254)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>>> ava:211)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.parseClass(GroovyUtil.
>>>>>>>>>>>>> java:195)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.getScriptClassFromLoca
>>>>>>>>>>>>> tion(GroovyUtil.java:159)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(Gr
>>>>>>>>>>>>> oovyUtil.java:206)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
>>>>>>>>>>>>> il.java:342)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
>>>>>>>>>>>>> il.java:324)
>>>>>>>>>>>>> at
>>>>>>>>>>>>>
>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>>
>>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>
>>
>>
>
>

[Rajesh Mallah]

@Jacques ,

Same Here as Nicolas,

I have plenty of CPU and RAM  , and some static IPs to host VMs  for
Ofbiz development.

regds
mallah.


On Fri, Mar 16, 2018 at 1:47 PM, Nicolas Malin <[hidden email]>
wrote:

> Hello,
>
> Jacques, if you need some testing server for you dev, don't hesitate to
> ask us. I'm sure we can use some time to deploy different OFBiz instance on
> the nereide farm.
>
> This proposal can be apply to all developer that works on an ofbiz issue
> who need strong architecture. If we can help to move forward, it's will be
> with great pleasure :)
>
> Nicolas
>
>
>
> On 16/03/2018 07:28, Jacques Le Roux wrote:
>
>> I'm sorry, this is a temporary poor man solution. I have no other domain
>> available.
>>
>> Jacques
>>
>>
>> Le 16/03/2018 à 03:08, Scott Gray a écrit :
>>
>>> I guess what Michael is getting at, is that the demo server is for demos,
>>> it's not intended for use as a development sandbox.
>>>
>>> As far as I can tell you don't *need* to be using the demo servers for
>>> this, it's just convenient for you.  But the problem is, if you're
>>> modifying the code on the demos and someone reports a problem, the rest
>>> of
>>> us will go looking for a problem in the branches that doesn't exist.
>>>
>>> Long story short, probably not an appropriate use of the demo instances.
>>>
>>> Regards
>>> Scott
>>>
>>> On 16 March 2018 at 08:34, Jacques Le Roux <[hidden email]
>>> >
>>> wrote:
>>>
>>> Before Jacopo asked to revert my work on OFBIZ-9833 I continued to work
>>>> on
>>>> a replacing solution.
>>>>
>>>> This other solution still uses the same (slightly modified)
>>>> externalServerLoginCheck preprocessor.
>>>> FYI this solution is still based on AutoUserLogin cookies, and uses now
>>>> Ajax and CORS, instead of  ContextFilter.
>>>>
>>>> So to test that on a server I need a small modification on the current
>>>> code:
>>>>
>>>> Index: framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>> ol/ExternalLoginKeysManager.java
>>>> ===================================================================
>>>> --- framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>> ol/ExternalLoginKeysManager.java (revision 1826773)
>>>> +++ framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>> ol/ExternalLoginKeysManager.java (working copy)
>>>> @@ -182,18 +182,15 @@
>>>>           Delegator delegator = (Delegator)
>>>> request.getAttribute("delegato
>>>> r");
>>>>           HttpSession session = request.getSession();
>>>>
>>>> -        // The target server does not allow external login by default
>>>> -        boolean useExternalServer = EntityUtilProperties.getProper
>>>> tyAsBoolean("security",
>>>> "use-external-server", false);
>>>> -        String sourceWebappName = request.getParameter(SOURCE_SE
>>>> RVER_WEBAPP_NAME);
>>>> -        if (!useExternalServer || sourceWebappName == null) return
>>>> "success"; // Nothing to do here
>>>> -
>>>>           try {
>>>>               String userLoginId = null;
>>>>               String authorizationHeader =
>>>> request.getHeader("Authorizati
>>>> on");
>>>>               if (authorizationHeader != null) {
>>>>                   Claims claims = returnsClaims(authorizationHeader);
>>>>                   userLoginId = getSourceUserLoginId(claims );
>>>> -                boolean jwtOK = checkJwt(authorizationHeader,
>>>> userLoginId, getTargetServerUrl(request), UtilHttp.getApplicationName(re
>>>> quest));
>>>> +                boolean jwtOK = checkJwt(authorizationHeader,
>>>> userLoginId, "","");
>>>>                   if (!jwtOK) {
>>>>                       // Something unexpected happened here
>>>>                       Debug.logWarning("*** There was a problem with the
>>>> JWT token, not signin in the user login " + userLoginId, module);
>>>>
>>>> I did this modification on the trunk demo. I have no other solution to
>>>> test my work.
>>>>
>>>> Also I had to request the installation of HTTPS headers handling by
>>>> infra:
>>>> https://issues.apache.org/jira/browse/INFRA-16189
>>>>
>>>> Jacques
>>>>
>>>>
>>>>
>>>> Le 15/03/2018 à 17:37, Michael Brohl a écrit :
>>>>
>>>> I still do not understand why you had to change the demo instance for
>>>>> your developments. What was this change?
>>>>>
>>>>> Michael
>>>>>
>>>>>
>>>>> Am 15.03.18 um 14:46 schrieb Jacques Le Roux:
>>>>>
>>>>> Because for testing changes for OFBIZ-9833 I had to make a slight
>>>>>> change
>>>>>> on the trunk demo instance and needed to restart but
>>>>>>
>>>>>> ./gradlew --no-daemon "ofbiz --shutdown"
>>>>>>
>>>>>> Does not always behaves well, at least on demos VM where there is 3
>>>>>> instances
>>>>>>
>>>>>> So you get unstable situation and have to use "kill -9".
>>>>>>
>>>>>> Anyway some data were not well loaded. A loadAll fixed it.
>>>>>>
>>>>>> HTH
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>> Le 15/03/2018 à 13:56, Michael Brohl a écrit :
>>>>>>
>>>>>> Of course it should read: "I try to understand why trunk demo was
>>>>>>> broken while the trunk codebase seems to have no issues."
>>>>>>>
>>>>>>> Michael
>>>>>>>
>>>>>>>
>>>>>>> Am 15.03.18 um 13:51 schrieb Michael Brohl:
>>>>>>>
>>>>>>> To be more clear: I try to understand why trunk demo was broken while
>>>>>>>> the trunk demo seems to have no issues.
>>>>>>>>
>>>>>>>> Michael
>>>>>>>>
>>>>>>>>
>>>>>>>> Am 15.03.18 um 13:36 schrieb Jacques Le Roux:
>>>>>>>>
>>>>>>>> Ho, it would be convoluted, please wait, WIP...
>>>>>>>>>
>>>>>>>>> Jacques
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 15/03/2018 à 12:37, Michael Brohl a écrit :
>>>>>>>>>
>>>>>>>>> Jacques did changes he already reverted in the mantime, see his
>>>>>>>>>> post
>>>>>>>>>> this morning.
>>>>>>>>>>
>>>>>>>>>> Jacques, can you please explain what happened?
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Am 15.03.18 um 12:24 schrieb Taher Alkhateeb:
>>>>>>>>>>
>>>>>>>>>> Hi Rishi, I'm not getting any errors in the demo on my side? Could
>>>>>>>>>>> it
>>>>>>>>>>> be a web browser cache thing? I always fall in that trap myself.
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki <
>>>>>>>>>>> [hidden email]> wrote:
>>>>>>>>>>>
>>>>>>>>>>> It seems something specific with deployment/data at demo
>>>>>>>>>>>> instance,
>>>>>>>>>>>> locally
>>>>>>>>>>>> It is working. No issue with latest trunk fresh data.
>>>>>>>>>>>>
>>>>>>>>>>>> Best,
>>>>>>>>>>>>
>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki <
>>>>>>>>>>>> [hidden email]>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> Devs,
>>>>>>>>>>>>
>>>>>>>>>>>>> On browsing - https://demo-trunk.ofbiz.apach
>>>>>>>>>>>>> e.org/webtools/control/
>>>>>>>>>>>>> FindGeneric?entityName=Party
>>>>>>>>>>>>>
>>>>>>>>>>>>> Received following exception, Any one facing the similar issue
>>>>>>>>>>>>> with demo
>>>>>>>>>>>>> please share. I'm looking into it and get back if find the root
>>>>>>>>>>>>> cause for
>>>>>>>>>>>>> the same.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks!
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Here is the error received on UI
>>>>>>>>>>>>>
>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>> ERROR rendering error page [/error/error.jsp], but here is the
>>>>>>>>>>>>> error text:
>>>>>>>>>>>>> java.lang.IllegalArgumentException: Error running script at
>>>>>>>>>>>>> location
>>>>>>>>>>>>> [component://webtools/groovyScripts/entity/FindGeneric.groovy]:
>>>>>>>>>>>>>
>>>>>>>>>>>>> org.codehaus.groovy.control.MultipleCompilationErrorsException:
>>>>>>>>>>>>>
>>>>>>>>>>>>> startup
>>>>>>>>>>>>> failed: General error during class generation:
>>>>>>>>>>>>> java.lang.NoClassDefFoundError:
>>>>>>>>>>>>> Unable to load class org.apache.ofbiz.widget.render
>>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>>> due to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>> java.lang.RuntimeException: java.lang.NoClassDefFoundError:
>>>>>>>>>>>>> Unable to
>>>>>>>>>>>>> load class org.apache.ofbiz.widget.render
>>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>>> due
>>>>>>>>>>>>> to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.
>>>>>>>>>>>>> convertUncaughtExceptionToCompilationError(CompilationUnit.java:1101)
>>>>>>>>>>>>>
>>>>>>>>>>>>> at
>>>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryCl
>>>>>>>>>>>>> assNodes(CompilationUnit.java:1079)
>>>>>>>>>>>>> at org.codehaus.groovy.control.Co
>>>>>>>>>>>>> mpilationUnit.doPhaseOperation
>>>>>>>>>>>>> (CompilationUnit.java:603)
>>>>>>>>>>>>> at org.codehaus.groovy.control.Co
>>>>>>>>>>>>> mpilationUnit.processPhaseOper
>>>>>>>>>>>>> ations(CompilationUnit.java:581)
>>>>>>>>>>>>> at org.codehaus.groovy.control.Co
>>>>>>>>>>>>> mpilationUnit.compile(Compilat
>>>>>>>>>>>>> ionUnit.java:558)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>> doParseClass(GroovyClassLoader
>>>>>>>>>>>>> .java:298)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>> parseClass(GroovyClassLoader.j
>>>>>>>>>>>>> ava:268)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>> parseClass(GroovyClassLoader.j
>>>>>>>>>>>>> ava:254)
>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>> parseClass(GroovyClassLoader.j
>>>>>>>>>>>>> ava:211)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Gro
>>>>>>>>>>>>> ovyUtil.parseClass(GroovyUtil.
>>>>>>>>>>>>> java:195)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Gro
>>>>>>>>>>>>> ovyUtil.getScriptClassFromLoca
>>>>>>>>>>>>> tion(GroovyUtil.java:159)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Gro
>>>>>>>>>>>>> ovyUtil.runScriptAtLocation(Gr
>>>>>>>>>>>>> oovyUtil.java:206)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Scr
>>>>>>>>>>>>> iptUtil.executeScript(ScriptUt
>>>>>>>>>>>>> il.java:342)
>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Scr
>>>>>>>>>>>>> iptUtil.executeScript(ScriptUt
>>>>>>>>>>>>> il.java:324)
>>>>>>>>>>>>> at
>>>>>>>>>>>>>
>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>>
>>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>
>>
>>
>

[Rajesh Mallah]

Additionally time to set them up.

regds
mallah.

On Fri, Mar 16, 2018 at 2:36 PM, Rajesh Mallah <[hidden email]>
wrote:

>
> @Jacques ,
>
> Same Here as Nicolas,
>
> I have plenty of CPU and RAM  , and some static IPs to host VMs  for
> Ofbiz development.
>
> regds
> mallah.
>
>
> On Fri, Mar 16, 2018 at 1:47 PM, Nicolas Malin <[hidden email]>
> wrote:
>
>> Hello,
>>
>> Jacques, if you need some testing server for you dev, don't hesitate to
>> ask us. I'm sure we can use some time to deploy different OFBiz instance on
>> the nereide farm.
>>
>> This proposal can be apply to all developer that works on an ofbiz issue
>> who need strong architecture. If we can help to move forward, it's will be
>> with great pleasure :)
>>
>> Nicolas
>>
>>
>>
>> On 16/03/2018 07:28, Jacques Le Roux wrote:
>>
>>> I'm sorry, this is a temporary poor man solution. I have no other domain
>>> available.
>>>
>>> Jacques
>>>
>>>
>>> Le 16/03/2018 à 03:08, Scott Gray a écrit :
>>>
>>>> I guess what Michael is getting at, is that the demo server is for
>>>> demos,
>>>> it's not intended for use as a development sandbox.
>>>>
>>>> As far as I can tell you don't *need* to be using the demo servers for
>>>> this, it's just convenient for you.  But the problem is, if you're
>>>> modifying the code on the demos and someone reports a problem, the rest
>>>> of
>>>> us will go looking for a problem in the branches that doesn't exist.
>>>>
>>>> Long story short, probably not an appropriate use of the demo instances.
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> On 16 March 2018 at 08:34, Jacques Le Roux <
>>>> [hidden email]>
>>>> wrote:
>>>>
>>>> Before Jacopo asked to revert my work on OFBIZ-9833 I continued to work
>>>>> on
>>>>> a replacing solution.
>>>>>
>>>>> This other solution still uses the same (slightly modified)
>>>>> externalServerLoginCheck preprocessor.
>>>>> FYI this solution is still based on AutoUserLogin cookies, and uses now
>>>>> Ajax and CORS, instead of  ContextFilter.
>>>>>
>>>>> So to test that on a server I need a small modification on the current
>>>>> code:
>>>>>
>>>>> Index: framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>>> ol/ExternalLoginKeysManager.java
>>>>> ===================================================================
>>>>> --- framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>>> ol/ExternalLoginKeysManager.java (revision 1826773)
>>>>> +++ framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>>> ol/ExternalLoginKeysManager.java (working copy)
>>>>> @@ -182,18 +182,15 @@
>>>>>           Delegator delegator = (Delegator)
>>>>> request.getAttribute("delegato
>>>>> r");
>>>>>           HttpSession session = request.getSession();
>>>>>
>>>>> -        // The target server does not allow external login by default
>>>>> -        boolean useExternalServer = EntityUtilProperties.getProper
>>>>> tyAsBoolean("security",
>>>>> "use-external-server", false);
>>>>> -        String sourceWebappName = request.getParameter(SOURCE_SE
>>>>> RVER_WEBAPP_NAME);
>>>>> -        if (!useExternalServer || sourceWebappName == null) return
>>>>> "success"; // Nothing to do here
>>>>> -
>>>>>           try {
>>>>>               String userLoginId = null;
>>>>>               String authorizationHeader =
>>>>> request.getHeader("Authorizati
>>>>> on");
>>>>>               if (authorizationHeader != null) {
>>>>>                   Claims claims = returnsClaims(authorizationHeader);
>>>>>                   userLoginId = getSourceUserLoginId(claims );
>>>>> -                boolean jwtOK = checkJwt(authorizationHeader,
>>>>> userLoginId, getTargetServerUrl(request),
>>>>> UtilHttp.getApplicationName(re
>>>>> quest));
>>>>> +                boolean jwtOK = checkJwt(authorizationHeader,
>>>>> userLoginId, "","");
>>>>>                   if (!jwtOK) {
>>>>>                       // Something unexpected happened here
>>>>>                       Debug.logWarning("*** There was a problem with
>>>>> the
>>>>> JWT token, not signin in the user login " + userLoginId, module);
>>>>>
>>>>> I did this modification on the trunk demo. I have no other solution to
>>>>> test my work.
>>>>>
>>>>> Also I had to request the installation of HTTPS headers handling by
>>>>> infra:
>>>>> https://issues.apache.org/jira/browse/INFRA-16189
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>>
>>>>> Le 15/03/2018 à 17:37, Michael Brohl a écrit :
>>>>>
>>>>> I still do not understand why you had to change the demo instance for
>>>>>> your developments. What was this change?
>>>>>>
>>>>>> Michael
>>>>>>
>>>>>>
>>>>>> Am 15.03.18 um 14:46 schrieb Jacques Le Roux:
>>>>>>
>>>>>> Because for testing changes for OFBIZ-9833 I had to make a slight
>>>>>>> change
>>>>>>> on the trunk demo instance and needed to restart but
>>>>>>>
>>>>>>> ./gradlew --no-daemon "ofbiz --shutdown"
>>>>>>>
>>>>>>> Does not always behaves well, at least on demos VM where there is 3
>>>>>>> instances
>>>>>>>
>>>>>>> So you get unstable situation and have to use "kill -9".
>>>>>>>
>>>>>>> Anyway some data were not well loaded. A loadAll fixed it.
>>>>>>>
>>>>>>> HTH
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>>
>>>>>>> Le 15/03/2018 à 13:56, Michael Brohl a écrit :
>>>>>>>
>>>>>>> Of course it should read: "I try to understand why trunk demo was
>>>>>>>> broken while the trunk codebase seems to have no issues."
>>>>>>>>
>>>>>>>> Michael
>>>>>>>>
>>>>>>>>
>>>>>>>> Am 15.03.18 um 13:51 schrieb Michael Brohl:
>>>>>>>>
>>>>>>>> To be more clear: I try to understand why trunk demo was broken
>>>>>>>>> while
>>>>>>>>> the trunk demo seems to have no issues.
>>>>>>>>>
>>>>>>>>> Michael
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Am 15.03.18 um 13:36 schrieb Jacques Le Roux:
>>>>>>>>>
>>>>>>>>> Ho, it would be convoluted, please wait, WIP...
>>>>>>>>>>
>>>>>>>>>> Jacques
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Le 15/03/2018 à 12:37, Michael Brohl a écrit :
>>>>>>>>>>
>>>>>>>>>> Jacques did changes he already reverted in the mantime, see his
>>>>>>>>>>> post
>>>>>>>>>>> this morning.
>>>>>>>>>>>
>>>>>>>>>>> Jacques, can you please explain what happened?
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Am 15.03.18 um 12:24 schrieb Taher Alkhateeb:
>>>>>>>>>>>
>>>>>>>>>>> Hi Rishi, I'm not getting any errors in the demo on my side?
>>>>>>>>>>>> Could
>>>>>>>>>>>> it
>>>>>>>>>>>> be a web browser cache thing? I always fall in that trap myself.
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki <
>>>>>>>>>>>> [hidden email]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> It seems something specific with deployment/data at demo
>>>>>>>>>>>>> instance,
>>>>>>>>>>>>> locally
>>>>>>>>>>>>> It is working. No issue with latest trunk fresh data.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Best,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki <
>>>>>>>>>>>>> [hidden email]>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> Devs,
>>>>>>>>>>>>>
>>>>>>>>>>>>>> On browsing - https://demo-trunk.ofbiz.apach
>>>>>>>>>>>>>> e.org/webtools/control/
>>>>>>>>>>>>>> FindGeneric?entityName=Party
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Received following exception, Any one facing the similar issue
>>>>>>>>>>>>>> with demo
>>>>>>>>>>>>>> please share. I'm looking into it and get back if find the
>>>>>>>>>>>>>> root
>>>>>>>>>>>>>> cause for
>>>>>>>>>>>>>> the same.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks!
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Here is the error received on UI
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>>> ERROR rendering error page [/error/error.jsp], but here is the
>>>>>>>>>>>>>> error text:
>>>>>>>>>>>>>> java.lang.IllegalArgumentException: Error running script at
>>>>>>>>>>>>>> location
>>>>>>>>>>>>>> [component://webtools/groovyScripts/entity/FindGeneric.groovy]:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> org.codehaus.groovy.control.MultipleCompilationErrorsException:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> startup
>>>>>>>>>>>>>> failed: General error during class generation:
>>>>>>>>>>>>>> java.lang.NoClassDefFoundError:
>>>>>>>>>>>>>> Unable to load class org.apache.ofbiz.widget.render
>>>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>>>> due to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>>> java.lang.RuntimeException: java.lang.NoClassDefFoundError:
>>>>>>>>>>>>>> Unable to
>>>>>>>>>>>>>> load class org.apache.ofbiz.widget.render
>>>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>>>> due
>>>>>>>>>>>>>> to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.
>>>>>>>>>>>>>> convertUncaughtExceptionToCompilationError(CompilationUnit.java:1101)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> at
>>>>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryCl
>>>>>>>>>>>>>> assNodes(CompilationUnit.java:1079)
>>>>>>>>>>>>>> at org.codehaus.groovy.control.Co
>>>>>>>>>>>>>> mpilationUnit.doPhaseOperation
>>>>>>>>>>>>>> (CompilationUnit.java:603)
>>>>>>>>>>>>>> at org.codehaus.groovy.control.Co
>>>>>>>>>>>>>> mpilationUnit.processPhaseOper
>>>>>>>>>>>>>> ations(CompilationUnit.java:581)
>>>>>>>>>>>>>> at org.codehaus.groovy.control.Co
>>>>>>>>>>>>>> mpilationUnit.compile(Compilat
>>>>>>>>>>>>>> ionUnit.java:558)
>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>>> doParseClass(GroovyClassLoader
>>>>>>>>>>>>>> .java:298)
>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>>> parseClass(GroovyClassLoader.j
>>>>>>>>>>>>>> ava:268)
>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>>> parseClass(GroovyClassLoader.j
>>>>>>>>>>>>>> ava:254)
>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>>> parseClass(GroovyClassLoader.j
>>>>>>>>>>>>>> ava:211)
>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Gro
>>>>>>>>>>>>>> ovyUtil.parseClass(GroovyUtil.
>>>>>>>>>>>>>> java:195)
>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Gro
>>>>>>>>>>>>>> ovyUtil.getScriptClassFromLoca
>>>>>>>>>>>>>> tion(GroovyUtil.java:159)
>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Gro
>>>>>>>>>>>>>> ovyUtil.runScriptAtLocation(Gr
>>>>>>>>>>>>>> oovyUtil.java:206)
>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Scr
>>>>>>>>>>>>>> iptUtil.executeScript(ScriptUt
>>>>>>>>>>>>>> il.java:342)
>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Scr
>>>>>>>>>>>>>> iptUtil.executeScript(ScriptUt
>>>>>>>>>>>>>> il.java:324)
>>>>>>>>>>>>>> at
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>
>>>
>>>
>>
>

[Jacques Le Roux]

Thanks Mallah,

Much appreciated

Jacques


Le 16/03/2018 à 10:07, Rajesh Mallah a écrit :

> Additionally time to set them up.
>
> regds
> mallah.
>
> On Fri, Mar 16, 2018 at 2:36 PM, Rajesh Mallah <[hidden email]>
> wrote:
>
>> @Jacques ,
>>
>> Same Here as Nicolas,
>>
>> I have plenty of CPU and RAM  , and some static IPs to host VMs  for
>> Ofbiz development.
>>
>> regds
>> mallah.
>>
>>
>> On Fri, Mar 16, 2018 at 1:47 PM, Nicolas Malin <[hidden email]>
>> wrote:
>>
>>> Hello,
>>>
>>> Jacques, if you need some testing server for you dev, don't hesitate to
>>> ask us. I'm sure we can use some time to deploy different OFBiz instance on
>>> the nereide farm.
>>>
>>> This proposal can be apply to all developer that works on an ofbiz issue
>>> who need strong architecture. If we can help to move forward, it's will be
>>> with great pleasure :)
>>>
>>> Nicolas
>>>
>>>
>>>
>>> On 16/03/2018 07:28, Jacques Le Roux wrote:
>>>
>>>> I'm sorry, this is a temporary poor man solution. I have no other domain
>>>> available.
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 16/03/2018 à 03:08, Scott Gray a écrit :
>>>>
>>>>> I guess what Michael is getting at, is that the demo server is for
>>>>> demos,
>>>>> it's not intended for use as a development sandbox.
>>>>>
>>>>> As far as I can tell you don't *need* to be using the demo servers for
>>>>> this, it's just convenient for you.  But the problem is, if you're
>>>>> modifying the code on the demos and someone reports a problem, the rest
>>>>> of
>>>>> us will go looking for a problem in the branches that doesn't exist.
>>>>>
>>>>> Long story short, probably not an appropriate use of the demo instances.
>>>>>
>>>>> Regards
>>>>> Scott
>>>>>
>>>>> On 16 March 2018 at 08:34, Jacques Le Roux <
>>>>> [hidden email]>
>>>>> wrote:
>>>>>
>>>>> Before Jacopo asked to revert my work on OFBIZ-9833 I continued to work
>>>>>> on
>>>>>> a replacing solution.
>>>>>>
>>>>>> This other solution still uses the same (slightly modified)
>>>>>> externalServerLoginCheck preprocessor.
>>>>>> FYI this solution is still based on AutoUserLogin cookies, and uses now
>>>>>> Ajax and CORS, instead of  ContextFilter.
>>>>>>
>>>>>> So to test that on a server I need a small modification on the current
>>>>>> code:
>>>>>>
>>>>>> Index: framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>>>> ol/ExternalLoginKeysManager.java
>>>>>> ===================================================================
>>>>>> --- framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>>>> ol/ExternalLoginKeysManager.java (revision 1826773)
>>>>>> +++ framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>>>> ol/ExternalLoginKeysManager.java (working copy)
>>>>>> @@ -182,18 +182,15 @@
>>>>>>            Delegator delegator = (Delegator)
>>>>>> request.getAttribute("delegato
>>>>>> r");
>>>>>>            HttpSession session = request.getSession();
>>>>>>
>>>>>> -        // The target server does not allow external login by default
>>>>>> -        boolean useExternalServer = EntityUtilProperties.getProper
>>>>>> tyAsBoolean("security",
>>>>>> "use-external-server", false);
>>>>>> -        String sourceWebappName = request.getParameter(SOURCE_SE
>>>>>> RVER_WEBAPP_NAME);
>>>>>> -        if (!useExternalServer || sourceWebappName == null) return
>>>>>> "success"; // Nothing to do here
>>>>>> -
>>>>>>            try {
>>>>>>                String userLoginId = null;
>>>>>>                String authorizationHeader =
>>>>>> request.getHeader("Authorizati
>>>>>> on");
>>>>>>                if (authorizationHeader != null) {
>>>>>>                    Claims claims = returnsClaims(authorizationHeader);
>>>>>>                    userLoginId = getSourceUserLoginId(claims );
>>>>>> -                boolean jwtOK = checkJwt(authorizationHeader,
>>>>>> userLoginId, getTargetServerUrl(request),
>>>>>> UtilHttp.getApplicationName(re
>>>>>> quest));
>>>>>> +                boolean jwtOK = checkJwt(authorizationHeader,
>>>>>> userLoginId, "","");
>>>>>>                    if (!jwtOK) {
>>>>>>                        // Something unexpected happened here
>>>>>>                        Debug.logWarning("*** There was a problem with
>>>>>> the
>>>>>> JWT token, not signin in the user login " + userLoginId, module);
>>>>>>
>>>>>> I did this modification on the trunk demo. I have no other solution to
>>>>>> test my work.
>>>>>>
>>>>>> Also I had to request the installation of HTTPS headers handling by
>>>>>> infra:
>>>>>> https://issues.apache.org/jira/browse/INFRA-16189
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>>
>>>>>> Le 15/03/2018 à 17:37, Michael Brohl a écrit :
>>>>>>
>>>>>> I still do not understand why you had to change the demo instance for
>>>>>>> your developments. What was this change?
>>>>>>>
>>>>>>> Michael
>>>>>>>
>>>>>>>
>>>>>>> Am 15.03.18 um 14:46 schrieb Jacques Le Roux:
>>>>>>>
>>>>>>> Because for testing changes for OFBIZ-9833 I had to make a slight
>>>>>>>> change
>>>>>>>> on the trunk demo instance and needed to restart but
>>>>>>>>
>>>>>>>> ./gradlew --no-daemon "ofbiz --shutdown"
>>>>>>>>
>>>>>>>> Does not always behaves well, at least on demos VM where there is 3
>>>>>>>> instances
>>>>>>>>
>>>>>>>> So you get unstable situation and have to use "kill -9".
>>>>>>>>
>>>>>>>> Anyway some data were not well loaded. A loadAll fixed it.
>>>>>>>>
>>>>>>>> HTH
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 15/03/2018 à 13:56, Michael Brohl a écrit :
>>>>>>>>
>>>>>>>> Of course it should read: "I try to understand why trunk demo was
>>>>>>>>> broken while the trunk codebase seems to have no issues."
>>>>>>>>>
>>>>>>>>> Michael
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Am 15.03.18 um 13:51 schrieb Michael Brohl:
>>>>>>>>>
>>>>>>>>> To be more clear: I try to understand why trunk demo was broken
>>>>>>>>>> while
>>>>>>>>>> the trunk demo seems to have no issues.
>>>>>>>>>>
>>>>>>>>>> Michael
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Am 15.03.18 um 13:36 schrieb Jacques Le Roux:
>>>>>>>>>>
>>>>>>>>>> Ho, it would be convoluted, please wait, WIP...
>>>>>>>>>>> Jacques
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Le 15/03/2018 à 12:37, Michael Brohl a écrit :
>>>>>>>>>>>
>>>>>>>>>>> Jacques did changes he already reverted in the mantime, see his
>>>>>>>>>>>> post
>>>>>>>>>>>> this morning.
>>>>>>>>>>>>
>>>>>>>>>>>> Jacques, can you please explain what happened?
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Am 15.03.18 um 12:24 schrieb Taher Alkhateeb:
>>>>>>>>>>>>
>>>>>>>>>>>> Hi Rishi, I'm not getting any errors in the demo on my side?
>>>>>>>>>>>>> Could
>>>>>>>>>>>>> it
>>>>>>>>>>>>> be a web browser cache thing? I always fall in that trap myself.
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki <
>>>>>>>>>>>>> [hidden email]> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> It seems something specific with deployment/data at demo
>>>>>>>>>>>>>> instance,
>>>>>>>>>>>>>> locally
>>>>>>>>>>>>>> It is working. No issue with latest trunk fresh data.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Best,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki <
>>>>>>>>>>>>>> [hidden email]>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Devs,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On browsing - https://demo-trunk.ofbiz.apach
>>>>>>>>>>>>>>> e.org/webtools/control/
>>>>>>>>>>>>>>> FindGeneric?entityName=Party
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Received following exception, Any one facing the similar issue
>>>>>>>>>>>>>>> with demo
>>>>>>>>>>>>>>> please share. I'm looking into it and get back if find the
>>>>>>>>>>>>>>> root
>>>>>>>>>>>>>>> cause for
>>>>>>>>>>>>>>> the same.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Thanks!
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Here is the error received on UI
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>>>> ERROR rendering error page [/error/error.jsp], but here is the
>>>>>>>>>>>>>>> error text:
>>>>>>>>>>>>>>> java.lang.IllegalArgumentException: Error running script at
>>>>>>>>>>>>>>> location
>>>>>>>>>>>>>>> [component://webtools/groovyScripts/entity/FindGeneric.groovy]:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> org.codehaus.groovy.control.MultipleCompilationErrorsException:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> startup
>>>>>>>>>>>>>>> failed: General error during class generation:
>>>>>>>>>>>>>>> java.lang.NoClassDefFoundError:
>>>>>>>>>>>>>>> Unable to load class org.apache.ofbiz.widget.render
>>>>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>>>>> due to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>>>> java.lang.RuntimeException: java.lang.NoClassDefFoundError:
>>>>>>>>>>>>>>> Unable to
>>>>>>>>>>>>>>> load class org.apache.ofbiz.widget.render
>>>>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>>>>> due
>>>>>>>>>>>>>>> to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.
>>>>>>>>>>>>>>> convertUncaughtExceptionToCompilationError(CompilationUnit.java:1101)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> at
>>>>>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryCl
>>>>>>>>>>>>>>> assNodes(CompilationUnit.java:1079)
>>>>>>>>>>>>>>> at org.codehaus.groovy.control.Co
>>>>>>>>>>>>>>> mpilationUnit.doPhaseOperation
>>>>>>>>>>>>>>> (CompilationUnit.java:603)
>>>>>>>>>>>>>>> at org.codehaus.groovy.control.Co
>>>>>>>>>>>>>>> mpilationUnit.processPhaseOper
>>>>>>>>>>>>>>> ations(CompilationUnit.java:581)
>>>>>>>>>>>>>>> at org.codehaus.groovy.control.Co
>>>>>>>>>>>>>>> mpilationUnit.compile(Compilat
>>>>>>>>>>>>>>> ionUnit.java:558)
>>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>>>> doParseClass(GroovyClassLoader
>>>>>>>>>>>>>>> .java:298)
>>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>>>> parseClass(GroovyClassLoader.j
>>>>>>>>>>>>>>> ava:268)
>>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>>>> parseClass(GroovyClassLoader.j
>>>>>>>>>>>>>>> ava:254)
>>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.
>>>>>>>>>>>>>>> parseClass(GroovyClassLoader.j
>>>>>>>>>>>>>>> ava:211)
>>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Gro
>>>>>>>>>>>>>>> ovyUtil.parseClass(GroovyUtil.
>>>>>>>>>>>>>>> java:195)
>>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Gro
>>>>>>>>>>>>>>> ovyUtil.getScriptClassFromLoca
>>>>>>>>>>>>>>> tion(GroovyUtil.java:159)
>>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Gro
>>>>>>>>>>>>>>> ovyUtil.runScriptAtLocation(Gr
>>>>>>>>>>>>>>> oovyUtil.java:206)
>>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Scr
>>>>>>>>>>>>>>> iptUtil.executeScript(ScriptUt
>>>>>>>>>>>>>>> il.java:342)
>>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.Scr
>>>>>>>>>>>>>>> iptUtil.executeScript(ScriptUt
>>>>>>>>>>>>>>> il.java:324)
>>>>>>>>>>>>>>> at
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>

[Jacques Le Roux]

I reverted the code change on trunk demo after r1826949

If I had knew it would have made so much noise I'd have done that from start :/

For CORS I let it for now, we will discuss it in OFBIZ-9833 after I revert all related

Jacques


Le 16/03/2018 à 09:56, Jacques Le Roux a écrit :

> Actually I expect to put this feature on the server to demonstrate it, for people to test it and use it on their side
>
> Still a WIP...
>
> Jacques
>
>
> Le 16/03/2018 à 09:30, Scott Gray a écrit :
>> That's the problem though, this domain isn't available for that purpose
>> either.
>>
>> You're also using infra volunteer time for feature development rather than
>> project support.
>>
>> Regards
>> Scott
>>
>> On 16/03/2018 7:29 PM, "Jacques Le Roux" <[hidden email]>
>> wrote:
>>
>>> I'm sorry, this is a temporary poor man solution. I have no other domain
>>> available.
>>>
>>> Jacques
>>>
>>>
>>> Le 16/03/2018 à 03:08, Scott Gray a écrit :
>>>
>>>> I guess what Michael is getting at, is that the demo server is for demos,
>>>> it's not intended for use as a development sandbox.
>>>>
>>>> As far as I can tell you don't *need* to be using the demo servers for
>>>> this, it's just convenient for you.  But the problem is, if you're
>>>> modifying the code on the demos and someone reports a problem, the rest of
>>>> us will go looking for a problem in the branches that doesn't exist.
>>>>
>>>> Long story short, probably not an appropriate use of the demo instances.
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> On 16 March 2018 at 08:34, Jacques Le Roux <[hidden email]>
>>>> wrote:
>>>>
>>>> Before Jacopo asked to revert my work on OFBIZ-9833 I continued to work on
>>>>> a replacing solution.
>>>>>
>>>>> This other solution still uses the same (slightly modified)
>>>>> externalServerLoginCheck preprocessor.
>>>>> FYI this solution is still based on AutoUserLogin cookies, and uses now
>>>>> Ajax and CORS, instead of  ContextFilter.
>>>>>
>>>>> So to test that on a server I need a small modification on the current
>>>>> code:
>>>>>
>>>>> Index: framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>>> ol/ExternalLoginKeysManager.java
>>>>> ===================================================================
>>>>> --- framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>>> ol/ExternalLoginKeysManager.java (revision 1826773)
>>>>> +++ framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
>>>>> ol/ExternalLoginKeysManager.java (working copy)
>>>>> @@ -182,18 +182,15 @@
>>>>>            Delegator delegator = (Delegator)
>>>>> request.getAttribute("delegato
>>>>> r");
>>>>>            HttpSession session = request.getSession();
>>>>>
>>>>> -        // The target server does not allow external login by default
>>>>> -        boolean useExternalServer = EntityUtilProperties.getProper
>>>>> tyAsBoolean("security",
>>>>> "use-external-server", false);
>>>>> -        String sourceWebappName = request.getParameter(SOURCE_SE
>>>>> RVER_WEBAPP_NAME);
>>>>> -        if (!useExternalServer || sourceWebappName == null) return
>>>>> "success"; // Nothing to do here
>>>>> -
>>>>>            try {
>>>>>                String userLoginId = null;
>>>>>                String authorizationHeader = request.getHeader("Authorizati
>>>>> on");
>>>>>                if (authorizationHeader != null) {
>>>>>                    Claims claims = returnsClaims(authorizationHeader);
>>>>>                    userLoginId = getSourceUserLoginId(claims );
>>>>> -                boolean jwtOK = checkJwt(authorizationHeader,
>>>>> userLoginId, getTargetServerUrl(request), UtilHttp.getApplicationName(re
>>>>> quest));
>>>>> +                boolean jwtOK = checkJwt(authorizationHeader,
>>>>> userLoginId, "","");
>>>>>                    if (!jwtOK) {
>>>>>                        // Something unexpected happened here
>>>>>                        Debug.logWarning("*** There was a problem with the
>>>>> JWT token, not signin in the user login " + userLoginId, module);
>>>>>
>>>>> I did this modification on the trunk demo. I have no other solution to
>>>>> test my work.
>>>>>
>>>>> Also I had to request the installation of HTTPS headers handling by
>>>>> infra:
>>>>> https://issues.apache.org/jira/browse/INFRA-16189
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>>
>>>>> Le 15/03/2018 à 17:37, Michael Brohl a écrit :
>>>>>
>>>>> I still do not understand why you had to change the demo instance for
>>>>>> your developments. What was this change?
>>>>>>
>>>>>> Michael
>>>>>>
>>>>>>
>>>>>> Am 15.03.18 um 14:46 schrieb Jacques Le Roux:
>>>>>>
>>>>>> Because for testing changes for OFBIZ-9833 I had to make a slight change
>>>>>>> on the trunk demo instance and needed to restart but
>>>>>>>
>>>>>>> ./gradlew --no-daemon "ofbiz --shutdown"
>>>>>>>
>>>>>>> Does not always behaves well, at least on demos VM where there is 3
>>>>>>> instances
>>>>>>>
>>>>>>> So you get unstable situation and have to use "kill -9".
>>>>>>>
>>>>>>> Anyway some data were not well loaded. A loadAll fixed it.
>>>>>>>
>>>>>>> HTH
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>>
>>>>>>> Le 15/03/2018 à 13:56, Michael Brohl a écrit :
>>>>>>>
>>>>>>> Of course it should read: "I try to understand why trunk demo was
>>>>>>>> broken while the trunk codebase seems to have no issues."
>>>>>>>>
>>>>>>>> Michael
>>>>>>>>
>>>>>>>>
>>>>>>>> Am 15.03.18 um 13:51 schrieb Michael Brohl:
>>>>>>>>
>>>>>>>> To be more clear: I try to understand why trunk demo was broken while
>>>>>>>>> the trunk demo seems to have no issues.
>>>>>>>>>
>>>>>>>>> Michael
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Am 15.03.18 um 13:36 schrieb Jacques Le Roux:
>>>>>>>>>
>>>>>>>>> Ho, it would be convoluted, please wait, WIP...
>>>>>>>>>> Jacques
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Le 15/03/2018 à 12:37, Michael Brohl a écrit :
>>>>>>>>>>
>>>>>>>>>> Jacques did changes he already reverted in the mantime, see his post
>>>>>>>>>>> this morning.
>>>>>>>>>>>
>>>>>>>>>>> Jacques, can you please explain what happened?
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Am 15.03.18 um 12:24 schrieb Taher Alkhateeb:
>>>>>>>>>>>
>>>>>>>>>>> Hi Rishi, I'm not getting any errors in the demo on my side? Could
>>>>>>>>>>>> it
>>>>>>>>>>>> be a web browser cache thing? I always fall in that trap myself.
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki <
>>>>>>>>>>>> [hidden email]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> It seems something specific with deployment/data at demo instance,
>>>>>>>>>>>>> locally
>>>>>>>>>>>>> It is working. No issue with latest trunk fresh data.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Best,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki <
>>>>>>>>>>>>> [hidden email]>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> Devs,
>>>>>>>>>>>>>
>>>>>>>>>>>>>> On browsing - https://demo-trunk.ofbiz.apach
>>>>>>>>>>>>>> e.org/webtools/control/
>>>>>>>>>>>>>> FindGeneric?entityName=Party
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Received following exception, Any one facing the similar issue
>>>>>>>>>>>>>> with demo
>>>>>>>>>>>>>> please share. I'm looking into it and get back if find the root
>>>>>>>>>>>>>> cause for
>>>>>>>>>>>>>> the same.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks!
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Here is the error received on UI
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>>> ERROR rendering error page [/error/error.jsp], but here is the
>>>>>>>>>>>>>> error text:
>>>>>>>>>>>>>> java.lang.IllegalArgumentException: Error running script at
>>>>>>>>>>>>>> location
>>>>>>>>>>>>>> [component://webtools/groovyScripts/entity/FindGeneric.groovy]:
>>>>>>>>>>>>>> org.codehaus.groovy.control.MultipleCompilationErrorsException:
>>>>>>>>>>>>>> startup
>>>>>>>>>>>>>> failed: General error during class generation:
>>>>>>>>>>>>>> java.lang.NoClassDefFoundError:
>>>>>>>>>>>>>> Unable to load class org.apache.ofbiz.widget.render
>>>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>>>> due to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>>> java.lang.RuntimeException: java.lang.NoClassDefFoundError:
>>>>>>>>>>>>>> Unable to
>>>>>>>>>>>>>> load class org.apache.ofbiz.widget.render
>>>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>>>> due
>>>>>>>>>>>>>> to missing dependency org/apache/ofbiz/widget/model/
>>>>>>>>>>>>>> ModelFormField$SubHyperlink
>>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.
>>>>>>>>>>>>>> convertUncaughtExceptionToCompilationError(CompilationUnit.j
>>>>>>>>>>>>>> ava:1101)
>>>>>>>>>>>>>> at
>>>>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryCl
>>>>>>>>>>>>>> assNodes(CompilationUnit.java:1079)
>>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation
>>>>>>>>>>>>>> (CompilationUnit.java:603)
>>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.processPhaseOper
>>>>>>>>>>>>>> ations(CompilationUnit.java:581)
>>>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.compile(Compilat
>>>>>>>>>>>>>> ionUnit.java:558)
>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader
>>>>>>>>>>>>>> .java:298)
>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>>>> ava:268)
>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>>>> ava:254)
>>>>>>>>>>>>>> at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>>>> ava:211)
>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.parseClass(GroovyUtil.
>>>>>>>>>>>>>> java:195)
>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.getScriptClassFromLoca
>>>>>>>>>>>>>> tion(GroovyUtil.java:159)
>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(Gr
>>>>>>>>>>>>>> oovyUtil.java:206)
>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
>>>>>>>>>>>>>> il.java:342)
>>>>>>>>>>>>>> at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
>>>>>>>>>>>>>> il.java:324)
>>>>>>>>>>>>>> at
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>
>

[Jacques Le Roux]

Le 16/03/2018 à 09:30, Scott Gray a écrit :
> You're also using infra volunteer time for feature development rather than
> project support.
Actually, after 1 day wandering around, I was a lost with CORS which is really a beast when you want to use send an Auth header from the client side
to another domain. So I 1st asked for help in Infra HipChat room

TL;DR: I confused the a2enmod headers *which check* the presence of HTTPD header mod (and it seems add it temporarily) with the real presence of the
HTTPD header mod

[9:10 AM] Jacques Le Roux: Dear Infra team,I'm crossing an issue I can't understand.On OFBiz VM, to test something, I need to install a2enmod headers
and add this headers  
     ## For remote test access
  # needs  a2enmod headers
  Header set Access-Control-Allow-Origin "https://localhost:8443"
  Header set Access-Control-Allow-Headers "Authorization"
I'm able to do it as root, but for a reason I don't understand they don't stay.
I see there was an infrastructure-puppet-deployment https://ci.apache.org/builders/infrastructure-puppet-deployment/builds/2916
But this was hours ago and no new since. So what could be removing my change in 25-ofbiz-trunk-vm2-443.conf ?

after 20 mins alone I went ahead

[9:30 AM] Jacques Le Roux: OK I will create a PR for ofbiz-vm2.apache.org.yaml
If you have some information about the issue above, please share :)

Later it was eventually finalised at https://github.com/apache/infrastructure-puppet/pull/809

This was just FYI, we still need to discuss that properly in OFBIZ-9833

Jacques

[Jacques Le Roux]

I have created https://issues.apache.org/jira/browse/OFBIZ-10287 for that

Just apart: sincerely there are some times I regret Ant for being able to stop and start a sole instance, and compile a component only.

Just a matter of time, but time is ultimately all what we have...

Jacques


Le 15/03/2018 à 15:31, Jacques Le Roux a écrit :

> It's seems related to the VM config. I mean having trunk, stable on the same machine.
>
> So if you want to do that you need to reproduce the config on a machine following the relevant parts in tools\demo-backup
>
> At least having a trunk and stable instance running on the same machine
>
> As it's random it will need several tries...
>
> Will you handle it?
>
> Jacques
>
>
> Le 15/03/2018 à 15:11, Taher Alkhateeb a écrit :
>> Can we test with java -jar build/lib/ofbiz.jar --shutdown?
>>
>> If it is stable with raw java, then we know it is a gradle setup issue. If
>> not, then we investigate the shutdown code in the start component.
>>
>> On Mar 15, 2018 4:59 PM, "Jacques Le Roux" <[hidden email]>
>> wrote:
>>
>>> In the case I faced this morning it hanged at 91%  I did not check more.
>>>
>>> This happens sometimes, not often, I'd say 15%  of the time, I don't see
>>> any reason
>>>
>>> Jacques
>>>
>>>
>>> Le 15/03/2018 à 14:52, Taher Alkhateeb a écrit :
>>>
>>>> Can you be specific about "does not always behave well"? Maybe we can
>>>> debug and fix the situation. What happens? Does it not shut down at
>>>> all? Does it hang? What happens exactly?
>>>>
>>>> On Thu, Mar 15, 2018 at 4:46 PM, Jacques Le Roux
>>>> <[hidden email]> wrote:
>>>>
>>>>> Because for testing changes for OFBIZ-9833 I had to make a slight change
>>>>> on
>>>>> the trunk demo instance and needed to restart but
>>>>>
>>>>> ./gradlew --no-daemon "ofbiz --shutdown"
>>>>>
>>>>> Does not always behaves well, at least on demos VM where there is 3
>>>>> instances
>>>>>
>>>>> So you get unstable situation and have to use "kill -9".
>>>>>
>>>>> Anyway some data were not well loaded. A loadAll fixed it.
>>>>>
>>>>> HTH
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>>
>>>>> Le 15/03/2018 à 13:56, Michael Brohl a écrit :
>>>>>
>>>>>> Of course it should read: "I try to understand why trunk demo was broken
>>>>>> while the trunk codebase seems to have no issues."
>>>>>>
>>>>>> Michael
>>>>>>
>>>>>>
>>>>>> Am 15.03.18 um 13:51 schrieb Michael Brohl:
>>>>>>
>>>>>>> To be more clear: I try to understand why trunk demo was broken while
>>>>>>> the
>>>>>>> trunk demo seems to have no issues.
>>>>>>>
>>>>>>> Michael
>>>>>>>
>>>>>>>
>>>>>>> Am 15.03.18 um 13:36 schrieb Jacques Le Roux:
>>>>>>>
>>>>>>>> Ho, it would be convoluted, please wait, WIP...
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 15/03/2018 à 12:37, Michael Brohl a écrit :
>>>>>>>>
>>>>>>>>> Jacques did changes he already reverted in the mantime, see his post
>>>>>>>>> this morning.
>>>>>>>>>
>>>>>>>>> Jacques, can you please explain what happened?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Am 15.03.18 um 12:24 schrieb Taher Alkhateeb:
>>>>>>>>>
>>>>>>>>>> Hi Rishi, I'm not getting any errors in the demo on my side? Could
>>>>>>>>>> it
>>>>>>>>>> be a web browser cache thing? I always fall in that trap myself.
>>>>>>>>>>
>>>>>>>>>> On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki
>>>>>>>>>> <[hidden email]> wrote:
>>>>>>>>>>
>>>>>>>>>>> It seems something specific with deployment/data at demo instance,
>>>>>>>>>>> locally
>>>>>>>>>>> It is working. No issue with latest trunk fresh data.
>>>>>>>>>>>
>>>>>>>>>>> Best,
>>>>>>>>>>>
>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki
>>>>>>>>>>> <[hidden email]>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Devs,
>>>>>>>>>>>> On browsing - https://demo-trunk.ofbiz.apach
>>>>>>>>>>>> e.org/webtools/control/
>>>>>>>>>>>> FindGeneric?entityName=Party
>>>>>>>>>>>>
>>>>>>>>>>>> Received following exception, Any one facing the similar issue
>>>>>>>>>>>> with
>>>>>>>>>>>> demo
>>>>>>>>>>>> please share. I'm looking into it and get back if find the root
>>>>>>>>>>>> cause for
>>>>>>>>>>>> the same.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks!
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Here is the error received on UI
>>>>>>>>>>>>
>>>>>>>>>>>> ========================================================
>>>>>>>>>>>> ERROR rendering error page [/error/error.jsp], but here is the
>>>>>>>>>>>> error
>>>>>>>>>>>> text:
>>>>>>>>>>>> java.lang.IllegalArgumentException: Error running script at
>>>>>>>>>>>> location
>>>>>>>>>>>> [component://webtools/groovyScripts/entity/FindGeneric.groovy]:
>>>>>>>>>>>> org.codehaus.groovy.control.MultipleCompilationErrorsException:
>>>>>>>>>>>> startup
>>>>>>>>>>>> failed: General error during class generation:
>>>>>>>>>>>> java.lang.NoClassDefFoundError:
>>>>>>>>>>>> Unable to load class
>>>>>>>>>>>> org.apache.ofbiz.widget.renderer.macro.MacroFormRenderer
>>>>>>>>>>>> due to missing dependency
>>>>>>>>>>>> org/apache/ofbiz/widget/model/ModelFormField$SubHyperlink
>>>>>>>>>>>> java.lang.RuntimeException: java.lang.NoClassDefFoundError:
>>>>>>>>>>>> Unable
>>>>>>>>>>>> to
>>>>>>>>>>>> load class org.apache.ofbiz.widget.render
>>>>>>>>>>>> er.macro.MacroFormRenderer
>>>>>>>>>>>> due
>>>>>>>>>>>> to missing dependency
>>>>>>>>>>>> org/apache/ofbiz/widget/model/ModelFormField$SubHyperlink
>>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.
>>>>>>>>>>>>
>>>>>>>>>>>> convertUncaughtExceptionToCompilationError(CompilationUnit.java:1101)
>>>>>>>>>>>> at
>>>>>>>>>>>>
>>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryCl
>>>>>>>>>>>> assNodes(CompilationUnit.java:1079)
>>>>>>>>>>>> at
>>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation
>>>>>>>>>>>> (CompilationUnit.java:603)
>>>>>>>>>>>> at
>>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.processPhaseOper
>>>>>>>>>>>> ations(CompilationUnit.java:581)
>>>>>>>>>>>> at
>>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.compile(Compilat
>>>>>>>>>>>> ionUnit.java:558)
>>>>>>>>>>>> at
>>>>>>>>>>>> groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader
>>>>>>>>>>>> .java:298)
>>>>>>>>>>>> at
>>>>>>>>>>>> groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>> ava:268)
>>>>>>>>>>>> at
>>>>>>>>>>>> groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>> ava:254)
>>>>>>>>>>>> at
>>>>>>>>>>>> groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
>>>>>>>>>>>> ava:211)
>>>>>>>>>>>> at
>>>>>>>>>>>> org.apache.ofbiz.base.util.GroovyUtil.parseClass(GroovyUtil.
>>>>>>>>>>>> java:195)
>>>>>>>>>>>> at
>>>>>>>>>>>> org.apache.ofbiz.base.util.GroovyUtil.getScriptClassFromLoca
>>>>>>>>>>>> tion(GroovyUtil.java:159)
>>>>>>>>>>>> at
>>>>>>>>>>>> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(Gr
>>>>>>>>>>>> oovyUtil.java:206)
>>>>>>>>>>>> at
>>>>>>>>>>>> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
>>>>>>>>>>>> il.java:342)
>>>>>>>>>>>> at
>>>>>>>>>>>> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
>>>>>>>>>>>> il.java:324)
>>>>>>>>>>>> at
>>>>>>>>>>>>
>>>>>>>>>>>> ========================================================
>>>>>>>>>>>>
>>>>>>>>>>>> Rishi Solanki
>>>>>>>>>>>> Sr Manager, Enterprise Software Development
>>>>>>>>>>>> HotWax Systems Pvt. Ltd.
>>>>>>>>>>>> Direct: [phone]
>>>>>>>>>>>> http://www.hotwaxsystems.com
>>>>>>>>>>>> www.hotwax.co
>>>>>>>>>>>>
>>>>>>>>>>>>
>
>

[taher]

What you are mentioning has nothing to do with ant / gradle, but rather
with the design of our build script, which BTW I prefer the way it is
designed now because it provides consistency and uniform access for all
components.

Also what we gained from the switch far outweighs any set backs. Package
management, plugin management, auto dependencies, custom code, less files,
better component iteration, templating and lots of other features that
would have been extremely difficult and / or complex to implement with Ant.

On Sun, Mar 18, 2018, 3:44 PM Jacques Le Roux <[hidden email]>
wrote:

> I have created https://issues.apache.org/jira/browse/OFBIZ-10287 for that
>
> Just apart: sincerely there are some times I regret Ant for being able to
> stop and start a sole instance, and compile a component only.
>
> Just a matter of time, but time is ultimately all what we have...
>
> Jacques
>
>
> Le 15/03/2018 à 15:31, Jacques Le Roux a écrit :
> > It's seems related to the VM config. I mean having trunk, stable on the
> same machine.
> >
> > So if you want to do that you need to reproduce the config on a machine
> following the relevant parts in tools\demo-backup
> >
> > At least having a trunk and stable instance running on the same machine
> >
> > As it's random it will need several tries...
> >
> > Will you handle it?
> >
> > Jacques
> >
> >
> > Le 15/03/2018 à 15:11, Taher Alkhateeb a écrit :
> >> Can we test with java -jar build/lib/ofbiz.jar --shutdown?
> >>
> >> If it is stable with raw java, then we know it is a gradle setup issue.
> If
> >> not, then we investigate the shutdown code in the start component.
> >>
> >> On Mar 15, 2018 4:59 PM, "Jacques Le Roux" <
> [hidden email]>
> >> wrote:
> >>
> >>> In the case I faced this morning it hanged at 91%  I did not check
> more.
> >>>
> >>> This happens sometimes, not often, I'd say 15%  of the time, I don't
> see
> >>> any reason
> >>>
> >>> Jacques
> >>>
> >>>
> >>> Le 15/03/2018 à 14:52, Taher Alkhateeb a écrit :
> >>>
> >>>> Can you be specific about "does not always behave well"? Maybe we can
> >>>> debug and fix the situation. What happens? Does it not shut down at
> >>>> all? Does it hang? What happens exactly?
> >>>>
> >>>> On Thu, Mar 15, 2018 at 4:46 PM, Jacques Le Roux
> >>>> <[hidden email]> wrote:
> >>>>
> >>>>> Because for testing changes for OFBIZ-9833 I had to make a slight
> change
> >>>>> on
> >>>>> the trunk demo instance and needed to restart but
> >>>>>
> >>>>> ./gradlew --no-daemon "ofbiz --shutdown"
> >>>>>
> >>>>> Does not always behaves well, at least on demos VM where there is 3
> >>>>> instances
> >>>>>
> >>>>> So you get unstable situation and have to use "kill -9".
> >>>>>
> >>>>> Anyway some data were not well loaded. A loadAll fixed it.
> >>>>>
> >>>>> HTH
> >>>>>
> >>>>> Jacques
> >>>>>
> >>>>>
> >>>>>
> >>>>> Le 15/03/2018 à 13:56, Michael Brohl a écrit :
> >>>>>
> >>>>>> Of course it should read: "I try to understand why trunk demo was
> broken
> >>>>>> while the trunk codebase seems to have no issues."
> >>>>>>
> >>>>>> Michael
> >>>>>>
> >>>>>>
> >>>>>> Am 15.03.18 um 13:51 schrieb Michael Brohl:
> >>>>>>
> >>>>>>> To be more clear: I try to understand why trunk demo was broken
> while
> >>>>>>> the
> >>>>>>> trunk demo seems to have no issues.
> >>>>>>>
> >>>>>>> Michael
> >>>>>>>
> >>>>>>>
> >>>>>>> Am 15.03.18 um 13:36 schrieb Jacques Le Roux:
> >>>>>>>
> >>>>>>>> Ho, it would be convoluted, please wait, WIP...
> >>>>>>>>
> >>>>>>>> Jacques
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Le 15/03/2018 à 12:37, Michael Brohl a écrit :
> >>>>>>>>
> >>>>>>>>> Jacques did changes he already reverted in the mantime, see his
> post
> >>>>>>>>> this morning.
> >>>>>>>>>
> >>>>>>>>> Jacques, can you please explain what happened?
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Am 15.03.18 um 12:24 schrieb Taher Alkhateeb:
> >>>>>>>>>
> >>>>>>>>>> Hi Rishi, I'm not getting any errors in the demo on my side?
> Could
> >>>>>>>>>> it
> >>>>>>>>>> be a web browser cache thing? I always fall in that trap myself.
> >>>>>>>>>>
> >>>>>>>>>> On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki
> >>>>>>>>>> <[hidden email]> wrote:
> >>>>>>>>>>
> >>>>>>>>>>> It seems something specific with deployment/data at demo
> instance,
> >>>>>>>>>>> locally
> >>>>>>>>>>> It is working. No issue with latest trunk fresh data.
> >>>>>>>>>>>
> >>>>>>>>>>> Best,
> >>>>>>>>>>>
> >>>>>>>>>>> Rishi Solanki
> >>>>>>>>>>> Sr Manager, Enterprise Software Development
> >>>>>>>>>>> HotWax Systems Pvt. Ltd.
> >>>>>>>>>>> Direct: [phone]
> >>>>>>>>>>> http://www.hotwaxsystems.com
> >>>>>>>>>>> www.hotwax.co
> >>>>>>>>>>>
> >>>>>>>>>>> On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki
> >>>>>>>>>>> <[hidden email]>
> >>>>>>>>>>> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>> Devs,
> >>>>>>>>>>>> On browsing - https://demo-trunk.ofbiz.apach
> >>>>>>>>>>>> e.org/webtools/control/
> >>>>>>>>>>>> FindGeneric?entityName=Party
> >>>>>>>>>>>>
> >>>>>>>>>>>> Received following exception, Any one facing the similar issue
> >>>>>>>>>>>> with
> >>>>>>>>>>>> demo
> >>>>>>>>>>>> please share. I'm looking into it and get back if find the
> root
> >>>>>>>>>>>> cause for
> >>>>>>>>>>>> the same.
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> Thanks!
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> Here is the error received on UI
> >>>>>>>>>>>>
> >>>>>>>>>>>> ========================================================
> >>>>>>>>>>>> ERROR rendering error page [/error/error.jsp], but here is the
> >>>>>>>>>>>> error
> >>>>>>>>>>>> text:
> >>>>>>>>>>>> java.lang.IllegalArgumentException: Error running script at
> >>>>>>>>>>>> location
> >>>>>>>>>>>>
> [component://webtools/groovyScripts/entity/FindGeneric.groovy]:
> >>>>>>>>>>>>
> org.codehaus.groovy.control.MultipleCompilationErrorsException:
> >>>>>>>>>>>> startup
> >>>>>>>>>>>> failed: General error during class generation:
> >>>>>>>>>>>> java.lang.NoClassDefFoundError:
> >>>>>>>>>>>> Unable to load class
> >>>>>>>>>>>> org.apache.ofbiz.widget.renderer.macro.MacroFormRenderer
> >>>>>>>>>>>> due to missing dependency
> >>>>>>>>>>>> org/apache/ofbiz/widget/model/ModelFormField$SubHyperlink
> >>>>>>>>>>>> java.lang.RuntimeException: java.lang.NoClassDefFoundError:
> >>>>>>>>>>>> Unable
> >>>>>>>>>>>> to
> >>>>>>>>>>>> load class org.apache.ofbiz.widget.render
> >>>>>>>>>>>> er.macro.MacroFormRenderer
> >>>>>>>>>>>> due
> >>>>>>>>>>>> to missing dependency
> >>>>>>>>>>>> org/apache/ofbiz/widget/model/ModelFormField$SubHyperlink
> >>>>>>>>>>>> at org.codehaus.groovy.control.CompilationUnit.
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> convertUncaughtExceptionToCompilationError(CompilationUnit.java:1101)
> >>>>>>>>>>>> at
> >>>>>>>>>>>>
> >>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.applyToPrimaryCl
> >>>>>>>>>>>> assNodes(CompilationUnit.java:1079)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.doPhaseOperation
> >>>>>>>>>>>> (CompilationUnit.java:603)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.processPhaseOper
> >>>>>>>>>>>> ations(CompilationUnit.java:581)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> org.codehaus.groovy.control.CompilationUnit.compile(Compilat
> >>>>>>>>>>>> ionUnit.java:558)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader
> >>>>>>>>>>>> .java:298)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
> >>>>>>>>>>>> ava:268)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
> >>>>>>>>>>>> ava:254)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
> >>>>>>>>>>>> ava:211)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> org.apache.ofbiz.base.util.GroovyUtil.parseClass(GroovyUtil.
> >>>>>>>>>>>> java:195)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> org.apache.ofbiz.base.util.GroovyUtil.getScriptClassFromLoca
> >>>>>>>>>>>> tion(GroovyUtil.java:159)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(Gr
> >>>>>>>>>>>> oovyUtil.java:206)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
> >>>>>>>>>>>> il.java:342)
> >>>>>>>>>>>> at
> >>>>>>>>>>>> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
> >>>>>>>>>>>> il.java:324)
> >>>>>>>>>>>> at
> >>>>>>>>>>>>
> >>>>>>>>>>>> ========================================================
> >>>>>>>>>>>>
> >>>>>>>>>>>> Rishi Solanki
> >>>>>>>>>>>> Sr Manager, Enterprise Software Development
> >>>>>>>>>>>> HotWax Systems Pvt. Ltd.
> >>>>>>>>>>>> Direct: [phone]
> >>>>>>>>>>>> http://www.hotwaxsystems.com
> >>>>>>>>>>>> www.hotwax.co
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >
> >
>
>