Dev - Bug in the updateWorkEffort service?

[Jacopo Cappellato]

Hi all,

I think there is a bug in the updateWorkEffort service.
When a new status is passed, a record in the WorkEffortStatus is
created; however the record is created for the old status, not the new
one... is it correct?

Here is my proposed patch, what do you think?


Index:
applications/workeffort/script/org/ofbiz/workeffort/workeffort/WorkEffortSimpleServices.xml
===================================================================
---
applications/workeffort/script/org/ofbiz/workeffort/workeffort/WorkEffortSimpleServices.xml
(revision 6474)
+++
applications/workeffort/script/org/ofbiz/workeffort/workeffort/WorkEffortSimpleServices.xml
(working copy)
@@ -84,7 +84,7 @@
                  <set from-field="nowTimestamp"
field="lookedUpValue.lastStatusUpdate"/>
                  <make-value value-name="newWorkEffortStatus"
entity-name="WorkEffortStatus"/>
                  <set from-field="lookedUpValue.workEffortId"
field="newWorkEffortStatus.workEffortId"/>
-                <set from-field="lookedUpValue.currentStatusId"
field="newWorkEffortStatus.statusId"/>
+                <set from-field="parameters.currentStatusId"
field="newWorkEffortStatus.statusId"/>
                  <set from-field="nowTimestamp"
field="newWorkEffortStatus.statusDatetime"/>
                  <set from-field="userLogin.userLoginId"
field="newWorkEffortStatus.setByUserLogin"/>
                  <create-value value-name="newWorkEffortStatus"/>

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[David E. Jones]

Jacopo,

Yes, this looks good. Thanks for sending it over. Your change is in  
rev 6517.

-David


On Jan 13, 2006, at 11:06 AM, Jacopo Cappellato wrote:

> Hi all,
>
> I think there is a bug in the updateWorkEffort service.
> When a new status is passed, a record in the WorkEffortStatus is
> created; however the record is created for the old status, not the new
> one... is it correct?
>
> Here is my proposed patch, what do you think?
>
>
> Index:
> applications/workeffort/script/org/ofbiz/workeffort/workeffort/
> WorkEffortSimpleServices.xml
> ===================================================================
> ---
> applications/workeffort/script/org/ofbiz/workeffort/workeffort/
> WorkEffortSimpleServices.xml
> (revision 6474)
> +++
> applications/workeffort/script/org/ofbiz/workeffort/workeffort/
> WorkEffortSimpleServices.xml
> (working copy)
> @@ -84,7 +84,7 @@
>                   <set from-field="nowTimestamp"
> field="lookedUpValue.lastStatusUpdate"/>
>                   <make-value value-name="newWorkEffortStatus"
> entity-name="WorkEffortStatus"/>
>                   <set from-field="lookedUpValue.workEffortId"
> field="newWorkEffortStatus.workEffortId"/>
> -                <set from-field="lookedUpValue.currentStatusId"
> field="newWorkEffortStatus.statusId"/>
> +                <set from-field="parameters.currentStatusId"
> field="newWorkEffortStatus.statusId"/>
>                   <set from-field="nowTimestamp"
> field="newWorkEffortStatus.statusDatetime"/>
>                   <set from-field="userLogin.userLoginId"
> field="newWorkEffortStatus.setByUserLogin"/>
>                   <create-value value-name="newWorkEffortStatus"/>
>
>
> _______________________________________________
> Dev mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/dev

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev