Dev - configurable custom views
Locked
12
12
Re: Dev - configurable custom views
 
|
Adrian, Jacopo, Yeah, I think it's fine. Working with a List is easy enough that it shouldn't be a problem for anyone, and it's a lot more flexible. Thanks for pushing this guys, and sorry for not chiming in sooner. Is there a clean patch for this anywhere? Is the one included in these replies meant to be it? I took a peek at OFBIZ-880 and there are a number of files... which I guess are just meant to be copied in, but that also seems somewhat independent of this specific issue. Is that right? Anyway, let me know and I'll get it in. -David Jacopo Cappellato wrote: > David, > > what do you think of this? > > Jacopo > > Adrian Crum wrote: >> Jacopo, >> >> Since no one has objected to this, could we get it committed? >> >> -Adrian >> >> >> Jacopo Cappellato wrote: >>> Adrian, >>> >>> about the styleSheet LIST issue: some time ago, David told me how to >>> create lists inside a screen action tag: >>> >>> <set field="styleSheets[]" value="/images/customstyles.css"/> >>> <set field="styleSheets[]" value="/images/specialcustomstyles.css"/> >>> >>> So this is no more an issue; it's ok for me to commit your changes. >>> >>> However, what do you (all) think of the attached patch? >>> >>> Jacopo >>> >>> >>> Adrian Crum wrote: >>> >>>> It would be nice if - while you're mulling this over - someone could >>>> at least commit the change to header.ftl >>>> (http://jira.undersunconsulting.com/browse/OFBIZ-880 ). Just that >>>> small change will enable a number of users to easily customize the UI. >>>> >>>> If that gets committed, there may be an issue with some of Jacopo's >>>> work - since he had originally modified header.ftl for a single >>>> alternative css file. The css file LIST that I proposed is preferable, >>>> but Jacopo was unable to create a list in the screen widget (see the >>>> notes on http://jira.undersunconsulting.com/browse/OFBIZ-174 ). In a >>>> nutshell, whatever components use Jacopo's alternative css file will >>>> have to be corrected to use a css file list. >>>> >>>> I would also like to thank Jacopo and anyone else who worked on Jira >>>> 174 to get the GlobalDecorator idea implemented. Without that work, a >>>> user-selected UI theme would require a lot more modification. >>>> >>>> -Adrian >>>> >>> ------------------------------------------------------------------------ >>> >>> Index: framework/common/webcommon/includes/header.ftl >>> =================================================================== >>> --- framework/common/webcommon/includes/header.ftl (revision 7592) >>> +++ framework/common/webcommon/includes/header.ftl (working copy) >>> @@ -41,8 +41,15 @@ >>> <script language="javascript" src="<@ofbizContentUrl>/images/calendar1.js</@ofbizContentUrl>" type="text/javascript"></script> >>> <script language="javascript" src="<@ofbizContentUrl>/images/selectall.js</@ofbizContentUrl>" type="text/javascript"></script> >>> <script language="javascript" src="<@ofbizContentUrl>/images/fieldlookup.js</@ofbizContentUrl>" type="text/javascript"></script> >>> - <link rel="stylesheet" href="<@ofbizContentUrl>/images/maincss.css</@ofbizContentUrl>" type="text/css"/> >>> - <link rel="stylesheet" href="<@ofbizContentUrl>/images/tabstyles.css</@ofbizContentUrl>" type="text/css"/> >>> + <#if layoutSettings.styleSheets?has_content> >>> + <#--layoutSettings.styleSheets is a list of style sheets. So, you can have a user-specified "main" style sheet, AND a component style sheet.--> >>> + <#list layoutSettings.styleSheets as styleSheet> >>> + <link rel="stylesheet" href="<@ofbizContentUrl>${styleSheet}</@ofbizContentUrl>" type="text/css"> >>> + </#list> >>> + <#else> >>> + <link rel="stylesheet" href="<@ofbizContentUrl>/images/maincss.css</@ofbizContentUrl>" type="text/css"/> >>> + <link rel="stylesheet" href="<@ofbizContentUrl>/images/tabstyles.css</@ofbizContentUrl>" type="text/css"/> >>> + </#if> >>> <#if layoutSettings.extraStyleSheet?exists> >>> <#-- Component-specified style sheet --> >>> <link rel="stylesheet" href="${layoutSettings.extraStyleSheet}" type="text/css"/> >>> >>> >>> ------------------------------------------------------------------------ >>> >>> >>> _______________________________________________ >>> Dev mailing list >>> [hidden email] >>> http://lists.ofbiz.org/mailman/listinfo/dev >> >> _______________________________________________ >> Dev mailing list >> [hidden email] >> http://lists.ofbiz.org/mailman/listinfo/dev >> > > > _______________________________________________ > Dev mailing list > [hidden email] > http://lists.ofbiz.org/mailman/listinfo/dev _______________________________________________ Dev mailing list [hidden email] http://lists.ofbiz.org/mailman/listinfo/dev |
Re: Dev - configurable custom views
|
|
David,
please find the attached patch. Thanks, Jacopo David E. Jones wrote: > Adrian, Jacopo, > > Yeah, I think it's fine. Working with a List is easy enough that it shouldn't be a problem for anyone, and it's a lot more flexible. Thanks for pushing this guys, and sorry for not chiming in sooner. > > Is there a clean patch for this anywhere? Is the one included in these replies meant to be it? I took a peek at OFBIZ-880 and there are a number of files... which I guess are just meant to be copied in, but that also seems somewhat independent of this specific issue. Is that right? > > Anyway, let me know and I'll get it in. > > -David > Index: framework/common/webcommon/includes/header.ftl =================================================================== --- framework/common/webcommon/includes/header.ftl (revision 7762) +++ framework/common/webcommon/includes/header.ftl (working copy) @@ -41,8 +41,15 @@ <script language="javascript" src="<@ofbizContentUrl>/images/calendar1.js</@ofbizContentUrl>" type="text/javascript"></script> <script language="javascript" src="<@ofbizContentUrl>/images/selectall.js</@ofbizContentUrl>" type="text/javascript"></script> <script language="javascript" src="<@ofbizContentUrl>/images/fieldlookup.js</@ofbizContentUrl>" type="text/javascript"></script> - <link rel="stylesheet" href="<@ofbizContentUrl>/images/maincss.css</@ofbizContentUrl>" type="text/css"/> - <link rel="stylesheet" href="<@ofbizContentUrl>/images/tabstyles.css</@ofbizContentUrl>" type="text/css"/> + <#if layoutSettings.styleSheets?has_content> + <#--layoutSettings.styleSheets is a list of style sheets. So, you can have a user-specified "main" style sheet, AND a component style sheet.--> + <#list layoutSettings.styleSheets as styleSheet> + <link rel="stylesheet" href="<@ofbizContentUrl>${styleSheet}</@ofbizContentUrl>" type="text/css"> + </#list> + <#else> + <link rel="stylesheet" href="<@ofbizContentUrl>/images/maincss.css</@ofbizContentUrl>" type="text/css"/> + <link rel="stylesheet" href="<@ofbizContentUrl>/images/tabstyles.css</@ofbizContentUrl>" type="text/css"/> + </#if> <#if layoutSettings.extraStyleSheet?exists> <#-- Component-specified style sheet --> <link rel="stylesheet" href="${layoutSettings.extraStyleSheet}" type="text/css"/> _______________________________________________ Dev mailing list [hidden email] http://lists.ofbiz.org/mailman/listinfo/dev |
Re: Dev - configurable custom views
|
|
Done. SVN rev 7768. -David Jacopo Cappellato wrote: > David, > > please find the attached patch. > > Thanks, > > Jacopo > > David E. Jones wrote: >> Adrian, Jacopo, >> >> Yeah, I think it's fine. Working with a List is easy enough that it >> shouldn't be a problem for anyone, and it's a lot more flexible. >> Thanks for pushing this guys, and sorry for not chiming in sooner. >> >> Is there a clean patch for this anywhere? Is the one included in these >> replies meant to be it? I took a peek at OFBIZ-880 and there are a >> number of files... which I guess are just meant to be copied in, but >> that also seems somewhat independent of this specific issue. Is that >> right? >> >> Anyway, let me know and I'll get it in. >> >> -David >> > > > ------------------------------------------------------------------------ > > Index: framework/common/webcommon/includes/header.ftl > =================================================================== > --- framework/common/webcommon/includes/header.ftl (revision 7762) > +++ framework/common/webcommon/includes/header.ftl (working copy) > @@ -41,8 +41,15 @@ > <script language="javascript" src="<@ofbizContentUrl>/images/calendar1.js</@ofbizContentUrl>" type="text/javascript"></script> > <script language="javascript" src="<@ofbizContentUrl>/images/selectall.js</@ofbizContentUrl>" type="text/javascript"></script> > <script language="javascript" src="<@ofbizContentUrl>/images/fieldlookup.js</@ofbizContentUrl>" type="text/javascript"></script> > - <link rel="stylesheet" href="<@ofbizContentUrl>/images/maincss.css</@ofbizContentUrl>" type="text/css"/> > - <link rel="stylesheet" href="<@ofbizContentUrl>/images/tabstyles.css</@ofbizContentUrl>" type="text/css"/> > + <#if layoutSettings.styleSheets?has_content> > + <#--layoutSettings.styleSheets is a list of style sheets. So, you can have a user-specified "main" style sheet, AND a component style sheet.--> > + <#list layoutSettings.styleSheets as styleSheet> > + <link rel="stylesheet" href="<@ofbizContentUrl>${styleSheet}</@ofbizContentUrl>" type="text/css"> > + </#list> > + <#else> > + <link rel="stylesheet" href="<@ofbizContentUrl>/images/maincss.css</@ofbizContentUrl>" type="text/css"/> > + <link rel="stylesheet" href="<@ofbizContentUrl>/images/tabstyles.css</@ofbizContentUrl>" type="text/css"/> > + </#if> > <#if layoutSettings.extraStyleSheet?exists> > <#-- Component-specified style sheet --> > <link rel="stylesheet" href="${layoutSettings.extraStyleSheet}" type="text/css"/> > > > ------------------------------------------------------------------------ > > > _______________________________________________ > Dev mailing list > [hidden email] > http://lists.ofbiz.org/mailman/listinfo/dev _______________________________________________ Dev mailing list [hidden email] http://lists.ofbiz.org/mailman/listinfo/dev |
Re: Dev - configurable custom views
|
|
In reply to this post by Adrian Crum
Adrian,
(sorry for the off-topic) I've tried to contact you privately (I have to ask you a question about your iCLA) but the message I've sent to your mail address could not be delivered... Could you please contact me? Thanks, Jacopo Adrian Crum wrote: > Jacopo, > > Since no one has objected to this, could we get it committed? > > -Adrian > _______________________________________________ Dev mailing list [hidden email] http://lists.ofbiz.org/mailman/listinfo/dev |
Re: Dev - configurable custom views
|
|
In reply to this post by David E. Jones
David,
Only the patch that Jacopo attached. I created Jira 880 to show Si how I had already implemented something that he was considering adding to OFBiz. It was just there to show one way of doing it - I never intended it to be committed to the project. -Adrian David E. Jones wrote: > Adrian, Jacopo, > > Yeah, I think it's fine. Working with a List is easy enough that it shouldn't be a problem for anyone, and it's a lot more flexible. Thanks for pushing this guys, and sorry for not chiming in sooner. > > Is there a clean patch for this anywhere? Is the one included in these replies meant to be it? I took a peek at OFBIZ-880 and there are a number of files... which I guess are just meant to be copied in, but that also seems somewhat independent of this specific issue. Is that right? > > Anyway, let me know and I'll get it in. > > -David > > > Jacopo Cappellato wrote: > >>David, >> >>what do you think of this? >> >>Jacopo >> >>Adrian Crum wrote: >> >>>Jacopo, >>> >>>Since no one has objected to this, could we get it committed? >>> >>>-Adrian >>> >>> >>>Jacopo Cappellato wrote: >>> >>>>Adrian, >>>> >>>>about the styleSheet LIST issue: some time ago, David told me how to >>>>create lists inside a screen action tag: >>>> >>>><set field="styleSheets[]" value="/images/customstyles.css"/> >>>><set field="styleSheets[]" value="/images/specialcustomstyles.css"/> >>>> >>>>So this is no more an issue; it's ok for me to commit your changes. >>>> >>>>However, what do you (all) think of the attached patch? >>>> >>>>Jacopo >>>> >>>> >>>>Adrian Crum wrote: >>>> >>>> >>>>>It would be nice if - while you're mulling this over - someone could >>>>>at least commit the change to header.ftl >>>>>(http://jira.undersunconsulting.com/browse/OFBIZ-880 ). Just that >>>>>small change will enable a number of users to easily customize the UI. >>>>> >>>>>If that gets committed, there may be an issue with some of Jacopo's >>>>>work - since he had originally modified header.ftl for a single >>>>>alternative css file. The css file LIST that I proposed is preferable, >>>>>but Jacopo was unable to create a list in the screen widget (see the >>>>>notes on http://jira.undersunconsulting.com/browse/OFBIZ-174 ). In a >>>>>nutshell, whatever components use Jacopo's alternative css file will >>>>>have to be corrected to use a css file list. >>>>> >>>>>I would also like to thank Jacopo and anyone else who worked on Jira >>>>>174 to get the GlobalDecorator idea implemented. Without that work, a >>>>>user-selected UI theme would require a lot more modification. >>>>> >>>>>-Adrian >>>>> >>>> >>>>------------------------------------------------------------------------ >>>> >>>>Index: framework/common/webcommon/includes/header.ftl >>>>=================================================================== >>>>--- framework/common/webcommon/includes/header.ftl (revision 7592) >>>>+++ framework/common/webcommon/includes/header.ftl (working copy) >>>>@@ -41,8 +41,15 @@ >>>> <script language="javascript" src="<@ofbizContentUrl>/images/calendar1.js</@ofbizContentUrl>" type="text/javascript"></script> >>>> <script language="javascript" src="<@ofbizContentUrl>/images/selectall.js</@ofbizContentUrl>" type="text/javascript"></script> >>>> <script language="javascript" src="<@ofbizContentUrl>/images/fieldlookup.js</@ofbizContentUrl>" type="text/javascript"></script> >>>>- <link rel="stylesheet" href="<@ofbizContentUrl>/images/maincss.css</@ofbizContentUrl>" type="text/css"/> >>>>- <link rel="stylesheet" href="<@ofbizContentUrl>/images/tabstyles.css</@ofbizContentUrl>" type="text/css"/> >>>>+ <#if layoutSettings.styleSheets?has_content> >>>>+ <#--layoutSettings.styleSheets is a list of style sheets. So, you can have a user-specified "main" style sheet, AND a component style sheet.--> >>>>+ <#list layoutSettings.styleSheets as styleSheet> >>>>+ <link rel="stylesheet" href="<@ofbizContentUrl>${styleSheet}</@ofbizContentUrl>" type="text/css"> >>>>+ </#list> >>>>+ <#else> >>>>+ <link rel="stylesheet" href="<@ofbizContentUrl>/images/maincss.css</@ofbizContentUrl>" type="text/css"/> >>>>+ <link rel="stylesheet" href="<@ofbizContentUrl>/images/tabstyles.css</@ofbizContentUrl>" type="text/css"/> >>>>+ </#if> >>>> <#if layoutSettings.extraStyleSheet?exists> >>>> <#-- Component-specified style sheet --> >>>> <link rel="stylesheet" href="${layoutSettings.extraStyleSheet}" type="text/css"/> >>>> >>>> >>>>------------------------------------------------------------------------ >>>> >>>> >>>>_______________________________________________ >>>>Dev mailing list >>>>[hidden email] >>>>http://lists.ofbiz.org/mailman/listinfo/dev >>> >>> >>>_______________________________________________ >>>Dev mailing list >>>[hidden email] >>>http://lists.ofbiz.org/mailman/listinfo/dev >>> >> >> >>_______________________________________________ >>Dev mailing list >>[hidden email] >>http://lists.ofbiz.org/mailman/listinfo/dev > > > _______________________________________________ > Dev mailing list > [hidden email] > http://lists.ofbiz.org/mailman/listinfo/dev > _______________________________________________ Dev mailing list [hidden email] http://lists.ofbiz.org/mailman/listinfo/dev |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |