Draft Minutes from Skype Framework Re-Factor Call: 15th March 2016

[Sharan-F]

Hi Everyone

A huge thank you goes out to everyone who participated in the Framework Re-Factor Skype Group call yesterday. It was a very dynamic and active call and I hope it helped to get us focussed on our general approach and our next steps. There were a lot of good ideas and suggestions that came out - which is great.

I've written up the draft minutes from the call based on my notes on the following wiki page (so everyone please feel free to take a look though what was discussed)

https://cwiki.apache.org/confluence/display/OFBIZ/Skype+Re-Factor+Group+Call%3A+15th+March+2016

I hope that I've captured all the main points but just in case there is something missing that is important or I've misunderstood then please let me know.

Thanks
Sharan

[taher]

Hi Sharan,

Excellent write-up. The only thing I would add is that the complex
refactoring would include design changes to the API signatures which might
affect existing systems as was raised by Ron Wheeler.

Regards,

Taher Alkhateeb

-----Original Message-----
From: Sharan-F [mailto:[hidden email]]
Sent: 16 March 2016 11:43
To: [hidden email]
Subject: Draft Minutes from Skype Framework Re-Factor Call: 15th March 2016

Hi Everyone

A huge thank you goes out to everyone who participated in the Framework
Re-Factor Skype Group call yesterday. It was a very dynamic and active call
and I hope it helped to get us focussed on our general approach and our next
steps. There were a lot of good ideas and suggestions that came out - which
is great.

I've written up the draft minutes from the call based on my notes on the
following wiki page (so everyone please feel free to take a look though what
was discussed)

https://cwiki.apache.org/confluence/display/OFBIZ/Skype+Re-Factor+Group+Call
%3A+15th+March+2016

I hope that I've captured all the main points but just in case there is
something missing that is important or I've misunderstood then please let me
know.

Thanks
Sharan



--
View this message in context:
http://ofbiz.135035.n4.nabble.com/Draft-Minutes-from-Skype-Framework-Re-Fact
or-Call-15th-March-2016-tp4677836.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

[Ron Wheeler]

One of the issues that was identified as a problem with code quality is
the number of warnings in the code.

There are 340 warnings in the system at the moment.
Most of them seem to be things that will make the code less prone to
unintended consequences of changes.
They also give the impression that the code is of low quality and
written in a careless way.

It would be a big help if all developers could stop digging this hole
deeper.

If you are working on a piece of code and it has warning in it, fix them.
If the warning really is spurious, add a Suppress Warning annotation for
the specific problem.
If you are not sure about how to fix the warning, ask.

It would be really helpful if the committers made warnings a reason for
not approving a commit.

Ron


On 16/03/2016 7:25 AM, Taher Alkhateeb wrote:

> Hi Sharan,
>
> Excellent write-up. The only thing I would add is that the complex
> refactoring would include design changes to the API signatures which might
> affect existing systems as was raised by Ron Wheeler.
>
> Regards,
>
> Taher Alkhateeb
>
> -----Original Message-----
> From: Sharan-F [mailto:[hidden email]]
> Sent: 16 March 2016 11:43
> To: [hidden email]
> Subject: Draft Minutes from Skype Framework Re-Factor Call: 15th March 2016
>
> Hi Everyone
>
> A huge thank you goes out to everyone who participated in the Framework
> Re-Factor Skype Group call yesterday. It was a very dynamic and active call
> and I hope it helped to get us focussed on our general approach and our next
> steps. There were a lot of good ideas and suggestions that came out - which
> is great.
>
> I've written up the draft minutes from the call based on my notes on the
> following wiki page (so everyone please feel free to take a look though what
> was discussed)
>
> https://cwiki.apache.org/confluence/display/OFBIZ/Skype+Re-Factor+Group+Call
> %3A+15th+March+2016
>
> I hope that I've captured all the main points but just in case there is
> something missing that is important or I've misunderstood then please let me
> know.
>
> Thanks
> Sharan
>
>
>
> --
> View this message in context:
> http://ofbiz.135035.n4.nabble.com/Draft-Minutes-from-Skype-Framework-Re-Fact
> or-Call-15th-March-2016-tp4677836.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>
>

--
Ron Wheeler
President
Artifact Software Inc
email: [hidden email]
skype: ronaldmwheeler
phone: [phone], ext 102

[Sharan-F]

Hi Taher

Thanks for the feedback.I've updated the minutes with this detail.

Thanks
Sharan

[Sharan-F]

Hi Ron

Yes, this was talked about and these are great suggestions. I think it might be good to have this written down somewhere on the re-factoring wiki pages as recommendations that would help.

Also in general - it is also something that we could put into our developers best practice area so that new people coming on board have a good start. What do people think?

Thanks
Sharan