EmailTemplateSetting vs ProductStoreEmailSetting

[Malin Nicolas]

Hi all,

I analyse email notification in OFBiz to set a generic system for a crm
et project managment components.

We have two entity to manage email notification : EmailTemplateSetting
and ProductStoreEmailSetting. In OFBiz history, the first entity used
was ProductStoreEmailSetting, for automatic email during ecommerce
process and in last time the EmailTemplateSetting for specific notification.

Both entities have the same field : bodyScreenLocation,
xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject,
contentType. Just primary key are differents.

To simplify the notification system, I will suggest :
* use only EmailTemplateSetting to edit email configuration
* associate ProductStoreEmailSetting to EmailTemplateSetting
* convert all service and screen that use ProductStoreEmailSetting
* create convert service.
* add contentId on EmailTemplateSetting (hors templaceContentId) to use
a content for rendering email

If somebody are interest, I can open a jira issue to manage this
improvement.

Any suggest ?

Nicolas

[BJ Freeman]

I would like to hear why the EmailTemplateSetting was emplemented.
I am also concerned that the current production systems, with
customization would be effected.
so if this effort can be done so that it is transparent to production
servers, then I don't see a problem.

Nicolas Malin sent the following on 7/5/2011 6:10 AM:

> Hi all,
>
> I analyse email notification in OFBiz to set a generic system for a crm
> et project managment components.
>
> We have two entity to manage email notification : EmailTemplateSetting
> and ProductStoreEmailSetting. In OFBiz history, the first entity used
> was ProductStoreEmailSetting, for automatic email during ecommerce
> process and in last time the EmailTemplateSetting for specific
> notification.
>
> Both entities have the same field : bodyScreenLocation,
> xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject,
> contentType. Just primary key are differents.
>
> To simplify the notification system, I will suggest :
> * use only EmailTemplateSetting to edit email configuration
> * associate ProductStoreEmailSetting to EmailTemplateSetting
> * convert all service and screen that use ProductStoreEmailSetting
> * create convert service.
> * add contentId on EmailTemplateSetting (hors templaceContentId) to use
> a content for rendering email
>
> If somebody are interest, I can open a jira issue to manage this
> improvement.
>
> Any suggest ?
>
> Nicolas
>

[Scott Gray-2]

I'm sure there is an open jira issue around somewhere that is relevant to this discussion.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 6/07/2011, at 3:13 AM, BJ Freeman wrote:

> I would like to hear why the EmailTemplateSetting was emplemented.
> I am also concerned that the current production systems, with
> customization would be effected.
> so if this effort can be done so that it is transparent to production
> servers, then I don't see a problem.
>
> Nicolas Malin sent the following on 7/5/2011 6:10 AM:
>> Hi all,
>>
>> I analyse email notification in OFBiz to set a generic system for a crm
>> et project managment components.
>>
>> We have two entity to manage email notification : EmailTemplateSetting
>> and ProductStoreEmailSetting. In OFBiz history, the first entity used
>> was ProductStoreEmailSetting, for automatic email during ecommerce
>> process and in last time the EmailTemplateSetting for specific
>> notification.
>>
>> Both entities have the same field : bodyScreenLocation,
>> xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject,
>> contentType. Just primary key are differents.
>>
>> To simplify the notification system, I will suggest :
>> * use only EmailTemplateSetting to edit email configuration
>> * associate ProductStoreEmailSetting to EmailTemplateSetting
>> * convert all service and screen that use ProductStoreEmailSetting
>> * create convert service.
>> * add contentId on EmailTemplateSetting (hors templaceContentId) to use
>> a content for rendering email
>>
>> If somebody are interest, I can open a jira issue to manage this
>> improvement.
>>
>> Any suggest ?
>>
>> Nicolas
>>

[Malin Nicolas]

Ok I create a jira issue.

This refactoring isn't easier. I propose to advanced step by step.
1. refactoring entities
2. refactoring service
3. impact modification on exist code
4. create service data migration
5. update screen

Nicolas

Le 06/07/2011 00:58, Scott Gray a écrit :

> I'm sure there is an open jira issue around somewhere that is relevant to this discussion.
>
> Regards
> Scott
>
> HotWax Media
> http://www.hotwaxmedia.com
>
> On 6/07/2011, at 3:13 AM, BJ Freeman wrote:
>
>> I would like to hear why the EmailTemplateSetting was emplemented.
>> I am also concerned that the current production systems, with
>> customization would be effected.
>> so if this effort can be done so that it is transparent to production
>> servers, then I don't see a problem.
>>
>> Nicolas Malin sent the following on 7/5/2011 6:10 AM:
>>> Hi all,
>>>
>>> I analyse email notification in OFBiz to set a generic system for a crm
>>> et project managment components.
>>>
>>> We have two entity to manage email notification : EmailTemplateSetting
>>> and ProductStoreEmailSetting. In OFBiz history, the first entity used
>>> was ProductStoreEmailSetting, for automatic email during ecommerce
>>> process and in last time the EmailTemplateSetting for specific
>>> notification.
>>>
>>> Both entities have the same field : bodyScreenLocation,
>>> xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject,
>>> contentType. Just primary key are differents.
>>>
>>> To simplify the notification system, I will suggest :
>>> * use only EmailTemplateSetting to edit email configuration
>>> * associate ProductStoreEmailSetting to EmailTemplateSetting
>>> * convert all service and screen that use ProductStoreEmailSetting
>>> * create convert service.
>>> * add contentId on EmailTemplateSetting (hors templaceContentId) to use
>>> a content for rendering email
>>>
>>> If somebody are interest, I can open a jira issue to manage this
>>> improvement.
>>>
>>> Any suggest ?
>>>
>>> Nicolas
>>>

--
Nicolas MALIN
Consultant
Tél : [phone]
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : [phone]
Site : http://www.librenberry.net/

[Scott Gray-2]

Found it: https://issues.apache.org/jira/browse/OFBIZ-3894

Regards
Scott

On 7/07/2011, at 8:33 PM, Nicolas Malin wrote:

> Ok I create a jira issue.
>
> This refactoring isn't easier. I propose to advanced step by step.
> 1. refactoring entities
> 2. refactoring service
> 3. impact modification on exist code
> 4. create service data migration
> 5. update screen
>
> Nicolas
>
> Le 06/07/2011 00:58, Scott Gray a écrit :
>> I'm sure there is an open jira issue around somewhere that is relevant to this discussion.
>>
>> Regards
>> Scott
>>
>> HotWax Media
>> http://www.hotwaxmedia.com
>>
>> On 6/07/2011, at 3:13 AM, BJ Freeman wrote:
>>
>>> I would like to hear why the EmailTemplateSetting was emplemented.
>>> I am also concerned that the current production systems, with
>>> customization would be effected.
>>> so if this effort can be done so that it is transparent to production
>>> servers, then I don't see a problem.
>>>
>>> Nicolas Malin sent the following on 7/5/2011 6:10 AM:
>>>> Hi all,
>>>>
>>>> I analyse email notification in OFBiz to set a generic system for a crm
>>>> et project managment components.
>>>>
>>>> We have two entity to manage email notification : EmailTemplateSetting
>>>> and ProductStoreEmailSetting. In OFBiz history, the first entity used
>>>> was ProductStoreEmailSetting, for automatic email during ecommerce
>>>> process and in last time the EmailTemplateSetting for specific
>>>> notification.
>>>>
>>>> Both entities have the same field : bodyScreenLocation,
>>>> xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject,
>>>> contentType. Just primary key are differents.
>>>>
>>>> To simplify the notification system, I will suggest :
>>>> * use only EmailTemplateSetting to edit email configuration
>>>> * associate ProductStoreEmailSetting to EmailTemplateSetting
>>>> * convert all service and screen that use ProductStoreEmailSetting
>>>> * create convert service.
>>>> * add contentId on EmailTemplateSetting (hors templaceContentId) to use
>>>> a content for rendering email
>>>>
>>>> If somebody are interest, I can open a jira issue to manage this
>>>> improvement.
>>>>
>>>> Any suggest ?
>>>>
>>>> Nicolas
>>>>
>
>
> --
> Nicolas MALIN
> Consultant
> Tél : [phone]
> Site projet : http://www.neogia.org/
> -------
> Société LibrenBerry
> Tél : [phone]
> Site : http://www.librenberry.net/
>

[Malin Nicolas]

Oh Sorry Scott, I realize that I didn't understand your previous message :/
My purpose is to cover your dream ;)
I check your analyze and modify my previous patch.

What's your prefer ? I close OFBIZ-4333 or change it to OFBIZ-3894 sub-task

Nicolas


Le 07/07/2011 12:51, Scott Gray a écrit :

> Found it:https://issues.apache.org/jira/browse/OFBIZ-3894
>
> Regards
> Scott
>
> On 7/07/2011, at 8:33 PM, Nicolas Malin wrote:
>
>> Ok I create a jira issue.
>>
>> This refactoring isn't easier. I propose to advanced step by step.
>> 1. refactoring entities
>> 2. refactoring service
>> 3. impact modification on exist code
>> 4. create service data migration
>> 5. update screen
>>
>> Nicolas
>>
>> Le 06/07/2011 00:58, Scott Gray a écrit :
>>> I'm sure there is an open jira issue around somewhere that is relevant to this discussion.
>>>
>>> Regards
>>> Scott
>>>
>>> HotWax Media
>>> http://www.hotwaxmedia.com
>>>
>>> On 6/07/2011, at 3:13 AM, BJ Freeman wrote:
>>>
>>>> I would like to hear why the EmailTemplateSetting was emplemented.
>>>> I am also concerned that the current production systems, with
>>>> customization would be effected.
>>>> so if this effort can be done so that it is transparent to production
>>>> servers, then I don't see a problem.
>>>>
>>>> Nicolas Malin sent the following on 7/5/2011 6:10 AM:
>>>>> Hi all,
>>>>>
>>>>> I analyse email notification in OFBiz to set a generic system for a crm
>>>>> et project managment components.
>>>>>
>>>>> We have two entity to manage email notification : EmailTemplateSetting
>>>>> and ProductStoreEmailSetting. In OFBiz history, the first entity used
>>>>> was ProductStoreEmailSetting, for automatic email during ecommerce
>>>>> process and in last time the EmailTemplateSetting for specific
>>>>> notification.
>>>>>
>>>>> Both entities have the same field : bodyScreenLocation,
>>>>> xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject,
>>>>> contentType. Just primary key are differents.
>>>>>
>>>>> To simplify the notification system, I will suggest :
>>>>> * use only EmailTemplateSetting to edit email configuration
>>>>> * associate ProductStoreEmailSetting to EmailTemplateSetting
>>>>> * convert all service and screen that use ProductStoreEmailSetting
>>>>> * create convert service.
>>>>> * add contentId on EmailTemplateSetting (hors templaceContentId) to use
>>>>> a content for rendering email
>>>>>
>>>>> If somebody are interest, I can open a jira issue to manage this
>>>>> improvement.
>>>>>
>>>>> Any suggest ?
>>>>>
>>>>> Nicolas
>>>>>
>> --
>> Nicolas MALIN
>> Consultant
>> Tél : [phone]
>> Site projet :http://www.neogia.org/
>> -------
>> Société LibrenBerry
>> Tél : [phone]
>> Site :http://www.librenberry.net/
>>

--
Nicolas MALIN
Consultant
Tél : [phone]
Site projet :http://www.neogia.org/
-------
Société LibrenBerry
Tél : [phone]
Site :http://www.librenberry.net/