Events Modeling.

[BJ Freeman]

My understanding is that and event is called through the controller then
return an error or Success that the controller processes.

HumanResEvents.toJsonObjectList() seems to break this model by having UI
processing.
should not this be done in a view?

[Jacques Le Roux]

From: "BJ Freeman" <[hidden email]>
> My understanding is that and event is called through the controller then
> return an error or Success that the controller processes.

Yes, or actually the controller can process which ever string the event returns
 
> HumanResEvents.toJsonObjectList() seems to break this model by having UI
> processing.
> should not this be done in a view?

Not sure about that because this way of doing is not new in OFBiz, but

I updated the .classpath in r1164844

The toJsonObjectList() method is duplicated in HumanResEvents, CategoryServices

There are also 2 other almost same duplicates in ImageManagementServices and EbayStoreOptions. They are older than the ones aboves

I think it's time to refactor all this in a sole and unique method in common...

Jacques

[BJ Freeman]

it is difficult to use other UI interfaces when it is buried in the code
instead of using the modeling of views, in my opinion.

it is ok if other forms of UI is used but should be at the same level
that uses Widget, FTL to generate the UI output.

instead of common would it not be better to put in the Jason section
defined in the Controllers?
The setup a view for Jason, sorry I have not followed Jason to know
enough to recommend the best way.

Jacques Le Roux sent the following on 9/3/2011 4:04 AM:

> From: "BJ Freeman" <[hidden email]>
>> My understanding is that and event is called through the controller then
>> return an error or Success that the controller processes.
>
> Yes, or actually the controller can process which ever string the event
> returns
>
>> HumanResEvents.toJsonObjectList() seems to break this model by having UI
>> processing.
>> should not this be done in a view?
>
> Not sure about that because this way of doing is not new in OFBiz, but
>
> I updated the .classpath in r1164844
>
> The toJsonObjectList() method is duplicated in HumanResEvents,
> CategoryServices
>
> There are also 2 other almost same duplicates in ImageManagementServices
> and EbayStoreOptions. They are older than the ones aboves
>
> I think it's time to refactor all this in a sole and unique method in
> common...
>
> Jacques
>
>

[BJ Freeman]

from the framework\common\webcommon\WEB-INF\common-controller.xml
<!-- These event handlers have been deprecated, if you need to send json
responses then chain
         the json request from this controller after calling your event

BJ Freeman sent the following on 9/3/2011 9:03 AM:

> it is difficult to use other UI interfaces when it is buried in the code
> instead of using the modeling of views, in my opinion.
>
> it is ok if other forms of UI is used but should be at the same level
> that uses Widget, FTL to generate the UI output.
>
> instead of common would it not be better to put in the Jason section
> defined in the Controllers?
> The setup a view for Jason, sorry I have not followed Jason to know
> enough to recommend the best way.
>
> Jacques Le Roux sent the following on 9/3/2011 4:04 AM:
>> From: "BJ Freeman" <[hidden email]>
>>> My understanding is that and event is called through the controller then
>>> return an error or Success that the controller processes.
>>
>> Yes, or actually the controller can process which ever string the event
>> returns
>>
>>> HumanResEvents.toJsonObjectList() seems to break this model by having UI
>>> processing.
>>> should not this be done in a view?
>>
>> Not sure about that because this way of doing is not new in OFBiz, but
>>
>> I updated the .classpath in r1164844
>>
>> The toJsonObjectList() method is duplicated in HumanResEvents,
>> CategoryServices
>>
>> There are also 2 other almost same duplicates in ImageManagementServices
>> and EbayStoreOptions. They are older than the ones aboves
>>
>> I think it's time to refactor all this in a sole and unique method in
>> common...
>>
>> Jacques
>>
>>
>