FIX:

[Jacques Le Roux]

Hi Adam,

I just finished to review your recent commits, parallel stuff looks promising. Do you intend to backport the "FIX:" ?

Also running for the 1st time, I don't think we need to show lines like

2011-07-01 08:15:32,484 (main) [  CatalinaContainer.java:510:INFO ]
createContext(org.ofbiz.base.component.ComponentConfig$WebappInfo@678ef3)

It does not give use any usable information

Also maybe we can improve
Warning : Module classpath component '"C:\Program Files\Java\jdk1.6.0_22\lib\tools.jar"' is not valid and will be ignored...
Warning : Module classpath component '"C:\Program Files\Java\jdk1.6.0_22\jre\lib\comm.jar"' is not valid and will be ignored...
Warning : Module classpath component 'C:\WINDOWS\Sun\Java\bin' is not valid and will be ignored...
Warning : Module classpath component 'C:\Program Files\Intel\DMIX' is not valid and will be ignored...
Warning : Module classpath component 'C:\Program Files\QuickTime Alternative\QTSystem' is not valid and will be ignored...
Warning : Module classpath component 'C:\Program Files\ktl20sta' is not valid and will be ignored...
Warning : Module classpath component 'C:\Program Files\OpenSSL\out32dll' is not valid and will be ignored...


Jacques

[Adam Heath-2]

On 07/01/2011 01:43 AM, Jacques Le Roux wrote:
> Hi Adam,
>
> I just finished to review your recent commits, parallel stuff looks
> promising. Do you intend to backport the "FIX:" ?

Thank's for the reviews.  Yes, we probably should backport the fixes.
  Most of those were developed on 902021(which has other fixes and
features, it's what we are currently using at brainfood).

>
> Also running for the 1st time, I don't think we need to show lines like
>
> 2011-07-01 08:15:32,484 (main) [ CatalinaContainer.java:510:INFO ]
> createContext(org.ofbiz.base.component.ComponentConfig$WebappInfo@678ef3)
 >
 > It does not give use any usable information

Oops, yeah, that's pure debug.  I'll queue up a commit to remove it.


>
> Also maybe we can improve

Probably.  Suggestions?

> Warning : Module classpath component '"C:\Program
> Files\Java\jdk1.6.0_22\lib\tools.jar"' is not valid and will be ignored...
> Warning : Module classpath component '"C:\Program
> Files\Java\jdk1.6.0_22\jre\lib\comm.jar"' is not valid and will be
> ignored...

framework/start adds these.  Maybe it should test for their existance
first.

> Warning : Module classpath component 'C:\WINDOWS\Sun\Java\bin' is not
> valid and will be ignored...
> Warning : Module classpath component 'C:\Program Files\Intel\DMIX' is
> not valid and will be ignored...
> Warning : Module classpath component 'C:\Program Files\QuickTime
> Alternative\QTSystem' is not valid and will be ignored...
> Warning : Module classpath component 'C:\Program Files\ktl20sta' is not
> valid and will be ignored...
> Warning : Module classpath component 'C:\Program Files\OpenSSL\out32dll'
> is not valid and will be ignored...

Something on your system is doing this.  Did you install some app in
windows, then remove it, and it didn't clean up after itself?  Or did
an app upgrade, and not do it correctly?

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>
> On 07/01/2011 01:43 AM, Jacques Le Roux wrote:
>> Hi Adam,
>>
>> I just finished to review your recent commits, parallel stuff looks
>> promising. Do you intend to backport the "FIX:" ?
>
> Thank's for the reviews.  Yes, we probably should backport the fixes.
>  Most of those were developed on 902021(which has other fixes and
> features, it's what we are currently using at brainfood).

Will you handle it?

Jacques

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>
> On 07/01/2011 01:43 AM, Jacques Le Roux wrote:
>> Hi Adam,
>>
>> I just finished to review your recent commits, parallel stuff looks
>> Also maybe we can improve
>
> Probably.  Suggestions?

I meant with things below

>> Warning : Module classpath component '"C:\Program
>> Files\Java\jdk1.6.0_22\lib\tools.jar"' is not valid and will be ignored...
>> Warning : Module classpath component '"C:\Program
>> Files\Java\jdk1.6.0_22\jre\lib\comm.jar"' is not valid and will be
>> ignored...
>
> framework/start adds these.  Maybe it should test for their existance
> first.
>
>> Warning : Module classpath component 'C:\WINDOWS\Sun\Java\bin' is not
>> valid and will be ignored...
>> Warning : Module classpath component 'C:\Program Files\Intel\DMIX' is
>> not valid and will be ignored...
>> Warning : Module classpath component 'C:\Program Files\QuickTime
>> Alternative\QTSystem' is not valid and will be ignored...
>> Warning : Module classpath component 'C:\Program Files\ktl20sta' is not
>> valid and will be ignored...
>> Warning : Module classpath component 'C:\Program Files\OpenSSL\out32dll'
>> is not valid and will be ignored...
>
> Something on your system is doing this.  Did you install some app in
> windows, then remove it, and it didn't clean up after itself?  Or did
> an app upgrade, and not do it correctly?

Those exist, thought I don't use both intel-xss.jar anymore, but they are correctly(?) installed on my system (XP)
C:\Program Files\Intel\XMLSoftwareSuite\Java\1.2\lib\intel-xss.jar
C:\Program Files\Intel\XMLSoftwareSuite\Java\1.0\Lib\intel-xss.jar

I think I added those by hand, not sure. They still exist
C:\Program Files\Java\jdk1.6.0_22\lib\tools.jar
C:\Program Files\Java\jdk1.6.0_22\jre\lib\comm.jar

This one was in my CLASSPATH var in env but no longer on disk, I removed it from CLASSPATH var
C:\Program Files\ktl20sta\rc15ktl.jar

I had those invalid in my path, removed
C:\Program Files\Intel\DMIX
C:\Program Files\QuickTime Alternative\QTSystem
C:\Program Files\OpenSSL\out32dll
C:\Program Files\ktl20sta

Don't know where come this (I mean not in var/env)
C:\WINDOWS\Sun\Java\bin

So I have now
[java] Warning : Module classpath component '"C:\Program Files\Java\jdk1.6.0_22\lib\tools.jar"' is not valid and will be ignored...
[java] Warning : Module classpath component '"C:\Program Files\Java\jdk1.6.0_22\jre\lib\comm.jar"' is not valid and will be
ignored...
[java] Warning : Module classpath component 'C:\WINDOWS\Sun\Java\bin' is not valid and will be ignored...

So, though I did not change anything for  intel-xss.jarS, I don't see them anymore

Thanks

Jacques

[Adam Heath-2]

On 07/03/2011 01:03 AM, Jacques Le Roux wrote:

> From: "Adam Heath" <[hidden email]>
>> On 07/01/2011 01:43 AM, Jacques Le Roux wrote:
>>> Hi Adam,
>>>
>>> I just finished to review your recent commits, parallel stuff looks
>>> promising. Do you intend to backport the "FIX:" ?
>>
>> Thank's for the reviews. Yes, we probably should backport the fixes.
>> Most of those were developed on 902021(which has other fixes and
>> features, it's what we are currently using at brainfood).
>
> Will you handle it?

Yeah.  I'm just reworking mergefromtrunk.sh to support git in a much
nicer way.  I can use the same set of cmdline args(to that script),
but instead of directly committing, it'll queue up in git.  Then, I
can test all the changes one after the other in a loop(using git
rebase).  Then commit all at once.

Currently, I have to merge, run the test, then commit, and that takes
me more time.  Whereas with my new way, I can use a block of time just
for the merging(and fixing any conflicts), then walk away from it
while all the tests run on each change.