File name pattern (Fwd: svn commit: r822169 - in /ofbiz/trunk/applications/mark
Locked
File name pattern (Fwd: svn commit: r822169 - in /ofbiz/trunk/applications/mark
 
|
Re: File name pattern (Fwd: svn commit: r822169 - in /ofbiz/trunk/applications/mark
|
|
Re: File name pattern (Fwd: svn commit: r822169 - in /ofbiz/trunk/applications/mark
|
Re: File name pattern (Fwd: svn commit: r822169 - in /ofbiz/trunk/applications/mark
Administrator
|
Re: File name pattern (Fwd: svn commit: r822169 - in /ofbiz/trunk/applications/mark
|
|
Re: File name pattern (Fwd: svn commit: r822169 - in /ofbiz/trunk/applications/mark
|
|
Re: File name pattern (Fwd: svn commit: r822169 - in /ofbiz/trunk/applications/mark
|
|
We already have a convention in place that can be seen at framework/
service/testdef/data/ There is a slight difference here in that the data in that folder is loaded at test time rather than during an installation. I haven't looked at the selenium stuff yet but it seems a little strange to me that the location of test files is being stored in the database rather than how our other tests are setup to be defined in an xml file. Does it have some sort of functionality to create and store tests at runtime? If so, very cool! About the file name my preference would be to add a subfolder to testdef such as selenium so the file would look something like this: applications/marketing/testdef/selenium/CommEventCreateOpportunity.xml That would keep what could be a potentially large number of files separate from our unit test definitions. Anyway just my 2 cents and thanks for your work Hans (and Brett) it's great to see some more effort going into testing. Regards Scott On 7/10/2009, at 10:53 PM, Vikas Mayur wrote: > Thanks Jacques, I hope people would not mind this big change with > existing file renaming. Any other opinions? > > Vikas > > On Oct 7, 2009, at 2:25 PM, Jacques Le Roux wrote: > >> I will vote for having, at least, the word data in all data files >> >> Jacques >> >> From: "Vikas Mayur" <[hidden email]> >>> +1 >>> >>> Btw, I also see issues with test data file location. Since it is >>> just a data file I think it should be in data folder and not >>> testdef. >>> >>> I think we should also discuss about the naming pattern of data >>> files, most of the files end with suffix Data but this pattern is >>> not followed strictly. >>> >>> Any thoughts? >>> >>> Vikas >>> >>> On Oct 7, 2009, at 1:19 AM, Anil Patel wrote: >>> >>>> Hi, >>>> I have problem with the naming of >>>> commeventCreateOpportunity_testsuite.xml >>>> >>>> This should be rather named commEventCreateOpportunityTests.xml. >>>> I don't see reason why we cannot stick to file naming >>>> conventions already in place. Its important indicator of quality >>>> of product. >>>> >>>> Thanks and Regards >>>> Anil Patel >>>> HotWax Media Inc >>>> http://www.hotwaxmedia.com >>>> >>>> Begin forwarded message: >>>> >>>>> From: [hidden email] >>>>> Date: October 6, 2009 4:47:36 AM EDT >>>>> To: [hidden email] >>>>> Subject: svn commit: r822169 - in /ofbiz/trunk/applications/ >>>>> marketing: ofbiz-component.xml testdef/MarketingTests.xml >>>>> testdef/ SeleniumTests.xml testdef/ >>>>> commeventCreateOpportunity_testsuite.xml >>>>> Reply-To: [hidden email] >>>>> >>>>> Author: hansbak >>>>> Date: Tue Oct 6 08:47:35 2009 >>>>> New Revision: 822169 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=822169&view=rev >>>>> Log: >>>>> added a selenium test when a opportunity is created from an email >>>>> >>>>> Added: >>>>> ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml >>>>> (with props) >>>>> ofbiz/trunk/applications/marketing/testdef/ >>>>> commeventCreateOpportunity_testsuite.xml (with props) >>>>> Modified: >>>>> ofbiz/trunk/applications/marketing/ofbiz-component.xml >>>>> ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml >>>>> >>>>> Modified: ofbiz/trunk/applications/marketing/ofbiz-component.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/ofbiz-component.xml?rev=822169&r1=822168&r2=822169&view=diff >>>>> = = = = = = = = = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/ofbiz-component.xml >>>>> (original) >>>>> +++ ofbiz/trunk/applications/marketing/ofbiz-component.xml Tue >>>>> Oct 6 08:47:35 2009 >>>>> @@ -30,6 +30,7 @@ >>>>> <entity-resource type="data" reader-name="seed" loader="main" >>>>> location="data/MarketingSecurityData.xml"/> >>>>> <entity-resource type="data" reader-name="seed" loader="main" >>>>> location="data/MarketingHelpData.xml"/> >>>>> <entity-resource type="data" reader-name="demo" loader="main" >>>>> location="data/sfaDemoData.xml"/> >>>>> + <entity-resource type="data" reader-name="demo" >>>>> loader="main" location="testdef/SeleniumTests.xml"/> >>>>> <service-resource type="model" loader="main" >>>>> location="servicedef/services.xml"/> >>>>> <service-resource type="model" loader="main" >>>>> location="servicedef/services_opportunity.xml"/> >>>>> <service-resource type="eca" loader="main" >>>>> location="servicedef/ secas.xml"/> >>>>> >>>>> Modified: ofbiz/trunk/applications/marketing/testdef/ >>>>> MarketingTests.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/MarketingTests.xml?rev=822169&r1=822168&r2=822169&view=diff >>>>> = = = = = = = = = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/testdef/ >>>>> MarketingTests.xml (original) >>>>> +++ ofbiz/trunk/applications/marketing/testdef/ >>>>> MarketingTests.xml Tue Oct 6 08:47:35 2009 >>>>> @@ -1,3 +1,4 @@ >>>>> +<?xml version="1.0" encoding="UTF-8"?> >>>>> <!-- >>>>> Licensed to the Apache Software Foundation (ASF) under one >>>>> or more contributor license agreements. See the NOTICE file >>>>> @@ -16,7 +17,6 @@ >>>>> specific language governing permissions and limitations >>>>> under the License. >>>>> --> >>>>> - >>>>> <test-suite suite-name="marketingtests" >>>>> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" >>>>> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/test-suite.xsd >>>>> "> >>>>> >>>>> Added: ofbiz/trunk/applications/marketing/testdef/ >>>>> SeleniumTests.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/SeleniumTests.xml?rev=822169&view=auto >>>>> = = = = = = = = = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/testdef/ >>>>> SeleniumTests.xml (added) >>>>> +++ ofbiz/trunk/applications/marketing/testdef/ >>>>> SeleniumTests.xml Tue Oct 6 08:47:35 2009 >>>>> @@ -0,0 +1,22 @@ >>>>> +<?xml version="1.0" encoding="UTF-8"?> >>>>> +<!-- >>>>> +Licensed to the Apache Software Foundation (ASF) under one >>>>> +or more contributor license agreements. See the NOTICE file >>>>> +distributed with this work for additional information >>>>> +regarding copyright ownership. The ASF licenses this file >>>>> +to you under the Apache License, Version 2.0 (the >>>>> +"License"); you may not use this file except in compliance >>>>> +with the License. You may obtain a copy of the License at >>>>> + >>>>> +http://www.apache.org/licenses/LICENSE-2.0 >>>>> + >>>>> +Unless required by applicable law or agreed to in writing, >>>>> +software distributed under the License is distributed on an >>>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>>>> +KIND, either express or implied. See the License for the >>>>> +specific language governing permissions and limitations >>>>> +under the License. >>>>> +--> >>>>> +<entity-engine-xml> >>>>> + <SeleniumTestSuitePath testSuiteId="COMMOPP_TESTSUITE" >>>>> testSuiteName="commeventopportunity_testsuite" >>>>> testSuitePath="applications/marketing/testdef/ >>>>> commeventCreateOpportunity_testsuite.xml" description="test >>>>> suite for create opportunity from communications event"/> >>>>> +</entity-engine-xml> >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/testdef/ >>>>> SeleniumTests.xml >>>>> ------------------------------------------------------------------------------ >>>>> svn:eol-style = native >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/testdef/ >>>>> SeleniumTests.xml >>>>> ------------------------------------------------------------------------------ >>>>> svn:keywords = "Date Rev Author URL Id" >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/testdef/ >>>>> SeleniumTests.xml >>>>> ------------------------------------------------------------------------------ >>>>> svn:mime-type = text/xml >>>>> >>>>> Added: ofbiz/trunk/applications/marketing/testdef/ >>>>> commeventCreateOpportunity_testsuite.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/testdef/commeventCreateOpportunity_testsuite.xml?rev=822169&view=auto >>>>> = = = = = = = = = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/marketing/testdef/ >>>>> commeventCreateOpportunity_testsuite.xml (added) >>>>> +++ ofbiz/trunk/applications/marketing/testdef/ >>>>> commeventCreateOpportunity_testsuite.xml Tue Oct 6 08:47:35 2009 >>>>> @@ -0,0 +1,49 @@ >>>>> +<?xml version="1.0" encoding="UTF-8"?> >>>>> +<!-- >>>>> +Licensed to the Apache Software Foundation (ASF) under one >>>>> +or more contributor license agreements. See the NOTICE file >>>>> +distributed with this work for additional information >>>>> +regarding copyright ownership. The ASF licenses this file >>>>> +to you under the Apache License, Version 2.0 (the >>>>> +"License"); you may not use this file except in compliance >>>>> +with the License. You may obtain a copy of the License at >>>>> + >>>>> +http://www.apache.org/licenses/LICENSE-2.0 >>>>> + >>>>> +Unless required by applicable law or agreed to in writing, >>>>> +software distributed under the License is distributed on an >>>>> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>>>> +KIND, either express or implied. See the License for the >>>>> +specific language governing permissions and limitations >>>>> +under the License. >>>>> +--> >>>>> + >>>>> +<testcase> >>>>> + <open value="/partymgr/control/logout" /> >>>>> + <waitForPageToLoad value="30000" /> >>>>> + <type name="USERNAME" value="admin" /> >>>>> + <type name="PASSWORD" value="ofbiz" /> >>>>> + <click locator="//input[@value='Login']" /> >>>>> + <waitForPageToLoad value="50000" /> >>>>> + <getBodyText out="bodyText"/> >>>>> + <getHtmlSource out="htmlSource"/> >>>>> + <click locator="link=Communications" /> >>>>> + <waitForPageToLoad value="50000" /> >>>>> + <click locator="link=New Communication" /> >>>>> + <waitForPageToLoad value="50000" /> >>>>> + <select locator="EditCommEvent_communicationEventTypeId" >>>>> option="label=Email" /> >>>>> + <select locator="EditCommEvent_statusId" >>>>> option="label=Entered" /> >>>>> + <type name="partyIdFrom" value="DemoCustomer" /> >>>>> + <type name="partyIdTo" value="admin" /> >>>>> + <select locator="EditCommEvent_contactMechTypeId" >>>>> option="label=Internal Note via partyId" /> >>>>> + <type name="EditCommEvent_subject" value="Test send >>>>> Internal note" /> >>>>> + <type name="EditCommEvent_content" value="Send from >>>>> democustomer to admin " /> >>>>> + <click locator="submitButton" /> >>>>> + <waitForPageToLoad value="50000" /> >>>>> + <click locator="link=Create Opportunity" /> >>>>> + <waitForPageToLoad value="50000" /> >>>>> + <click locator="//input[@name='submitButton' and >>>>> @value='Save']" /> >>>>> + <waitForPageToLoad value="50000" /> >>>>> + <click locator="link=Communications" /> >>>>> + <waitForPageToLoad value="50000" /> >>>>> +</testcase> >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/testdef/ >>>>> commeventCreateOpportunity_testsuite.xml >>>>> ------------------------------------------------------------------------------ >>>>> svn:eol-style = native >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/testdef/ >>>>> commeventCreateOpportunity_testsuite.xml >>>>> ------------------------------------------------------------------------------ >>>>> svn:keywords = "Date Rev Author URL Id" >>>>> >>>>> Propchange: ofbiz/trunk/applications/marketing/testdef/ >>>>> commeventCreateOpportunity_testsuite.xml >>>>> ------------------------------------------------------------------------------ >>>>> svn:mime-type = text/xml >>>>> >>>>> >>>> >> >> > |
smime.p7s (3K) | Free forum by Nabble | Edit this page |