FindBugs for Groovy?

[Michael Brohl-3]

Hi all,

we are heavily doing code analysis with FindBugs and made progress with
the Java packages, see [1].

We have decided to convert mini lang to Groovy files and it seems that
people start writing new services using the Groovy DSL. I see one
drawback that we cannot use static code analysis tools to check code
quality.

Does someone know a way compatible with OFBiz to also analyze Groovy files?

Any hint is appreciated.

Thanks,

Michael


[1] https://issues.apache.org/jira/browse/OFBIZ-9450

[taher]

Hi Michael,

Why not naybe something like codenarc [1]. They have a gradle builtin
plugin [2].
[1] http://codenarc.sourceforge.net/
[2] https://docs.gradle.org/current/userguide/codenarc_plugin.html

On Oct 12, 2017 12:59 PM, "Michael Brohl" <[hidden email]> wrote:

> Hi all,
>
> we are heavily doing code analysis with FindBugs and made progress with
> the Java packages, see [1].
>
> We have decided to convert mini lang to Groovy files and it seems that
> people start writing new services using the Groovy DSL. I see one drawback
> that we cannot use static code analysis tools to check code quality.
>
> Does someone know a way compatible with OFBiz to also analyze Groovy files?
>
> Any hint is appreciated.
>
> Thanks,
>
> Michael
>
>
> [1] https://issues.apache.org/jira/browse/OFBIZ-9450
>
>
>
>

[Michael Brohl-3]

Hi Taher,

yes, this would be a solution but I remembered Jacques having problems
to make it work with OFBiz [1].

I'll pick up the thread to get to know the problem.

Thanks,

Michael


[1]
https://lists.apache.org/thread.html/40240117ca0e24ef3f4b14a3c6c7c491a49b4071dfe08923cd4751a8@%3Cdev.ofbiz.apache.org%3E


Am 12.10.17 um 12:05 schrieb Taher Alkhateeb:

> Hi Michael,
>
> Why not naybe something like codenarc [1]. They have a gradle builtin
> plugin [2].
> [1] http://codenarc.sourceforge.net/
> [2] https://docs.gradle.org/current/userguide/codenarc_plugin.html
>
> On Oct 12, 2017 12:59 PM, "Michael Brohl" <[hidden email]> wrote:
>
>> Hi all,
>>
>> we are heavily doing code analysis with FindBugs and made progress with
>> the Java packages, see [1].
>>
>> We have decided to convert mini lang to Groovy files and it seems that
>> people start writing new services using the Groovy DSL. I see one drawback
>> that we cannot use static code analysis tools to check code quality.
>>
>> Does someone know a way compatible with OFBiz to also analyze Groovy files?
>>
>> Any hint is appreciated.
>>
>> Thanks,
>>
>> Michael
>>
>>
>> [1] https://issues.apache.org/jira/browse/OFBIZ-9450
>>
>>
>>
>>

[taher]

Oh, without digging into details it's probably not going to be easy.
Not because the tool is insufficient but because of problems in the
way we integrate groovy in OFBiz. It's not standardized, and we use it
as a DSL with code snippets scattered around. Ideally, our groovy code
should reside for example in src/main/groovy and src/test/groovy for
example whereas we have it in non-standard locations both in webapps
and in other directories.

I could be wrong but I suspect that it would not be easy to find a
solution out of the box because of the unusual setup I mentioned
above.

On Thu, Oct 12, 2017 at 1:42 PM, Michael Brohl <[hidden email]> wrote:

> Hi Taher,
>
> yes, this would be a solution but I remembered Jacques having problems to
> make it work with OFBiz [1].
>
> I'll pick up the thread to get to know the problem.
>
> Thanks,
>
> Michael
>
>
> [1]
> https://lists.apache.org/thread.html/40240117ca0e24ef3f4b14a3c6c7c491a49b4071dfe08923cd4751a8@%3Cdev.ofbiz.apache.org%3E
>
>
> Am 12.10.17 um 12:05 schrieb Taher Alkhateeb:
>
>> Hi Michael,
>>
>> Why not naybe something like codenarc [1]. They have a gradle builtin
>> plugin [2].
>> [1] http://codenarc.sourceforge.net/
>> [2] https://docs.gradle.org/current/userguide/codenarc_plugin.html
>>
>> On Oct 12, 2017 12:59 PM, "Michael Brohl" <[hidden email]>
>> wrote:
>>
>>> Hi all,
>>>
>>> we are heavily doing code analysis with FindBugs and made progress with
>>> the Java packages, see [1].
>>>
>>> We have decided to convert mini lang to Groovy files and it seems that
>>> people start writing new services using the Groovy DSL. I see one
>>> drawback
>>> that we cannot use static code analysis tools to check code quality.
>>>
>>> Does someone know a way compatible with OFBiz to also analyze Groovy
>>> files?
>>>
>>> Any hint is appreciated.
>>>
>>> Thanks,
>>>
>>> Michael
>>>
>>>
>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9450
>>>
>>>
>>>
>>>
>
>

[Jacques Le Roux]

Hi Taher, Michael,

I don't remember exactly the issues I crossed; but I tend to agree that following conventions often helps!

Jacques


Le 12/10/2017 à 12:48, Taher Alkhateeb a écrit :

> Oh, without digging into details it's probably not going to be easy.
> Not because the tool is insufficient but because of problems in the
> way we integrate groovy in OFBiz. It's not standardized, and we use it
> as a DSL with code snippets scattered around. Ideally, our groovy code
> should reside for example in src/main/groovy and src/test/groovy for
> example whereas we have it in non-standard locations both in webapps
> and in other directories.
>
> I could be wrong but I suspect that it would not be easy to find a
> solution out of the box because of the unusual setup I mentioned
> above.
>
> On Thu, Oct 12, 2017 at 1:42 PM, Michael Brohl <[hidden email]> wrote:
>> Hi Taher,
>>
>> yes, this would be a solution but I remembered Jacques having problems to
>> make it work with OFBiz [1].
>>
>> I'll pick up the thread to get to know the problem.
>>
>> Thanks,
>>
>> Michael
>>
>>
>> [1]
>> https://lists.apache.org/thread.html/40240117ca0e24ef3f4b14a3c6c7c491a49b4071dfe08923cd4751a8@%3Cdev.ofbiz.apache.org%3E
>>
>>
>> Am 12.10.17 um 12:05 schrieb Taher Alkhateeb:
>>
>>> Hi Michael,
>>>
>>> Why not naybe something like codenarc [1]. They have a gradle builtin
>>> plugin [2].
>>> [1] http://codenarc.sourceforge.net/
>>> [2] https://docs.gradle.org/current/userguide/codenarc_plugin.html
>>>
>>> On Oct 12, 2017 12:59 PM, "Michael Brohl" <[hidden email]>
>>> wrote:
>>>
>>>> Hi all,
>>>>
>>>> we are heavily doing code analysis with FindBugs and made progress with
>>>> the Java packages, see [1].
>>>>
>>>> We have decided to convert mini lang to Groovy files and it seems that
>>>> people start writing new services using the Groovy DSL. I see one
>>>> drawback
>>>> that we cannot use static code analysis tools to check code quality.
>>>>
>>>> Does someone know a way compatible with OFBiz to also analyze Groovy
>>>> files?
>>>>
>>>> Any hint is appreciated.
>>>>
>>>> Thanks,
>>>>
>>>> Michael
>>>>
>>>>
>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9450
>>>>
>>>>
>>>>
>>>>
>>