Form Widget labels disappearing

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: Form Widget labels disappearing

Jacques Le Roux-2-2
Mmm, I work on Windows (so do Adrian, AFAIK) and anyway is this not Debian specific?

Jacques
PS : my second choice is Ubuntun when I need to work on Linux. Anyway I will have to definitely switch one day, because of this
stupid Windows RAM limit, after 2 years of 4Go use I begin to feel a bit tight (a real wastefulness, not even capable or getting
back unused memory, OK enough rants, it's "my choice" ;o)

From: "Adam Heath" <[hidden email]>
> Jacques Le Roux wrote:
>> Then we should have this kind of advices in the API or the documentation
>> somewhere. We can't expect that future devs will pick this
>> message easily. It would be easier for us to refer to somewhere as well.
>
> Create an annotation that marks such things, then use apt to verify it
> at the source level.
>

Reply | Threaded
Open this post in threaded view
|

Re: FlexibleStringExpander

Adrian Crum
In reply to this post by Adam Heath-2
Adam Heath wrote:

> Adrian Crum wrote:
>> Adam Heath wrote:
>>> Adrian Crum wrote:
>>>> FlexibleStringExpander fse =
>>>> FlexibleStringExpander.getInstance("someExpression");
>>>> if (fse != null) {
>>>>   // some code
>>>> }
>>> This was always broken.  Type foo = new Type();  foo will *never* be
>>> null, period.  There are existing places in the code where this new
>>> Type() compared to null takes place, unrelated to FSE.
>> I was trying to provide a simplified example. You are correct - the
>> simplified example would never work to begin with. What the simplified
>> example might really look like:
>>
>> protected FlexibleStringExpander description = null;
>
> Just for reference, the correct fix here would remove the null default
> value, make it final, and remove the condition check below.

Exactly.

Reply | Threaded
Open this post in threaded view
|

Re: Form Widget labels disappearing

Adam Heath-2
In reply to this post by Jacques Le Roux-2-2
Jacques Le Roux wrote:
> Mmm, I work on Windows (so do Adrian, AFAIK) and anyway is this not
> Debian specific?

Er, no.  java apt, not debian apt.  Go do some more java reading.

APT -> Annotation Processing Tool.

Reply | Threaded
Open this post in threaded view
|

Re: Form Widget labels disappearing

Jacques Le Roux-2-2
Ha ok  (I was quite sure I was missing something because I was not seeing the relation with Debian apt). Sure I will read more, I'm
currently reading *details* about Java 5 types (not as simple as I thought...)

Thanks

Jacques

From: "Adam Heath" <[hidden email]>
> Jacques Le Roux wrote:
>> Mmm, I work on Windows (so do Adrian, AFAIK) and anyway is this not
>> Debian specific?
>
> Er, no.  java apt, not debian apt.  Go do some more java reading.
>
> APT -> Annotation Processing Tool.
>

Reply | Threaded
Open this post in threaded view
|

Re: Form Widget labels disappearing

hans_bakker
In reply to this post by Scott Gray-2
Hi Scott, as this is affecting everybody i thought it was useful for
others to know that....

Regards,
Hans

On Tue, 2010-02-02 at 07:12 -0800, Scott Gray wrote:

> Thanks Hans, but I'm pretty sure you know that I know how to revert :-)
>
> Regards
> Scott
>
> On 2/02/2010, at 12:35 AM, Hans Bakker wrote:
>
> > Hi this seems to be caused by  r904592
> >
> > to revert this change:
> > svn merge http://svn.apache.org/repos/asf/ofbiz/trunk -r904592:904591
> >
> > Regards,
> > Hans
> >
> >
> > On Mon, 2010-02-01 at 23:07 -0800, Scott Gray wrote:
> >> After taking an update today, a lot of form widget field labels seem to be missing from various screens.  If any committers are aware of any changes they may have made which could have impacted this please take a look and see if it's related to your work.
> >>
> >> Here's an example: https://localhost:8443/catalog/control/FindProductConfigItems (only one of the 3 search option fields are presenting a field label)
> >> Here's another: https://localhost:8443/accounting/control/findPayments
> >>
> >> Thanks
> >> Scott
> >>
> >> HotWax Media
> >> http://www.hotwaxmedia.com
> >>
> >>
> > --
> > Antwebsystems.com: Quality OFBiz services for competitive rates
> >
>
--
Antwebsystems.com: Quality OFBiz services for competitive rates

12