Form widget pagine

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Form widget pagine

Bilgin Ibryam-2
Hi all,

On the form widget I see an attribute called paginate="true/false" but
it is not used at all, because its value is always overriden.
Can someone tell me what was the purpose of this attribute? I suppose it
was intended for disabling pagination and rendering all rows in one page?
Currently we achieve this by setting a big page size number, which I
don't like much, and I'm planning to fix that.

Bilgin


Reply | Threaded
Open this post in threaded view
|

Re: Form widget pagine

Bilgin Ibryam-2
Bilgin Ibryam wrote:

> Hi all,
>
> On the form widget I see an attribute called paginate="true/false" but
> it is not used at all, because its value is always overriden.
> Can someone tell me what was the purpose of this attribute? I suppose
> it was intended for disabling pagination and rendering all rows in one
> page?
> Currently we achieve this by setting a big page size number, which I
> don't like much, and I'm planning to fix that.
>
> Bilgin
>
>
Done in r892264
Reply | Threaded
Open this post in threaded view
|

Re: Form widget pagine

Jacopo Cappellato-4
very cool, Bilgin.
Is it possible to also set and pass the "paginate" boolean from the screen? In this way, the same form could be used with pagination in some screens and without pagination in other screens.

Jacopo

On Dec 18, 2009, at 3:48 PM, Bilgin Ibryam wrote:

> Bilgin Ibryam wrote:
>> Hi all,
>>
>> On the form widget I see an attribute called paginate="true/false" but it is not used at all, because its value is always overriden.
>> Can someone tell me what was the purpose of this attribute? I suppose it was intended for disabling pagination and rendering all rows in one page?
>> Currently we achieve this by setting a big page size number, which I don't like much, and I'm planning to fix that.
>>
>> Bilgin
>>
>>
> Done in r892264

Reply | Threaded
Open this post in threaded view
|

Re: Form widget pagine

Bilgin Ibryam-2
Jacopo Cappellato wrote:
> very cool, Bilgin.
> Is it possible to also set and pass the "paginate" boolean from the screen? In this way, the same form could be used with pagination in some screens and without pagination in other screens.
>
> Jacopo
>
>  
Jacopo, thanks for the idea. I added this feature in r892371

Bilgin
Reply | Threaded
Open this post in threaded view
|

Re: Form widget pagine

Jacopo Cappellato-4
Hi Bilgin,

thanks for doing this; a small suggestion, what if we do this:

On Dec 18, 2009, at 9:25 PM, [hidden email] wrote:

> +        if (this.paginate == null || formElement.hasAttribute("paginate")) {
> +            this.paginate = FlexibleStringExpander.getInstance(formElement.getAttribute("paginate"));
> +        }
else if (this.paginate == null) {
    this.paginate = FlexibleStringExpander.getInstance("${paginate}");
}

In this way we will be able to set the "paginate" variable even if the form doesn't explicitly define the paginate attribute.

What do you think?

Jacopo


On Dec 19, 2009, at 12:27 AM, Bilgin Ibryam wrote:

> Jacopo Cappellato wrote:
>> very cool, Bilgin.
>> Is it possible to also set and pass the "paginate" boolean from the screen? In this way, the same form could be used with pagination in some screens and without pagination in other screens.
>>
>> Jacopo
>>
>>
> Jacopo, thanks for the idea. I added this feature in r892371
>
> Bilgin

Reply | Threaded
Open this post in threaded view
|

Re: Form widget pagine

Bilgin Ibryam-2
Jacopo Cappellato wrote:

> Hi Bilgin,
>
> thanks for doing this; a small suggestion, what if we do this:
>
> On Dec 18, 2009, at 9:25 PM, [hidden email] wrote:
>
>  
>> +        if (this.paginate == null || formElement.hasAttribute("paginate")) {
>> +            this.paginate = FlexibleStringExpander.getInstance(formElement.getAttribute("paginate"));
>> +        }
>>    
> else if (this.paginate == null) {
>     this.paginate = FlexibleStringExpander.getInstance("${paginate}");
> }
>
> In this way we will be able to set the "paginate" variable even if the form doesn't explicitly define the paginate attribute.
>
> What do you think?
>
> Jacopo
>  

Jacopo,

 thanks for the suggestion. In r894179 I set ${paginate} as default
value for paginate attribute in the schema and  it worked  w/o  any
other modifications.

Bilgin