Fwd: svn commit: r467519 - /incubator/ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/showcartitems.ftl

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Fwd: svn commit: r467519 - /incubator/ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/showcartitems.ftl

Si Chen-2
Hi.  I just had to make this change so that the cart items' line  
totals were correct after changing them during order manager order  
entry, which made me wonder...what is  
ShoppingCartItem.getDisplayItemSubTotal for?  How come it doesn't  
change after I change the price?

Begin forwarded message:

> From: [hidden email]
> Date: October 24, 2006 4:48:13 PM PDT
> To: [hidden email]
> Subject: svn commit: r467519 - /incubator/ofbiz/trunk/applications/
> order/webapp/ordermgr/entry/cart/showcartitems.ftl
> Reply-To: [hidden email]
>
> Author: sichen
> Date: Tue Oct 24 16:48:11 2006
> New Revision: 467519
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=467519
> Log:
> Fix bug where cart lines' values were not changing after prices  
> were changed during order entry
>
> Modified:
>     incubator/ofbiz/trunk/applications/order/webapp/ordermgr/entry/
> cart/showcartitems.ftl
>
> Modified: incubator/ofbiz/trunk/applications/order/webapp/ordermgr/
> entry/cart/showcartitems.ftl
> URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/ 
> applications/order/webapp/ordermgr/entry/cart/showcartitems.ftl?
> view=diff&rev=467519&r1=467518&r2=467519
> ======================================================================
> ========
> --- incubator/ofbiz/trunk/applications/order/webapp/ordermgr/entry/
> cart/showcartitems.ftl (original)
> +++ incubator/ofbiz/trunk/applications/order/webapp/ordermgr/entry/
> cart/showcartitems.ftl Tue Oct 24 16:48:11 2006
> @@ -244,7 +244,7 @@
>                </div>
>              </td>
>              <td nowrap align="right"><div  
> class="tabletext"><@ofbizCurrency  
> amount=cartLine.getOtherAdjustments() isoCode=currencyUomId/></
> div></td>
> -            <td nowrap align="right"><div  
> class="tabletext"><@ofbizCurrency  
> amount=cartLine.getDisplayItemSubTotal() isoCode=currencyUomId/></
> div></td>
> +            <td nowrap align="right"><div  
> class="tabletext"><@ofbizCurrency amount=cartLine.getItemSubTotal()  
> isoCode=currencyUomId/></div></td>
>              <td nowrap align="center"><div class="tabletext"><#if !
> cartLine.getIsPromo()><input type="checkbox" name="selectedItem"  
> value="${cartLineIndex}" onclick="javascript:checkToggle
> (this);"><#else>&nbsp;</#if></div></td>
>            </tr>
>          </#list>
>

Best Regards,

Si
[hidden email]



Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r467519 - /incubator/ofbiz/trunk/applications/order/webapp/ordermgr/entry/cart/showcartitems.ftl

David E Jones-2

Yes, this change should be rolled back and the problem fixed in  
another place (ie making sure the field that is displayed is updated  
instead of changing the field that is displayed).

We have separate display and base prices for a cart item because they  
will be different in various circumstances, the most notable right  
now being display of prices with tax included, but considering them  
without tax when the order is placed so that adjustment will add in  
correctly.

-David


On Oct 24, 2006, at 5:51 PM, Si Chen wrote:

> Hi.  I just had to make this change so that the cart items' line  
> totals were correct after changing them during order manager order  
> entry, which made me wonder...what is  
> ShoppingCartItem.getDisplayItemSubTotal for?  How come it doesn't  
> change after I change the price?
>
> Begin forwarded message:
>
>> From: [hidden email]
>> Date: October 24, 2006 4:48:13 PM PDT
>> To: [hidden email]
>> Subject: svn commit: r467519 - /incubator/ofbiz/trunk/applications/
>> order/webapp/ordermgr/entry/cart/showcartitems.ftl
>> Reply-To: [hidden email]
>>
>> Author: sichen
>> Date: Tue Oct 24 16:48:11 2006
>> New Revision: 467519
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=467519
>> Log:
>> Fix bug where cart lines' values were not changing after prices  
>> were changed during order entry
>>
>> Modified:
>>     incubator/ofbiz/trunk/applications/order/webapp/ordermgr/entry/
>> cart/showcartitems.ftl
>>
>> Modified: incubator/ofbiz/trunk/applications/order/webapp/ordermgr/
>> entry/cart/showcartitems.ftl
>> URL: http://svn.apache.org/viewvc/incubator/ofbiz/trunk/ 
>> applications/order/webapp/ordermgr/entry/cart/showcartitems.ftl?
>> view=diff&rev=467519&r1=467518&r2=467519
>> =====================================================================
>> =========
>> --- incubator/ofbiz/trunk/applications/order/webapp/ordermgr/entry/
>> cart/showcartitems.ftl (original)
>> +++ incubator/ofbiz/trunk/applications/order/webapp/ordermgr/entry/
>> cart/showcartitems.ftl Tue Oct 24 16:48:11 2006
>> @@ -244,7 +244,7 @@
>>                </div>
>>              </td>
>>              <td nowrap align="right"><div  
>> class="tabletext"><@ofbizCurrency  
>> amount=cartLine.getOtherAdjustments() isoCode=currencyUomId/></
>> div></td>
>> -            <td nowrap align="right"><div  
>> class="tabletext"><@ofbizCurrency  
>> amount=cartLine.getDisplayItemSubTotal() isoCode=currencyUomId/></
>> div></td>
>> +            <td nowrap align="right"><div  
>> class="tabletext"><@ofbizCurrency amount=cartLine.getItemSubTotal
>> () isoCode=currencyUomId/></div></td>
>>              <td nowrap align="center"><div  
>> class="tabletext"><#if !cartLine.getIsPromo()><input  
>> type="checkbox" name="selectedItem" value="${cartLineIndex}"  
>> onclick="javascript:checkToggle(this);"><#else>&nbsp;</#if></div></
>> td>
>>            </tr>
>>          </#list>
>>
>
> Best Regards,
>
> Si
> [hidden email]
>
>
>