[Fwd: svn commit: r510756 - /ofbiz/trunk/applications/content/webapp/content/WEB-INF/controller.xml]

[Si Chen-2]

Andy -

Are you sure about getting rid of the request-redirect?  If the user
accidentally hits the refresh button on his browser he'd resubmit a
request twice.  We've noticed this is a very common source of errors for
users.

Si

Author: jaz
Date: Thu Feb 22 17:46:18 2007
New Revision: 510756

URL: http://svn.apache.org/viewvc?view=rev&rev=510756
Log:
got rid of request-direct returns, not needed and cause problems with large amounts of data

Modified:
    ofbiz/trunk/applications/content/webapp/content/WEB-INF/controller.xml

Modified: ofbiz/trunk/applications/content/webapp/content/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/webapp/content/WEB-INF/controller.xml?view=diff&rev=510756&r1=510755&r2=510756
==============================================================================
--- ofbiz/trunk/applications/content/webapp/content/WEB-INF/controller.xml (original)
+++ ofbiz/trunk/applications/content/webapp/content/WEB-INF/controller.xml Thu Feb 22 17:46:18 2007
@@ -280,7 +280,7 @@
     <request-map uri="createTextContentCms">
         <security https="true" auth="true"/>
         <event type="service" invoke="createTextContent"/>
-        <response name="success" type="request-redirect" value="WebSiteCms"/>
+        <response name="success" type="view" value="WebSiteCMS"/>
         <response name="error" type="view" value="WebSiteCMS"/>
     </request-map>
     <request-map uri="updateTextContentCms">
@@ -292,7 +292,7 @@
     <request-map uri="updateTextContentCms">
         <security https="true" auth="true"/>
         <event type="service" invoke="updateTextContent"/>
-        <response name="success" type="request-redirect" value="WebSiteCms"/>
+        <response name="success" type="view" value="WebSiteCMS"/>
         <response name="error" type="view" value="WebSiteCMS"/>
     </request-map>
     <request-map uri="createWebSitePathAliasJson">

[Andrew Zeneski]

Yes, I am 100% sure. I put it there initially for this reason, but  
then found that when the directed happened it would die when the text  
date was more than the limit of HTTP GET. This caused the whole  
process to blow up and ended up causing the same problem I was trying  
to avoid.

So, in this case when the HTTP POST data exceeds the HTTP GET  
limitations, we can't use the redirect. The redirect w/ no parameters  
fails since the screen does require certain parameters.

Andrew

On Feb 27, 2007, at 2:35 PM, Si Chen wrote:

> Andy -
>
> Are you sure about getting rid of the request-redirect?  If the  
> user accidentally hits the refresh button on his browser he'd  
> resubmit a request twice.  We've noticed this is a very common  
> source of errors for users.
>
> Si
>
> From: [hidden email]
> Date: February 22, 2007 8:46:19 PM EST
> To: [hidden email]
> Subject: svn commit: r510756 - /ofbiz/trunk/applications/content/
> webapp/content/WEB-INF/controller.xml
> Reply-To: [hidden email]
>
>
> Author: jaz
> Date: Thu Feb 22 17:46:18 2007
> New Revision: 510756
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=510756
> Log:
> got rid of request-direct returns, not needed and cause problems  
> with large amounts of data
>
> Modified:
>     ofbiz/trunk/applications/content/webapp/content/WEB-INF/
> controller.xml
>
> Modified: ofbiz/trunk/applications/content/webapp/content/WEB-INF/
> controller.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/ 
> webapp/content/WEB-INF/controller.xml?
> view=diff&rev=510756&r1=510755&r2=510756
> ======================================================================
> ========
> --- ofbiz/trunk/applications/content/webapp/content/WEB-INF/
> controller.xml (original)
> +++ ofbiz/trunk/applications/content/webapp/content/WEB-INF/
> controller.xml Thu Feb 22 17:46:18 2007
> @@ -280,7 +280,7 @@
>      <request-map uri="createTextContentCms">
>          <security https="true" auth="true"/>
>          <event type="service" invoke="createTextContent"/>
> -        <response name="success" type="request-redirect"  
> value="WebSiteCms"/>
> +        <response name="success" type="view" value="WebSiteCMS"/>
>          <response name="error" type="view" value="WebSiteCMS"/>
>      </request-map>
>      <request-map uri="updateTextContentCms">
> @@ -292,7 +292,7 @@
>      <request-map uri="updateTextContentCms">
>          <security https="true" auth="true"/>
>          <event type="service" invoke="updateTextContent"/>
> -        <response name="success" type="request-redirect"  
> value="WebSiteCms"/>
> +        <response name="success" type="view" value="WebSiteCMS"/>
>          <response name="error" type="view" value="WebSiteCMS"/>
>      </request-map>
>      <request-map uri="createWebSitePathAliasJson">
>
>
>
>