GeoData_CH.xml seed data

Hi all,

I'm new on this list and want to contribute to the development of OFBiz.

I found that in the seed data there exists a file containing the seed
data for the switzerland states. But the file is not used upon reading
the seed data. Is there a reason for this? Or should I just file a bug
for this? I can also immediately a patch for this.

Best regards,
Martin

[Jacques Le Roux]

Thanks for report,

You are right, this is now fixed in trunk at revision: 1342846

Though I noticed that at
https://localhost:8443/example/control/FormWidgetExamples#DropDownFieldsExampleForm_stateProvinceGeoId_title no states are shown, I
gave up...

To be consistent, I have also renamed GeoData_CHE.xml to GeoData_CH.xml.  Not sure what should be used for geoTypeId. Is STATE
correct (not a big deal)?

While at it, I also renamed GeoData_IRL.xml to GeoData_IE.xml , renamed things internally, and extracted the  North Ireland geo data
from it to GeoData_UK.xml where it actually belongs

I did not fill an entry at
https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration+%28upgrade+ofbiz%29, I think it'spretty
obvious. Also I did not backport to branches releases.

Please check

Jacques

From: "Martin Kaiser" <[hidden email]>

> Hi all,
>
> I'm new on this list and want to contribute to the development of OFBiz.
>
> I found that in the seed data there exists a file containing the seed
> data for the switzerland states. But the file is not used upon reading
> the seed data. Is there a reason for this? Or should I just file a bug
> for this? I can also immediately a patch for this.
>
> Best regards,
> Martin

[Jacques Le Roux]

From: "Jacques Le Roux" <[hidden email]>
> Thanks for report,
>
> You are right, this is now fixed in trunk at revision: 1342846
>
> Though I noticed that at
> https://localhost:8443/example/control/FormWidgetExamples#DropDownFieldsExampleForm_stateProvinceGeoId_title no states are shown,
> I
> gave up...

OK fixed at http://svn.apache.org/viewvc?rev=1342874&view=rev

> To be consistent, I have also renamed GeoData_CHE.xml to GeoData_CH.xml.  Not sure what should be used for geoTypeId. Is STATE
> correct (not a big deal)?
>
> While at it, I also renamed GeoData_IRL.xml to GeoData_IE.xml , renamed things internally, and extracted the  North Ireland geo
> data
> from it to GeoData_UK.xml where it actually belongs
>
> I did not fill an entry at
> https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration+%28upgrade+ofbiz%29, I think it'spretty
> obvious. Also I did not backport to branches releases.
>
> Please check
>
> Jacques
>
> From: "Martin Kaiser" <[hidden email]>
>> Hi all,
>>
>> I'm new on this list and want to contribute to the development of OFBiz.
>>
>> I found that in the seed data there exists a file containing the seed
>> data for the switzerland states. But the file is not used upon reading
>> the seed data. Is there a reason for this? Or should I just file a bug
>> for this? I can also immediately a patch for this.
>>
>> Best regards,
>> Martin

[Martin Kaiser]

Hi Jacques,

thanks for fixing this. I think that 'state' is the correct (or best)
term for the 'Kantone' in english. In the german file the
'Bundesländer' are translated the same way, so I think this is
correct.

There is a question left on my side: How is the usual procedure for
reporting this? Should I file a bug for this, or should I directly
submit the patch to this list? (I guess if I would have given you the
patch I made for my local installation you would have directly seen
what the problem with the dropdown was, which took me also around an
hour or so).

best regards,
Martin

On 26 May 2012 12:05, Jacques Le Roux <[hidden email]> wrote:

> From: "Jacques Le Roux" <[hidden email]>
>
>> Thanks for report,
>>
>> You are right, this is now fixed in trunk at revision: 1342846
>>
>> Though I noticed that at
>>
>> https://localhost:8443/example/control/FormWidgetExamples#DropDownFieldsExampleForm_stateProvinceGeoId_title
>> no states are shown, I
>> gave up...
>
>
> OK fixed at http://svn.apache.org/viewvc?rev=1342874&view=rev
>
>
>> To be consistent, I have also renamed GeoData_CHE.xml to GeoData_CH.xml.
>>  Not sure what should be used for geoTypeId. Is STATE
>> correct (not a big deal)?
>>
>> While at it, I also renamed GeoData_IRL.xml to GeoData_IE.xml , renamed
>> things internally, and extracted the  North Ireland geo data
>> from it to GeoData_UK.xml where it actually belongs
>>
>> I did not fill an entry at
>>
>> https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration+%28upgrade+ofbiz%29,
>> I think it'spretty
>> obvious. Also I did not backport to branches releases.
>>
>> Please check
>>
>> Jacques
>>
>> From: "Martin Kaiser" <[hidden email]>
>>>
>>> Hi all,
>>>
>>> I'm new on this list and want to contribute to the development of OFBiz.
>>>
>>> I found that in the seed data there exists a file containing the seed
>>> data for the switzerland states. But the file is not used upon reading
>>> the seed data. Is there a reason for this? Or should I just file a bug
>>> for this? I can also immediately a patch for this.
>>>
>>> Best regards,
>>> Martin

[Jacques Le Roux]

From: "Martin Kaiser" <[hidden email]>

> Hi Jacques,
>
> thanks for fixing this. I think that 'state' is the correct (or best)
> term for the 'Kantone' in english. In the german file the
> 'Bundesländer' are translated the same way, so I think this is
> correct.
>
> There is a question left on my side: How is the usual procedure for
> reporting this? Should I file a bug for this, or should I directly
> submit the patch to this list? (I guess if I would have given you the
> patch I made for my local installation you would have directly seen
> what the problem with the dropdown was, which took me also around an
> hour or so).

https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices

Welcome! :o)

Jacques

> best regards,
> Martin
>
> On 26 May 2012 12:05, Jacques Le Roux <[hidden email]> wrote:
>> From: "Jacques Le Roux" <[hidden email]>
>>
>>> Thanks for report,
>>>
>>> You are right, this is now fixed in trunk at revision: 1342846
>>>
>>> Though I noticed that at
>>>
>>> https://localhost:8443/example/control/FormWidgetExamples#DropDownFieldsExampleForm_stateProvinceGeoId_title
>>> no states are shown, I
>>> gave up...
>>
>>
>> OK fixed at http://svn.apache.org/viewvc?rev=1342874&view=rev
>>
>>
>>> To be consistent, I have also renamed GeoData_CHE.xml to GeoData_CH.xml.
>>> Not sure what should be used for geoTypeId. Is STATE
>>> correct (not a big deal)?
>>>
>>> While at it, I also renamed GeoData_IRL.xml to GeoData_IE.xml , renamed
>>> things internally, and extracted the North Ireland geo data
>>> from it to GeoData_UK.xml where it actually belongs
>>>
>>> I did not fill an entry at
>>>
>>> https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration+%28upgrade+ofbiz%29,
>>> I think it'spretty
>>> obvious. Also I did not backport to branches releases.
>>>
>>> Please check
>>>
>>> Jacques
>>>
>>> From: "Martin Kaiser" <[hidden email]>
>>>>
>>>> Hi all,
>>>>
>>>> I'm new on this list and want to contribute to the development of OFBiz.
>>>>
>>>> I found that in the seed data there exists a file containing the seed
>>>> data for the switzerland states. But the file is not used upon reading
>>>> the seed data. Is there a reason for this? Or should I just file a bug
>>>> for this? I can also immediately a patch for this.
>>>>
>>>> Best regards,
>>>> Martin
>