[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #117: Improved: Update Data Sets
Locked
1234
1234
 
|
PierreSmits commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-633900985 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
PierreSmits commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-639308014 How is this check fail possible? 2 days ago everything was fine, and now it is stating that it failed. The only thing changed is added a few records in the demo set. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
PierreSmits edited a comment on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-639308014 How is this check fail possible? 2 days ago everything was fine, and now it is stating that it failed. The only thing changed is added a few records in the demo set. https://github.com/apache/ofbiz-framework/pull/117#issuecomment-639298833 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-640248142 Hi Pierre, Maybe because they improved the rules ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux edited a comment on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-640248142 Hi Pierre, Maybe because SonarCloud Quality Gate mproved the checking rules? Better fix issues before merging I'd say. I can do it if you prefer but not sure how this would merge with your code. We can also fix issues after merging, maybe easier, but we need to be reminded... It seems (at 1st glance) you can neglect the code smells warning ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-640248142 Hi Pierre, Maybe because they improved the rules ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
PierreSmits commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-650543620 I do. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
«
Return to OFBiz - Notifications
|
1 view|%1 views
| Free forum by Nabble | Edit this page |