[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

[GitBox]

PierreSmits opened a new pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295


   
   Improved: OrderAdjustmentType.Description label for VAT
   (OFBIZ-12234)
   Added the labels for DE, EN and NL


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

sonarcloud[bot] commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-840616242


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=295&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=295) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=295&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=295&metric=new_duplicated_lines_density&view=list)
   
   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

JacquesLeRoux commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-841796683


   Hi Pierre,
   
   Would you mind adding
    <value xml:lang="fr">TVA</value>
   in your forked repo and then update this PR? TIA :)


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

JacquesLeRoux edited a comment on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-841796683


   Hi Pierre,
   
   Would you mind adding
   
   `<value xml:lang="fr">TVA</value>`
   
   in your forked repo and then update this PR? TIA :)


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

PierreSmits commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560


   Jaqcues,
   
   The pull request is good enough, and can be committed as such.
   
   When committed it will create an opportunity for other contributors to enhance when that need arises. I would not want to deprive others from participating.
   
   Best regards,
   Pierre


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

PierreSmits edited a comment on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560


   Jaqcues,
   
   The pull request is good enough, and can be merged as such.
   
   When committed it will create an opportunity for other contributors to enhance when that need arises. I would not want to deprive others from participating.
   
   Best regards,
   Pierre


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

JacquesLeRoux commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842213276


   Oh, too bad, it's impossible to me to add the change in your forked repo. I can merge/push as is but then I need to redo the trivial work again locally and commit from there.


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

PierreSmits commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842214368


   Yeah. Let's not bother with trivial work....


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

PierreSmits commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842215549


   You don't have to do everything yourself, Jacques. Don't deprive other contributors of the opportunity. :smile:


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

JacquesLeRoux merged pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295


   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

JacquesLeRoux commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-841796683






--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

JacquesLeRoux edited a comment on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-841796683


   Hi Pierre,
   
   Would you mind adding
   
   `<value xml:lang="fr">TVA</value>`
   
   in your forked repo and then update this PR? TIA :)


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

PierreSmits edited a comment on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560


   Jaqcues,
   
   The pull request is good enough, and can be merged as such.
   
   When committed it will create an opportunity for other contributors to enhance when that need arises. I would not want to deprive others from participating.
   
   Best regards,
   Pierre


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

JacquesLeRoux merged pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295


   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

PierreSmits commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560






--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]