OFBiz › OFBiz - Notifications

[GitHub] [ofbiz-framework] adityasharma7 opened a new pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

27 messages Options

GitBox

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

GitBox

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

In reply to this post by GitBox

GitBox

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

In reply to this post by GitBox

sonarcloud[bot] commented on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

GitBox

[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

In reply to this post by GitBox

adityasharma7 commented on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842388591

Hi @JacquesLeRoux,
This is done now. Initially, I have added only jQuery, jQuery browser, and Validate plugin through npm. As these are the libraries required for the front end to work I have kept the npmInstall task part of the Java build, so it executes on each tasks.

Steps to verify:
1. Fetch the branch on your local
2. Start the server
You will notice packages being downloaded with npmInstall task

<img width="893" alt="image" src="https://user-images.githubusercontent.com/15027245/118508711-0dfd4900-b74d-11eb-8888-18863cd40dcc.png">

You will find the node_modules under the js folder

<img width="257" alt="image" src="https://user-images.githubusercontent.com/15027245/118508970-4866e600-b74d-11eb-820c-2db716fd3b11.png">

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

GitBox

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

In reply to this post by GitBox

sonarcloud[bot] removed a comment on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

GitBox

[GitHub] [ofbiz-framework] JacquesLeRoux removed a comment on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

In reply to this post by GitBox

JacquesLeRoux removed a comment on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-682383949

Oops really sorry (again) Aditya,

I was working on other things at the same time and got confused :blush:. Moreover we crossed online.

Thanks for your explanation. I'll wait a week rather ;)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

GitBox

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

In reply to this post by GitBox

JacquesLeRoux commented on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-845116375

Hi Aditya,

I tried, got:

```
C:\projectsASF\Git\Jacques\ofbiz-framework>gradlew clean build
Starting a Gradle Daemon, 3 busy Daemons could not be reused, use --status for details

> Configure project :
You are using one or more deprecated Asciidoctor Gradle plugin features. To help with migration run with --warning-mode=all.

> Task :clean UP-TO-DATE

> Task :compileJava
Z:\Gradle\caches\modules-2\files-2.1\org.apache.tomcat\tomcat-el-api\9.0.43\ce73ae606e6bee7df54e4a7701e51886e793d3ac\tomcat-el-api-9.0.43.jar(javax/el/ExpressionFactory.class): warning: Cannot find annotation
method 'value()' in type 'ServiceConsumer': class file for aQute.bnd.annotation.spi.ServiceConsumer not found
1 warning

> Task :compileGroovy
> Task :nodeSetup
> Task :npmSetup SKIPPED
> Task :processResources
> Task :classes
> Task :compileGroovyScriptsJava NO-SOURCE
> Task :compileTestJava

> Task :npmInstall
added 4 packages from 3 contributors and audited 4 packages in 2.393s
found 1 moderate severity vulnerability
run `npm audit fix` to fix them, or `npm audit` for details

> Task :jar
> Task :startScripts
> Task :distTar
> Task :distZip
> Task :assemble
> Task :compileGroovyScriptsGroovy SKIPPED
> Task :processGroovyScriptsResources NO-SOURCE
> Task :groovyScriptsClasses UP-TO-DATE
> Task :checkstyleGroovyScripts NO-SOURCE

> Task :checkstyleMain
Checkstyle rule violations were found. See the report at: file:///C:/projectsASF/Git/Jacques/ofbiz-framework/build/reports/checkstyle/main.html
Checkstyle files with violations: 57
Checkstyle violations by severity: [error:115]

> Task :compileTestGroovy
> Task :processTestResources
> Task :testClasses
> Task :checkstyleTest
> Task :test
> Task :check
> Task :build

BUILD SUCCESSFUL in 5m 14s
16 actionable tasks: 15 executed, 1 up-to-date
C:\projectsASF\Git\Jacques\ofbiz-framework>
```

So it works for me and I indeed see very good progress with this way.
I don't think we need to worry about
> SonarCloud Code Analysis Failing after 15m — Quality Gate failed
Looking briefly at the cascading links, I guess it's related to already existing Js code we have.

So +1 with me for merging

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]