alexbodn opened a new pull request #204: URL: https://github.com/apache/ofbiz-framework/pull/204 i understand the policy is against unsafe-inline, but as a matter of fact there are as lot of inline js/css, and part of the js is adding additional remote js. the report uri is implemented in a plugin with this purpose. Improved: Implemented: Documented: Completed: Reverted: Fixed: (OFBIZ-) Explanation Thanks: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
JacquesLeRoux commented on pull request #204: URL: https://github.com/apache/ofbiz-framework/pull/204#issuecomment-657196086 Hi Alex, I agree there are still inline js/css even if most are handled correctly. We have related Jiras to eventually use require.js: https://issues.apache.org/jira/browse/OFBIZ-9465 https://issues.apache.org/jira/browse/OFBIZ-9976. Even if they yet got much attention we still hope to work on it. So you can do that in your own project, we won't in official repo. If you disagree you may start a thread on the [dev ML]([hidden email]). Else please close. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
In reply to this post by GitBox
mbrohl commented on pull request #204: URL: https://github.com/apache/ofbiz-framework/pull/204#issuecomment-769247659 @alexbodn Can you please close this PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
In reply to this post by GitBox
JacquesLeRoux edited a comment on pull request #204: URL: https://github.com/apache/ofbiz-framework/pull/204#issuecomment-657196086 Hi Alex, I agree there are still inline js/css, even if most are handled correctly. We have related Jiras to eventually use require.js: https://issues.apache.org/jira/browse/OFBIZ-9465 https://issues.apache.org/jira/browse/OFBIZ-9976. Even if they not yet got much attention we still hope to work on it. So you can do that in your own project, we won't in official repo. If you disagree you may start a thread on the [dev ML]([hidden email]). Else please close. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
In reply to this post by GitBox
JacquesLeRoux commented on pull request #204: URL: https://github.com/apache/ofbiz-framework/pull/204#issuecomment-778737942 Hi Michael, It seems Alex is no longer interested in OFBiz, closing... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
In reply to this post by GitBox
JacquesLeRoux closed pull request #204: URL: https://github.com/apache/ofbiz-framework/pull/204 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
Free forum by Nabble | Edit this page |