[GitHub] [ofbiz-framework] wpaetzold opened a new pull request #150: OFBIZ-11468 Improved: Convert ShipmentReceiptServices.xml mini lang to groovy
Locked
 
|
wpaetzold opened a new pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150 (OFBIZ-11468) Also converted getTotalIssuedQuantityForOrderItem in IssuanceServices, because it is used in ShipmentReceiptServices and needed more return values. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150#issuecomment-640464452 Hi Wiebke, After a break, I'll continue to review, sorry for the delay. I agree with Pierre. It does not make sense to have directories with a single file named "as" the directory, like it's in XML currently. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150#issuecomment-647982379 Hi Wiebke, Would you have a chance to change as Pierre suggested? We though could do that later with another PR if your prefer... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
wpaetzold commented on pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150#issuecomment-648014855 Hi, sorry for the delay. Of course I can change the structure as Pierre sugessted. I just copied the structure from the minilang files. But wouldn't it be better to move all ShipmentServices into one folder in a separate PR, since picklist, issuance and shipment each also contain only one file? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150#issuecomment-648023128 You later suggestion sounds good to me, Wiebke. I have still to finish the review, from what I saw so far (half of it), I'll maybe not do a complete review but just check another service before merging... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
wpaetzold commented on pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150#issuecomment-648029682 Then I will leave the structure as it is and we can create a separate PR for it later ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on a change in pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150#discussion_r431605375 ########## File path: applications/product/groovyScripts/shipment/receipt/ShipmentReceiptServices.groovy ########## @@ -0,0 +1,495 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License") you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.math.RoundingMode +import java.sql.Timestamp + +import org.apache.ofbiz.base.util.UtilDateTime +import org.apache.ofbiz.base.util.UtilProperties +import org.apache.ofbiz.entity.GenericValue +import org.apache.ofbiz.entity.condition.EntityCondition + +/** + * Create a ShipmentReceipt + * @return + */ +def createShipmentReceipt() { + Map result = success() + GenericValue newEntity = makeValue("ShipmentReceipt") + newEntity.setNonPKFields(parameters) + + String receiptId = delegator.getNextSeqId("ShipmentReceipt").toString() + newEntity.receiptId = receiptId + result.receiptId = receiptId + + if (!newEntity.datetimeReceived) { + newEntity.datetimeReceived = UtilDateTime.nowTimestamp() + } + newEntity.receivedByUserLoginId = userLogin.userLoginId + newEntity.create() + + if (parameters.inventoryItemDetailSeqId) { + GenericValue invDet = from("InventoryItemDetail") + .where(inventoryItemDetailSeqId: parameters.inventoryItemDetailSeqId, inventoryItemId: parameters.inventoryItemId) + .queryOne() + invDet.receiptId = receiptId + invDet.store() + } + Boolean affectAccounting = true + + GenericValue product = from("Product").where(parameters).queryOne() + if (product.productTypeId == "SERVICE_PRODUCT" || product.productTypeId == "ASSET_USAGE_OUT_IN" || product.productTypeId == "AGGREGATEDSERV_CONF") { Review comment: Though we use now 150 chars it would be easier to read if the or would be split by line. To be sincere, this was more to test the GH review feature :) ########## File path: applications/product/groovyScripts/shipment/receipt/ShipmentReceiptServices.groovy ########## @@ -0,0 +1,495 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License") you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.math.RoundingMode +import java.sql.Timestamp + +import org.apache.ofbiz.base.util.UtilDateTime +import org.apache.ofbiz.base.util.UtilProperties +import org.apache.ofbiz.entity.GenericValue +import org.apache.ofbiz.entity.condition.EntityCondition + +/** + * Create a ShipmentReceipt + * @return + */ +def createShipmentReceipt() { + Map result = success() + GenericValue newEntity = makeValue("ShipmentReceipt") + newEntity.setNonPKFields(parameters) + + String receiptId = delegator.getNextSeqId("ShipmentReceipt").toString() + newEntity.receiptId = receiptId + result.receiptId = receiptId + + if (!newEntity.datetimeReceived) { + newEntity.datetimeReceived = UtilDateTime.nowTimestamp() + } + newEntity.receivedByUserLoginId = userLogin.userLoginId + newEntity.create() + + if (parameters.inventoryItemDetailSeqId) { + GenericValue invDet = from("InventoryItemDetail") + .where(inventoryItemDetailSeqId: parameters.inventoryItemDetailSeqId, inventoryItemId: parameters.inventoryItemId) + .queryOne() + invDet.receiptId = receiptId + invDet.store() + } + Boolean affectAccounting = true + + GenericValue product = from("Product").where(parameters).queryOne() + if (product.productTypeId == "SERVICE_PRODUCT" || product.productTypeId == "ASSET_USAGE_OUT_IN" || product.productTypeId == "AGGREGATEDSERV_CONF") { + affectAccounting = false + } + result.affectAccounting = affectAccounting + return result +} + +/** + * Receive Inventory in new Inventory Item(s) + * @return success, inventoryItemId, successMessageList + */ +def receiveInventoryProduct () { + /* + * NOTES + * + * - for serialized items with a serial number passed in: the quantityAccepted _should_ always be 1 + * - if the type is SERIALIZED_INV_ITEM but there is not serial number (which is weird...) we'll create a bunch of individual InventoryItems + * - DEJ20070822: something to consider for the future: maybe instead of this funny looping maybe for serialized items we should only allow a quantity of 1, ie return an error if it is not 1 Review comment: Another (inherited) too long line ########## File path: applications/product/groovyScripts/shipment/receipt/ShipmentReceiptServices.groovy ########## @@ -0,0 +1,495 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License") you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.math.RoundingMode +import java.sql.Timestamp + +import org.apache.ofbiz.base.util.UtilDateTime +import org.apache.ofbiz.base.util.UtilProperties +import org.apache.ofbiz.entity.GenericValue +import org.apache.ofbiz.entity.condition.EntityCondition + +/** + * Create a ShipmentReceipt + * @return + */ +def createShipmentReceipt() { + Map result = success() + GenericValue newEntity = makeValue("ShipmentReceipt") + newEntity.setNonPKFields(parameters) + + String receiptId = delegator.getNextSeqId("ShipmentReceipt").toString() + newEntity.receiptId = receiptId + result.receiptId = receiptId + + if (!newEntity.datetimeReceived) { + newEntity.datetimeReceived = UtilDateTime.nowTimestamp() + } + newEntity.receivedByUserLoginId = userLogin.userLoginId + newEntity.create() + + if (parameters.inventoryItemDetailSeqId) { + GenericValue invDet = from("InventoryItemDetail") + .where(inventoryItemDetailSeqId: parameters.inventoryItemDetailSeqId, inventoryItemId: parameters.inventoryItemId) + .queryOne() + invDet.receiptId = receiptId + invDet.store() + } + Boolean affectAccounting = true + + GenericValue product = from("Product").where(parameters).queryOne() + if (product.productTypeId == "SERVICE_PRODUCT" || product.productTypeId == "ASSET_USAGE_OUT_IN" || product.productTypeId == "AGGREGATEDSERV_CONF") { + affectAccounting = false + } + result.affectAccounting = affectAccounting + return result +} + +/** + * Receive Inventory in new Inventory Item(s) + * @return success, inventoryItemId, successMessageList + */ +def receiveInventoryProduct () { + /* + * NOTES + * + * - for serialized items with a serial number passed in: the quantityAccepted _should_ always be 1 + * - if the type is SERIALIZED_INV_ITEM but there is not serial number (which is weird...) we'll create a bunch of individual InventoryItems + * - DEJ20070822: something to consider for the future: maybe instead of this funny looping maybe for serialized items we should only allow a quantity of 1, ie return an error if it is not 1 + */ + Map result = success() + List successMessageList =[] + String currentInventoryItemId + Double loops = 1.0 + if (parameters.inventoryItemTypeId == "SERIALIZED_INV_ITEM") { + // if we are serialized and either a serialNumber or inventoyItemId is passed in and the quantityAccepted is greater than 1 then complain + if ((parameters.serialNumber || parameters.currentInventoryItemId) && (parameters.quantityAccepted > (BigDecimal) 1)) { + Map errorLog = [parameters: parameters] + return error(UtilProperties.getMessage("ProductUiLabels", "FacilityReceiveInventoryProduct", errorLog, parameters.locale)) + // before getting going, see if there are any validation issues so far + } + loops = parameters.quantityAccepted + parameters.quantityAccepted = (BigDecimal) 1 + } + parameters.quantityOnHandDiff = parameters.quantityAccepted + parameters.availableToPromiseDiff = parameters.quantityAccepted + + //Status for Non serialized and Serialized inventory are different, lets make sure correct status is stored in database + if (parameters.inventoryItemTypeId == "NON_SERIAL_INV_ITEM") { + if (parameters.statusId == "INV_DEFECTIVE") { + // This status may come from the Receive Return Screen + parameters.statusId = "INV_NS_DEFECTIVE" + } else if (parameters.statusId == "INV_ON_HOLD") { + parameters.statusId = "INV_NS_ON_HOLD" + } else if (parameters.statusId == "INV_RETURNED") { + parameters.statusId = "INV_NS_RETURNED" + } else { + // Any other status should be just set to null, if it is not a valid status for Non Serialized inventory + parameters.statusId = null + } + } + + for (Double currentLoop = 0; currentLoop <= loops; currentLoop++) { + logInfo("receiveInventoryProduct Looping and creating inventory info - ${currentLoop}") + + // if there is an inventoryItemId, update it (this will happen when receiving serialized inventory already in the system, like for returns); if not create one + Map serviceInMap = [:] + currentInventoryItemId = null + + // Set supplier partyId, if inventory received by purchase order + if (parameters.orderId) { + GenericValue orderRole = from("OrderRole") + .where(orderId: parameters.orderId, roleTypeId: "SUPPLIER_AGENT") + .queryFirst() + if (orderRole) { + parameters.partyId = orderRole.partyId + } + } + if (!parameters.currentInventoryItemId) { + Map serviceResult = run service:"createInventoryItem", with: parameters + currentInventoryItemId = serviceResult.inventoryItemId + } else { + if (parameters.currentInventoryItemId) { + parameters.inventoryItemId = parameters.currentInventoryItemId + } + run service:"updateInventoryItem", with: parameters + currentInventoryItemId = parameters.currentInventoryItemId + } + + // do this only for non-serialized inventory + if (parameters.inventoryItemTypeId != "SERIALIZED_INV_ITEM") { + serviceInMap = [:] + serviceInMap = parameters + serviceInMap.inventoryItemId = currentInventoryItemId + Map serviceCIID = run service:"createInventoryItemDetail", with: serviceInMap + parameters.inventoryItemDetailSeqId = serviceCIID.inventoryItemDetailSeqId + } + serviceInMap = [:] + serviceInMap = parameters + serviceInMap.inventoryItemId = currentInventoryItemId + run service:"createShipmentReceipt", with: serviceInMap + + //update serialized items to AVAILABLE (only if this is not a return), which then triggers other SECA chains + if (parameters.inventoryItemTypeId == "SERIALIZED_INV_ITEM" && !parameters.returnId) { + // Retrieve the new inventoryItem + GenericValue inventoryItem = from("InventoryItem").where(inventoryItemId: currentInventoryItemId).queryOne() + + // Don't reset the status if it's already set to INV_PROMISED or INV_ON_HOLD + if (inventoryItem.statusId != "INV_PROMISED" && inventoryItem.statusId != "INV_ON_HOLD") { + serviceInMap = [:] + serviceInMap.inventoryItemId = currentInventoryItemId + serviceInMap.statusId = "INV_AVAILABLE" // XXX set to returned instead + run service:"updateInventoryItem", with: serviceInMap + } + } + serviceInMap = [:] + serviceInMap = parameters + serviceInMap.inventoryItemId = currentInventoryItemId + run service:"balanceInventoryItems", with: serviceInMap + + successMessageList << "Received ${parameters.quantityAccepted} of ${parameters.productId} in inventory item ${currentInventoryItemId}" + } + // return the last inventory item received + result.inventoryItemId = currentInventoryItemId + result.successMessageList = successMessageList + + return result +} + +/** + * Quick Receive Entire Return + * @return + */ +def quickReceiveReturn() { + Map result = success() + GenericValue returnHeader = from("ReturnHeader").where(returnId: parameters.returnId).queryOne() + if (returnHeader.needsInventoryReceive == "Y") { + // before receiving inventory, check to see if there is inventory information in this database + Long iiCount = from("InventoryItem").where(facilityId: returnHeader.destinationFacilityId).queryCount() + + if (iiCount > (Integer) 0) { + // create a return shipment for this return + Map shipmentCtx = [returnId: parameters.returnId] + Map serviceCSFR = run service:"createShipmentForReturn", with: shipmentCtx + String shipmentId = serviceCSFR.shipmentId + logInfo("Created new shipment ${shipmentId}") + + List returnItems = from("ReturnItem").where(returnId: returnHeader.returnId).queryList() + + // if no inventory item type specified, get default from facility + if(!parameters.inventoryItemTypeId) { + GenericValue facility = delegator.getRelatedOne("Facility", returnHeader, false) + parameters.inventoryItemTypeId = facility.defaultInventoryItemTypeId ?: "NON_SERIAL_INV_ITEM" + } + Timestamp nowTimestamp = UtilDateTime.nowTimestamp() + + Long returnItemCount = from("ReturnItem").where(returnId: returnHeader.returnId).queryCount() + Long nonProductItems = (Long) 0 + + for (GenericValue returnItem : returnItems) { + // record this return item on the return shipment as well. not sure if this is actually necessary... + Map shipItemCtx = [shipmentId: shipmentId, productId: returnItem.productId, quantity: returnItem.returnQuantity] + logInfo("calling create shipment item with ${shipItemCtx}") + Map serviceCSI = run service:"createShipmentItem", with: shipItemCtx + String shipmentItemSeqId = serviceCSI.shipmentItemSeqId + } + for (GenericValue returnItem : returnItems) { + Map receiveCtx = [:] + if (!returnItem.expectedItemStatus) { + returnItem.expectedItemStatus = "INV_RETURNED" + } + GenericValue orderItem = delegator.getRelatedOne("OrderItem", returnItem, false) + if (orderItem?.productId) { + Map costCtx = [returnItemSeqId: returnItem.returnItemSeqId, returnId: returnItem.returnId] + Map serviceGRIIC = run service:"getReturnItemInitialCost", with: costCtx + receiveCtx.unitCost = serviceGRIIC.initialItemCost + + // check if the items already have SERIALIZED inventory. If so, it still puts them back as SERIALIZED with status "Accepted." + Long serializedItemCount = from("InventoryItem") + .where(productId: returnItem.productId, facilityId: returnHeader.destinationFacilityId, inventoryItemTypeId: "SERIALIZED_INV_ITEM") + .queryCount() + Boolean setNonSerial = false + if (parameters.inventoryItemTypeId == "NON_SERIAL_INV_ITEM") { + if (serializedItemCount == 0) { + parameters.inventoryItemTypeId = "NON_SERIAL_INV_ITEM" + setNonSerial = true + } + } + if (!setNonSerial) { + parameters.inventoryItemTypeId = "SERIALIZED_INV_ITEM" + returnItem.returnQuantity = (BigDecimal) 1 + } + receiveCtx = [inventoryItemTypeId: parameters.inventoryItemTypeId, + statusId: returnItem.expectedItemStatus, + productId: returnItem.productId, + returnItemSeqId: returnItem.returnItemSeqId, + returnId: returnItem.returnId, + quantityAccepted: returnItem.returnQuantity, + facilityId: returnHeader.destinationFacilityId, + shipmentId: shipmentId, // important: associate ShipmentReceipt with return shipment created + comments: "Returned Item RA# ${returnItem.returnId}", + datetimeReceived: nowTimestamp, + quantityRejected: (BigDecimal) 0 + ] + Map serviceResult = run service:"receiveInventoryProduct", with: receiveCtx + result.successMessageList = serviceResult.successMessageList + } else { + nonProductItems += (Long) 1 + } + } + // now that the receive is done; set the need flag to N + returnHeader.refresh() + returnHeader.needsInventoryReceive = "N" + returnHeader.store() + + // always check/update the ReturnHeader status, even though it might have been from the receiving above, just make sure + if (returnHeader.statusId != "RETURN_RECEIVED") { + Map retStCtx = [returnId: returnHeader.returnId, statusId: "RETURN_RECEIVED"] + run service:"updateReturnHeader", with: retStCtx + } + } else { + logInfo("Not receiving inventory for returnId ${returnHeader.returnId}, no inventory information available.") + } + } + return result +} + +/** + * Issues order item quantity specified to the shipment, then receives inventory for that item and quantity + * @return + */ +def issueOrderItemToShipmentAndReceiveAgainstPO() { + Map result = success() + String shipmentItemSeqId + GenericValue shipmentItem + // get orderItem + GenericValue orderItem = from("OrderItem").where(parameters).queryOne() + // get orderItemShipGroupAssoc + GenericValue orderItemShipGroupAssoc = from("OrderItemShipGroupAssoc").where(parameters).queryOne() + // get shipment + GenericValue shipment = from("Shipment").where(parameters).queryOne() + + // try to find an existing shipmentItem and attach to it, if none found create a new shipmentItem + // if there is NO productId on the orderItem, ALWAYS create a new shipmentItem + if (orderItem?.productId) { + EntityCondition condition = EntityCondition.makeCondition([ + EntityCondition.makeCondition(productId: orderItem.productId), + EntityCondition.makeCondition(shipmentId: shipment.shipmentId) + ]) + if (parameters.shipmentItemSeqId) { + condition = EntityCondition.makeCondition([ + EntityCondition.makeCondition(shipmentItemSeqId: parameters.shipmentItemSeqId), + condition + ]) + } + shipmentItem = from("ShipmentItem") + .where(condition) + .orderBy("shipmentItemSeqId") + .queryFirst() + } + if (!shipmentItem) { + Map shipmentItemCreate = [productId: orderItem.productId, shipmentId: parameters.shipmentId, quantity: parameters.quantity] + Map serviceResult = run service:"createShipmentItem", with: shipmentItemCreate + Map shipmentItemLookupPk = [shipmentItemSeqId: serviceResult.shipmentItemSeqId, shipmentId: parameters.shipmentId] + shipmentItem = from("ShipmentItem").where(shipmentItemLookupPk).queryOne() + + // Create OrderShipment for this ShipmentItem + Map orderShipmentCreate =[quantity: parameters.quantity, + shipmentId: shipmentItem.shipmentId, + shipmentItemSeqId: shipmentItem.shipmentItemSeqId, + orderId: orderItem.orderId, + orderItemSeqId: orderItem.orderItemSeqId] + if (orderItemShipGroupAssoc) { + // If we have a ShipGroup Assoc for this Item to focus on, set that; this is mostly the case for purchase orders and such + orderShipmentCreate.shipGroupSeqId = orderItemShipGroupAssoc.shipGroupSeqId + } + run service:"createOrderShipment", with: orderShipmentCreate + } else { + Map inputMap = parameters + inputMap.orderItem = orderItem + Map serviceResult = run service:"getTotalIssuedQuantityForOrderItem", with: inputMap + BigDecimal totalIssuedQuantity = serviceResult.totalIssuedQuantity + BigDecimal receivedQuantity = getReceivedQuantityForOrderItem(orderItem) + receivedQuantity += parameters.quantity + GenericValue orderShipment = from("OrderShipment") + .where(orderId: orderItem.orderId, + orderItemSeqId: orderItem.orderItemSeqId, + shipmentId: shipmentItem.shipmentId, + shipmentItemSeqId: shipmentItem.shipmentItemSeqId, + shipGroupSeqId: orderItemShipGroupAssoc.shipGroupSeqId) + .queryFirst() + if (totalIssuedQuantity < receivedQuantity) { + BigDecimal quantityToAdd = receivedQuantity - totalIssuedQuantity + shipmentItem.quantity += quantityToAdd + shipmentItem.store() + shipmentItemSeqId = shipmentItem.shipmentItemSeqId + + orderShipment.quantity = orderShipment.quantity + quantityToAdd + orderShipment.store() + } + } + // TODO: if we want to record the role of the facility operation we have to re-implement this using ShipmentReceiptRole + // <call-simple-method method-name="associateIssueRoles" xml-resource="component://product/minilang/shipment/issuance/IssuanceServices.xml"/> + + Map receiveInventoryProductCtx = parameters + receiveInventoryProductCtx.shipmentItemSeqId = shipmentItemSeqId + Map serviceResult = run service:"receiveInventoryProduct", with:receiveInventoryProductCtx + result.inventoryItemId = serviceResult.inventoryItemId + result.successMessageList = serviceResult.successMessageList + + return result +} + +/** + * Computes the till now received quantity from all ShipmentReceipts + * @return + */ +def getReceivedQuantityForOrderItem (GenericValue orderItem) { + BigDecimal receivedQuantity = 0 + List shipmentReceipts = from("ShipmentReceipt").where(orderId: orderItem.orderId, orderItemSeqId: orderItem.orderItemSeqId).queryList() + for (GenericValue shipmentReceipt : shipmentReceipts) { + receivedQuantity += shipmentReceipt.quantityAccepted + } + return receivedQuantity +} + +/** + * Update issuance, shipment and order items if quantity received is higher than quantity on purchase order + * @return + */ +def updateIssuanceShipmentAndPoOnReceiveInventory() { + GenericValue orderItem = from("OrderItem").where(parameters).queryOne() + if (parameters.orderCurrencyUnitPrice) { + if (parameters.orderCurrencyUnitPrice != orderItem.unitPrice) { + orderItem.unitPrice = new BigDecimal (parameters.orderCurrencyUnitPrice) + orderItem.store() + } + } else { + if (parameters.unitCost != orderItem.unitPrice) { + orderItem.unitPrice = parameters.unitCost + orderItem.store() + } + } + BigDecimal receivedQuantity = getReceivedQuantityForOrderItem(orderItem) + if (orderItem.quantity < receivedQuantity) { + GenericValue orderItemShipGroupAssoc = from("OrderItemShipGroupAssoc") + .where(orderId: orderItem.orderId, orderItemSeqId: orderItem.orderItemSeqId) + .queryFirst() + BigDecimal quantityVariance = (receivedQuantity - orderItem.quantity).setScale(2, RoundingMode.HALF_UP) + BigDecimal oisgaQuantity = (orderItemShipGroupAssoc.quantity + quantityVariance).setScale(2, RoundingMode.HALF_UP) + orderItemShipGroupAssoc.quantity = oisgaQuantity + orderItem.quantity = receivedQuantity + orderItemShipGroupAssoc.store() + orderItem.store() + } + if (parameters.shipmentId) { + if (orderItem.productId) { + Map inputMap = parameters + inputMap.orderItem = orderItem + Map serviceResult = run service:"getTotalIssuedQuantityForOrderItem", with: inputMap + BigDecimal totalIssuedQuantity = serviceResult.totalIssuedQuantity + if (totalIssuedQuantity < receivedQuantity) { + BigDecimal quantityToAdd = receivedQuantity - totalIssuedQuantity + EntityCondition condition = EntityCondition.makeCondition([ + EntityCondition.makeCondition(productId: orderItem.productId), + EntityCondition.makeCondition(shipmentId: parameters.shipmentId) + ]) + if (parameters.shipmentItemSeqId) { + condition = EntityCondition.makeCondition([ + EntityCondition.makeCondition(shipmentItemSeqId: parameters.shipmentItemSeqId), + condition + ]) + } + GenericValue shipmentItem = from("ShipmentItem").where(condition).orderBy("shipmentItemSeqId").queryFirst() + if (shipmentItem) { + shipmentItem.quantity += quantityToAdd + shipmentItem.store() + GenericValue orderShipment = from("OrderShipment") + .where(orderId: parameters.orderId, orderItemSeqId: parameters.orderItemSeqId, shipmentId: parameters.shipmentId, shipmentItemSeqId: shipmentItem.shipmentItemSeqId) + .queryFirst() + if (orderShipment) { + orderShipment.quantity += quantityToAdd + orderShipment.store() + } + } + + // TODO: if we want to record the role of the facility operation we have to re-implement this using ShipmentReceiptRole + // <set field="itemIssuanceId" from-field="itemIssuance.itemIssuanceId"/> + // <call-simple-method method-name="associateIssueRoles" xml-resource="component://product/minilang/shipment/issuance/IssuanceServices.xml"/> + } + } + } + return success() +} + + +/** + * Cancel Received Items against a purchase order if received something incorrectly + * @return + */ +def cancelReceivedItems() { + // TODO: When items are received against a Purchase Order, service listed below changes certain things in the system. Changes done by these + // services also need to be reverted and missing logic can be added later. + // 1. addProductsBackToCategory + // 2. setUnitPriceAsLastPrice + // 3. createAcctgTransForShipmentReceipt + // 4. updateProductIfAvailableFromShipment + + // update the accepted and received quantity to zero in ShipmentReceipt entity + GenericValue shipmentReceipt = from("ShipmentReceipt").where(parameters).queryOne() + shipmentReceipt.quantityAccepted = 0.0 + shipmentReceipt.quantityRejected = 0.0 + shipmentReceipt.store() + + // create record for InventoryItemDetail entity + GenericValue inventoryItem = delegator.getRelatedOne("InventoryItem", shipmentReceipt, false) + Map inventoryItemDetailMap = [inventoryItemId: inventoryItem.inventoryItemId] + inventoryItemDetailMap.quantityOnHandDiff = inventoryItem.quantityOnHandTotal * (-1) + inventoryItemDetailMap.availableToPromiseDiff = inventoryItem.availableToPromiseTotal *(-1) + run service:"createInventoryItemDetail", with: inventoryItemDetailMap + + // Balance the inventory item + Map balanceInventoryItemMap = [inventoryItemId: inventoryItem.inventoryItemId, priorityOrderId: shipmentReceipt.orderId, priorityOrderItemSeqId: shipmentReceipt.orderItemSeqId] Review comment: This line is 26 chars too long (180 instead of max 250) ########## File path: applications/product/groovyScripts/shipment/receipt/ShipmentReceiptServices.groovy ########## @@ -0,0 +1,495 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License") you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.math.RoundingMode +import java.sql.Timestamp + +import org.apache.ofbiz.base.util.UtilDateTime +import org.apache.ofbiz.base.util.UtilProperties +import org.apache.ofbiz.entity.GenericValue +import org.apache.ofbiz.entity.condition.EntityCondition + +/** + * Create a ShipmentReceipt + * @return + */ +def createShipmentReceipt() { + Map result = success() + GenericValue newEntity = makeValue("ShipmentReceipt") + newEntity.setNonPKFields(parameters) + + String receiptId = delegator.getNextSeqId("ShipmentReceipt").toString() + newEntity.receiptId = receiptId + result.receiptId = receiptId + + if (!newEntity.datetimeReceived) { + newEntity.datetimeReceived = UtilDateTime.nowTimestamp() + } + newEntity.receivedByUserLoginId = userLogin.userLoginId + newEntity.create() + + if (parameters.inventoryItemDetailSeqId) { + GenericValue invDet = from("InventoryItemDetail") + .where(inventoryItemDetailSeqId: parameters.inventoryItemDetailSeqId, inventoryItemId: parameters.inventoryItemId) + .queryOne() + invDet.receiptId = receiptId + invDet.store() + } + Boolean affectAccounting = true + + GenericValue product = from("Product").where(parameters).queryOne() + if (product.productTypeId == "SERVICE_PRODUCT" || product.productTypeId == "ASSET_USAGE_OUT_IN" || product.productTypeId == "AGGREGATEDSERV_CONF") { + affectAccounting = false + } + result.affectAccounting = affectAccounting + return result +} + +/** + * Receive Inventory in new Inventory Item(s) + * @return success, inventoryItemId, successMessageList + */ +def receiveInventoryProduct () { + /* + * NOTES + * + * - for serialized items with a serial number passed in: the quantityAccepted _should_ always be 1 + * - if the type is SERIALIZED_INV_ITEM but there is not serial number (which is weird...) we'll create a bunch of individual InventoryItems + * - DEJ20070822: something to consider for the future: maybe instead of this funny looping maybe for serialized items we should only allow a quantity of 1, ie return an error if it is not 1 + */ + Map result = success() + List successMessageList =[] + String currentInventoryItemId + Double loops = 1.0 + if (parameters.inventoryItemTypeId == "SERIALIZED_INV_ITEM") { + // if we are serialized and either a serialNumber or inventoyItemId is passed in and the quantityAccepted is greater than 1 then complain + if ((parameters.serialNumber || parameters.currentInventoryItemId) && (parameters.quantityAccepted > (BigDecimal) 1)) { + Map errorLog = [parameters: parameters] + return error(UtilProperties.getMessage("ProductUiLabels", "FacilityReceiveInventoryProduct", errorLog, parameters.locale)) + // before getting going, see if there are any validation issues so far + } + loops = parameters.quantityAccepted + parameters.quantityAccepted = (BigDecimal) 1 + } + parameters.quantityOnHandDiff = parameters.quantityAccepted + parameters.availableToPromiseDiff = parameters.quantityAccepted + + //Status for Non serialized and Serialized inventory are different, lets make sure correct status is stored in database + if (parameters.inventoryItemTypeId == "NON_SERIAL_INV_ITEM") { + if (parameters.statusId == "INV_DEFECTIVE") { + // This status may come from the Receive Return Screen + parameters.statusId = "INV_NS_DEFECTIVE" + } else if (parameters.statusId == "INV_ON_HOLD") { + parameters.statusId = "INV_NS_ON_HOLD" + } else if (parameters.statusId == "INV_RETURNED") { + parameters.statusId = "INV_NS_RETURNED" + } else { + // Any other status should be just set to null, if it is not a valid status for Non Serialized inventory + parameters.statusId = null + } + } + + for (Double currentLoop = 0; currentLoop <= loops; currentLoop++) { + logInfo("receiveInventoryProduct Looping and creating inventory info - ${currentLoop}") + + // if there is an inventoryItemId, update it (this will happen when receiving serialized inventory already in the system, like for returns); if not create one + Map serviceInMap = [:] + currentInventoryItemId = null + + // Set supplier partyId, if inventory received by purchase order + if (parameters.orderId) { + GenericValue orderRole = from("OrderRole") + .where(orderId: parameters.orderId, roleTypeId: "SUPPLIER_AGENT") + .queryFirst() + if (orderRole) { + parameters.partyId = orderRole.partyId + } + } + if (!parameters.currentInventoryItemId) { + Map serviceResult = run service:"createInventoryItem", with: parameters + currentInventoryItemId = serviceResult.inventoryItemId + } else { + if (parameters.currentInventoryItemId) { + parameters.inventoryItemId = parameters.currentInventoryItemId + } + run service:"updateInventoryItem", with: parameters + currentInventoryItemId = parameters.currentInventoryItemId + } + + // do this only for non-serialized inventory + if (parameters.inventoryItemTypeId != "SERIALIZED_INV_ITEM") { + serviceInMap = [:] + serviceInMap = parameters + serviceInMap.inventoryItemId = currentInventoryItemId + Map serviceCIID = run service:"createInventoryItemDetail", with: serviceInMap + parameters.inventoryItemDetailSeqId = serviceCIID.inventoryItemDetailSeqId + } + serviceInMap = [:] + serviceInMap = parameters + serviceInMap.inventoryItemId = currentInventoryItemId + run service:"createShipmentReceipt", with: serviceInMap + + //update serialized items to AVAILABLE (only if this is not a return), which then triggers other SECA chains + if (parameters.inventoryItemTypeId == "SERIALIZED_INV_ITEM" && !parameters.returnId) { + // Retrieve the new inventoryItem + GenericValue inventoryItem = from("InventoryItem").where(inventoryItemId: currentInventoryItemId).queryOne() + + // Don't reset the status if it's already set to INV_PROMISED or INV_ON_HOLD + if (inventoryItem.statusId != "INV_PROMISED" && inventoryItem.statusId != "INV_ON_HOLD") { + serviceInMap = [:] + serviceInMap.inventoryItemId = currentInventoryItemId + serviceInMap.statusId = "INV_AVAILABLE" // XXX set to returned instead + run service:"updateInventoryItem", with: serviceInMap + } + } + serviceInMap = [:] + serviceInMap = parameters + serviceInMap.inventoryItemId = currentInventoryItemId + run service:"balanceInventoryItems", with: serviceInMap + + successMessageList << "Received ${parameters.quantityAccepted} of ${parameters.productId} in inventory item ${currentInventoryItemId}" + } + // return the last inventory item received + result.inventoryItemId = currentInventoryItemId + result.successMessageList = successMessageList + + return result +} + +/** + * Quick Receive Entire Return + * @return + */ +def quickReceiveReturn() { + Map result = success() + GenericValue returnHeader = from("ReturnHeader").where(returnId: parameters.returnId).queryOne() + if (returnHeader.needsInventoryReceive == "Y") { + // before receiving inventory, check to see if there is inventory information in this database + Long iiCount = from("InventoryItem").where(facilityId: returnHeader.destinationFacilityId).queryCount() + + if (iiCount > (Integer) 0) { + // create a return shipment for this return + Map shipmentCtx = [returnId: parameters.returnId] + Map serviceCSFR = run service:"createShipmentForReturn", with: shipmentCtx + String shipmentId = serviceCSFR.shipmentId + logInfo("Created new shipment ${shipmentId}") + + List returnItems = from("ReturnItem").where(returnId: returnHeader.returnId).queryList() + + // if no inventory item type specified, get default from facility + if(!parameters.inventoryItemTypeId) { + GenericValue facility = delegator.getRelatedOne("Facility", returnHeader, false) + parameters.inventoryItemTypeId = facility.defaultInventoryItemTypeId ?: "NON_SERIAL_INV_ITEM" + } + Timestamp nowTimestamp = UtilDateTime.nowTimestamp() + + Long returnItemCount = from("ReturnItem").where(returnId: returnHeader.returnId).queryCount() + Long nonProductItems = (Long) 0 + + for (GenericValue returnItem : returnItems) { + // record this return item on the return shipment as well. not sure if this is actually necessary... + Map shipItemCtx = [shipmentId: shipmentId, productId: returnItem.productId, quantity: returnItem.returnQuantity] + logInfo("calling create shipment item with ${shipItemCtx}") + Map serviceCSI = run service:"createShipmentItem", with: shipItemCtx + String shipmentItemSeqId = serviceCSI.shipmentItemSeqId + } + for (GenericValue returnItem : returnItems) { + Map receiveCtx = [:] + if (!returnItem.expectedItemStatus) { + returnItem.expectedItemStatus = "INV_RETURNED" + } + GenericValue orderItem = delegator.getRelatedOne("OrderItem", returnItem, false) + if (orderItem?.productId) { + Map costCtx = [returnItemSeqId: returnItem.returnItemSeqId, returnId: returnItem.returnId] + Map serviceGRIIC = run service:"getReturnItemInitialCost", with: costCtx + receiveCtx.unitCost = serviceGRIIC.initialItemCost + + // check if the items already have SERIALIZED inventory. If so, it still puts them back as SERIALIZED with status "Accepted." + Long serializedItemCount = from("InventoryItem") + .where(productId: returnItem.productId, facilityId: returnHeader.destinationFacilityId, inventoryItemTypeId: "SERIALIZED_INV_ITEM") + .queryCount() + Boolean setNonSerial = false + if (parameters.inventoryItemTypeId == "NON_SERIAL_INV_ITEM") { + if (serializedItemCount == 0) { + parameters.inventoryItemTypeId = "NON_SERIAL_INV_ITEM" + setNonSerial = true + } + } + if (!setNonSerial) { + parameters.inventoryItemTypeId = "SERIALIZED_INV_ITEM" + returnItem.returnQuantity = (BigDecimal) 1 + } + receiveCtx = [inventoryItemTypeId: parameters.inventoryItemTypeId, + statusId: returnItem.expectedItemStatus, + productId: returnItem.productId, + returnItemSeqId: returnItem.returnItemSeqId, + returnId: returnItem.returnId, + quantityAccepted: returnItem.returnQuantity, + facilityId: returnHeader.destinationFacilityId, + shipmentId: shipmentId, // important: associate ShipmentReceipt with return shipment created + comments: "Returned Item RA# ${returnItem.returnId}", + datetimeReceived: nowTimestamp, + quantityRejected: (BigDecimal) 0 + ] + Map serviceResult = run service:"receiveInventoryProduct", with: receiveCtx + result.successMessageList = serviceResult.successMessageList + } else { + nonProductItems += (Long) 1 + } + } + // now that the receive is done; set the need flag to N + returnHeader.refresh() + returnHeader.needsInventoryReceive = "N" + returnHeader.store() + + // always check/update the ReturnHeader status, even though it might have been from the receiving above, just make sure + if (returnHeader.statusId != "RETURN_RECEIVED") { + Map retStCtx = [returnId: returnHeader.returnId, statusId: "RETURN_RECEIVED"] + run service:"updateReturnHeader", with: retStCtx + } + } else { + logInfo("Not receiving inventory for returnId ${returnHeader.returnId}, no inventory information available.") + } + } + return result +} + +/** + * Issues order item quantity specified to the shipment, then receives inventory for that item and quantity + * @return + */ +def issueOrderItemToShipmentAndReceiveAgainstPO() { + Map result = success() + String shipmentItemSeqId + GenericValue shipmentItem + // get orderItem + GenericValue orderItem = from("OrderItem").where(parameters).queryOne() + // get orderItemShipGroupAssoc + GenericValue orderItemShipGroupAssoc = from("OrderItemShipGroupAssoc").where(parameters).queryOne() + // get shipment + GenericValue shipment = from("Shipment").where(parameters).queryOne() + + // try to find an existing shipmentItem and attach to it, if none found create a new shipmentItem + // if there is NO productId on the orderItem, ALWAYS create a new shipmentItem + if (orderItem?.productId) { + EntityCondition condition = EntityCondition.makeCondition([ + EntityCondition.makeCondition(productId: orderItem.productId), + EntityCondition.makeCondition(shipmentId: shipment.shipmentId) + ]) + if (parameters.shipmentItemSeqId) { + condition = EntityCondition.makeCondition([ + EntityCondition.makeCondition(shipmentItemSeqId: parameters.shipmentItemSeqId), + condition + ]) + } + shipmentItem = from("ShipmentItem") + .where(condition) + .orderBy("shipmentItemSeqId") + .queryFirst() + } + if (!shipmentItem) { + Map shipmentItemCreate = [productId: orderItem.productId, shipmentId: parameters.shipmentId, quantity: parameters.quantity] + Map serviceResult = run service:"createShipmentItem", with: shipmentItemCreate + Map shipmentItemLookupPk = [shipmentItemSeqId: serviceResult.shipmentItemSeqId, shipmentId: parameters.shipmentId] + shipmentItem = from("ShipmentItem").where(shipmentItemLookupPk).queryOne() + + // Create OrderShipment for this ShipmentItem + Map orderShipmentCreate =[quantity: parameters.quantity, + shipmentId: shipmentItem.shipmentId, + shipmentItemSeqId: shipmentItem.shipmentItemSeqId, + orderId: orderItem.orderId, + orderItemSeqId: orderItem.orderItemSeqId] + if (orderItemShipGroupAssoc) { + // If we have a ShipGroup Assoc for this Item to focus on, set that; this is mostly the case for purchase orders and such + orderShipmentCreate.shipGroupSeqId = orderItemShipGroupAssoc.shipGroupSeqId + } + run service:"createOrderShipment", with: orderShipmentCreate + } else { + Map inputMap = parameters + inputMap.orderItem = orderItem + Map serviceResult = run service:"getTotalIssuedQuantityForOrderItem", with: inputMap + BigDecimal totalIssuedQuantity = serviceResult.totalIssuedQuantity + BigDecimal receivedQuantity = getReceivedQuantityForOrderItem(orderItem) + receivedQuantity += parameters.quantity + GenericValue orderShipment = from("OrderShipment") + .where(orderId: orderItem.orderId, + orderItemSeqId: orderItem.orderItemSeqId, + shipmentId: shipmentItem.shipmentId, + shipmentItemSeqId: shipmentItem.shipmentItemSeqId, + shipGroupSeqId: orderItemShipGroupAssoc.shipGroupSeqId) + .queryFirst() + if (totalIssuedQuantity < receivedQuantity) { + BigDecimal quantityToAdd = receivedQuantity - totalIssuedQuantity + shipmentItem.quantity += quantityToAdd + shipmentItem.store() + shipmentItemSeqId = shipmentItem.shipmentItemSeqId + + orderShipment.quantity = orderShipment.quantity + quantityToAdd + orderShipment.store() + } + } + // TODO: if we want to record the role of the facility operation we have to re-implement this using ShipmentReceiptRole + // <call-simple-method method-name="associateIssueRoles" xml-resource="component://product/minilang/shipment/issuance/IssuanceServices.xml"/> + + Map receiveInventoryProductCtx = parameters + receiveInventoryProductCtx.shipmentItemSeqId = shipmentItemSeqId + Map serviceResult = run service:"receiveInventoryProduct", with:receiveInventoryProductCtx + result.inventoryItemId = serviceResult.inventoryItemId + result.successMessageList = serviceResult.successMessageList + + return result +} + +/** + * Computes the till now received quantity from all ShipmentReceipts + * @return + */ +def getReceivedQuantityForOrderItem (GenericValue orderItem) { + BigDecimal receivedQuantity = 0 + List shipmentReceipts = from("ShipmentReceipt").where(orderId: orderItem.orderId, orderItemSeqId: orderItem.orderItemSeqId).queryList() + for (GenericValue shipmentReceipt : shipmentReceipts) { + receivedQuantity += shipmentReceipt.quantityAccepted + } + return receivedQuantity +} + +/** + * Update issuance, shipment and order items if quantity received is higher than quantity on purchase order + * @return + */ +def updateIssuanceShipmentAndPoOnReceiveInventory() { + GenericValue orderItem = from("OrderItem").where(parameters).queryOne() + if (parameters.orderCurrencyUnitPrice) { + if (parameters.orderCurrencyUnitPrice != orderItem.unitPrice) { + orderItem.unitPrice = new BigDecimal (parameters.orderCurrencyUnitPrice) + orderItem.store() + } + } else { + if (parameters.unitCost != orderItem.unitPrice) { + orderItem.unitPrice = parameters.unitCost + orderItem.store() + } + } + BigDecimal receivedQuantity = getReceivedQuantityForOrderItem(orderItem) + if (orderItem.quantity < receivedQuantity) { + GenericValue orderItemShipGroupAssoc = from("OrderItemShipGroupAssoc") + .where(orderId: orderItem.orderId, orderItemSeqId: orderItem.orderItemSeqId) + .queryFirst() + BigDecimal quantityVariance = (receivedQuantity - orderItem.quantity).setScale(2, RoundingMode.HALF_UP) + BigDecimal oisgaQuantity = (orderItemShipGroupAssoc.quantity + quantityVariance).setScale(2, RoundingMode.HALF_UP) + orderItemShipGroupAssoc.quantity = oisgaQuantity + orderItem.quantity = receivedQuantity + orderItemShipGroupAssoc.store() + orderItem.store() + } + if (parameters.shipmentId) { + if (orderItem.productId) { + Map inputMap = parameters + inputMap.orderItem = orderItem + Map serviceResult = run service:"getTotalIssuedQuantityForOrderItem", with: inputMap + BigDecimal totalIssuedQuantity = serviceResult.totalIssuedQuantity + if (totalIssuedQuantity < receivedQuantity) { + BigDecimal quantityToAdd = receivedQuantity - totalIssuedQuantity + EntityCondition condition = EntityCondition.makeCondition([ + EntityCondition.makeCondition(productId: orderItem.productId), + EntityCondition.makeCondition(shipmentId: parameters.shipmentId) + ]) + if (parameters.shipmentItemSeqId) { + condition = EntityCondition.makeCondition([ + EntityCondition.makeCondition(shipmentItemSeqId: parameters.shipmentItemSeqId), + condition + ]) + } + GenericValue shipmentItem = from("ShipmentItem").where(condition).orderBy("shipmentItemSeqId").queryFirst() + if (shipmentItem) { + shipmentItem.quantity += quantityToAdd + shipmentItem.store() + GenericValue orderShipment = from("OrderShipment") + .where(orderId: parameters.orderId, orderItemSeqId: parameters.orderItemSeqId, shipmentId: parameters.shipmentId, shipmentItemSeqId: shipmentItem.shipmentItemSeqId) Review comment: another too long line ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150#issuecomment-648044667 Very good code, just 4 too long lines, thanks for the good work Wiebke (even if I did not review all, I'm confident with what I saw about the code quality) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux merged pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150#issuecomment-650501995 Hi Pierre, Wiebke, With 392613495029e287c947d392636dbdf539358348 commit I have moved the files in up-dir ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
JacquesLeRoux commented on pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150#issuecomment-650522360 Forgot to change in services def, Pawan handled it :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
«
Return to OFBiz - Notifications
|
1 view|%1 views
| Free forum by Nabble | Edit this page |