In reply to this post by GitBox
mbrohl commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-778237015 @Olivier-Heintz This PR seems to be problematic in several aspects: - there is too much code duplication, see sonarcloud analysis. Please try to avoid copied inline functions and write them in separate function to reuse them - the commits do not follow the commit message template (Fixed:, Improved: etc.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
In reply to this post by GitBox
mbrohl commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-778239041 If you want to show that this is a draft PR which is not finished yet to be reviewed and merged, you can also specify a "draft pull request". I did not find a way to specify this afterwards so you might need to provide a new PR instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
In reply to this post by GitBox
Olivier-Heintz commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-778264215 Thank you Michael for your remarks. This PR is to show what is working but clearly, not yet ready to be merge. I will try to create a "draft pull request". PS: Currently, my knowledge of vuejs is not enough to remove all duplicate lines ! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
In reply to this post by GitBox
Olivier-Heintz closed pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
Free forum by Nabble | Edit this page |