[GitHub] [ofbiz-plugins] PierreSmits commented on issue #11: Improved: BI Component (OFBIZ-11414)

[GitBox]

PierreSmits commented on issue #11: Improved: BI Component (OFBIZ-11414)
URL: https://github.com/apache/ofbiz-plugins/pull/11#issuecomment-603465292
 
 
   Aspect #1 should not give any problem.
   
   And then I would do the rest in a somewhat different order:
   1. create a test branch from trunk,
   2. rebase the PR onto the test branch,
   3. test the test branch,
   4. evaluate the code changes
   
   And then evaluate - if still necessary - the change from commit to commit.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services