[GitHub] [ofbiz-plugins] mbrohl opened a new pull request #60: Improved: Remove ofbiz suffix from rest plugin, code cleanup (OFBIZ-12197)
Locked
 
|
mbrohl opened a new pull request #60: URL: https://github.com/apache/ofbiz-plugins/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
mbrohl commented on pull request #60: URL: https://github.com/apache/ofbiz-plugins/pull/60#issuecomment-804403382 @girishvasmatkar the bugs and security hotspots were introduced by the initial plugin implementation. Can you please check them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
mbrohl commented on pull request #60: URL: https://github.com/apache/ofbiz-plugins/pull/60#issuecomment-804422184 @girishvasmatkar what does the redoc.html file which currently causes SonarCloud to fail? I do not find this file in the Swagger UI distribution files, everything else seems to match. Do we need it or can it be removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
mbrohl commented on pull request #60: URL: https://github.com/apache/ofbiz-plugins/pull/60#issuecomment-806223974 > @girishvasmatkar the bugs and security hotspots were introduced by the initial plugin implementation. > Can you please check them? Ok, I've now fixed the SonarCloud errors. Please check the pull request if it can be committed so I can work from there, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
girishvasmatkar commented on pull request #60: URL: https://github.com/apache/ofbiz-plugins/pull/60#issuecomment-806314138 @mbrohl redoc.html is not part of Swagger UI. It is a separate UI similar to Swagger that also reads the OpenAPI spec YAML/JSON files and renders a nice presentable HTML I should be able to take a look at the PR today. Thank you Micahel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
mbrohl merged pull request #60: URL: https://github.com/apache/ofbiz-plugins/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
|
|
In reply to this post by GitBox
mbrohl commented on pull request #60: URL: https://github.com/apache/ofbiz-plugins/pull/60#issuecomment-808703391 Thanks @girishvasmatkar ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [hidden email] |
«
Return to OFBiz - Notifications
|
1 view|%1 views
| Free forum by Nabble | Edit this page |