[GitHub] [ofbiz-plugins] pritambkute opened a new pull request #34: Adding new plugin for integration of First Data payment gateway with …

[GitBox]

pritambkute opened a new pull request #34:
URL: https://github.com/apache/ofbiz-plugins/pull/34


   …Apache OFBiz. (OFBIZ-11837)
   
   Implemented: First Data Payment Gateway Integration
   (OFBIZ-11837)
   
   Implemented the First Data payment gateway integration. Added Auth, Capture, Release and Refund methods.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

sonarcloud[bot] commented on pull request #34:
URL: https://github.com/apache/ofbiz-plugins/pull/34#issuecomment-649220205


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=34&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=34&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=34&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=34&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=34&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=34&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=34&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=34&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=34&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=34&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=34&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=34) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=34&metric=duplicated_lines_density&view=list) No Duplication information
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

asfgit merged pull request #34:
URL: https://github.com/apache/ofbiz-plugins/pull/34


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

verma-pawan commented on pull request #34:
URL: https://github.com/apache/ofbiz-plugins/pull/34#issuecomment-650501679


   What happened to this PR? @asfgit  merged it???


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

JacquesLeRoux commented on pull request #34:
URL: https://github.com/apache/ofbiz-plugins/pull/34#issuecomment-650527027


   That's quite weird indeed.
   
   I see no relation with the current PR and I'm not sure what https://github.com/asfgit is. Maybe because .asf.yaml is related with Infra something (or someone?) did that automatically. What asfgit did is to merge .asf.yaml with the commit, after I added the missing ASL2 header it seems. I don't think we need to worry, maybe ask Infra? Since the PR is closed we need to create another one for this issue and commit the same again, don't you think so?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

JacquesLeRoux commented on pull request #34:
URL: https://github.com/apache/ofbiz-plugins/pull/34#issuecomment-650734259


   I had another look, it's OK as is but we have a small test issue with OFBIZ-11837


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]