Github PR template
Locked
 
|
Hi Dev,
I think we should add the github PR request [1] template for ofbiz repositories. It will help to guide new contributors to follow our practices and we will have a generic template for PR. [1] https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository Thanks & Regards -- Deepak Dixit ofbiz.apache.org |
|
|
+1. And our current contributor pages in the wiki should be updated
accordingly. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since 2008 (without privileges) *Apache Trafodion <https://trafodion.apache.org>, Vice President* *Apache Directory <https://directory.apache.org>, PMC Member* Apache Incubator <https://incubator.apache.org>, committer Apache Steve <https://steve.apache.org>, committer On Wed, May 13, 2020 at 12:02 PM Deepak Dixit <[hidden email]> wrote: > Hi Dev, > > I think we should add the github PR request [1] template for ofbiz > repositories. > It will help to guide new contributors to follow our practices and we will > have a generic template for PR. > > [1] > > https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository > > Thanks & Regards > -- > Deepak Dixit > ofbiz.apache.org > |
Administrator
|
Hi Deepak,
Agreed, we had this discussion earlier: https://markmail.org/message/3l6dwx4vkknmovew We just miss a sub-task under https://issues.apache.org/jira/browse/OFBIZ-11268 HTH Jacques Le 13/05/2020 à 12:06, Pierre Smits a écrit : > +1. And our current contributor pages in the wiki should be updated > accordingly. > > Met vriendelijke groet, > > Pierre Smits > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since > 2008 (without privileges) > > *Apache Trafodion <https://trafodion.apache.org>, Vice President* > *Apache Directory <https://directory.apache.org>, PMC Member* > Apache Incubator <https://incubator.apache.org>, committer > Apache Steve <https://steve.apache.org>, committer > > > On Wed, May 13, 2020 at 12:02 PM Deepak Dixit <[hidden email]> wrote: > >> Hi Dev, >> >> I think we should add the github PR request [1] template for ofbiz >> repositories. >> It will help to guide new contributors to follow our practices and we will >> have a generic template for PR. >> >> [1] >> >> https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository >> >> Thanks & Regards >> -- >> Deepak Dixit >> ofbiz.apache.org >> |
|
Administrator
|
I created https://issues.apache.org/jira/browse/OFBIZ-11722 for that
Jacques Le 13/05/2020 à 12:13, Jacques Le Roux a écrit : > Hi Deepak, > > Agreed, we had this discussion earlier: https://markmail.org/message/3l6dwx4vkknmovew > > We just miss a sub-task under https://issues.apache.org/jira/browse/OFBIZ-11268 > > HTH > > Jacques > > Le 13/05/2020 à 12:06, Pierre Smits a écrit : >> +1. And our current contributor pages in the wiki should be updated >> accordingly. >> >> Met vriendelijke groet, >> >> Pierre Smits >> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since >> 2008 (without privileges) >> >> *Apache Trafodion <https://trafodion.apache.org>, Vice President* >> *Apache Directory <https://directory.apache.org>, PMC Member* >> Apache Incubator <https://incubator.apache.org>, committer >> Apache Steve <https://steve.apache.org>, committer >> >> >> On Wed, May 13, 2020 at 12:02 PM Deepak Dixit <[hidden email]> wrote: >> >>> Hi Dev, >>> >>> I think we should add the github PR request [1] template for ofbiz >>> repositories. >>> It will help to guide new contributors to follow our practices and we will >>> have a generic template for PR. >>> >>> [1] >>> >>> https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository >>> >>> Thanks & Regards >>> -- >>> Deepak Dixit >>> ofbiz.apache.org >>> |
|
Administrator
|
Done, please review and amend if necessary
Le 22/05/2020 à 12:45, Jacques Le Roux a écrit : > I created https://issues.apache.org/jira/browse/OFBIZ-11722 for that > > Jacques > > Le 13/05/2020 à 12:13, Jacques Le Roux a écrit : >> Hi Deepak, >> >> Agreed, we had this discussion earlier: https://markmail.org/message/3l6dwx4vkknmovew >> >> We just miss a sub-task under https://issues.apache.org/jira/browse/OFBIZ-11268 >> >> HTH >> >> Jacques >> >> Le 13/05/2020 à 12:06, Pierre Smits a écrit : >>> +1. And our current contributor pages in the wiki should be updated >>> accordingly. >>> >>> Met vriendelijke groet, >>> >>> Pierre Smits >>> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since >>> 2008 (without privileges) >>> >>> *Apache Trafodion <https://trafodion.apache.org>, Vice President* >>> *Apache Directory <https://directory.apache.org>, PMC Member* >>> Apache Incubator <https://incubator.apache.org>, committer >>> Apache Steve <https://steve.apache.org>, committer >>> >>> >>> On Wed, May 13, 2020 at 12:02 PM Deepak Dixit <[hidden email]> wrote: >>> >>>> Hi Dev, >>>> >>>> I think we should add the github PR request [1] template for ofbiz >>>> repositories. >>>> It will help to guide new contributors to follow our practices and we will >>>> have a generic template for PR. >>>> >>>> [1] >>>> >>>> https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository >>>> >>>> Thanks & Regards >>>> -- >>>> Deepak Dixit >>>> ofbiz.apache.org >>>> |
|
Administrator
|
Note (also added as a comment in OFBIZ-11722):
As the Github PR template is not related to OFBiz I followed this GH advice: To store your file in a hidden directory, name the pull request template .github/pull_request_template.md. I don't think it's a problem, since it's only related to GH, but I don't see .github in Windows. Using Git Bash: Jacques@LDLC MINGW64 /c/projectsASF/Git/ofbiz-framework (trunk) $ git pull Current branch trunk is up to date. Jacques@LDLC MINGW64 /c/projectsASF/Git/ofbiz-framework (trunk) $ cd .github bash: cd: .github: No such file or directory Jacques Le 27/05/2020 à 11:04, Jacques Le Roux a écrit : > Done, please review and amend if necessary > > Le 22/05/2020 à 12:45, Jacques Le Roux a écrit : >> I created https://issues.apache.org/jira/browse/OFBIZ-11722 for that >> >> Jacques >> >> Le 13/05/2020 à 12:13, Jacques Le Roux a écrit : >>> Hi Deepak, >>> >>> Agreed, we had this discussion earlier: https://markmail.org/message/3l6dwx4vkknmovew >>> >>> We just miss a sub-task under https://issues.apache.org/jira/browse/OFBIZ-11268 >>> >>> HTH >>> >>> Jacques >>> >>> Le 13/05/2020 à 12:06, Pierre Smits a écrit : >>>> +1. And our current contributor pages in the wiki should be updated >>>> accordingly. >>>> >>>> Met vriendelijke groet, >>>> >>>> Pierre Smits >>>> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since >>>> 2008 (without privileges) >>>> >>>> *Apache Trafodion <https://trafodion.apache.org>, Vice President* >>>> *Apache Directory <https://directory.apache.org>, PMC Member* >>>> Apache Incubator <https://incubator.apache.org>, committer >>>> Apache Steve <https://steve.apache.org>, committer >>>> >>>> >>>> On Wed, May 13, 2020 at 12:02 PM Deepak Dixit <[hidden email]> wrote: >>>> >>>>> Hi Dev, >>>>> >>>>> I think we should add the github PR request [1] template for ofbiz >>>>> repositories. >>>>> It will help to guide new contributors to follow our practices and we will >>>>> have a generic template for PR. >>>>> >>>>> [1] >>>>> >>>>> https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository >>>>> >>>>> Thanks & Regards >>>>> -- >>>>> Deepak Dixit >>>>> ofbiz.apache.org >>>>> |
|
|
Thanks Jacques! It works I tried creating a PR by comparing trunk to my
fork branches and content from template show up. >> I don't think it's a problem, since it's only related to GH, but I don't see .github in Windows. I think this might not be a problem until you got to change it ;) Thanks and Regards, Aditya Sharma On Wed, May 27, 2020 at 7:57 PM Jacques Le Roux < [hidden email]> wrote: > Note (also added as a comment in OFBIZ-11722): > > As the Github PR template is not related to OFBiz I followed this GH > advice: > > To store your file in a hidden directory, name the pull request > template .github/pull_request_template.md. > > I don't think it's a problem, since it's only related to GH, but I don't > see .github in Windows. Using Git Bash: > > Jacques@LDLC MINGW64 /c/projectsASF/Git/ofbiz-framework (trunk) > $ git pull > Current branch trunk is up to date. > > Jacques@LDLC MINGW64 /c/projectsASF/Git/ofbiz-framework (trunk) > $ cd .github > bash: cd: .github: No such file or directory > > Jacques > > Le 27/05/2020 à 11:04, Jacques Le Roux a écrit : > > Done, please review and amend if necessary > > > > Le 22/05/2020 à 12:45, Jacques Le Roux a écrit : > >> I created https://issues.apache.org/jira/browse/OFBIZ-11722 for that > >> > >> Jacques > >> > >> Le 13/05/2020 à 12:13, Jacques Le Roux a écrit : > >>> Hi Deepak, > >>> > >>> Agreed, we had this discussion earlier: > https://markmail.org/message/3l6dwx4vkknmovew > >>> > >>> We just miss a sub-task under > https://issues.apache.org/jira/browse/OFBIZ-11268 > >>> > >>> HTH > >>> > >>> Jacques > >>> > >>> Le 13/05/2020 à 12:06, Pierre Smits a écrit : > >>>> +1. And our current contributor pages in the wiki should be updated > >>>> accordingly. > >>>> > >>>> Met vriendelijke groet, > >>>> > >>>> Pierre Smits > >>>> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> > since > >>>> 2008 (without privileges) > >>>> > >>>> *Apache Trafodion <https://trafodion.apache.org>, Vice President* > >>>> *Apache Directory <https://directory.apache.org>, PMC Member* > >>>> Apache Incubator <https://incubator.apache.org>, committer > >>>> Apache Steve <https://steve.apache.org>, committer > >>>> > >>>> > >>>> On Wed, May 13, 2020 at 12:02 PM Deepak Dixit <[hidden email]> > wrote: > >>>> > >>>>> Hi Dev, > >>>>> > >>>>> I think we should add the github PR request [1] template for ofbiz > >>>>> repositories. > >>>>> It will help to guide new contributors to follow our practices and > we will > >>>>> have a generic template for PR. > >>>>> > >>>>> [1] > >>>>> > >>>>> > https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository > >>>>> > >>>>> Thanks & Regards > >>>>> -- > >>>>> Deepak Dixit > >>>>> ofbiz.apache.org > >>>>> > |
|
Administrator
|
Le 28/05/2020 à 07:45, Aditya Sharma a écrit :
> I think this might not be a problem until you got to change it;) Thanks Aditya, Actually I simply forgot to commit from my Linux VM :) https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0 Jacques |
|
|
This is awesome.
Thanks everyone involved in this effort. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, May 28, 2020 at 12:12 PM Jacques Le Roux < [hidden email]> wrote: > Le 28/05/2020 à 07:45, Aditya Sharma a écrit : > > I think this might not be a problem until you got to change it;) > > Thanks Aditya, > > Actually I simply forgot to commit from my Linux VM :) > > > https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0 > > Jacques > > |
|
|
Hello team,
IMO, we should imply these changes to plugins repository as well. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 30, 2020 at 1:29 PM Suraj Khurana <[hidden email]> wrote: > This is awesome. > > Thanks everyone involved in this effort. > > -- > > Best Regards, > Suraj Khurana > Senior Technical Consultant > > > On Thu, May 28, 2020 at 12:12 PM Jacques Le Roux < > [hidden email]> wrote: > >> Le 28/05/2020 à 07:45, Aditya Sharma a écrit : >> > I think this might not be a problem until you got to change it;) >> >> Thanks Aditya, >> >> Actually I simply forgot to commit from my Linux VM :) >> >> >> https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0 >> >> Jacques >> >> |
|
|
+1
Thanks and Regards, Aditya Sharma On Sat, May 30, 2020 at 10:43 PM Suraj Khurana <[hidden email]> wrote: > Hello team, > > IMO, we should imply these changes to plugins repository as well. > > -- > Best Regards, > Suraj Khurana > Senior Technical Consultant > > > On Sat, May 30, 2020 at 1:29 PM Suraj Khurana <[hidden email]> > wrote: > > > This is awesome. > > > > Thanks everyone involved in this effort. > > > > -- > > > > Best Regards, > > Suraj Khurana > > Senior Technical Consultant > > > > > > On Thu, May 28, 2020 at 12:12 PM Jacques Le Roux < > > [hidden email]> wrote: > > > >> Le 28/05/2020 à 07:45, Aditya Sharma a écrit : > >> > I think this might not be a problem until you got to change it;) > >> > >> Thanks Aditya, > >> > >> Actually I simply forgot to commit from my Linux VM :) > >> > >> > >> > https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0 > >> > >> Jacques > >> > >> > |
|
Administrator
|
Done also in R17 and R18, it can still be improved if necessary
I removed a "ecomify-OFBIZ-11468_Convert_ShipmentReceiptServices-squashed" branch that I pushed by mistake in ofbiz-framework.git Jacques Le 31/05/2020 à 05:55, Aditya Sharma a écrit : > +1 > > Thanks and Regards, > Aditya Sharma > > On Sat, May 30, 2020 at 10:43 PM Suraj Khurana <[hidden email]> > wrote: > >> Hello team, >> >> IMO, we should imply these changes to plugins repository as well. >> >> -- >> Best Regards, >> Suraj Khurana >> Senior Technical Consultant >> >> >> On Sat, May 30, 2020 at 1:29 PM Suraj Khurana <[hidden email]> >> wrote: >> >>> This is awesome. >>> >>> Thanks everyone involved in this effort. >>> >>> -- >>> >>> Best Regards, >>> Suraj Khurana >>> Senior Technical Consultant >>> >>> >>> On Thu, May 28, 2020 at 12:12 PM Jacques Le Roux < >>> [hidden email]> wrote: >>> >>>> Le 28/05/2020 à 07:45, Aditya Sharma a écrit : >>>>> I think this might not be a problem until you got to change it;) >>>> Thanks Aditya, >>>> >>>> Actually I simply forgot to commit from my Linux VM :) >>>> >>>> >>>> >> https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0 >>>> Jacques >>>> >>>> |
|
|
Thanks Jacques.
-- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, May 31, 2020 at 1:21 PM Jacques Le Roux < [hidden email]> wrote: > Done also in R17 and R18, it can still be improved if necessary > > I removed a "ecomify-OFBIZ-11468_Convert_ShipmentReceiptServices-squashed" > branch that I pushed by mistake in ofbiz-framework.git > > Jacques > > Le 31/05/2020 à 05:55, Aditya Sharma a écrit : > > +1 > > > > Thanks and Regards, > > Aditya Sharma > > > > On Sat, May 30, 2020 at 10:43 PM Suraj Khurana <[hidden email]> > > wrote: > > > >> Hello team, > >> > >> IMO, we should imply these changes to plugins repository as well. > >> > >> -- > >> Best Regards, > >> Suraj Khurana > >> Senior Technical Consultant > >> > >> > >> On Sat, May 30, 2020 at 1:29 PM Suraj Khurana <[hidden email]> > >> wrote: > >> > >>> This is awesome. > >>> > >>> Thanks everyone involved in this effort. > >>> > >>> -- > >>> > >>> Best Regards, > >>> Suraj Khurana > >>> Senior Technical Consultant > >>> > >>> > >>> On Thu, May 28, 2020 at 12:12 PM Jacques Le Roux < > >>> [hidden email]> wrote: > >>> > >>>> Le 28/05/2020 à 07:45, Aditya Sharma a écrit : > >>>>> I think this might not be a problem until you got to change it;) > >>>> Thanks Aditya, > >>>> > >>>> Actually I simply forgot to commit from my Linux VM :) > >>>> > >>>> > >>>> > >> > https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0 > >>>> Jacques > >>>> > >>>> > |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |