Hello,
I noticed many occurrences where service response is not handled properly and it leads to taking more time while debugging issues. IMO, every service calling from java/groovy must handle errors by service util methods such as *isError*, *reutrnError *etc. and similarly in case of XML <*call-service*, there should be <*check-error*/> to make sure service was executed successfully. Apart from this, one suggestion is to include *Debug.logError *in *ServiceUtil.returnProblem *so that in case of any error occurred and handled, it will always be logged on the console. Please let me know your thoughts on this. -- Thanks and Regards, *Suraj Khurana* | Sr. Enterprise Software Engineer *HotWax Commerce* by *HotWax Systems* Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 |
Administrator
|
Le 07/11/2017 à 12:13, Suraj Khurana a écrit :
> Hello, > > I noticed many occurrences where service response is not handled properly > and it leads to taking more time while debugging issues. > IMO, every service calling from java/groovy must handle errors by service > util methods such as *isError*, *reutrnError *etc. and similarly in case of > XML <*call-service*, there should be <*check-error*/> to make sure service > was executed successfully. > > Apart from this, one suggestion is to include *Debug.logError *in > *ServiceUtil.returnProblem *so that in case of any error occurred and > handled, it will always be logged on the console. > > Please let me know your thoughts on this. > > -- > Thanks and Regards, > *Suraj Khurana* | Sr. Enterprise Software Engineer > *HotWax Commerce* by *HotWax Systems* > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 > +1 Jacques |
In reply to this post by Suraj Khurana
+1
Thanks and Regards -- Akash Jain On Tue, Nov 7, 2017 at 4:43 PM, Suraj Khurana < [hidden email]> wrote: > Hello, > > I noticed many occurrences where service response is not handled properly > and it leads to taking more time while debugging issues. > IMO, every service calling from java/groovy must handle errors by service > util methods such as *isError*, *reutrnError *etc. and similarly in case of > XML <*call-service*, there should be <*check-error*/> to make sure service > was executed successfully. > > Apart from this, one suggestion is to include *Debug.logError *in > *ServiceUtil.returnProblem *so that in case of any error occurred and > handled, it will always be logged on the console. > > Please let me know your thoughts on this. > > -- > Thanks and Regards, > *Suraj Khurana* | Sr. Enterprise Software Engineer > *HotWax Commerce* by *HotWax Systems* > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 > |
Indeed +1
Thanks and Regards, *Aditya Sharma* | Enterprise Software Engineer HotWax Systems <http://www.hotwaxsystems.com/> <https://www.linkedin.com/in/aditya-sharma-78291810a/> On Thu, Nov 9, 2017 at 1:43 PM, Akash Jain <[hidden email]> wrote: > +1 > > Thanks and Regards > -- > Akash Jain > > On Tue, Nov 7, 2017 at 4:43 PM, Suraj Khurana < > [hidden email]> wrote: > > > Hello, > > > > I noticed many occurrences where service response is not handled properly > > and it leads to taking more time while debugging issues. > > IMO, every service calling from java/groovy must handle errors by service > > util methods such as *isError*, *reutrnError *etc. and similarly in case > of > > XML <*call-service*, there should be <*check-error*/> to make sure > service > > was executed successfully. > > > > Apart from this, one suggestion is to include *Debug.logError *in > > *ServiceUtil.returnProblem *so that in case of any error occurred and > > handled, it will always be logged on the console. > > > > Please let me know your thoughts on this. > > > > -- > > Thanks and Regards, > > *Suraj Khurana* | Sr. Enterprise Software Engineer > > *HotWax Commerce* by *HotWax Systems* > > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 > > > |
Thanks everyone.
I have created a Jira ticket here <https://issues.apache.org/jira/browse/OFBIZ-9981> -- Thanks and Regards, *Suraj Khurana* | Sr. Enterprise Software Engineer *HotWax Commerce* by *HotWax Systems* Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 On Thu, Nov 9, 2017 at 1:49 PM, Aditya Sharma < [hidden email]> wrote: > Indeed +1 > > Thanks and Regards, > > *Aditya Sharma* | Enterprise Software Engineer > HotWax Systems <http://www.hotwaxsystems.com/> > <https://www.linkedin.com/in/aditya-sharma-78291810a/> > > On Thu, Nov 9, 2017 at 1:43 PM, Akash Jain <[hidden email]> > wrote: > > > +1 > > > > Thanks and Regards > > -- > > Akash Jain > > > > On Tue, Nov 7, 2017 at 4:43 PM, Suraj Khurana < > > [hidden email]> wrote: > > > > > Hello, > > > > > > I noticed many occurrences where service response is not handled > properly > > > and it leads to taking more time while debugging issues. > > > IMO, every service calling from java/groovy must handle errors by > service > > > util methods such as *isError*, *reutrnError *etc. and similarly in > case > > of > > > XML <*call-service*, there should be <*check-error*/> to make sure > > service > > > was executed successfully. > > > > > > Apart from this, one suggestion is to include *Debug.logError *in > > > *ServiceUtil.returnProblem *so that in case of any error occurred and > > > handled, it will always be logged on the console. > > > > > > Please let me know your thoughts on this. > > > > > > -- > > > Thanks and Regards, > > > *Suraj Khurana* | Sr. Enterprise Software Engineer > > > *HotWax Commerce* by *HotWax Systems* > > > Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 > > > > > > |
Free forum by Nabble | Edit this page |