Implied application component dependency

[Bob Morley]

I was recently working on formatting some payment methods / financial accounts and I came across ContactHelper.formatCreditCard that was part of the Party component.  This felt odd to me since the CreditCard entity is defined in Accounting and there did not seem to be any direct relationship between Party and Accounting (at least at the code level in build.xml).

Is there an implied dependency graph between components under application or should they all be siblings?  It seems to me that this format method would be better placed in UtilAccounting (potentially along side my new format methods for billing account, financial account, and the gift certificate variant of a financial account).

Customers of the formatCreditCard appear to be the party and order applications along with ecommerce.

[David E. Jones-2]

Bob,

This is the closest thing we have to a document describing  
dependencies (or at least intended dependencies...) between components.

The code you site (ContactHelper.formatCreditCard) should go into  
accounting instead of party. I'm not sure if it violates the  
dependency (ie things in party should not depend on things in  
accounting). What would be nice at some point is to clean up these  
dependencies, even looser dependencies like entities and services that  
are only used at runtime.

-David


On Oct 13, 2009, at 12:25 PM, Bob Morley wrote:

>
> I was recently working on formatting some payment methods / financial
> accounts and I came across ContactHelper.formatCreditCard that was  
> part of
> the Party component.  This felt odd to me since the CreditCard  
> entity is
> defined in Accounting and there did not seem to be any direct  
> relationship
> between Party and Accounting (at least at the code level in  
> build.xml).
>
> Is there an implied dependency graph between components under  
> application or
> should they all be siblings?  It seems to me that this format method  
> would
> be better placed in UtilAccounting (potentially along side my new  
> format
> methods for billing account, financial account, and the gift  
> certificate
> variant of a financial account).
>
> Customers of the formatCreditCard appear to be the party and order
> applications along with ecommerce.
> --
> View this message in context: http://n4.nabble.com/Implied-application-component-dependancy-tp252431p252431.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.

[David E. Jones-2]

Wow, I forgot the link... that's even worse than forgetting an  
attachment...

Here it is:

http://docs.ofbiz.org/display/OFBADMIN/Component+and+Component+Set+Dependencies

-David


On Oct 13, 2009, at 2:17 PM, David E Jones wrote:

>
> Bob,
>
> This is the closest thing we have to a document describing  
> dependencies (or at least intended dependencies...) between  
> components.
>
> The code you site (ContactHelper.formatCreditCard) should go into  
> accounting instead of party. I'm not sure if it violates the  
> dependency (ie things in party should not depend on things in  
> accounting). What would be nice at some point is to clean up these  
> dependencies, even looser dependencies like entities and services  
> that are only used at runtime.
>
> -David
>
>
> On Oct 13, 2009, at 12:25 PM, Bob Morley wrote:
>
>>
>> I was recently working on formatting some payment methods / financial
>> accounts and I came across ContactHelper.formatCreditCard that was  
>> part of
>> the Party component.  This felt odd to me since the CreditCard  
>> entity is
>> defined in Accounting and there did not seem to be any direct  
>> relationship
>> between Party and Accounting (at least at the code level in  
>> build.xml).
>>
>> Is there an implied dependency graph between components under  
>> application or
>> should they all be siblings?  It seems to me that this format  
>> method would
>> be better placed in UtilAccounting (potentially along side my new  
>> format
>> methods for billing account, financial account, and the gift  
>> certificate
>> variant of a financial account).
>>
>> Customers of the formatCreditCard appear to be the party and order
>> applications along with ecommerce.
>> --
>> View this message in context: http://n4.nabble.com/Implied-application-component-dependancy-tp252431p252431.html
>> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>