Is the CC update in the one page checkout broken?

[Rene Scheibe]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Shall the one page checkout working properly?

I get this error when continuing to Step 5:

[java] ---- runtime exception report
- --------------------------------------------------
[java] Error evaluating Groovy scriptlet [${groovy:
org.ofbiz.order.shoppingcart.ShoppingCart.CartPaymentInfo cpi =
shoppingCart.getPaymentInfo(paymentMethodId, null, null, null, true);
cpi.securityCode = cardSecurityCode; return cpi;}], inserting nothing;
error was: groovy.lang.MissingPropertyException: No such property:
cardSecurityCode for class: script1281352061618804188587
[java] Exception: groovy.lang.MissingPropertyException
[java] Message: No such property: cardSecurityCode for class:
script1281352061618804188587
     [java] ---- stack trace
- ---------------------------------------------------------------

1. Looks like OnePageCheckoutProcess.ftl defines...
<input id="CVV2" name="cardSecurityCode" size="4" type="text"
maxlength="4" value="" />

2. ..but in service_checkout.xml the parameter is named different...
<attribute name="billToCardSecurityCode" type="String" mode="IN"
optional="true"/>

3. ...and in CheckoutServices.xml the parameter is mapped again...
<set field="cardSecurityCode"
from-field="parameters.billToCardSecurityCode"/>

So why not changing the attribute name in the service definition to
"cardSecurityCode" and removing the mapping in CheckoutServices.xml?  By
the way, "billToCardSecurityCode" is not used anywhere else.

Any proposals?

Regards,
René
- --
René Scheibe * [hidden email]
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterföhring
Geschäftsführer: Henrik Klagges, Gerhard Müller, Christoph Stock
Sitz: Unterföhring * Amtsgericht München * HRB 135082
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxgJSwACgkQUXs9EHvIuCoJOQCeJij4SJwJhjvuK/YrGWJXmmow
VHAAn0jTPprXNcEXUaj6+r57He5G7Nje
=Ay9T
-----END PGP SIGNATURE-----

[Rene Scheibe]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/09/2010 05:56 PM, Rene Scheibe wrote:

> Shall the one page checkout working properly?
>
> I get this error when continuing to Step 5:
>
> [java] ---- runtime exception report
> --------------------------------------------------
> [java] Error evaluating Groovy scriptlet [${groovy:
> org.ofbiz.order.shoppingcart.ShoppingCart.CartPaymentInfo cpi =
> shoppingCart.getPaymentInfo(paymentMethodId, null, null, null, true);
> cpi.securityCode = cardSecurityCode; return cpi;}], inserting nothing;
> error was: groovy.lang.MissingPropertyException: No such property:
> cardSecurityCode for class: script1281352061618804188587
> [java] Exception: groovy.lang.MissingPropertyException
> [java] Message: No such property: cardSecurityCode for class:
> script1281352061618804188587
>      [java] ---- stack trace
> ---------------------------------------------------------------
>
> 1. Looks like OnePageCheckoutProcess.ftl defines...
> <input id="CVV2" name="cardSecurityCode" size="4" type="text"
> maxlength="4" value="" />
>
> 2. ..but in service_checkout.xml the parameter is named different...
> <attribute name="billToCardSecurityCode" type="String" mode="IN"
> optional="true"/>
>
> 3. ...and in CheckoutServices.xml the parameter is mapped again...
> <set field="cardSecurityCode"
> from-field="parameters.billToCardSecurityCode"/>
>
> So why not changing the attribute name in the service definition to
> "cardSecurityCode" and removing the mapping in CheckoutServices.xml?  By
> the way, "billToCardSecurityCode" is not used anywhere else.
>
> Any proposals?

Two more questions:

1. Why is the form field id="CVV2" but the name="cardSecurityCode"?
2. Why is this parameter optional and not mandatory?

Another suggestion how to fix this problem:
1. Rename the label, id and name to "billToCardSecurityCode" in
OnePageCheckoutProcess.ftl to meet the service definition.
2. Extend the attribute mapping line in CheckoutServices.xml so that in
case the CVV2 is not entered by the user, the field is defined
anyway.(otherwise groovy.lang.MissingPropertyException is still thrown)
<set field="cardSecurityCode"
from-field="parameters.billToCardSecurityCode" set-if-null="true"
set-if-empty="true"/>

Regards,
René
- --
René Scheibe * [hidden email]
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterföhring
Geschäftsführer: Henrik Klagges, Gerhard Müller, Christoph Stock
Sitz: Unterföhring * Amtsgericht München * HRB 135082
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxgLgAACgkQUXs9EHvIuCry+wCfU6KsRH8awsVe3VgoioXRiIoD
2RQAn1Q0vuldNIsveOdNZO9Mjt6Sq7Av
=AxrU
-----END PGP SIGNATURE-----