[JIRA] Closed: (OFBIZ-230) replace zero len strings with space in visithandler.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Closed: (OFBIZ-230) replace zero len strings with space in visithandler.java

JIRA jira@ofbiz.org
     [ http://jira.undersunconsulting.com/browse/OFBIZ-230?page=all ]
     
David E. Jones closed OFBIZ-230:
--------------------------------

     Assign To: David E. Jones  (was: Jira Administrator)
    Resolution: Won't Fix

Yeah, this is an old one that was somewhat intentionally ignored and should have been closed way back when. Technically I don't see a justification for the change and it would cause more problems than fix.

> replace zero len strings with space in visithandler.java
> --------------------------------------------------------
>
>          Key: OFBIZ-230
>          URL: http://jira.undersunconsulting.com/browse/OFBIZ-230
>      Project: [OFBiz] Open For Business
>         Type: Bug
>   Components: webapp
>     Versions: SVN
>     Reporter: BJ Freeman
>     Assignee: David E. Jones

>
> Original Estimate: 1 hour
>         Remaining: 1 hour
>
> MS-SQL does not accept zero len parms in a store proceedure.
> the JDTS converts all SQL call to proceedures.
> so put a space in the "" strings
> replace
>         String initialLocale = request.getLocale() != null ? request.getLocale().toString() : "";
>         String initialRequest = fullRequestUrl.toString();
>         String initialReferrer = request.getHeader("Referer") != null ? request.getHeader("Referer") : "";
>         String initialUserAgent = request.getHeader("User-Agent") != null ? request.getHeader("User-Agent") : "";
> with
>         String initialLocale = request.getLocale() != null ? request.getLocale().toString() : " ";
>         String initialRequest = fullRequestUrl.toString();
>         String initialReferrer = request.getHeader("Referer") != null ? request.getHeader("Referer") : " ";
>         String initialUserAgent = request.getHeader("User-Agent") != null ? request.getHeader("User-Agent") : " ";

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.undersunconsulting.com/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira