[JIRA] Closed: (OFBIZ-82) protect the member variables in ContainerConfig, and use better OO separation

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Closed: (OFBIZ-82) protect the member variables in ContainerConfig, and use better OO separation

JIRA jira@ofbiz.org
     [ http://jira.undersunconsulting.com/browse/OFBIZ-82?page=all ]
     
David E. Jones closed OFBIZ-82:
-------------------------------

      Assign To: David E. Jones  (was: Jira Administrator)
     Resolution: Won't Fix
    Fix Version:     (was: SVN)

I agree that what is in there is not ideal, but at this point I don't think this change is worth it.

> protect the member variables in ContainerConfig, and use better OO separation
> -----------------------------------------------------------------------------
>
>          Key: OFBIZ-82
>          URL: http://jira.undersunconsulting.com/browse/OFBIZ-82
>      Project: [OFBiz] Open For Business
>         Type: Improvement
>     Versions: SVN
>     Reporter: Adam Heath
>     Assignee: David E. Jones
>     Priority: Minor
>  Attachments: oo-sep.patch
>
>
> The fields in the property/container classes are public.  This is poor OO design.  The attached patch changes all code to use accessor methods to get the data.  This is needed for a later patch.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.undersunconsulting.com/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira