[JIRA] Commented: (OFBIZ-230) replace zero len strings with space in visithandler.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (OFBIZ-230) replace zero len strings with space in visithandler.java

JIRA jira@ofbiz.org
     [ http://jira.undersunconsulting.com/browse/OFBIZ-230?page=comments#action_13826 ]
     
Marco Risaliti commented on OFBIZ-230:
--------------------------------------

This little change is not still applied to the SVN, is it very important and there is also someone still interested on it ?
I think we can close it.

Thanks
Marco

> replace zero len strings with space in visithandler.java
> --------------------------------------------------------
>
>          Key: OFBIZ-230
>          URL: http://jira.undersunconsulting.com/browse/OFBIZ-230
>      Project: [OFBiz] Open For Business
>         Type: Bug
>   Components: webapp
>     Versions: SVN
>     Reporter: BJ Freeman
>     Assignee: Jira Administrator

>
> Original Estimate: 1 hour
>         Remaining: 1 hour
>
> MS-SQL does not accept zero len parms in a store proceedure.
> the JDTS converts all SQL call to proceedures.
> so put a space in the "" strings
> replace
>         String initialLocale = request.getLocale() != null ? request.getLocale().toString() : "";
>         String initialRequest = fullRequestUrl.toString();
>         String initialReferrer = request.getHeader("Referer") != null ? request.getHeader("Referer") : "";
>         String initialUserAgent = request.getHeader("User-Agent") != null ? request.getHeader("User-Agent") : "";
> with
>         String initialLocale = request.getLocale() != null ? request.getLocale().toString() : " ";
>         String initialRequest = fullRequestUrl.toString();
>         String initialReferrer = request.getHeader("Referer") != null ? request.getHeader("Referer") : " ";
>         String initialUserAgent = request.getHeader("User-Agent") != null ? request.getHeader("User-Agent") : " ";

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.undersunconsulting.com/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira