[
http://jira.undersunconsulting.com/browse/OFBIZ-657?page=comments#action_13934 ]
Daniel Kunkel commented on OFBIZ-657:
-------------------------------------
I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed.
PS. I do have an iCLA signed.
> USPS Rate Estimation
> --------------------
>
> Key: OFBIZ-657
> URL:
http://jira.undersunconsulting.com/browse/OFBIZ-657> Project: [OFBiz] Open For Business
> Type: Bug
> Components: product
> Versions: SVN
> Environment: Any
> Reporter: Daniel Kunkel
> Assignee: Jira Administrator
> Priority: Minor
> Attachments: shipping.patch
>
>
> The USPS automatic Rate Inquiry module has numerous flaws.
> I was able to find and fix them, albeit, with potentially unacceptable techniques.
> Specifically:
> 1.) USPS now uses Get and does not Post any longer.
> 2.) Pounds must be a integer number.
> 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too)
> 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of &
> !!!! My fix for this issue may not be appropriate!
> 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound.
> Remaining Issues...
> Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage.
> Need to add International Shipping Support.
> Finally... This is my first patch contribution... It will need extra time and attention to verify!
> Thanks
> Daniel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.undersunconsulting.com/secure/Administrators.jspa-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
