[JIRA] Commented: (OFBIZ-838) Allow extending a form widget from a different file with the same form name

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (OFBIZ-838) Allow extending a form widget from a different file with the same form name

JIRA jira@ofbiz.org
     [ http://jira.undersunconsulting.com/browse/OFBIZ-838?page=comments#action_14083 ]
     
Marco Risaliti commented on OFBIZ-838:
--------------------------------------

Hi David,

could you please help me this patch is important and so I have to move to the new jira server of simply close it ?

Thanks
Marco

> Allow extending a form widget from a different file with the same form name
> ---------------------------------------------------------------------------
>
>          Key: OFBIZ-838
>          URL: http://jira.undersunconsulting.com/browse/OFBIZ-838
>      Project: [OFBiz] Open For Business
>         Type: Improvement
>   Components: widget
>     Versions: SVN
>  Environment: Linux
>     Reporter: Peter Goron
>     Assignee: Jira Administrator
>     Priority: Minor
>  Attachments: extends-resource.patch
>
>
> With form-widget, it is not possible to extend another form with the same form-name. I agree with this behaviour when we extend a form from another one in the same file to avoid recursive definition.
> Exemple :
> FormsA.xml
> <form name="test">...</form>
> <form name="test" extends="test">...</form>
> => recursive definition
> But :
> FormsB.xml
> <form name="test" extends="test" extends-resource="FormsA.xml">...</form>
> => should work because forms are in different files
> I think this limitation is not necessary when we extend a form from another file and I've found a "TODO" comment in ModelForm.java about this problem.
> So I propose a patch to fix this small issue. I hope I've not missed some implications.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.undersunconsulting.com/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira