[JIRA] Commented: (OFBIZ-873) MySQL 5.0+ changed TYPE to engine=, breaks DatabaseUtil.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[JIRA] Commented: (OFBIZ-873) MySQL 5.0+ changed TYPE to engine=, breaks DatabaseUtil.java

JIRA jira@ofbiz.org
     [ http://jira.undersunconsulting.com/browse/OFBIZ-873?page=comments#action_13944 ]
     
Marco Risaliti commented on OFBIZ-873:
--------------------------------------

Someone has seen if it still an issue ?

Thanks
Marco

> MySQL 5.0+ changed TYPE to engine=, breaks DatabaseUtil.java
> ------------------------------------------------------------
>
>          Key: OFBIZ-873
>          URL: http://jira.undersunconsulting.com/browse/OFBIZ-873
>      Project: [OFBiz] Open For Business
>         Type: Bug
>   Components: entity
>     Versions: SVN
>     Reporter: Leon Torres
>     Assignee: Jira Administrator

>
>
> In MySQL 5.0 and beyond, the table type is defined by engine=. For example, innodb is engine=innodb. This breaks with the standard, which is hardcoded into DatabaseUtil.java:
>         // if there is a tableType, add the TYPE arg here
>         if (UtilValidate.isNotEmpty(this.datasourceInfo.tableType)) {
>             sqlBuf.append(" TYPE ");
>             sqlBuf.append(this.datasourceInfo.tableType);
>         }
> A proposed patch is located at:
> http://sourceforge.net/tracker/index.php?func=detail&aid=1477343&group_id=145855&atid=763271
> However note that it just changes TYPE to ENGINE, which would break other databases. We'll need to fix this somehow. Shouldn't the JDBC driver be doing the work in this case?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.undersunconsulting.com/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira