ListEntityIterator not close and extend form

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

ListEntityIterator not close and extend form

Nicolas Malin-2
Hello,

I think with the thread safe improvement on the screen engine we have an
other regression on extend form.

I detected it on sfa form and I have the confirmation of the reason with
this test :
* run the search on
https://localhost:8443/accounting/control/FindAgreement -> no error in log
* apply this

Index: applications/accounting/widget/AgreementForms.xml
===================================================================
--- applications/accounting/widget/AgreementForms.xml    (révision 1649945)
+++ applications/accounting/widget/AgreementForms.xml    (copie de travail)
@@ -49,7 +49,19 @@
          </field>
      </form>

-    <form name="ListAgreements" list-name="listIt" target="" title=""
type="list" paginate-target="FindAgreement"
+    <form name="ListAgreements" extends="ListAgreementsBase">
+        <actions>
+            <set field="entityName" value="Agreement"/>
+            <service service-name="performFind" result-map="result"
result-map-list="listIt">
+                <field-map field-name="inputFields"
from-field="requestParameters"/>
+                <field-map field-name="entityName"
from-field="entityName"/>
+                <field-map field-name="orderBy"
from-field="parameters.sortField"/>
+                <field-map field-name="viewIndex" from-field="viewIndex"/>
+                <field-map field-name="viewSize" from-field="viewSize"/>
+            </service>
+        </actions>
+    </form>
+    <form name="ListAgreementsBase" list-name="listIt" target=""
title="" type="list" paginate-target="FindAgreement"
          odd-row-style="alternate-row" default-table-style="basic-table
hover-bar" header-row-style="header-row-2">
          <actions>
              <set field="entityName" value="Agreement"/>

  * run the same search and on log we have :
     [java] 2015-01-06 23:33:45,026 |http-bio-8443-exec-4
|ServiceDispatcher             |T| Sync service [accounting/performFind]
finished in [3] milliseconds
      [java] 2015-01-06 23:33:45,029 |http-bio-8443-exec-4
|ServiceDispatcher             |T| Sync service [accounting/performFind]
finished in [3] milliseconds
      [java] 2015-01-06 23:33:45,056 |Finalizer
|EntityListIterator            |E|
      [java]
====================================================================
      [java]  EntityListIterator Not Closed for Entity [Agreement],
caught in Finalize
      [java]
====================================================================

If I found the time I will try to check this week.

Nicolas
--

Nicolas Malin - Consultant - 06 17 66 40 06 - nereide.fr
<http://nereide.fr>

Reply | Threaded
Open this post in threaded view
|

Re: ListEntityIterator not close and extend form

Adrian Crum-3
I think I know what is causing this. I will take care of it.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 1/6/2015 3:15 PM, Nicolas Malin wrote:

> Hello,
>
> I think with the thread safe improvement on the screen engine we have an
> other regression on extend form.
>
> I detected it on sfa form and I have the confirmation of the reason with
> this test :
> * run the search on
> https://localhost:8443/accounting/control/FindAgreement -> no error in log
> * apply this
>
> Index: applications/accounting/widget/AgreementForms.xml
> ===================================================================
> --- applications/accounting/widget/AgreementForms.xml    (révision 1649945)
> +++ applications/accounting/widget/AgreementForms.xml    (copie de travail)
> @@ -49,7 +49,19 @@
>           </field>
>       </form>
>
> -    <form name="ListAgreements" list-name="listIt" target="" title=""
> type="list" paginate-target="FindAgreement"
> +    <form name="ListAgreements" extends="ListAgreementsBase">
> +        <actions>
> +            <set field="entityName" value="Agreement"/>
> +            <service service-name="performFind" result-map="result"
> result-map-list="listIt">
> +                <field-map field-name="inputFields"
> from-field="requestParameters"/>
> +                <field-map field-name="entityName"
> from-field="entityName"/>
> +                <field-map field-name="orderBy"
> from-field="parameters.sortField"/>
> +                <field-map field-name="viewIndex" from-field="viewIndex"/>
> +                <field-map field-name="viewSize" from-field="viewSize"/>
> +            </service>
> +        </actions>
> +    </form>
> +    <form name="ListAgreementsBase" list-name="listIt" target=""
> title="" type="list" paginate-target="FindAgreement"
>           odd-row-style="alternate-row" default-table-style="basic-table
> hover-bar" header-row-style="header-row-2">
>           <actions>
>               <set field="entityName" value="Agreement"/>
>
>   * run the same search and on log we have :
>      [java] 2015-01-06 23:33:45,026 |http-bio-8443-exec-4
> |ServiceDispatcher             |T| Sync service [accounting/performFind]
> finished in [3] milliseconds
>       [java] 2015-01-06 23:33:45,029 |http-bio-8443-exec-4
> |ServiceDispatcher             |T| Sync service [accounting/performFind]
> finished in [3] milliseconds
>       [java] 2015-01-06 23:33:45,056 |Finalizer
> |EntityListIterator            |E|
>       [java]
> ====================================================================
>       [java]  EntityListIterator Not Closed for Entity [Agreement],
> caught in Finalize
>       [java]
> ====================================================================
>
> If I found the time I will try to check this week.
>
> Nicolas
Reply | Threaded
Open this post in threaded view
|

Re: ListEntityIterator not close and extend form

Adrian Crum-3
This should be fixed in rev 1650348. Let me know if you see any more ELI
warnings.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 1/8/2015 8:26 AM, Adrian Crum wrote:

> I think I know what is causing this. I will take care of it.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 1/6/2015 3:15 PM, Nicolas Malin wrote:
>> Hello,
>>
>> I think with the thread safe improvement on the screen engine we have an
>> other regression on extend form.
>>
>> I detected it on sfa form and I have the confirmation of the reason with
>> this test :
>> * run the search on
>> https://localhost:8443/accounting/control/FindAgreement -> no error in
>> log
>> * apply this
>>
>> Index: applications/accounting/widget/AgreementForms.xml
>> ===================================================================
>> --- applications/accounting/widget/AgreementForms.xml    (révision
>> 1649945)
>> +++ applications/accounting/widget/AgreementForms.xml    (copie de
>> travail)
>> @@ -49,7 +49,19 @@
>>           </field>
>>       </form>
>>
>> -    <form name="ListAgreements" list-name="listIt" target="" title=""
>> type="list" paginate-target="FindAgreement"
>> +    <form name="ListAgreements" extends="ListAgreementsBase">
>> +        <actions>
>> +            <set field="entityName" value="Agreement"/>
>> +            <service service-name="performFind" result-map="result"
>> result-map-list="listIt">
>> +                <field-map field-name="inputFields"
>> from-field="requestParameters"/>
>> +                <field-map field-name="entityName"
>> from-field="entityName"/>
>> +                <field-map field-name="orderBy"
>> from-field="parameters.sortField"/>
>> +                <field-map field-name="viewIndex"
>> from-field="viewIndex"/>
>> +                <field-map field-name="viewSize" from-field="viewSize"/>
>> +            </service>
>> +        </actions>
>> +    </form>
>> +    <form name="ListAgreementsBase" list-name="listIt" target=""
>> title="" type="list" paginate-target="FindAgreement"
>>           odd-row-style="alternate-row" default-table-style="basic-table
>> hover-bar" header-row-style="header-row-2">
>>           <actions>
>>               <set field="entityName" value="Agreement"/>
>>
>>   * run the same search and on log we have :
>>      [java] 2015-01-06 23:33:45,026 |http-bio-8443-exec-4
>> |ServiceDispatcher             |T| Sync service [accounting/performFind]
>> finished in [3] milliseconds
>>       [java] 2015-01-06 23:33:45,029 |http-bio-8443-exec-4
>> |ServiceDispatcher             |T| Sync service [accounting/performFind]
>> finished in [3] milliseconds
>>       [java] 2015-01-06 23:33:45,056 |Finalizer
>> |EntityListIterator            |E|
>>       [java]
>> ====================================================================
>>       [java]  EntityListIterator Not Closed for Entity [Agreement],
>> caught in Finalize
>>       [java]
>> ====================================================================
>>
>> If I found the time I will try to check this week.
>>
>> Nicolas
Reply | Threaded
Open this post in threaded view
|

Re: ListEntityIterator not close and extend form

Nicolas Malin-2
Exactly Adrian ! My respects for your reactivity :)

Nicolas


Le 08/01/2015 18:56, Adrian Crum a écrit :

> This should be fixed in rev 1650348. Let me know if you see any more
> ELI warnings.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 1/8/2015 8:26 AM, Adrian Crum wrote:
>> I think I know what is causing this. I will take care of it.
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 1/6/2015 3:15 PM, Nicolas Malin wrote:
>>> Hello,
>>>
>>> I think with the thread safe improvement on the screen engine we
>>> have an
>>> other regression on extend form.
>>>
>>> I detected it on sfa form and I have the confirmation of the reason
>>> with
>>> this test :
>>> * run the search on
>>> https://localhost:8443/accounting/control/FindAgreement -> no error in
>>> log
>>> * apply this
>>>
>>> Index: applications/accounting/widget/AgreementForms.xml
>>> ===================================================================
>>> --- applications/accounting/widget/AgreementForms.xml (révision
>>> 1649945)
>>> +++ applications/accounting/widget/AgreementForms.xml (copie de
>>> travail)
>>> @@ -49,7 +49,19 @@
>>>           </field>
>>>       </form>
>>>
>>> -    <form name="ListAgreements" list-name="listIt" target="" title=""
>>> type="list" paginate-target="FindAgreement"
>>> +    <form name="ListAgreements" extends="ListAgreementsBase">
>>> +        <actions>
>>> +            <set field="entityName" value="Agreement"/>
>>> +            <service service-name="performFind" result-map="result"
>>> result-map-list="listIt">
>>> +                <field-map field-name="inputFields"
>>> from-field="requestParameters"/>
>>> +                <field-map field-name="entityName"
>>> from-field="entityName"/>
>>> +                <field-map field-name="orderBy"
>>> from-field="parameters.sortField"/>
>>> +                <field-map field-name="viewIndex"
>>> from-field="viewIndex"/>
>>> +                <field-map field-name="viewSize"
>>> from-field="viewSize"/>
>>> +            </service>
>>> +        </actions>
>>> +    </form>
>>> +    <form name="ListAgreementsBase" list-name="listIt" target=""
>>> title="" type="list" paginate-target="FindAgreement"
>>>           odd-row-style="alternate-row"
>>> default-table-style="basic-table
>>> hover-bar" header-row-style="header-row-2">
>>>           <actions>
>>>               <set field="entityName" value="Agreement"/>
>>>
>>>   * run the same search and on log we have :
>>>      [java] 2015-01-06 23:33:45,026 |http-bio-8443-exec-4
>>> |ServiceDispatcher             |T| Sync service
>>> [accounting/performFind]
>>> finished in [3] milliseconds
>>>       [java] 2015-01-06 23:33:45,029 |http-bio-8443-exec-4
>>> |ServiceDispatcher             |T| Sync service
>>> [accounting/performFind]
>>> finished in [3] milliseconds
>>>       [java] 2015-01-06 23:33:45,056 |Finalizer
>>> |EntityListIterator            |E|
>>>       [java]
>>> ====================================================================
>>>       [java]  EntityListIterator Not Closed for Entity [Agreement],
>>> caught in Finalize
>>>       [java]
>>> ====================================================================
>>>
>>> If I found the time I will try to check this week.
>>>
>>> Nicolas