MethodLength checkstyle rule

[Suraj Khurana-2]

Hello team,

Currently there are around 200 issues due method length.

Its default value is 150, we need to decide this configuration. In current
code, maximum method length I noticed is of 945 lines
(createOrder#OrderServices.java)

I have created OFBIZ-11915 for this, we can continue this effort as per
conclusions drawn in this thread.

Please share your thoughts on this.
--
Best Regards,
Suraj Khurana
SENIOR TECHNICAL CONSULTANT
mobile: [phone]
email: [hidden email]
*www.hotwax.co <http://www.hotwax.co/>*

[Suraj Khurana-2]

Hello team,

Any thoughts on this, IMO we can make it to 450 or something, it's quite
readable by then.
Please suggest.

--

Best Regards,
Suraj Khurana
Senior Technical Consultant


On Sun, Jul 26, 2020 at 9:12 PM Suraj Khurana <[hidden email]>
wrote:

> Hello team,
>
> Currently there are around 200 issues due method length.
>
> Its default value is 150, we need to decide this configuration. In current
> code, maximum method length I noticed is of 945 lines
> (createOrder#OrderServices.java)
>
> I have created OFBIZ-11915 for this, we can continue this effort as per
> conclusions drawn in this thread.
>
> Please share your thoughts on this.
> --
> Best Regards,
> Suraj Khurana
> SENIOR TECHNICAL CONSULTANT
> mobile: [phone]
> email: [hidden email]
> *www.hotwax.co <http://www.hotwax.co/>*
>

[Jacques Le Roux]

Hi Suraj,

Has I had no ideas about the best length, I was to suggest to add the 2 number (150+945) and to divide the total by 2.

This gives us around 550, I'd have suggested 500, but 450 is fine with me.

Thanks

Jacques

Le 29/07/2020 à 19:47, Suraj Khurana a écrit :

> Hello team,
>
> Any thoughts on this, IMO we can make it to 450 or something, it's quite
> readable by then.
> Please suggest.
>
> --
>
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant
>
>
> On Sun, Jul 26, 2020 at 9:12 PM Suraj Khurana <[hidden email]>
> wrote:
>
>> Hello team,
>>
>> Currently there are around 200 issues due method length.
>>
>> Its default value is 150, we need to decide this configuration. In current
>> code, maximum method length I noticed is of 945 lines
>> (createOrder#OrderServices.java)
>>
>> I have created OFBIZ-11915 for this, we can continue this effort as per
>> conclusions drawn in this thread.
>>
>> Please share your thoughts on this.
>> --
>> Best Regards,
>> Suraj Khurana
>> SENIOR TECHNICAL CONSULTANT
>> mobile: [phone]
>> email: [hidden email]
>> *www.hotwax.co <http://www.hotwax.co/>*
>>

[Suraj Khurana-2]

Thanks Jacques,

I think we can go with 500, I have uploaded the patch on the ticket
(OFBIZ-11915).

--
Best Regards,
Suraj Khurana
Senior Technical Consultant


On Thu, Jul 30, 2020 at 2:06 PM Jacques Le Roux <
[hidden email]> wrote:

> Hi Suraj,
>
> Has I had no ideas about the best length, I was to suggest to add the 2
> number (150+945) and to divide the total by 2.
>
> This gives us around 550, I'd have suggested 500, but 450 is fine with me.
>
> Thanks
>
> Jacques
>
> Le 29/07/2020 à 19:47, Suraj Khurana a écrit :
> > Hello team,
> >
> > Any thoughts on this, IMO we can make it to 450 or something, it's quite
> > readable by then.
> > Please suggest.
> >
> > --
> >
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
> >
> >
> > On Sun, Jul 26, 2020 at 9:12 PM Suraj Khurana <[hidden email]>
> > wrote:
> >
> >> Hello team,
> >>
> >> Currently there are around 200 issues due method length.
> >>
> >> Its default value is 150, we need to decide this configuration. In
> current
> >> code, maximum method length I noticed is of 945 lines
> >> (createOrder#OrderServices.java)
> >>
> >> I have created OFBIZ-11915 for this, we can continue this effort as per
> >> conclusions drawn in this thread.
> >>
> >> Please share your thoughts on this.
> >> --
> >> Best Regards,
> >> Suraj Khurana
> >> SENIOR TECHNICAL CONSULTANT
> >> mobile: [phone]
> >> email: [hidden email]
> >> *www.hotwax.co <http://www.hotwax.co/>*
> >>
>