Multiple order payments

[Rashko Rejmer]

I want to ask if anyone can tell me if my assumptions are right, because I see that there are some inaccuracy when trying to pay sales order by billing account and by another payment method.

I create sales order to party, that has a billing account. In the screen "Order Entry Payment Settings" I chose:
 - the billing account associated to this party;
 - bill up to - half of the order total;
 - COD(radio button)
 
My assumptions were that 2 OrderPaymentPreference records would be created:
 - first for the half amount of the order total for the billing account and
 - second for the other half amount of the order total for COD payment;
but 3 records are created - two for this billing account with half of the amount and one for COD with 0 amount.

Is this a bug or I am wrong with my assumptions?
If this is a bug please give me some tips me for the right solution and I will try to apply a patch!


Thanks,
Rashko Rejmer

[Jacques Le Roux]

Please ask this kind of question to user ML
http://docs.ofbiz.org/display/OFBADMIN/Mailing+Lists

Thanks

Jacques

De : "Rashko Rejmer" <[hidden email]>

>
> I want to ask if anyone can tell me if my assumptions are right, because I
> see that there are some inaccuracy when trying to pay sales order by billing
> account and by another payment method.
>
> I create sales order to party, that has a billing account. In the screen
> "Order Entry Payment Settings" I chose:
>  - the billing account associated to this party;
>  - bill up to - half of the order total;
>  - COD(radio button)
>  
> My assumptions were that 2 OrderPaymentPreference records would be created:
>  - first for the half amount of the order total for the billing account and
>  - second for the other half amount of the order total for COD payment;
> but 3 records are created - two for this billing account with half of the
> amount and one for COD with 0 amount.
>
> Is this a bug or I am wrong with my assumptions?
> If this is a bug please give me some tips me for the right solution and I
> will try to apply a patch!
>
>
> Thanks,
> Rashko Rejmer
> --
> View this message in context: http://www.nabble.com/Multiple-order-payments-tf4019138.html#a11414822
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.

[Jacopo Cappellato]

Hi Rashko,

this is interesting... and it seems definitely a bug.
Are you entering the order from the order manager application or
ecommerce? (please try with the order manager application)
Could you please try to use a credit card instead of COD (together with
billing account)? Is it happening the same thing?

Please let me know and I will help you to fix.

Jacopo


Rashko Rejmer wrote:

> I want to ask if anyone can tell me if my assumptions are right, because I
> see that there are some inaccuracy when trying to pay sales order by billing
> account and by another payment method.
>
> I create sales order to party, that has a billing account. In the screen
> "Order Entry Payment Settings" I chose:
>  - the billing account associated to this party;
>  - bill up to - half of the order total;
>  - COD(radio button)
>  
> My assumptions were that 2 OrderPaymentPreference records would be created:
>  - first for the half amount of the order total for the billing account and
>  - second for the other half amount of the order total for COD payment;
> but 3 records are created - two for this billing account with half of the
> amount and one for COD with 0 amount.
>
> Is this a bug or I am wrong with my assumptions?
> If this is a bug please give me some tips me for the right solution and I
> will try to apply a patch!
>
>
> Thanks,
> Rashko Rejmer

[Jacques Le Roux]

Sorry Rashko,

Did not see that you proposed to write a patch. My apologies.

Thanks

Jacques

De : "Jacopo Cappellato" <[hidden email]>

> Hi Rashko,
>
> this is interesting... and it seems definitely a bug.
> Are you entering the order from the order manager application or
> ecommerce? (please try with the order manager application)
> Could you please try to use a credit card instead of COD (together with
> billing account)? Is it happening the same thing?
>
> Please let me know and I will help you to fix.
>
> Jacopo
>
>
> Rashko Rejmer wrote:
> > I want to ask if anyone can tell me if my assumptions are right, because I
> > see that there are some inaccuracy when trying to pay sales order by billing
> > account and by another payment method.
> >
> > I create sales order to party, that has a billing account. In the screen
> > "Order Entry Payment Settings" I chose:
> >  - the billing account associated to this party;
> >  - bill up to - half of the order total;
> >  - COD(radio button)
> >  
> > My assumptions were that 2 OrderPaymentPreference records would be created:
> >  - first for the half amount of the order total for the billing account and
> >  - second for the other half amount of the order total for COD payment;
> > but 3 records are created - two for this billing account with half of the
> > amount and one for COD with 0 amount.
> >
> > Is this a bug or I am wrong with my assumptions?
> > If this is a bug please give me some tips me for the right solution and I
> > will try to apply a patch!
> >
> >
> > Thanks,
> > Rashko Rejmer

[Rashko Rejmer]

Hi Jacopo,

I entered the order from the order manager application. The problem still exists. I tried to use credit card - the result is the same. The strange thing is that if you want to pay order with billing account only, 2 OrderPaymentPreference entries are created - one for the whole amount of the order(EXT_BILLACT) and another with 0 amount(EXT_BILLACT). I was wondering if the appearance of the 0 amount record is bug or it has some special use?

I was looking in the code and I think that the problem is in ShoppingCart.makeAllOrderPaymentInfos() method.

Thanks,
Rashko Rejmer

[Jacopo Cappellato]

Rashko,

that is really strange since I recently tested a lot that process (when
I worked on the billing accounts refactoring) and that was not
happening... but I could be wrong, or something has changed after the tests.
You are right about the ShoppingCart.makeAllOrderPaymentInfos method: it
is the right place to start your investigations.
My first bet would be that in that method there is an approximation
issue, for example a fake 0.00001$ remaining, and so the system creates
a new record that once stored in the db, is approximated to 0.

Jacopo


Rashko Rejmer wrote:

> Hi Jacopo,
>
> I entered the order from the order manager application. The problem still
> exists. I tried to use credit card - the result is the same. The strange
> thing is that if you want to pay order with billing account only, 2
> OrderPaymentPreference entries are created - one for the whole amount of the
> order(EXT_BILLACT) and another with 0 amount(EXT_BILLACT). I was wondering
> if the appearance of the 0 amount record is bug or it has some special use?
>
> I was looking in the code and I think that the problem is in
> ShoppingCart.makeAllOrderPaymentInfos() method.
>
> Thanks,
> Rashko Rejmer

[Scott Gray]

Hi Jacopo, Rashko,

I just gave it a go and two billing account payment prefs were created, I'll
have a dig and see whats going on.

Regards
Scott

On 04/07/07, Jacopo Cappellato <[hidden email]> wrote:

>
> Rashko,
>
> that is really strange since I recently tested a lot that process (when
> I worked on the billing accounts refactoring) and that was not
> happening... but I could be wrong, or something has changed after the
> tests.
> You are right about the ShoppingCart.makeAllOrderPaymentInfos method: it
> is the right place to start your investigations.
> My first bet would be that in that method there is an approximation
> issue, for example a fake 0.00001$ remaining, and so the system creates
> a new record that once stored in the db, is approximated to 0.
>
> Jacopo
>
>
> Rashko Rejmer wrote:
> > Hi Jacopo,
> >
> > I entered the order from the order manager application. The problem
> still
> > exists. I tried to use credit card - the result is the same. The strange
> > thing is that if you want to pay order with billing account only, 2
> > OrderPaymentPreference entries are created - one for the whole amount of
> the
> > order(EXT_BILLACT) and another with 0 amount(EXT_BILLACT). I was
> wondering
> > if the appearance of the 0 amount record is bug or it has some special
> use?
> >
> > I was looking in the code and I think that the problem is in
> > ShoppingCart.makeAllOrderPaymentInfos() method.
> >
> > Thanks,
> > Rashko Rejmer
>
>
>

[Scott Gray]

Ok should be fixed in rev. 553114

Regards
Scott

On 04/07/07, Scott Gray <[hidden email]> wrote:

>
> Hi Jacopo, Rashko,
>
> I just gave it a go and two billing account payment prefs were created,
> I'll have a dig and see whats going on.
>
> Regards
> Scott
>
> On 04/07/07, Jacopo Cappellato <[hidden email]> wrote:
> >
> > Rashko,
> >
> > that is really strange since I recently tested a lot that process (when
> > I worked on the billing accounts refactoring) and that was not
> > happening... but I could be wrong, or something has changed after the
> > tests.
> > You are right about the ShoppingCart.makeAllOrderPaymentInfos method: it
> > is the right place to start your investigations.
> > My first bet would be that in that method there is an approximation
> > issue, for example a fake 0.00001$ remaining, and so the system creates
> > a new record that once stored in the db, is approximated to 0.
> >
> > Jacopo
> >
> >
> > Rashko Rejmer wrote:
> > > Hi Jacopo,
> > >
> > > I entered the order from the order manager application. The problem
> > still
> > > exists. I tried to use credit card - the result is the same. The
> > strange
> > > thing is that if you want to pay order with billing account only, 2
> > > OrderPaymentPreference entries are created - one for the whole amount
> > of the
> > > order(EXT_BILLACT) and another with 0 amount(EXT_BILLACT). I was
> > wondering
> > > if the appearance of the 0 amount record is bug or it has some special
> > use?
> > >
> > > I was looking in the code and I think that the problem is in
> > > ShoppingCart.makeAllOrderPaymentInfos() method.
> > >
> > > Thanks,
> > > Rashko Rejmer
> >
> >
> >
>

[Scott Gray]

Oops sorry Rashko, I should have left this for you to fix, I read your
emails too quickly.  Fixing bugs is a great way to get better acquainted
with OFBiz.

Regards
Scott

On 04/07/07, Jacques Le Roux <[hidden email]> wrote:

>
> Sorry Rashko,
>
> Did not see that you proposed to write a patch. My apologies.
>
> Thanks
>
> Jacques
>
> De : "Jacopo Cappellato" <[hidden email]>
> > Hi Rashko,
> >
> > this is interesting... and it seems definitely a bug.
> > Are you entering the order from the order manager application or
> > ecommerce? (please try with the order manager application)
> > Could you please try to use a credit card instead of COD (together with
> > billing account)? Is it happening the same thing?
> >
> > Please let me know and I will help you to fix.
> >
> > Jacopo
> >
> >
> > Rashko Rejmer wrote:
> > > I want to ask if anyone can tell me if my assumptions are right,
> because I
> > > see that there are some inaccuracy when trying to pay sales order by
> billing
> > > account and by another payment method.
> > >
> > > I create sales order to party, that has a billing account. In the
> screen
> > > "Order Entry Payment Settings" I chose:
> > >  - the billing account associated to this party;
> > >  - bill up to - half of the order total;
> > >  - COD(radio button)
> > >
> > > My assumptions were that 2 OrderPaymentPreference records would be
> created:
> > >  - first for the half amount of the order total for the billing
> account and
> > >  - second for the other half amount of the order total for COD
> payment;
> > > but 3 records are created - two for this billing account with half of
> the
> > > amount and one for COD with 0 amount.
> > >
> > > Is this a bug or I am wrong with my assumptions?
> > > If this is a bug please give me some tips me for the right solution
> and I
> > > will try to apply a patch!
> > >
> > >
> > > Thanks,
> > > Rashko Rejmer
>

[Rashko Rejmer]

Hi Jacopo, Scott, Jacques,

No problem, the important thing is that the problems is fixed. Thanks a lot.

Regards
Rashko Rejmer