No values in Trial Balance report

[Sharan-F]

Hi

I've been doing some testing on the latest Hotwax demo and the Trial Balance report isnt showing  any values even if the GL Account does have a credit and/or debit values.

I clicked the link to an account (400000 Sales) off the Trial Balance report for Company then did a 'Find' on the Accounting Transaction entries and saw that there were values posted from sales invoices that are not showing up on the Trial Balance.

As another check I looked at the Income Statement for the same data and the correct values from the GL Account for Sales is appearing there.

Thanks
Sharan

[Enrique Ruibal]

I think there is an error in this report format, as I am sure it was working before...

-Enrique Ruibal

[Scott Gray]

I had a quick look and the screen definition appears to be missing the
service call that would pull up all the values, the screen def could
have just been copied from another originally and the service never
implemented...

Regards
Scott

2008/8/25 Enrique Ruibal <[hidden email]>:

>
> I think there is an error in this report format, as I am sure it was working
> before...
>
> -Enrique Ruibal
>
> --
> View this message in context: http://www.nabble.com/No-values-in-Trial-Balance-report-tp19136068p19138145.html
> Sent from the OFBiz - User mailing list archive at Nabble.com.
>
>

[Jacopo Cappellato-3]

no, it was actually working fine and I the service is probably called  
from the action section of the form.

I will have a look at this.

Jacopo

On Aug 25, 2008, at 7:33 AM, Scott Gray wrote:

> I had a quick look and the screen definition appears to be missing the
> service call that would pull up all the values, the screen def could
> have just been copied from another originally and the service never
> implemented...
>
> Regards
> Scott
>
> 2008/8/25 Enrique Ruibal <[hidden email]>:
>>
>> I think there is an error in this report format, as I am sure it  
>> was working
>> before...
>>
>> -Enrique Ruibal
>>
>> --
>> View this message in context: http://www.nabble.com/No-values-in-Trial-Balance-report-tp19136068p19138145.html
>> Sent from the OFBiz - User mailing list archive at Nabble.com.
>>
>>

[Scott Gray]

Hi Jacopo

You're right about the data being pulled in the form rather than
screen, my look was perhaps a little too quick :-)

Even though you said you would look at this I was curious so I took a
look myself and the problem is actually from a change I made to the
form widget in rev. 684244.

I'm having a another look at the code now and will commit a fix shortly.

Regards
Scott

2008/8/25 Jacopo Cappellato <[hidden email]>:

> no, it was actually working fine and I the service is probably called from
> the action section of the form.
>
> I will have a look at this.
>
> Jacopo
>
> On Aug 25, 2008, at 7:33 AM, Scott Gray wrote:
>
>> I had a quick look and the screen definition appears to be missing the
>> service call that would pull up all the values, the screen def could
>> have just been copied from another originally and the service never
>> implemented...
>>
>> Regards
>> Scott
>>
>> 2008/8/25 Enrique Ruibal <[hidden email]>:
>>>
>>> I think there is an error in this report format, as I am sure it was
>>> working
>>> before...
>>>
>>> -Enrique Ruibal
>>>
>>> --
>>> View this message in context:
>>> http://www.nabble.com/No-values-in-Trial-Balance-report-tp19136068p19138145.html
>>> Sent from the OFBiz - User mailing list archive at Nabble.com.
>>>
>>>
>
>

[Scott Gray]

Ok I've looked at the code and decided it is correct and that it is
the form definition that needs to change.

When a form of type="single" is being used and default-map-name is set
then you cannot pull values straight off the context using the form
field's name or entry-name attributes, they are only applicable to
entries in the default map.  Since 684244 the same is now true for
list forms, so if you want to access fields in the context map you
need to use the description attribute of the display element or any
other attribute that supports ${} notation for retrieving field
values.

So for the trial balance form this:
<field name="debit" entry-name="absolutePostedBalance"
use-when="showDebit"><display type="currency"
currency="${currencyUomId}"/></field>
now becomes this:
<field name="credit" use-when="showCredit"><display
description="${absolutePostedBalance}" type="currency"
currency="${currencyUomId}"/></field>

If anybody thinks that sounds crazy let me know otherwise I'll go
through and check all of the list forms and correct any needing it.

Regards
Scott

2008/8/26 Scott Gray <[hidden email]>:

> Hi Jacopo
>
> You're right about the data being pulled in the form rather than
> screen, my look was perhaps a little too quick :-)
>
> Even though you said you would look at this I was curious so I took a
> look myself and the problem is actually from a change I made to the
> form widget in rev. 684244.
>
> I'm having a another look at the code now and will commit a fix shortly.
>
> Regards
> Scott
>
> 2008/8/25 Jacopo Cappellato <[hidden email]>:
>> no, it was actually working fine and I the service is probably called from
>> the action section of the form.
>>
>> I will have a look at this.
>>
>> Jacopo
>>
>> On Aug 25, 2008, at 7:33 AM, Scott Gray wrote:
>>
>>> I had a quick look and the screen definition appears to be missing the
>>> service call that would pull up all the values, the screen def could
>>> have just been copied from another originally and the service never
>>> implemented...
>>>
>>> Regards
>>> Scott
>>>
>>> 2008/8/25 Enrique Ruibal <[hidden email]>:
>>>>
>>>> I think there is an error in this report format, as I am sure it was
>>>> working
>>>> before...
>>>>
>>>> -Enrique Ruibal
>>>>
>>>> --
>>>> View this message in context:
>>>> http://www.nabble.com/No-values-in-Trial-Balance-report-tp19136068p19138145.html
>>>> Sent from the OFBiz - User mailing list archive at Nabble.com.
>>>>
>>>>
>>
>>
>

[Jacopo Cappellato-3]

Scott,

thanks for looking at this, much appreciated.
Unfortunately I don't have time at the moment to look at the form  
definition, but I'd say that if the modifications you are suggesting  
will fix the issue, then please commit them.
That form is already messed up (let's say that I have pushed at its  
limits the form widgets features!) so don't worry too much about being  
too crazy (sooner or later we may also refactor it into more  
traditional code).
But if i the meantime you can provide a fix, please go for it.

Jacopo

On Aug 26, 2008, at 6:01 AM, Scott Gray wrote:

> Ok I've looked at the code and decided it is correct and that it is
> the form definition that needs to change.
>
> When a form of type="single" is being used and default-map-name is set
> then you cannot pull values straight off the context using the form
> field's name or entry-name attributes, they are only applicable to
> entries in the default map.  Since 684244 the same is now true for
> list forms, so if you want to access fields in the context map you
> need to use the description attribute of the display element or any
> other attribute that supports ${} notation for retrieving field
> values.
>
> So for the trial balance form this:
> <field name="debit" entry-name="absolutePostedBalance"
> use-when="showDebit"><display type="currency"
> currency="${currencyUomId}"/></field>
> now becomes this:
> <field name="credit" use-when="showCredit"><display
> description="${absolutePostedBalance}" type="currency"
> currency="${currencyUomId}"/></field>
>
> If anybody thinks that sounds crazy let me know otherwise I'll go
> through and check all of the list forms and correct any needing it.
>
> Regards
> Scott
>
> 2008/8/26 Scott Gray <[hidden email]>:
>> Hi Jacopo
>>
>> You're right about the data being pulled in the form rather than
>> screen, my look was perhaps a little too quick :-)
>>
>> Even though you said you would look at this I was curious so I took a
>> look myself and the problem is actually from a change I made to the
>> form widget in rev. 684244.
>>
>> I'm having a another look at the code now and will commit a fix  
>> shortly.
>>
>> Regards
>> Scott
>>
>> 2008/8/25 Jacopo Cappellato <[hidden email]>:
>>> no, it was actually working fine and I the service is probably  
>>> called from
>>> the action section of the form.
>>>
>>> I will have a look at this.
>>>
>>> Jacopo
>>>
>>> On Aug 25, 2008, at 7:33 AM, Scott Gray wrote:
>>>
>>>> I had a quick look and the screen definition appears to be  
>>>> missing the
>>>> service call that would pull up all the values, the screen def  
>>>> could
>>>> have just been copied from another originally and the service never
>>>> implemented...
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> 2008/8/25 Enrique Ruibal <[hidden email]>:
>>>>>
>>>>> I think there is an error in this report format, as I am sure it  
>>>>> was
>>>>> working
>>>>> before...
>>>>>
>>>>> -Enrique Ruibal
>>>>>
>>>>> --
>>>>> View this message in context:
>>>>> http://www.nabble.com/No-values-in-Trial-Balance-report-tp19136068p19138145.html
>>>>> Sent from the OFBiz - User mailing list archive at Nabble.com.
>>>>>
>>>>>
>>>
>>>
>>

[Scott Gray]

All fixed up in rev. 689040, thanks Sharan and Jacopo

Regards
Scott

2008/8/26 Jacopo Cappellato <[hidden email]>:

> Scott,
>
> thanks for looking at this, much appreciated.
> Unfortunately I don't have time at the moment to look at the form
> definition, but I'd say that if the modifications you are suggesting will
> fix the issue, then please commit them.
> That form is already messed up (let's say that I have pushed at its limits
> the form widgets features!) so don't worry too much about being too crazy
> (sooner or later we may also refactor it into more traditional code).
> But if i the meantime you can provide a fix, please go for it.
>
> Jacopo
>
> On Aug 26, 2008, at 6:01 AM, Scott Gray wrote:
>
>> Ok I've looked at the code and decided it is correct and that it is
>> the form definition that needs to change.
>>
>> When a form of type="single" is being used and default-map-name is set
>> then you cannot pull values straight off the context using the form
>> field's name or entry-name attributes, they are only applicable to
>> entries in the default map.  Since 684244 the same is now true for
>> list forms, so if you want to access fields in the context map you
>> need to use the description attribute of the display element or any
>> other attribute that supports ${} notation for retrieving field
>> values.
>>
>> So for the trial balance form this:
>> <field name="debit" entry-name="absolutePostedBalance"
>> use-when="showDebit"><display type="currency"
>> currency="${currencyUomId}"/></field>
>> now becomes this:
>> <field name="credit" use-when="showCredit"><display
>> description="${absolutePostedBalance}" type="currency"
>> currency="${currencyUomId}"/></field>
>>
>> If anybody thinks that sounds crazy let me know otherwise I'll go
>> through and check all of the list forms and correct any needing it.
>>
>> Regards
>> Scott
>>
>> 2008/8/26 Scott Gray <[hidden email]>:
>>>
>>> Hi Jacopo
>>>
>>> You're right about the data being pulled in the form rather than
>>> screen, my look was perhaps a little too quick :-)
>>>
>>> Even though you said you would look at this I was curious so I took a
>>> look myself and the problem is actually from a change I made to the
>>> form widget in rev. 684244.
>>>
>>> I'm having a another look at the code now and will commit a fix shortly.
>>>
>>> Regards
>>> Scott
>>>
>>> 2008/8/25 Jacopo Cappellato <[hidden email]>:
>>>>
>>>> no, it was actually working fine and I the service is probably called
>>>> from
>>>> the action section of the form.
>>>>
>>>> I will have a look at this.
>>>>
>>>> Jacopo
>>>>
>>>> On Aug 25, 2008, at 7:33 AM, Scott Gray wrote:
>>>>
>>>>> I had a quick look and the screen definition appears to be missing the
>>>>> service call that would pull up all the values, the screen def could
>>>>> have just been copied from another originally and the service never
>>>>> implemented...
>>>>>
>>>>> Regards
>>>>> Scott
>>>>>
>>>>> 2008/8/25 Enrique Ruibal <[hidden email]>:
>>>>>>
>>>>>> I think there is an error in this report format, as I am sure it was
>>>>>> working
>>>>>> before...
>>>>>>
>>>>>> -Enrique Ruibal
>>>>>>
>>>>>> --
>>>>>> View this message in context:
>>>>>>
>>>>>> http://www.nabble.com/No-values-in-Trial-Balance-report-tp19136068p19138145.html
>>>>>> Sent from the OFBiz - User mailing list archive at Nabble.com.
>>>>>>
>>>>>>
>>>>
>>>>
>>>
>
>