OFBIZ-10693 vs OFBIZ-10694

[Jacques Le Roux]

Hi,

Mathieu and I propose 2 solutions for "gradlew generateOfbizDocumentation’ fails with Gradle 5.0"

Please check which one you would prefer to be committed

Thanks

Jacques

[Jacques Le Roux]

Le 07/12/2018 à 11:06, Jacques Le Roux a écrit :

> Hi,
>
> Mathieu and I propose 2 solutions for "gradlew generateOfbizDocumentation’ fails with Gradle 5.0"
>
> Please check which one you would prefer to be committed
>
> Thanks
>
> Jacques
>
>

I think I did not give enough elements.

Mathieu suggested to use

    -        classpath 'org.asciidoctor:asciidoctor-gradle-plugin:1.5.9.2'
    +        classpath 'org.asciidoctor:asciidoctor-gradle-plugin:1.5.8.1'

I suggested

    +    configurations.all { exclude module: "groovy-all" } // Temporary workaround, see OFBIZ-10694

We crossed on wire so were not influenced. I think now that my proposition, though temporary, as the merit of not depend on a specific
asciidoctor-gradle-plugin version

I did not invent it, it comes from https://github.com/gradle/gradle/issues/3698

Thanks for your opinions to fix this issue ASAP

Jacques

[Shi Jinghai-3]

My + 1 to Mathieu's method, as I have confidence it will not affect dependencies check and tasks such as eclipseClasspath.


-----邮件原件-----
发件人: Jacques Le Roux [mailto:[hidden email]]
发送时间: 2018年12月11日 23:13
收件人: [hidden email]
主题: Re: OFBIZ-10693 vs OFBIZ-10694

Le 07/12/2018 à 11:06, Jacques Le Roux a écrit :

> Hi,
>
> Mathieu and I propose 2 solutions for "gradlew generateOfbizDocumentation’ fails with Gradle 5.0"
>
> Please check which one you would prefer to be committed
>
> Thanks
>
> Jacques
>
>

I think I did not give enough elements.

Mathieu suggested to use

    -        classpath 'org.asciidoctor:asciidoctor-gradle-plugin:1.5.9.2'
    +        classpath 'org.asciidoctor:asciidoctor-gradle-plugin:1.5.8.1'

I suggested

    +    configurations.all { exclude module: "groovy-all" } // Temporary workaround, see OFBIZ-10694

We crossed on wire so were not influenced. I think now that my proposition, though temporary, as the merit of not depend on a specific
asciidoctor-gradle-plugin version

I did not invent it, it comes from https://github.com/gradle/gradle/issues/3698

Thanks for your opinions to fix this issue ASAP

Jacques

[Jacques Le Roux]

Thanks Jinghai for your opinion,

Fixed with OFBIZ-10693

Jacques

Le 07/12/2018 à 11:06, Jacques Le Roux a écrit :

> Hi,
>
> Mathieu and I propose 2 solutions for "gradlew generateOfbizDocumentation’ fails with Gradle 5.0"
>
> Please check which one you would prefer to be committed
>
> Thanks
>
> Jacques
>
>

[Shi Jinghai-3]

Hi Jacques,

Love you! :)


-----邮件原件-----
发件人: Jacques Le Roux [mailto:[hidden email]]
发送时间: 2018年12月13日 22:55
收件人: [hidden email]
主题: Re: OFBIZ-10693 vs OFBIZ-10694

Thanks Jinghai for your opinion,

Fixed with OFBIZ-10693

Jacques

Le 07/12/2018 à 11:06, Jacques Le Roux a écrit :

> Hi,
>
> Mathieu and I propose 2 solutions for "gradlew generateOfbizDocumentation’ fails with Gradle 5.0"
>
> Please check which one you would prefer to be committed
>
> Thanks
>
> Jacques
>
>