OFBIZ-2805 For Jacques

[Schumann]

Dear Jacques,

For the captioned JIRA note, it works still as opening but then closing immediately.
I’m using version 16.11.05 & 16.11.04 (windows 10 + Chrome/Firefox). Both versions are the same in my end.

Could you pls elaborate when exactly you’ve changed to fix it as you mentioned in OFBIZ-2805.
Best Regards
Schumann

[Jacques Le Roux]

Hi Schumann Ye,

These changes are very old (almost 10 years): http://svn.apache.org/viewvc?view=revision&revision=r811528 so I guess they are irrelevant now.

I just tried with stable demo (ie R16 branch). It seems it does not work at all, or I don't see the image popping up and disappearing as you say.

When you click on the image it calls the js function popupDetail() which seems to do nothing.

This function is embedded in /ecommerce/template/catalog/ProductDetail.ftl (there is a similar one in is a duplicate of what is in
order/template/entry/catalog/ProductDetail.ftl)

But try with https://demo-stable.ofbiz.apache.org/ecommerce/micro-chrome-widget-WG-1111-p

At bottom there is "Try these instead of Micro Chrome Widget:" if you hover on the image it works

It seems to me that popupDetail() is obsolete and has been replaced by a CSS trick, the one which works when you hover the bottom image. But it's not
used on product detail pages.

Note that this trick has been broken in trunk where the Bootstrap front-end framework is used, hovering no longer works.

Sorry I have no more time to spend on that

HTH

Jacques

Le 27/01/2019 à 03:27, Schumann Ye a écrit :
> Dear Jacques,
>
> For the captioned JIRA note, it works still as opening but then closing immediately.
> I’m using version 16.11.05 & 16.11.04 (windows 10 + Chrome/Firefox). Both versions are the same in my end.
>
> Could you pls elaborate when exactly you’ve changed to fix it as you mentioned in OFBIZ-2805.
> Best Regards
> Schumann
>

[Schumann]

Hi Jacques,

You’ve been always helpful.
After some case studies, I’ve kind of found out the root cause.

It’s because of the safety mechanism of Chrome/Firefox/Edge except IE.
The current codes work for IE but not the previous main browsers because the system treats it calling maliciously since it’s not directly being called by a direct user’s click.
I’m still debugging it and once I had a solution then I will update a JIRA note for your next release.

Have a nice day!
Schumann
发件人: Jacques Le Roux<mailto:[hidden email]>
发送时间: 2019年1月27日 17:56
收件人: [hidden email]<mailto:[hidden email]>
主题: Re: OFBIZ-2805 For Jacques

Hi Schumann Ye,

These changes are very old (almost 10 years): http://svn.apache.org/viewvc?view=revision&revision=r811528 so I guess they are irrelevant now.

I just tried with stable demo (ie R16 branch). It seems it does not work at all, or I don't see the image popping up and disappearing as you say.

When you click on the image it calls the js function popupDetail() which seems to do nothing.

This function is embedded in /ecommerce/template/catalog/ProductDetail.ftl (there is a similar one in is a duplicate of what is in
order/template/entry/catalog/ProductDetail.ftl)

But try with https://demo-stable.ofbiz.apache.org/ecommerce/micro-chrome-widget-WG-1111-p

At bottom there is "Try these instead of Micro Chrome Widget:" if you hover on the image it works

It seems to me that popupDetail() is obsolete and has been replaced by a CSS trick, the one which works when you hover the bottom image. But it's not
used on product detail pages.

Note that this trick has been broken in trunk where the Bootstrap front-end framework is used, hovering no longer works.

Sorry I have no more time to spend on that

HTH

Jacques

Le 27/01/2019 à 03:27, Schumann Ye a écrit :
> Dear Jacques,
>
> For the captioned JIRA note, it works still as opening but then closing immediately.
> I’m using version 16.11.05 & 16.11.04 (windows 10 + Chrome/Firefox). Both versions are the same in my end.
>
> Could you pls elaborate when exactly you’ve changed to fix it as you mentioned in OFBIZ-2805.
> Best Regards
> Schumann
>

[Jacques Le Roux]

Great news, thank Ye

Jacques

Le 28/01/2019 à 13:09, Schumann Ye a écrit :

> Hi Jacques,
>
> You’ve been always helpful.
> After some case studies, I’ve kind of found out the root cause.
>
> It’s because of the safety mechanism of Chrome/Firefox/Edge except IE.
> The current codes work for IE but not the previous main browsers because the system treats it calling maliciously since it’s not directly being called by a direct user’s click.
> I’m still debugging it and once I had a solution then I will update a JIRA note for your next release.
>
> Have a nice day!
> Schumann
> 发件人: Jacques Le Roux<mailto:[hidden email]>
> 发送时间: 2019年1月27日 17:56
> 收件人: [hidden email]<mailto:[hidden email]>
> 主题: Re: OFBIZ-2805 For Jacques
>
> Hi Schumann Ye,
>
> These changes are very old (almost 10 years): http://svn.apache.org/viewvc?view=revision&revision=r811528 so I guess they are irrelevant now.
>
> I just tried with stable demo (ie R16 branch). It seems it does not work at all, or I don't see the image popping up and disappearing as you say.
>
> When you click on the image it calls the js function popupDetail() which seems to do nothing.
>
> This function is embedded in /ecommerce/template/catalog/ProductDetail.ftl (there is a similar one in is a duplicate of what is in
> order/template/entry/catalog/ProductDetail.ftl)
>
> But try with https://demo-stable.ofbiz.apache.org/ecommerce/micro-chrome-widget-WG-1111-p
>
> At bottom there is "Try these instead of Micro Chrome Widget:" if you hover on the image it works
>
> It seems to me that popupDetail() is obsolete and has been replaced by a CSS trick, the one which works when you hover the bottom image. But it's not
> used on product detail pages.
>
> Note that this trick has been broken in trunk where the Bootstrap front-end framework is used, hovering no longer works.
>
> Sorry I have no more time to spend on that
>
> HTH
>
> Jacques
>
> Le 27/01/2019 à 03:27, Schumann Ye a écrit :
>> Dear Jacques,
>>
>> For the captioned JIRA note, it works still as opening but then closing immediately.
>> I’m using version 16.11.05 & 16.11.04 (windows 10 + Chrome/Firefox). Both versions are the same in my end.
>>
>> Could you pls elaborate when exactly you’ve changed to fix it as you mentioned in OFBIZ-2805.
>> Best Regards
>> Schumann
>>