Hi all,
Propose to allow developer to open FTL source file from the browser. This saves times locating for the template in the IDE. JIRA issue is created at OFBIZ-12018 with patch file. Regards, James |
Dear James,
Thanks for your effort, looks good to me. You have already taken care of dev and prod environment settings for this. I never tried to open FTL in a browser, hopefully people used to do it. Best Regards, -- Rishi Solanki *CTO, Mindpath Technology* Intelligent Solutions cell: +91-98932-87847 LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> On Sat, Sep 19, 2020 at 12:46 PM James Yong <[hidden email]> wrote: > Hi all, > > Propose to allow developer to open FTL source file from the browser. > This saves times locating for the template in the IDE. > JIRA issue is created at OFBIZ-12018 with patch file. > > Regards, > James > |
Administrator
|
Hi James,
I just tried w/o looking into details. I got an issue when getting to https://localhost:8443/catalog/control/login?USERNAME=admin&PASSWORD=ofbiz&JavaScriptEnabled=Y 2020-09-20 12:19:36,510 |jsse-nio-8443-exec-4 |ControlServlet |E| Error in request handler: java.lang.StringIndexOutOfBoundsException: String index out of range: -1 at java.lang.String.substring(String.java:1967) ~[?:1.8.0_202] at org.apache.ofbiz.base.util.UtilHtml.getVisualThemeFolderNamesToExempt(UtilHtml.java:133) ~[main/:?] I got the same w/ https://localhost:8443/catalog/control/main# which was the URL returned by the error above. Same also when using https://localhost:8443/catalog/control/main 1st time (ie before login once) but OK after. Then I tried to use my simplest default editor: Scite. I put <<widget.dev.cmd.openSourceFile=C:\Scite\scite ${sourceLocation}>> I got no result but a JavaScript message saying "Source file opened". Do I miss something? How would it be for Eclipse? Also I don't think it should be enabled OOTB (ie NONE should be used) by default. Because each screen stays on with these information blocking most links for 5 seconds Thanks Jacques Le 19/09/2020 à 20:52, Rishi Solanki a écrit : > Dear James, > Thanks for your effort, looks good to me. You have already taken care of > dev and prod environment settings for this. > I never tried to open FTL in a browser, hopefully people used to do it. > > Best Regards, > -- > Rishi Solanki > *CTO, Mindpath Technology* > Intelligent Solutions > cell: +91-98932-87847 > LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> > > > On Sat, Sep 19, 2020 at 12:46 PM James Yong <[hidden email]> wrote: > >> Hi all, >> >> Propose to allow developer to open FTL source file from the browser. >> This saves times locating for the template in the IDE. >> JIRA issue is created at OFBIZ-12018 with patch file. >> >> Regards, >> James >> |
Administrator
|
James,
>How would it be for Eclipse? OK found for Eclipse as you documented: https://wiki.eclipse.org/Eclipse/OpenFileFeature I found another issue which seems related to the one Olivier reported in the Jira. In ecommerce if, from the categories tree you get to one of the categories, the labels stays (tested w/ labels only) Jacques Le 20/09/2020 à 12:51, Jacques Le Roux a écrit : > Hi James, > > I just tried w/o looking into details. I got an issue when getting to > > https://localhost:8443/catalog/control/login?USERNAME=admin&PASSWORD=ofbiz&JavaScriptEnabled=Y > > 2020-09-20 12:19:36,510 |jsse-nio-8443-exec-4 |ControlServlet |E| Error in request handler: > java.lang.StringIndexOutOfBoundsException: String index out of range: -1 > at java.lang.String.substring(String.java:1967) ~[?:1.8.0_202] > at org.apache.ofbiz.base.util.UtilHtml.getVisualThemeFolderNamesToExempt(UtilHtml.java:133) ~[main/:?] > > I got the same w/ https://localhost:8443/catalog/control/main# which was the URL returned by the error above. > Same also when using https://localhost:8443/catalog/control/main 1st time (ie before login once) but OK after. > > Then I tried to use my simplest default editor: Scite. > I put <<widget.dev.cmd.openSourceFile=C:\Scite\scite ${sourceLocation}>> > I got no result but a JavaScript message saying "Source file opened". Do I miss something? How would it be for Eclipse? > > Also I don't think it should be enabled OOTB (ie NONE should be used) by default. > Because each screen stays on with these information blocking most links for 5 seconds > > Thanks > > Jacques > > Le 19/09/2020 à 20:52, Rishi Solanki a écrit : >> Dear James, >> Thanks for your effort, looks good to me. You have already taken care of >> dev and prod environment settings for this. >> I never tried to open FTL in a browser, hopefully people used to do it. >> >> Best Regards, >> -- >> Rishi Solanki >> *CTO, Mindpath Technology* >> Intelligent Solutions >> cell: +91-98932-87847 >> LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> >> >> >> On Sat, Sep 19, 2020 at 12:46 PM James Yong <[hidden email]> wrote: >> >>> Hi all, >>> >>> Propose to allow developer to open FTL source file from the browser. >>> This saves times locating for the template in the IDE. >>> JIRA issue is created at OFBIZ-12018 with patch file. >>> >>> Regards, >>> James >>> |
Administrator
|
There is even something more annoying. At least when using labels only and the categories tree.
If you revert the changes done by patching the feature remains even after a "clean". I don't understand why since the patch only makes changes in Java, JavaScript and properties files, w/ any data being stored in DB. I did not get more into details for tonight... Le 20/09/2020 à 19:14, Jacques Le Roux a écrit : > James, > > >How would it be for Eclipse? > OK found for Eclipse as you documented: https://wiki.eclipse.org/Eclipse/OpenFileFeature > > I found another issue which seems related to the one Olivier reported in the Jira. > In ecommerce if, from the categories tree you get to one of the categories, the labels stays (tested w/ labels only) > > Jacques > > Le 20/09/2020 à 12:51, Jacques Le Roux a écrit : >> Hi James, >> >> I just tried w/o looking into details. I got an issue when getting to >> >> https://localhost:8443/catalog/control/login?USERNAME=admin&PASSWORD=ofbiz&JavaScriptEnabled=Y >> >> 2020-09-20 12:19:36,510 |jsse-nio-8443-exec-4 |ControlServlet |E| Error in request handler: >> java.lang.StringIndexOutOfBoundsException: String index out of range: -1 >> at java.lang.String.substring(String.java:1967) ~[?:1.8.0_202] >> at org.apache.ofbiz.base.util.UtilHtml.getVisualThemeFolderNamesToExempt(UtilHtml.java:133) ~[main/:?] >> >> I got the same w/ https://localhost:8443/catalog/control/main# which was the URL returned by the error above. >> Same also when using https://localhost:8443/catalog/control/main 1st time (ie before login once) but OK after. >> >> Then I tried to use my simplest default editor: Scite. >> I put <<widget.dev.cmd.openSourceFile=C:\Scite\scite ${sourceLocation}>> >> I got no result but a JavaScript message saying "Source file opened". Do I miss something? How would it be for Eclipse? >> >> Also I don't think it should be enabled OOTB (ie NONE should be used) by default. >> Because each screen stays on with these information blocking most links for 5 seconds >> >> Thanks >> >> Jacques >> >> Le 19/09/2020 à 20:52, Rishi Solanki a écrit : >>> Dear James, >>> Thanks for your effort, looks good to me. You have already taken care of >>> dev and prod environment settings for this. >>> I never tried to open FTL in a browser, hopefully people used to do it. >>> >>> Best Regards, >>> -- >>> Rishi Solanki >>> *CTO, Mindpath Technology* >>> Intelligent Solutions >>> cell: +91-98932-87847 >>> LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> >>> >>> >>> On Sat, Sep 19, 2020 at 12:46 PM James Yong <[hidden email]> wrote: >>> >>>> Hi all, >>>> >>>> Propose to allow developer to open FTL source file from the browser. >>>> This saves times locating for the template in the IDE. >>>> JIRA issue is created at OFBIZ-12018 with patch file. >>>> >>>> Regards, >>>> James >>>> |
Administrator
|
About Olivier's comment, it's in OFBIZ-12002
TIA Le 20/09/2020 à 19:29, Jacques Le Roux a écrit : > There is even something more annoying. At least when using labels only and the categories tree. > If you revert the changes done by patching the feature remains even after a "clean". > I don't understand why since the patch only makes changes in Java, JavaScript and properties files, w/ any data being stored in DB. > I did not get more into details for tonight... > > Le 20/09/2020 à 19:14, Jacques Le Roux a écrit : >> James, >> >> >How would it be for Eclipse? >> OK found for Eclipse as you documented: https://wiki.eclipse.org/Eclipse/OpenFileFeature >> >> I found another issue which seems related to the one Olivier reported in the Jira. >> In ecommerce if, from the categories tree you get to one of the categories, the labels stays (tested w/ labels only) >> >> Jacques >> >> Le 20/09/2020 à 12:51, Jacques Le Roux a écrit : >>> Hi James, >>> >>> I just tried w/o looking into details. I got an issue when getting to >>> >>> https://localhost:8443/catalog/control/login?USERNAME=admin&PASSWORD=ofbiz&JavaScriptEnabled=Y >>> >>> 2020-09-20 12:19:36,510 |jsse-nio-8443-exec-4 |ControlServlet |E| Error in request handler: >>> java.lang.StringIndexOutOfBoundsException: String index out of range: -1 >>> at java.lang.String.substring(String.java:1967) ~[?:1.8.0_202] >>> at org.apache.ofbiz.base.util.UtilHtml.getVisualThemeFolderNamesToExempt(UtilHtml.java:133) ~[main/:?] >>> >>> I got the same w/ https://localhost:8443/catalog/control/main# which was the URL returned by the error above. >>> Same also when using https://localhost:8443/catalog/control/main 1st time (ie before login once) but OK after. >>> >>> Then I tried to use my simplest default editor: Scite. >>> I put <<widget.dev.cmd.openSourceFile=C:\Scite\scite ${sourceLocation}>> >>> I got no result but a JavaScript message saying "Source file opened". Do I miss something? How would it be for Eclipse? >>> >>> Also I don't think it should be enabled OOTB (ie NONE should be used) by default. >>> Because each screen stays on with these information blocking most links for 5 seconds >>> >>> Thanks >>> >>> Jacques >>> >>> Le 19/09/2020 à 20:52, Rishi Solanki a écrit : >>>> Dear James, >>>> Thanks for your effort, looks good to me. You have already taken care of >>>> dev and prod environment settings for this. >>>> I never tried to open FTL in a browser, hopefully people used to do it. >>>> >>>> Best Regards, >>>> -- >>>> Rishi Solanki >>>> *CTO, Mindpath Technology* >>>> Intelligent Solutions >>>> cell: +91-98932-87847 >>>> LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> >>>> >>>> >>>> On Sat, Sep 19, 2020 at 12:46 PM James Yong <[hidden email]> wrote: >>>> >>>>> Hi all, >>>>> >>>>> Propose to allow developer to open FTL source file from the browser. >>>>> This saves times locating for the template in the IDE. >>>>> JIRA issue is created at OFBIZ-12018 with patch file. >>>>> >>>>> Regards, >>>>> James >>>>> |
Administrator
|
Thanks James for fixing the error reported by Olivier,
It was blocking me checking OFBIZ-11993 <https://issues.apache.org/jira/browse/OFBIZ-11993> in ecomseo when coming from the categories tree. This said I still don't understand why using trunk HEAD I still see the labels. It was the last option I tested. Also I still get the same " String index out of range: -1 " going 1st time to https://localhost:8443/ecomseo or https://localhost:8443/ecommerce (no login there) TIA Jacques Le 20/09/2020 à 21:11, Jacques Le Roux a écrit : > About Olivier's comment, it's in OFBIZ-12002 > > TIA > > Le 20/09/2020 à 19:29, Jacques Le Roux a écrit : >> There is even something more annoying. At least when using labels only and the categories tree. >> If you revert the changes done by patching the feature remains even after a "clean". >> I don't understand why since the patch only makes changes in Java, JavaScript and properties files, w/ any data being stored in DB. >> I did not get more into details for tonight... >> >> Le 20/09/2020 à 19:14, Jacques Le Roux a écrit : >>> James, >>> >>> >How would it be for Eclipse? >>> OK found for Eclipse as you documented: https://wiki.eclipse.org/Eclipse/OpenFileFeature >>> >>> I found another issue which seems related to the one Olivier reported in the Jira. >>> In ecommerce if, from the categories tree you get to one of the categories, the labels stays (tested w/ labels only) >>> >>> Jacques >>> >>> Le 20/09/2020 à 12:51, Jacques Le Roux a écrit : >>>> Hi James, >>>> >>>> I just tried w/o looking into details. I got an issue when getting to >>>> >>>> https://localhost:8443/catalog/control/login?USERNAME=admin&PASSWORD=ofbiz&JavaScriptEnabled=Y >>>> >>>> 2020-09-20 12:19:36,510 |jsse-nio-8443-exec-4 |ControlServlet |E| Error in request handler: >>>> java.lang.StringIndexOutOfBoundsException: String index out of range: -1 >>>> at java.lang.String.substring(String.java:1967) ~[?:1.8.0_202] >>>> at org.apache.ofbiz.base.util.UtilHtml.getVisualThemeFolderNamesToExempt(UtilHtml.java:133) ~[main/:?] >>>> >>>> I got the same w/ https://localhost:8443/catalog/control/main# which was the URL returned by the error above. >>>> Same also when using https://localhost:8443/catalog/control/main 1st time (ie before login once) but OK after. >>>> >>>> Then I tried to use my simplest default editor: Scite. >>>> I put <<widget.dev.cmd.openSourceFile=C:\Scite\scite ${sourceLocation}>> >>>> I got no result but a JavaScript message saying "Source file opened". Do I miss something? How would it be for Eclipse? >>>> >>>> Also I don't think it should be enabled OOTB (ie NONE should be used) by default. >>>> Because each screen stays on with these information blocking most links for 5 seconds >>>> >>>> Thanks >>>> >>>> Jacques >>>> >>>> Le 19/09/2020 à 20:52, Rishi Solanki a écrit : >>>>> Dear James, >>>>> Thanks for your effort, looks good to me. You have already taken care of >>>>> dev and prod environment settings for this. >>>>> I never tried to open FTL in a browser, hopefully people used to do it. >>>>> >>>>> Best Regards, >>>>> -- >>>>> Rishi Solanki >>>>> *CTO, Mindpath Technology* >>>>> Intelligent Solutions >>>>> cell: +91-98932-87847 >>>>> LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> >>>>> >>>>> >>>>> On Sat, Sep 19, 2020 at 12:46 PM James Yong <[hidden email]> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> Propose to allow developer to open FTL source file from the browser. >>>>>> This saves times locating for the template in the IDE. >>>>>> JIRA issue is created at OFBIZ-12018 with patch file. >>>>>> >>>>>> Regards, >>>>>> James >>>>>> |
Hi Jacques,
To turn off the labels, can try setting widget.dev.namedBorder=false in widgets.properties. Can help me check the value of the 'path' variable before the exception occured at line 133 in UtilHtml.java? Regards, James On 2020/09/21 09:02:24, Jacques Le Roux <[hidden email]> wrote: > Thanks James for fixing the error reported by Olivier, > > It was blocking me checking OFBIZ-11993 <https://issues.apache.org/jira/browse/OFBIZ-11993> in ecomseo when coming from the categories tree. > > This said I still don't understand why using trunk HEAD I still see the labels. It was the last option I tested. > > Also I still get the same " String index out of range: -1 " going 1st time to https://localhost:8443/ecomseo or https://localhost:8443/ecommerce (no > login there) > > TIA > > Jacques > > Le 20/09/2020 à 21:11, Jacques Le Roux a écrit : > > About Olivier's comment, it's in OFBIZ-12002 > > > > TIA > > > > Le 20/09/2020 à 19:29, Jacques Le Roux a écrit : > >> There is even something more annoying. At least when using labels only and the categories tree. > >> If you revert the changes done by patching the feature remains even after a "clean". > >> I don't understand why since the patch only makes changes in Java, JavaScript and properties files, w/ any data being stored in DB. > >> I did not get more into details for tonight... > >> > >> Le 20/09/2020 à 19:14, Jacques Le Roux a écrit : > >>> James, > >>> > >>> >How would it be for Eclipse? > >>> OK found for Eclipse as you documented: https://wiki.eclipse.org/Eclipse/OpenFileFeature > >>> > >>> I found another issue which seems related to the one Olivier reported in the Jira. > >>> In ecommerce if, from the categories tree you get to one of the categories, the labels stays (tested w/ labels only) > >>> > >>> Jacques > >>> > >>> Le 20/09/2020 à 12:51, Jacques Le Roux a écrit : > >>>> Hi James, > >>>> > >>>> I just tried w/o looking into details. I got an issue when getting to > >>>> > >>>> https://localhost:8443/catalog/control/login?USERNAME=admin&PASSWORD=ofbiz&JavaScriptEnabled=Y > >>>> > >>>> 2020-09-20 12:19:36,510 |jsse-nio-8443-exec-4 |ControlServlet |E| Error in request handler: > >>>> java.lang.StringIndexOutOfBoundsException: String index out of range: -1 > >>>> at java.lang.String.substring(String.java:1967) ~[?:1.8.0_202] > >>>> at org.apache.ofbiz.base.util.UtilHtml.getVisualThemeFolderNamesToExempt(UtilHtml.java:133) ~[main/:?] > >>>> > >>>> I got the same w/ https://localhost:8443/catalog/control/main# which was the URL returned by the error above. > >>>> Same also when using https://localhost:8443/catalog/control/main 1st time (ie before login once) but OK after. > >>>> > >>>> Then I tried to use my simplest default editor: Scite. > >>>> I put <<widget.dev.cmd.openSourceFile=C:\Scite\scite ${sourceLocation}>> > >>>> I got no result but a JavaScript message saying "Source file opened". Do I miss something? How would it be for Eclipse? > >>>> > >>>> Also I don't think it should be enabled OOTB (ie NONE should be used) by default. > >>>> Because each screen stays on with these information blocking most links for 5 seconds > >>>> > >>>> Thanks > >>>> > >>>> Jacques > >>>> > >>>> Le 19/09/2020 à 20:52, Rishi Solanki a écrit : > >>>>> Dear James, > >>>>> Thanks for your effort, looks good to me. You have already taken care of > >>>>> dev and prod environment settings for this. > >>>>> I never tried to open FTL in a browser, hopefully people used to do it. > >>>>> > >>>>> Best Regards, > >>>>> -- > >>>>> Rishi Solanki > >>>>> *CTO, Mindpath Technology* > >>>>> Intelligent Solutions > >>>>> cell: +91-98932-87847 > >>>>> LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> > >>>>> > >>>>> > >>>>> On Sat, Sep 19, 2020 at 12:46 PM James Yong <[hidden email]> wrote: > >>>>> > >>>>>> Hi all, > >>>>>> > >>>>>> Propose to allow developer to open FTL source file from the browser. > >>>>>> This saves times locating for the template in the IDE. > >>>>>> JIRA issue is created at OFBIZ-12018 with patch file. > >>>>>> > >>>>>> Regards, > >>>>>> James > >>>>>> > |
Administrator
|
Hi James,
Le 21/09/2020 à 11:26, James Yong a écrit : > Hi Jacques, > > To turn off the labels, can try setting widget.dev.namedBorder=false in widgets.properties. Using NONE with the last patch works, thanks > Can help me check the value of the 'path' variable before the exception occured at line 133 in UtilHtml.java? I'll have a look ... > > Regards, > James > > On 2020/09/21 09:02:24, Jacques Le Roux <[hidden email]> wrote: >> Thanks James for fixing the error reported by Olivier, >> >> It was blocking me checking OFBIZ-11993 <https://issues.apache.org/jira/browse/OFBIZ-11993> in ecomseo when coming from the categories tree. >> >> This said I still don't understand why using trunk HEAD I still see the labels. It was the last option I tested. >> >> Also I still get the same " String index out of range: -1 " going 1st time to https://localhost:8443/ecomseo or https://localhost:8443/ecommerce (no >> login there) >> >> TIA >> >> Jacques >> >> Le 20/09/2020 à 21:11, Jacques Le Roux a écrit : >>> About Olivier's comment, it's in OFBIZ-12002 >>> >>> TIA >>> >>> Le 20/09/2020 à 19:29, Jacques Le Roux a écrit : >>>> There is even something more annoying. At least when using labels only and the categories tree. >>>> If you revert the changes done by patching the feature remains even after a "clean". >>>> I don't understand why since the patch only makes changes in Java, JavaScript and properties files, w/ any data being stored in DB. >>>> I did not get more into details for tonight... >>>> >>>> Le 20/09/2020 à 19:14, Jacques Le Roux a écrit : >>>>> James, >>>>> >>>>>> How would it be for Eclipse? >>>>> OK found for Eclipse as you documented: https://wiki.eclipse.org/Eclipse/OpenFileFeature >>>>> >>>>> I found another issue which seems related to the one Olivier reported in the Jira. >>>>> In ecommerce if, from the categories tree you get to one of the categories, the labels stays (tested w/ labels only) >>>>> >>>>> Jacques >>>>> >>>>> Le 20/09/2020 à 12:51, Jacques Le Roux a écrit : >>>>>> Hi James, >>>>>> >>>>>> I just tried w/o looking into details. I got an issue when getting to >>>>>> >>>>>> https://localhost:8443/catalog/control/login?USERNAME=admin&PASSWORD=ofbiz&JavaScriptEnabled=Y >>>>>> >>>>>> 2020-09-20 12:19:36,510 |jsse-nio-8443-exec-4 |ControlServlet |E| Error in request handler: >>>>>> java.lang.StringIndexOutOfBoundsException: String index out of range: -1 >>>>>> at java.lang.String.substring(String.java:1967) ~[?:1.8.0_202] >>>>>> at org.apache.ofbiz.base.util.UtilHtml.getVisualThemeFolderNamesToExempt(UtilHtml.java:133) ~[main/:?] >>>>>> >>>>>> I got the same w/ https://localhost:8443/catalog/control/main# which was the URL returned by the error above. >>>>>> Same also when using https://localhost:8443/catalog/control/main 1st time (ie before login once) but OK after. >>>>>> >>>>>> Then I tried to use my simplest default editor: Scite. >>>>>> I put <<widget.dev.cmd.openSourceFile=C:\Scite\scite ${sourceLocation}>> >>>>>> I got no result but a JavaScript message saying "Source file opened". Do I miss something? How would it be for Eclipse? >>>>>> >>>>>> Also I don't think it should be enabled OOTB (ie NONE should be used) by default. >>>>>> Because each screen stays on with these information blocking most links for 5 seconds >>>>>> >>>>>> Thanks >>>>>> >>>>>> Jacques >>>>>> >>>>>> Le 19/09/2020 à 20:52, Rishi Solanki a écrit : >>>>>>> Dear James, >>>>>>> Thanks for your effort, looks good to me. You have already taken care of >>>>>>> dev and prod environment settings for this. >>>>>>> I never tried to open FTL in a browser, hopefully people used to do it. >>>>>>> >>>>>>> Best Regards, >>>>>>> -- >>>>>>> Rishi Solanki >>>>>>> *CTO, Mindpath Technology* >>>>>>> Intelligent Solutions >>>>>>> cell: +91-98932-87847 >>>>>>> LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> >>>>>>> >>>>>>> >>>>>>> On Sat, Sep 19, 2020 at 12:46 PM James Yong <[hidden email]> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> Propose to allow developer to open FTL source file from the browser. >>>>>>>> This saves times locating for the template in the IDE. >>>>>>>> JIRA issue is created at OFBIZ-12018 with patch file. >>>>>>>> >>>>>>>> Regards, >>>>>>>> James >>>>>>>> |
Free forum by Nabble | Edit this page |