Opinions on layout changes

[Jacques Le Roux]

Hi,

I just created this comment https://s.apache.org/mWCY at current bottom of OFBIZ-10221.

I hope it's only a change in the  product/catalog main page (/applications/product/template/Main.ftl) but it could be that the same exists in other
FTL pages.

I'd like to have your opinions and especially ask you to test the changes in trunk UI.

The more we are to manually test the safer these manual tests will be.

Thanks

Jacques

[taher]

The newer version makes more sense than the older one because
alignment occurs relative to the parent. So I prefer to keep the new
one.

However, the new version looks a bit odd and misaligned. Some
improvement to formatting would be good IMO.

On Fri, May 4, 2018 at 12:52 PM, Jacques Le Roux
<[hidden email]> wrote:

> Hi,
>
> I just created this comment https://s.apache.org/mWCY at current bottom of
> OFBIZ-10221.
>
> I hope it's only a change in the  product/catalog main page
> (/applications/product/template/Main.ftl) but it could be that the same
> exists in other FTL pages.
>
> I'd like to have your opinions and especially ask you to test the changes in
> trunk UI.
>
> The more we are to manually test the safer these manual tests will be.
>
> Thanks
>
> Jacques
>

[Jacques Le Roux]

Yes my concern is actually just about alignment. The code format looks better for instance.

Jacques


Le 04/05/2018 à 15:20, Taher Alkhateeb a écrit :

> The newer version makes more sense than the older one because
> alignment occurs relative to the parent. So I prefer to keep the new
> one.
>
> However, the new version looks a bit odd and misaligned. Some
> improvement to formatting would be good IMO.
>
> On Fri, May 4, 2018 at 12:52 PM, Jacques Le Roux
> <[hidden email]> wrote:
>> Hi,
>>
>> I just created this comment https://s.apache.org/mWCY at current bottom of
>> OFBIZ-10221.
>>
>> I hope it's only a change in the  product/catalog main page
>> (/applications/product/template/Main.ftl) but it could be that the same
>> exists in other FTL pages.
>>
>> I'd like to have your opinions and especially ask you to test the changes in
>> trunk UI.
>>
>> The more we are to manually test the safer these manual tests will be.
>>
>> Thanks
>>
>> Jacques
>>